From 69cd72671d8264ced592f364309fb35e8dcd568a Mon Sep 17 00:00:00 2001 From: Yusuke Watanabe <42527473+ywatanabe1989@users.noreply.github.com> Date: Fri, 24 Jul 2026 01:43:27 +0900 Subject: [PATCH] fix(cla): accept the phrase the workflow tells contributors to comment custom-notsigned-prcomment instructs contributors to comment "I have read and agree to the SciTeX CLA." but custom-pr-sign-comment was unset, so the action accepted only its own default phrase. A contributor following the published instruction verbatim was told nothing happened, and the CLA check sat stale-FAILURE with no way for them to discover why. Measured on figrecipe #319/#320: the contributor commented the quoted phrase on 2026-07-23 15:56 and both CLA runs that day concluded failure. This affects every repo calling the org-reusable workflow, not just figrecipe. Verified custom-pr-sign-comment is a real input on the pinned action (scitex-ai/github-action@114064a, action.yml line 31) before adding it, so this is not a no-op key. Comment added tying the two strings together as one contract. --- .github/workflows/cla.yml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.github/workflows/cla.yml b/.github/workflows/cla.yml index a8898fb..48772dd 100644 --- a/.github/workflows/cla.yml +++ b/.github/workflows/cla.yml @@ -84,3 +84,13 @@ jobs: custom-notsigned-prcomment: | Please sign the [SciTeX CLA](https://github.com/${{ github.repository }}/blob/${{ inputs.default_branch }}/CLA.md) before your contribution can be merged. Comment `I have read and agree to the SciTeX CLA.` to sign. + # MUST stay byte-identical to the phrase quoted just above. Without + # this input the action accepts ONLY its own default ("I have read + # the CLA Document and I hereby sign the CLA"), so the instruction we + # publish is one the system rejects: a contributor who follows it + # exactly is told nothing happened, and the check sits stale-FAILURE + # with no way for them to discover why. Measured 2026-07-23 on + # figrecipe #319/#320 — the contributor commented the quoted phrase + # on 07-23 15:56 and both CLA runs that day concluded `failure`. + # If you edit either string, edit BOTH. They are one contract. + custom-pr-sign-comment: "I have read and agree to the SciTeX CLA."