Use console.debug instead of wrapping console.log?

[baodrate]

omnisearch implements debug logging by having a plugin setting that toggles the behavior of logDebug, which wraps console.log.

obsidian-omnisearch/src/tools/utils.ts

Lines 233 to 252 in 1c98d8b

	export function logDebug(...args: any[]): void {
	printDebug(console.log, ...args)
	}
	export function warnDebug(...args: any[]): void {
	printDebug(console.warn, ...args)
	}
	let printDebugEnabled = false
	export function enablePrintDebug(enable: boolean): void {
	printDebugEnabled = enable
	}
	function printDebug(fn: (...args: any[]) => any, ...args: any[]): void {
	if (printDebugEnabled) {
	const t = new Date()
	const ts = `${t.getMinutes()}:${t.getSeconds()}:${t.getMilliseconds()}`
	fn(...['Omnisearch -', ts + ' -', ...args])
	}
	}

Why not just call console.debug instead? Then you don't need a separate setting, and you can filter debug level log messages dynamically (they don't get dropped, they're just hidden by default)

And by calling console.debug, the developer console will show the line where the log message was called, instead of the definition of logDebug

Also, wrapping console.log to prepend a timestamp is unnecessary because you just need to enable console timestamps in the developer console:

[baodrate]

On top of that. I think that Omnisearch logs too much by default. From the plugin guidelines:

Please avoid unnecessary logging.
In it's default configuration, the developer console should only show error messages, debug messages should not be shown.

[scambier]

Good points.

Edit: actually, logDebug() and warnDebug() are useful because they check if the verbose logging is enabled. Though I'll replace the console.log call with a console.debug.