Skip to content

Update @actions/exec to avoid passing the docker password on the command line #134

Description

@domdfcoding

Per the comment in DockerActionBuilder.ts:

// Todo: use stdin
// https://github.com/actions/toolkit/pull/360
// waiting for new release.
await exec.exec('docker login', [
registry,
'-u', user,
'-p', token,
])
}

this depended on actions/toolkit#360, which has been merged. From what I can tell the changes made it into version 1.0.4

Would it be possible to have this updated to use stdin?

Thanks 😃

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions