The whole library has a very inconsistent code style. Apart from basic naming conventions (like functions and types are CamlCase, variable lowerCamlCase and constants are UPPER_CASE), there is no format convention, pointer * are sometimes attached to the type, sometimes to the function, some code use spaces, some use tabs, some use tabs but configured to be 2 space long, etc...
I strongly suggest that a maintainer should define a convention once and for all, they are all arbitrary don't worry too much about which one, maybe just try to minimize the differences from current "average" code, configure an auto-formater such as clang-format to follow this convention and apply it everywhere, and continue applying it on every incoming pull request.
This is a minor problem but it might save time on conflict resolution, and make collaboration on the project a lot more pleasant in my opinion.
The whole library has a very inconsistent code style. Apart from basic naming conventions (like functions and types are CamlCase, variable lowerCamlCase and constants are UPPER_CASE), there is no format convention, pointer * are sometimes attached to the type, sometimes to the function, some code use spaces, some use tabs, some use tabs but configured to be 2 space long, etc...
I strongly suggest that a maintainer should define a convention once and for all, they are all arbitrary don't worry too much about which one, maybe just try to minimize the differences from current "average" code, configure an auto-formater such as clang-format to follow this convention and apply it everywhere, and continue applying it on every incoming pull request.
This is a minor problem but it might save time on conflict resolution, and make collaboration on the project a lot more pleasant in my opinion.