switch argument order for the verify method on the provider

Author: jgreeer

rcgen/src/crypto/aws_lc_rs.rs

@@ -298,10 +298,10 @@ impl CryptoProvider for AwsLcProvider {
 
 	fn verify(
 		&self,
-		algorithm: &'static SignatureAlgorithm,
-		public_key: &[u8],
 		message: &[u8],
 		signature_bytes: &[u8],
+		public_key: &[u8],
+		algorithm: &'static SignatureAlgorithm,
 	) -> Result<(), Error> {
 		#[cfg(feature = "aws_lc_rs")]
 		{
@@ -443,7 +443,7 @@ mod tests {
 			let message = b"stable ML-DSA provider";
 			let signature = loaded.sign(message).unwrap();
 			provider
-				.verify(algorithm, loaded.der_bytes(), message, &signature)
+				.verify(message, &signature, loaded.der_bytes(), algorithm)
 				.unwrap();
 
 			#[cfg(feature = "x509-parser")]

rcgen/src/crypto/mod.rs

@@ -50,10 +50,10 @@ pub trait CryptoProvider: std::fmt::Debug + Send + Sync {
 	/// STRING contents, matching [`PublicKeyData::der_bytes`](crate::PublicKeyData::der_bytes).
 	fn verify(
 		&self,
-		algorithm: &'static SignatureAlgorithm,
-		public_key: &[u8],
 		message: &[u8],
 		signature: &[u8],
+		public_key: &[u8],
+		algorithm: &'static SignatureAlgorithm,
 	) -> Result<(), Error>;
 }
 

rcgen/src/crypto/ring.rs

@@ -167,10 +167,10 @@ impl CryptoProvider for RingProvider {
 
 	fn verify(
 		&self,
-		algorithm: &'static SignatureAlgorithm,
-		public_key: &[u8],
 		message: &[u8],
 		signature_bytes: &[u8],
+		public_key: &[u8],
+		algorithm: &'static SignatureAlgorithm,
 	) -> Result<(), Error> {
 		let verification_algorithm: &'static dyn VerificationAlgorithm =
 			if algorithm == &PKCS_ECDSA_P256_SHA256 {

rcgen/src/csr.rs

@@ -141,10 +141,10 @@ impl CertificateSigningRequestParams {
 
 		provider
 			.verify(
-				alg,
-				info.subject_pki.subject_public_key.data.as_ref(),
 				info.raw,
 				csr.signature_value.data.as_ref(),
+				info.subject_pki.subject_public_key.data.as_ref(),
+				alg,
 			)
 			.map_err(|error| match error {
 				Error::UnsupportedSignatureAlgorithm => error,

rcgen/tests/custom_provider.rs

@@ -58,10 +58,10 @@ impl CryptoProvider for TestBackend {
 
 	fn verify(
 		&self,
-		algorithm: &'static SignatureAlgorithm,
-		public_key: &[u8],
 		message: &[u8],
 		signature: &[u8],
+		public_key: &[u8],
+		algorithm: &'static SignatureAlgorithm,
 	) -> Result<(), Error> {
 		assert_eq!(algorithm, &PKCS_ED25519);
 		assert_eq!(public_key, [7; 32]);