Binding generation script generates wrong platform/arch specific code

[russell-islam]

Even though some definitions and constants are behind a x86_64 or arm64 gated, generation script wrongly put those code to both platform.

[NunoDasNeves]

@russell-islam there are some definitions with x64 in the name, which are not inside an #if defined(__x86_64__), for example hv_x64_fp_register is not gated by that so it appears in the arm64 bindings. We can change that, but it looks like a different issue.

Can you provide an example of a definition that is gated to one arch but still generated for both? I checked a few and couldn't find one.

[russell-islam]

I guess the error is wen we add CONFIG_X86_64 or CONFIG_ARM64. Please see https://github.com/rust-vmm/mshv/blob/main/mshv-bindings/src/x86_64/bindings.rs#L1999

[NunoDasNeves]

CONFIG_ defines are only for kernel code, and I don't see them in hv-headers. We use __x86_64__ and __aarch64__ for these userspace headers.