windows-sys generated WinAPI bindings break ARM platforms

[bdbai]

In #110152 the WinAPI definitions have been replaced by windows-bindgen generated bindings. However, the win32metadata project does not generate metadata for ARM32-specific items, hence the generated bindings lack a few types like CONTEXT and WSADATA on this platform. It effectively breaks thumbv7a-*-windows-* for Rust.

@ChrisDenton

[ChrisDenton]

Unfortunately, 32-bit ARM is not being supported by Microsoft going forward. What we could do is insert our own definitions in the prelude, copied from before the changes.

[bdbai]

Besides the issue with ARM, all UWP targets actually have problems with linkage as well. Previously the APIs forbidden on UWP are gated behind fine-grained conditional compilation flags, but it is no longer the case with generated ones. I got this when building the UWP app that links again a Rust staticlib.

[ChrisDenton]

Iirc, the Nt functions were never gated. But we loaded them lazily (and panicked if they didn't load). This did allow UWP targets to compile. No idea if they actually ran. I'm not sure who's responsible for these targets.

[bdbai]

Iirc, the Nt functions were never gated. But we loaded them lazily (and panicked if they didn't load). This did allow UWP targets to compile. No idea if they actually ran. I'm not sure who's responsible for these targets.

I think you are correct. I can reproduce the link errors with toolchain nightly-2023-05-06. Let me file another issue after I pinpoint the underlying problem.

[ChrisDenton]

Oh wait, as staticlib? You currently need to make sure to link all the libraries it depends on. You can get them using --print native-static-libs.

[bdbai]

Oh wait, as staticlib? You currently need to make sure to link all the libraries it depends on. You can get them using --print native-static-libs.

This will fail Windows App Cert Kit tests.

[ChrisDenton]

In that case I'm surprised that lazy loading worked.

[apiraino]

WG-prioritization assigning priority (Zulip discussion).

@rustbot label -I-prioritize +P-low