Skip to content

Commit 849a980

Browse files
committed
Enable all EII tests on Windows MSVC
1 parent 88f7399 commit 849a980

3 files changed

Lines changed: 6 additions & 4 deletions

File tree

tests/ui/eii/duplicate/dylib_default_duplicate.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
//@ needs-crate-type: dylib
33
//@ compile-flags: --emit link
44
//@ ignore-backends: gcc
5-
// FIXME: linking on windows (specifically mingw) not yet supported, see tracking issue #125418
6-
//@ ignore-windows
5+
// FIXME(#125418): linking on Windows GNU targets is not yet supported.
6+
//@ ignore-windows-gnu
77
// Regression test for https://github.com/rust-lang/rust/issues/156320.
88
// A default implementation from an upstream dylib has already been selected and
99
// must not be overridden by a downstream explicit implementation.

tests/ui/eii/linking/track_caller_cross_crate.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
//@ aux-build: track_caller_cross_other_crate.rs
44
//@ compile-flags: -O
55
//@ ignore-backends: gcc
6-
//@ ignore-windows
6+
// FIXME(#125418): linking on Windows GNU targets is not yet supported.
7+
//@ ignore-windows-gnu
78
// Tests that `#[track_caller]` on an EII declaration in one crate is derived
89
// onto an explicit implementation in another crate.
910

tests/ui/eii/track_caller.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
//@ run-pass
22
//@ ignore-backends: gcc
3-
//@ ignore-windows
3+
// FIXME(#125418): linking on Windows GNU targets is not yet supported.
4+
//@ ignore-windows-gnu
45
// Tests that `#[track_caller]` on an EII declaration is threaded through both
56
// the default impl (no override) and an explicit override (which does not
67
// repeat `#[track_caller]` — it is derived during codegen so the shim ABI matches).

0 commit comments

Comments
 (0)