apirecorder: handle super method invocations on interfaces

for some reason these have weird types that normal TypeName.super.method
invocations do not

Author: abextm

apirecorder/src/main/java/net/runelite/pluginhub/apirecorder/RecordingTreeScanner.java

@@ -117,8 +117,12 @@ public Void visitIdentifier(IdentifierTree node, Void unused)
 	@Override
 	public Void visitMemberSelect(MemberSelectTree node, Void unused)
 	{
-		TypeMirror receiver = trees.getTypeMirror(new TreePath(getCurrentPath(), node.getExpression()));
-		recordElement(trees.getElement(getCurrentPath()), receiver);
+		// if we are super-ing then the receiver is already recorded
+		if (!node.getIdentifier().contentEquals("super"))
+		{
+			TypeMirror receiver = trees.getTypeMirror(new TreePath(getCurrentPath(), node.getExpression()));
+			recordElement(trees.getElement(getCurrentPath()), receiver);
+		}
 		return super.visitMemberSelect(node, unused);
 	}
 

apirecorder/src/test/resources/net/runelite/pluginhub/apirecorder/expected.txt

@@ -8,6 +8,7 @@ Lnet/runelite/pluginhub/apirecorder/test/core/CoreConstants;b
 Lnet/runelite/pluginhub/apirecorder/test/core/CoreEnum;.FIRST:Lnet/runelite/pluginhub/apirecorder/test/core/CoreEnum;:bsf:
 Lnet/runelite/pluginhub/apirecorder/test/core/CoreEnum;bf
 Lnet/runelite/pluginhub/apirecorder/test/core/CoreGrandparent;.grandparentMethod()V:b
+Lnet/runelite/pluginhub/apirecorder/test/core/CoreInterfaceBase;.baseMethod()V:b
 Lnet/runelite/pluginhub/apirecorder/test/core/CoreInterfaceChild;>Lnet/runelite/pluginhub/apirecorder/test/core/CoreInterfaceBase;
 Lnet/runelite/pluginhub/apirecorder/test/core/CoreInterfaceChild;aib
 Lnet/runelite/pluginhub/apirecorder/test/core/CoreParent;>Lnet/runelite/pluginhub/apirecorder/test/core/CoreGrandparent;

apirecorder/src/testCore/java/net/runelite/pluginhub/apirecorder/test/core/CoreInterfaceBase.java

@@ -2,5 +2,7 @@
 
 public interface CoreInterfaceBase
 {
-	void baseMethod();
+	default void baseMethod()
+	{
+	}
 }

apirecorder/src/testPlugin/java/net/runelite/pluginhub/apirecorder/test/plugin/ImplementsInterface.java

@@ -7,6 +7,7 @@ public class ImplementsInterface implements CoreInterfaceChild
 	@Override
 	public void baseMethod()
 	{
+		CoreInterfaceChild.super.baseMethod();
 	}
 
 	@Override