Avoid using fork in Process specs

Author: eregon

core/process/detach_spec.rb

@@ -1,81 +1,82 @@
 require_relative '../../spec_helper'
+require_relative 'fixtures/common'
 
 describe "Process.detach" do
-  platform_is_not :windows do
-    it "returns a thread" do
-      pid = Process.fork { Process.exit! }
-      thr = Process.detach(pid)
-      thr.should.is_a?(Thread)
-      thr.join
-    end
+  ProcessSpecs.use_system_ruby(self)
 
-    it "produces the exit Process::Status as the thread value" do
-      pid = Process.fork { Process.exit! }
-      thr = Process.detach(pid)
-      thr.join
+  it "returns a thread" do
+    pid = Process.spawn(*ruby_exe, "-e", "exit")
+    thr = Process.detach(pid)
+    thr.should.is_a?(Thread)
+    thr.join
+  end
 
-      status = thr.value
-      status.should.is_a?(Process::Status)
-      status.pid.should == pid
-    end
+  it "produces the exit Process::Status as the thread value" do
+    pid = Process.spawn(*ruby_exe, "-e", "exit")
+    thr = Process.detach(pid)
+    thr.join
+
+    status = thr.value
+    status.should.is_a?(Process::Status)
+    status.pid.should == pid
+  end
 
-    platform_is_not :openbsd do
-      it "reaps the child process's status automatically" do
-        pid = Process.fork { Process.exit! }
-        Process.detach(pid).join
-        -> { Process.waitpid(pid) }.should.raise(Errno::ECHILD)
-      end
+  platform_is_not :openbsd do
+    it "reaps the child process's status automatically" do
+      pid = Process.spawn(*ruby_exe, "-e", "exit")
+      Process.detach(pid).join
+      -> { Process.waitpid(pid) }.should.raise(Errno::ECHILD)
     end
+  end
 
-    it "sets the :pid thread-local to the PID" do
-      pid = Process.fork { Process.exit! }
-      thr = Process.detach(pid)
-      thr.join
+  it "sets the :pid thread-local to the PID" do
+    pid = Process.spawn(*ruby_exe, "-e", "exit")
+    thr = Process.detach(pid)
+    thr.join
 
-      thr[:pid].should == pid
-    end
+    thr[:pid].should == pid
+  end
 
-    it "provides a #pid method on the returned thread which returns the PID" do
-      pid = Process.fork { Process.exit! }
-      thr = Process.detach(pid)
-      thr.join
+  it "provides a #pid method on the returned thread which returns the PID" do
+    pid = Process.spawn(*ruby_exe, "-e", "exit")
+    thr = Process.detach(pid)
+    thr.join
 
-      thr.pid.should == pid
-    end
+    thr.pid.should == pid
+  end
 
-    it "tolerates not existing child process pid" do
-      # Use a value that is close to the INT_MAX (pid usually is signed int).
-      # It should (at least) be greater than allowed pid limit value that depends on OS.
-      pid_not_existing = 2.pow(30)
+  it "tolerates not existing child process pid" do
+    # Use a value that is close to the INT_MAX (pid usually is signed int).
+    # It should (at least) be greater than allowed pid limit value that depends on OS.
+    pid_not_existing = 2.pow(30)
 
-      # Check that there is no a child process with this hardcoded pid.
-      # Command `kill 0 pid`:
-      # - returns "1" if a process exists and
-      # - raises Errno::ESRCH otherwise
-      -> {  Process.kill(0, pid_not_existing) }.should.raise(Errno::ESRCH)
+    # Check that there is no a child process with this hardcoded pid.
+    # Command `kill 0 pid`:
+    # - returns "1" if a process exists and
+    # - raises Errno::ESRCH otherwise
+    -> {  Process.kill(0, pid_not_existing) }.should.raise(Errno::ESRCH)
 
-      thr = Process.detach(pid_not_existing)
-      thr.join
+    thr = Process.detach(pid_not_existing)
+    thr.join
 
-      thr.should.is_a?(Thread)
-    end
+    thr.should.is_a?(Thread)
+  end
 
-    it "calls #to_int to implicitly convert non-Integer pid to Integer" do
-      pid = MockObject.new('mock-enumerable')
-      pid.should_receive(:to_int).and_return(100500)
+  it "calls #to_int to implicitly convert non-Integer pid to Integer" do
+    pid = MockObject.new('mock-enumerable')
+    pid.should_receive(:to_int).and_return(100500)
 
-      Process.detach(pid).join
-    end
+    Process.detach(pid).join
+  end
 
-    it "raises TypeError when pid argument does not have #to_int method" do
-      -> { Process.detach(Object.new) }.should.raise(TypeError, "no implicit conversion of Object into Integer")
-    end
+  it "raises TypeError when pid argument does not have #to_int method" do
+    -> { Process.detach(Object.new) }.should.raise(TypeError, "no implicit conversion of Object into Integer")
+  end
 
-    it "raises TypeError when #to_int returns non-Integer value" do
-      pid = MockObject.new('mock-enumerable')
-      pid.should_receive(:to_int).and_return(:symbol)
+  it "raises TypeError when #to_int returns non-Integer value" do
+    pid = MockObject.new('mock-enumerable')
+    pid.should_receive(:to_int).and_return(:symbol)
 
-      -> { Process.detach(pid) }.should raise_consistent_error(TypeError, "can't convert MockObject into Integer (MockObject#to_int gives Symbol)")
-    end
+    -> { Process.detach(pid) }.should raise_consistent_error(TypeError, "can't convert MockObject into Integer (MockObject#to_int gives Symbol)")
   end
 end

core/process/wait2_spec.rb

@@ -1,6 +1,9 @@
 require_relative '../../spec_helper'
+require_relative 'fixtures/common'
 
 describe "Process.wait2" do
+  ProcessSpecs.use_system_ruby(self)
+
   before :all do
     # HACK: this kludge is temporarily necessary because some
     # misbehaving spec somewhere else does not clear processes
@@ -18,15 +21,13 @@
     end
   end
 
-  platform_is_not :windows do
-    it "returns the pid and status of child process" do
-      pidf = Process.fork { Process.exit! 99 }
-      results = Process.wait2
-      results.size.should == 2
-      pidw, status = results
-      pidf.should == pidw
-      status.exitstatus.should == 99
-    end
+  it "returns the pid and status of child process" do
+    pidf = Process.spawn(*ruby_exe, "-e", "exit 99")
+    results = Process.wait2
+    results.size.should == 2
+    pidw, status = results
+    pidf.should == pidw
+    status.exitstatus.should == 99
   end
 
   it "raises a StandardError if no child processes exist" do

core/process/wait_spec.rb

@@ -17,19 +17,19 @@
     -> { Process.wait }.should.raise(Errno::ECHILD)
   end
 
-  platform_is_not :windows do
-    it "returns its child pid" do
-      pid = Process.spawn(ruby_cmd('exit'))
-      Process.wait.should == pid
-    end
+  it "returns its child pid" do
+    pid = Process.spawn(ruby_cmd('exit'))
+    Process.wait.should == pid
+  end
 
-    it "sets $? to a Process::Status" do
-      pid = Process.spawn(ruby_cmd('exit'))
-      Process.wait
-      $?.should.is_a?(Process::Status)
-      $?.pid.should == pid
-    end
+  it "sets $? to a Process::Status" do
+    pid = Process.spawn(ruby_cmd('exit'))
+    Process.wait
+    $?.should.is_a?(Process::Status)
+    $?.pid.should == pid
+  end
 
+  platform_is_not :windows do
     it "waits for any child process if no pid is given" do
       pid = Process.spawn(ruby_cmd('exit'))
       Process.wait.should == pid
@@ -59,8 +59,10 @@
       Process.wait(0).should == pid2
       Process.wait.should == pid1
     end
+  end
 
-    # This spec is probably system-dependent.
+  # This spec is probably system-dependent.
+  guard -> { Process.respond_to?(:fork) } do
     it "doesn't block if no child is available when WNOHANG is used" do
       read, write = IO.pipe
       pid = Process.fork do
@@ -81,7 +83,9 @@
       Process.kill("TERM", pid)
       Process.wait.should == pid
     end
+  end
 
+  platform_is_not :windows do
     it "always accepts flags=0" do
       pid = Process.spawn(ruby_cmd('exit'))
       Process.wait(-1, 0).should == pid

core/process/waitall_spec.rb

@@ -1,6 +1,9 @@
 require_relative '../../spec_helper'
+require_relative 'fixtures/common'
 
 describe "Process.waitall" do
+  ProcessSpecs.use_system_ruby(self)
+
   before :all do
     begin
       Process.waitall
@@ -17,23 +20,16 @@
   end
 
   platform_is_not :windows do
-    it "waits for all children" do
+    it "waits for all children and returns an array of pid/status pairs" do
       pids = []
-      pids << Process.fork { Process.exit! 2 }
-      pids << Process.fork { Process.exit! 1 }
-      pids << Process.fork { Process.exit! 0 }
-      Process.waitall
+      pids << Process.spawn(ruby_cmd('exit 2'))
+      pids << Process.spawn(ruby_cmd('exit 1'))
+      pids << Process.spawn(ruby_cmd('exit 0'))
+      a = Process.waitall
       pids.each { |pid|
         -> { Process.kill(0, pid) }.should.raise(Errno::ESRCH)
       }
-    end
 
-    it "returns an array of pid/status pairs" do
-      pids = []
-      pids << Process.fork { Process.exit! 2 }
-      pids << Process.fork { Process.exit! 1 }
-      pids << Process.fork { Process.exit! 0 }
-      a = Process.waitall
       a.should.is_a?(Array)
       a.size.should == 3
       pids.each { |pid|