Move Method to rely less on shared examples

Author: Earlopain

core/method/call_spec.rb

@@ -1,7 +1,54 @@
 require_relative '../../spec_helper'
 require_relative 'fixtures/classes'
-require_relative 'shared/call'
 
 describe "Method#call" do
-  it_behaves_like :method_call, :call
+  it "invokes the method with the specified arguments, returning the method's return value" do
+    m = 12.method("+")
+    m.call(3).should == 15
+    m.call(20).should == 32
+
+    m = MethodSpecs::Methods.new.method(:attr=)
+    m.call(42).should == 42
+  end
+
+  it "raises an ArgumentError when given incorrect number of arguments" do
+    -> {
+      MethodSpecs::Methods.new.method(:two_req).call(1, 2, 3)
+    }.should.raise(ArgumentError)
+    -> {
+      MethodSpecs::Methods.new.method(:two_req).call(1)
+    }.should.raise(ArgumentError)
+  end
+
+  describe "for a Method generated by respond_to_missing?" do
+    it "invokes method_missing with the specified arguments and returns the result" do
+      @m = MethodSpecs::Methods.new
+      meth = @m.method(:handled_via_method_missing)
+      meth.call(:argument).should == [:argument]
+    end
+
+    it "invokes method_missing with the method name and the specified arguments" do
+      @m = MethodSpecs::Methods.new
+      meth = @m.method(:handled_via_method_missing)
+
+      @m.should_receive(:method_missing).with(:handled_via_method_missing, :argument)
+      meth.call(:argument)
+    end
+
+    it "invokes method_missing dynamically" do
+      @m = MethodSpecs::Methods.new
+      meth = @m.method(:handled_via_method_missing)
+
+      def @m.method_missing(*); :changed; end
+      meth.call(:argument).should == :changed
+    end
+
+    it "does not call the original method name even if it now exists" do
+      @m = MethodSpecs::Methods.new
+      meth = @m.method(:handled_via_method_missing)
+
+      def @m.handled_via_method_missing(*); :not_called; end
+      meth.call(:argument).should == [:argument]
+    end
+  end
 end

core/method/case_compare_spec.rb

@@ -1,7 +1,7 @@
 require_relative '../../spec_helper'
-require_relative 'fixtures/classes'
-require_relative 'shared/call'
 
 describe "Method#===" do
-  it_behaves_like :method_call, :===
+  it "is an alias of Method#call" do
+    Method.instance_method(:===).should == Method.instance_method(:call)
+  end
 end

core/method/element_reference_spec.rb

@@ -1,7 +1,7 @@
 require_relative '../../spec_helper'
-require_relative 'fixtures/classes'
-require_relative 'shared/call'
 
 describe "Method#[]" do
-  it_behaves_like :method_call, :[]
+  it "is an alias of Method#call" do
+    Method.instance_method(:[]).should == Method.instance_method(:call)
+  end
 end

core/method/eql_spec.rb

@@ -1,6 +1,94 @@
 require_relative '../../spec_helper'
-require_relative 'shared/eql'
+require_relative 'fixtures/classes'
 
 describe "Method#eql?" do
-  it_behaves_like :method_equal, :eql?
+  before :each do
+    @m = MethodSpecs::Methods.new
+    @m_foo = @m.method(:foo)
+    @m2 = MethodSpecs::Methods.new
+    @a = MethodSpecs::A.new
+  end
+
+  it "returns true if methods are the same" do
+    m2 = @m.method(:foo)
+
+    @m_foo.eql?(@m_foo).should == true
+    @m_foo.eql?(m2).should == true
+  end
+
+  it "returns true on aliased methods" do
+    m_bar = @m.method(:bar)
+
+    m_bar.eql?(@m_foo).should == true
+  end
+
+  it "returns true if the two core methods are aliases" do
+    s = "hello"
+    a = s.method(:size)
+    b = s.method(:length)
+    a.eql?(b).should == true
+  end
+
+  it "returns false on a method which is neither aliased nor the same method" do
+    m2 = @m.method(:zero)
+
+    @m_foo.eql?(m2).should == false
+  end
+
+  it "returns false for a method which is not bound to the same object" do
+    m2_foo = @m2.method(:foo)
+    a_baz = @a.method(:baz)
+
+    @m_foo.eql?(m2_foo).should == false
+    @m_foo.eql?(a_baz).should == false
+  end
+
+  it "returns false if the two methods are bound to the same object but were defined independently" do
+    m2 = @m.method(:same_as_foo)
+    @m_foo.eql?(m2).should == false
+  end
+
+  it "returns true if a method was defined using the other one" do
+    MethodSpecs::Methods.send :define_method, :defined_foo, MethodSpecs::Methods.instance_method(:foo)
+    m2 = @m.method(:defined_foo)
+    @m_foo.eql?(m2).should == true
+  end
+
+  it "returns false if comparing a method defined via define_method and def" do
+    defn = @m.method(:zero)
+    defined = @m.method(:zero_defined_method)
+
+    defn.eql?(defined).should == false
+    defined.eql?(defn).should == false
+  end
+
+  describe 'missing methods' do
+    it "returns true for the same method missing" do
+      miss1 = @m.method(:handled_via_method_missing)
+      miss1bis = @m.method(:handled_via_method_missing)
+      miss2 = @m.method(:also_handled)
+
+      miss1.eql?(miss1bis).should == true
+      miss1.eql?(miss2).should == false
+    end
+
+    it 'calls respond_to_missing? with true to include private methods' do
+      @m.should_receive(:respond_to_missing?).with(:some_missing_method, true).and_return(true)
+      @m.method(:some_missing_method)
+    end
+  end
+
+  it "returns false if the two methods are bound to different objects, have the same names, and identical bodies" do
+    a = MethodSpecs::Eql.instance_method(:same_body)
+    b = MethodSpecs::Eql2.instance_method(:same_body)
+    a.eql?(b).should == false
+  end
+
+  it "returns false if the argument is not a Method object" do
+    String.instance_method(:size).eql?(7).should == false
+  end
+
+  it "returns false if the argument is an unbound version of self" do
+    method(:load).eql?(method(:load).unbind).should == false
+  end
 end

core/method/equal_value_spec.rb

@@ -1,6 +1,7 @@
 require_relative '../../spec_helper'
-require_relative 'shared/eql'
 
 describe "Method#==" do
-  it_behaves_like :method_equal, :==
+  it "is an alias of Method#eql?" do
+    Method.instance_method(:==).should == Method.instance_method(:eql?)
+  end
 end

core/method/shared/call.rb

@@ -1,8 +1,7 @@
 require_relative '../../spec_helper'
-require_relative 'shared/to_s'
-require_relative 'shared/aliased_inspect'
 
 describe "Method#to_s" do
-  it_behaves_like :method_to_s, :to_s
-  it_behaves_like :method_to_s_aliased, :to_s, -> meth { meth }
+  it "is an alias of Method#inspect" do
+    Method.instance_method(:to_s).should == Method.instance_method(:inspect)
+  end
 end