From 8536004594e415a3508fe678f5eee5892da59a41 Mon Sep 17 00:00:00 2001 From: Stephan Drescher Date: Tue, 21 Nov 2017 22:48:52 +0100 Subject: [PATCH] Fix: wrong getCurrentTabPosition value when called from OnTabSelectListener Fixes this: bottomBar.setOnTabSelectListener { tabResId -> bottomBar.getCurrentTabPosition() // wrong value - I get the previous one not the current one } --- .../src/main/java/com/roughike/bottombar/BottomBar.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bottom-bar/src/main/java/com/roughike/bottombar/BottomBar.java b/bottom-bar/src/main/java/com/roughike/bottombar/BottomBar.java index 350cc316..b083dc35 100644 --- a/bottom-bar/src/main/java/com/roughike/bottombar/BottomBar.java +++ b/bottom-bar/src/main/java/com/roughike/bottombar/BottomBar.java @@ -942,6 +942,8 @@ private boolean handleLongClick(BottomBarTab longClickedTab) { } private void updateSelectedTab(int newPosition) { + currentTabPosition = newPosition; + int newTabId = getTabAtPosition(newPosition).getId(); if (newPosition != currentTabPosition) { @@ -952,8 +954,6 @@ private void updateSelectedTab(int newPosition) { onTabReselectListener.onTabReSelected(newTabId); } - currentTabPosition = newPosition; - if (ignoreTabReselectionListener) { ignoreTabReselectionListener = false; }