From 5ca83eb39ab8e8b13327f06fb6d92ef4e91b6c9c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ma=C3=ABlle=20Salmon?= Date: Mon, 30 Sep 2024 06:41:44 +0200 Subject: [PATCH 1/3] test: remove call to load() cf https://r-pkgs.org/data.html#sec-data-sysdata --- tests/testthat/test-cetesb_retrieve_met_pol.R | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/testthat/test-cetesb_retrieve_met_pol.R b/tests/testthat/test-cetesb_retrieve_met_pol.R index 7151ee6..2577376 100644 --- a/tests/testthat/test-cetesb_retrieve_met_pol.R +++ b/tests/testthat/test-cetesb_retrieve_met_pol.R @@ -1,7 +1,5 @@ test_that("cetesb_retrieve_met_pol works!", { - load("sysdata.rda") - pinheiros <- cetesb_retrieve_met_pol(u,p,aqs_code = 99, start_date = "01/01/2020", end_date = "07/01/2020") From 171f5da7792d9f32afe66c93deb033645eef0267 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ma=C3=ABlle=20Salmon?= Date: Mon, 30 Sep 2024 06:45:29 +0200 Subject: [PATCH 2/3] test: use expect_lt() and expect_gt() for a more informative error message --- tests/testthat/test-cetesb_retrieve_met_pol.R | 33 ++++++++++++------- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/tests/testthat/test-cetesb_retrieve_met_pol.R b/tests/testthat/test-cetesb_retrieve_met_pol.R index 2577376..bde117c 100644 --- a/tests/testthat/test-cetesb_retrieve_met_pol.R +++ b/tests/testthat/test-cetesb_retrieve_met_pol.R @@ -10,17 +10,28 @@ test_that("cetesb_retrieve_met_pol works!", { # Testing data.frame values param_means<- colMeans(pinheiros[, 2:13], na.rm = TRUE) - expect_equal(param_means["tc"] > 23, param_means["tc"] < 24) - expect_equal(param_means["rh"] > 74, param_means["rh"] < 75) - expect_equal(param_means["ws"] > 1, param_means["ws"] < 2) - expect_equal(param_means["wd"] > 238, param_means["wd"] < 239) - expect_equal(param_means["o3"] > 27, param_means["o3"] < 28) - expect_equal(param_means["no"] > 8, param_means["no"] < 9) - expect_equal(param_means["no2"] > 26, param_means["no2"] < 27) - expect_equal(param_means["nox"] > 20, param_means["nox"] < 21) - expect_equal(param_means["co"] > 0.3, param_means["co"] < 0.4) - expect_equal(param_means["pm10"] > 19, param_means["pm10"] < 20) - expect_equal(param_means["pm25"] > 5, param_means["pm25"] < 7) + expect_lt(param_means["tc"], 23) + expect_gt(param_means["tc"], 24) + expect_lt(param_means["rh"], 74) + expect_gt(param_means["rh"], 75) + expect_lt(param_means["ws"], 1) + expect_gt(param_means["ws"], 2) + expect_lt(param_means["wd"], 238) + expect_gt(param_means["wd"], 239) + expect_lt(param_means["o3"], 27) + expect_gt(param_means["o3"], 28) + expect_lt(param_means["no"], 8) + expect_gt(param_means["no"], 9) + expect_lt(param_means["no2"], 26) + expect_gt(param_means["no2"], 27) + expect_lt(param_means["nox"], 20) + expect_gt(param_means["nox"], 21) + expect_lt(param_means["co"], 0.3) + expect_gt(param_means["co"], 0.4) + expect_lt(param_means["pm10"], 19) + expect_gt(param_means["pm10"], 20) + expect_lt(param_means["pm25"], 5) + expect_gt(param_means["pm25"], 7) # Testing data.frame classes expect_equal(TRUE, "data.frame" %in% class(pinheiros)) From 1bc328554c61f9f2f8759729839d02a4ed906262 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ma=C3=ABlle=20Salmon?= Date: Mon, 30 Sep 2024 06:49:36 +0200 Subject: [PATCH 3/3] test: use more specific expectations for class --- tests/testthat/test-cetesb_retrieve_met_pol.R | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/testthat/test-cetesb_retrieve_met_pol.R b/tests/testthat/test-cetesb_retrieve_met_pol.R index bde117c..df1091f 100644 --- a/tests/testthat/test-cetesb_retrieve_met_pol.R +++ b/tests/testthat/test-cetesb_retrieve_met_pol.R @@ -34,7 +34,10 @@ test_that("cetesb_retrieve_met_pol works!", { expect_gt(param_means["pm25"], 7) # Testing data.frame classes - expect_equal(TRUE, "data.frame" %in% class(pinheiros)) + expect_s3_class(pinheiros, "data.frame") + expect_type(pinheiros$tc, "double") + # but probably better + # expect_setequal(unname(apply(pinheiros, 2, class)), c()) expect_equal(TRUE, "numeric" %in% class(pinheiros$tc)) expect_equal(TRUE, "numeric" %in% class(pinheiros$rh)) expect_equal(TRUE, "numeric" %in% class(pinheiros$ws))