From 36048b69ab64935d93ceadfc759f2be01bc1dba5 Mon Sep 17 00:00:00 2001 From: Jonas Rembser Date: Fri, 31 Jul 2026 11:31:17 +0000 Subject: [PATCH] [RF][HF] Guard testHistFactory XML round trip with HISTFACTORY_XML This is already done for other parts of the test, and over time it was just forgotten to apply it consistently. (cherry picked from commit 0ee55a96fea9b7043b36a88818fd015481442048) --- roofit/histfactory/test/testHistFactory.cxx | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/roofit/histfactory/test/testHistFactory.cxx b/roofit/histfactory/test/testHistFactory.cxx index 843419a6a5d14..8bb9eabf62653 100644 --- a/roofit/histfactory/test/testHistFactory.cxx +++ b/roofit/histfactory/test/testHistFactory.cxx @@ -4,7 +4,9 @@ #include #include +#ifdef HISTFACTORY_XML #include +#endif #include #include @@ -897,6 +899,9 @@ TEST(HistFactory, ShapeFactorValueAndRange) } // 2. XML file round trip. + // The ConfigParser is only built with the xml build option, so this part + // of the test is skipped when ROOT is built without XML support. +#ifdef HISTFACTORY_XML { Measurement meas = makeMeasurement(); const std::string xmlDir = "TestShapeFactorRangeXML"; @@ -912,6 +917,7 @@ TEST(HistFactory, ShapeFactorValueAndRange) ASSERT_EQ(measFromXML.size(), 1u); checkShapeFactor(measFromXML.front(), "XML file round trip"); } +#endif // 3. End to end: the gamma parameters of the workspace pick up the requested // value and range.