Git completions limited

[TruePhoton]

It seems that z4h intercepts the normal git completion script and rejects some completions, for example if I run git while using z4h it shows 23 completions, while when using \git it shows 168 completions, some important commands like commit for example don't show up, this also causes issues with options (--smth) I tried to find a way to disable this behavior but I can't at all.

[romkatv]

What does whence git say?

[TruePhoton]

What does whence git say?

/opt/homebrew/bin/git

[TruePhoton]

it might be the case that the problem is in here in "fn/-z4h-init-zle", I can't find any way to disable it at all though

zstyle ':completion:*:git-*:argument-rest:heads-local'     ignored-patterns '(FETCH_|ORIG_|)HEAD'
zstyle ':completion:*:git-*:argument-rest:heads-remote'    ignored-patterns '*/HEAD'
zstyle ':completion:*:git-*:argument-rest:commits'         ignored-patterns '*'
zstyle ':completion:*:git-*:argument-rest:commit-objects'  ignored-patterns '*'
zstyle ':completion:*:git-*:argument-rest:recent-branches' ignored-patterns '*'

[romkatv]

These do indeed affect git completion, but not the subcommand completion, and they should affect \git completions just as well. The only difference between git and \git is that the latter does not undergo alias expansion. But given that on your system git isn't an alias, I don't know how they could possibly result in different completions.

[TruePhoton]

These do indeed affect git completion, but not the subcommand completion, and they should affect \git completions just as well. The only difference between git and \git is that the latter does not undergo alias expansion. But given that on your system git isn't an alias, I don't know how they could possibly result in different completions.

hmmm I m sure git isn't aliased to anything, but smth weird just happened, I just uninstalled homebrew git and used the preinstalled git on mac (/usr/bin/git) and the completions worked fine showing everything!? then in same session i insatlled homebrew git and completions also worked fine but then after restarting terminal it is back to showing much less completions, this problem seems homebrew related.

[TruePhoton]

Ok I found the solution but I don't understand what happens exactly, removing those 2 files makes it work, it now shows 141 completions (less than 168 completions for preinsatlled git but this doesn't seem to be a problem)

• /opt/homebrew/share/zsh/site-functions/_git
• /opt/homebrew/share/zsh/site-functions/git-completion.bash

I m not sure if everyone else has the same problem, I m also not sure if i ll always have to delete these 2 files everytime I brew upgrade git

[romkatv]

When you install git via homebrew, you are also installing completions for it. Apparently brew completions are worse than the default for you.

I still don't understand why you are getting different completions for git and \git. Are you able to reproduce this?

[TruePhoton]

When you install git via homebrew, you are also installing completions for it. Apparently brew completions are worse than the default for you.

I still don't understand why you are getting different completions for git and \git. Are you able to reproduce this?

Ok this is my first time opening an issue on github but I ll try.
before having this issue and when using preinstalled git (/usr/bin/git) typing git shows 141 completions, type _git gives _git is a shell function from /usr/share/zsh/5.9/functions/_git

Steps to reproduce:

1. brew install git, 3 files are installed "/opt/homebrew/share/zsh/site-functions/_git" and "/opt/homebrew/share/zsh/site-functions/git-completion.bash" and "/opt/homebrew/etc/bash_completion.d/git-completion.bash"
2. restart terminal
3. git now shows only 23 completions instead of 141 completions , type _git gives _git is a shell function from /opt/homebrew/share/zsh/site-functions/_git
4. remove "/opt/homebrew/share/zsh/site-functions/_git" then restart and now completions working fully again! (141 completions)

I think I know what is happening, when using preinstalled git _git is taken from "/usr/share/zsh/5.9/functions/_git" which works very well, after installing homebrew, _git is taken from "/opt/homebrew/share/zsh/site-functions" it calls the "git-completion.bash" script that is present in the same directory, now the stock _git function is 388,215 bytes while the git-completion.bash is 94,600 bytes so I m not sure if this is just normal behavior and intended. I hope someone else can confirm that when they type git they only get 23 items in fzf menu.

[LangLangBart]

I hope someone else can confirm that when they type git they only get 23 items in fzf menu.

✅ Confirmed

I still don't understand why you are getting different completions for git and \git. Are you able to reproduce this?

I believe the issue sits in /opt/homebrew/share/zsh/site-functions/_git

rg -C3 'zstyle -T' /opt/homebrew/share/zsh/site-functions/_git

21-#  zstyle ':completion:*:*:git:*' script ~/.git-completion.bash
22-#
23-
24:zstyle -T ':completion:*:*:git:*' tag-order && \
25-	zstyle ':completion:*:*:git:*' tag-order 'common-commands'
26-
27-zstyle -s ":completion:*:*:git:*" script script

Ref: https://github.com/git/git/blob/master/contrib/completion/git-completion.zsh

After adding the following line to my zshrc, tab completion behaves the same for git and \git.

zstyle ':completion:*:*:git:*' tag-order ''

@TruePhoton can u confirm ?

[LangLangBart]

The person who authored the zsh git completion still maintains his own repo:

• Ref: git <TAB> doesn't complete Git aliases with ZSH felipec/git-completion#7

Related discussions on git archive about it:

• Remove your ZSH completion in favor of the completion script distributed and maintained by ZSH

[dserodio]

After adding the following line to my zshrc, tab completion behaves the same for git and \git.

zstyle ':completion:::git:*' tag-order ''
@TruePhoton can u confirm ?

I'm not TrueProton but this worked for me

[LangLangBart]

I'm not TrueProton but this worked for me

Thanks. I was dissatisfied with the Git-provided Zsh completions, so I adjusted my fpath to give higher precedence to the default Zsh Git completions¹ bundled with every Zsh release.

# List matching file paths for _git completion functions in order of precedence
print -rl -- ${^fpath}/_git(N)

# .zshrc: Altered fpath
fpath=(
  "${ZDOTDIR:-$HOME}"/functions             # My own completions
  /usr/share/zsh/"${ZSH_VERSION}"/functions # Prefer default completions
  "${fpath[@]}"                             # Rest
)

Footnotes

1. https://github.com/zsh-users/zsh/blob/5.9/Completion/Unix/Command/_git ↩