Idea: visual indicator if a weakness is 4x effective

[ArchOwlen]

Not something I would use since I know typings, but could be useful for new pokemon players' ease-of-use

Also not sure what would make it "pop" the best without making a new box, as say: a "blue border" around the icon (like a discord status circle around the icon) wouldn't work well for blue-colored typings like ice (color blindness in mind especially)

Perhaps a 4x sub-circle to that weakness?
Though it may also be hard to see when small

[ArchOwlen]

This could also apply to 4x resistance, but the implementation could probably be the same as the type being resisted would be in the "strength" box, so context could be used to determine the 4x means resist

(In other words, the 4x sub-circle could be used in both strength and weakness as it would already be in the strength/weakness zone)

[roguedex-dev]

The problem with this is that via PokeAPI I have no way of knowing if a type is 2x or 4x weak/resistant to something.

[aalejandrofer]

You will have to calculate it. Let's say you have a Fighting and Bug because both have Flying in the 2x table then Flying becomes 4x.

Maybe something like this, probably better to combine with the existing fetch.

async function getTypeInfo(typeName) {
    const response = await fetch(`https://pokeapi.co/api/v2/type/${typeName}`);
    const data = await response.json();
    return data.damage_relations;
}

async function calculate4Damage(pokemonName, attackType) {
    const response = await fetch(`https://pokeapi.co/api/v2/pokemon/${pokemonName}`);
    const data = await response.json();

    if (data.types.length !== 2) {
        return False; // Pokemon does not have 2 types, therefore can not be 4x.
    }

    const type1Info = await getTypeInfo(data.types[0].type.name);
    const type2Info = await getTypeInfo(data.types[1].type.name);

    const type1Weaknesses = type1Info.double_damage_from.map(type => type.name);
    const type2Weaknesses = type2Info.double_damage_from.map(type => type.name);

    const overlap = type1Weaknesses.filter(type => type2Weaknesses.includes(type));

    if (overlap.includes(attackType)) {
        return True; // If it overlaps therefore 4x
    } else {
        return False; // If it does not
    }
}

[aalejandrofer]

It could be the same for 0.5x. I also like the idea of just doing a ring around the logo or something like that.

I guess one thing to add too, I don't know how big spliced Pokemon will become, now you only find them from now and then but might be worth seeing if is possible to get the types from the intercepted REQUEST and then calculate it on the extension using the PokeAPI just on /types/

[roguedex-dev]

So what you're saying is that there is no single type with 4x weakness / 1/4x resistance, and that it always comes from double typing?

[aalejandrofer]

To my understanding yes. Look at this site (https://www.pkmn.help/defense/) is also open-source.

[ArchOwlen]

In 99% of circumstances, yes, it is only possible with double typing

However, there are a few edge cases introduced in Scarlet/Violet where a move's description states
"This move is more effective against [type/s]"

I don't recall the specific move names, but I did spot one being used in PokeRogue
However, I don't remember if it was partially implemented as of right now

[aalejandrofer]

Yes you are right. Salt Cure is an example of that.

Salt Cure inflicts 1/8 of the target's maximum HP as damage per turn in addition to the damage dealt when it is used. If a Water type is affected by Salt Cure, the amount of damage per turn is ¼ of its maximum HP.

[aalejandrofer]

Also to my point above about DNA Splitting, also Terraforming affects what a pokemon is weak to. Thats why if possible I suggest only looking at the typing of the currentEnemy rather than the pokemon name/id.

Either calculate it or get ChatGPT to map out all combinations and put it on an enum data type file.

[ArchOwlen]

Yep, just tested and made #28 (even though it may be considered redundant)

We should probably track types rather than the pokemon themselves