colors from previously set colorscheme leak over to shadow scheme.

[effinsky]

title -- I am getting font colors with tresitter etc. from a different scheme when shadow scheme is set.

[vmarlier]

Hey @effinsky
I tried something, can you try to reproduce on this branch: https://github.com/vmarlier/shadow.nvim/tree/feat/treesitter-support

[effinsky]

Hey @effinsky I tried something, can you try to reproduce on this branch: vmarlier/shadow.nvim@feat/treesitter-support

it works with your changes.

[vmarlier]

I'll open a PR then

[effinsky]

of course, go ahead! honestly, I think this scheme needs some more work :) the contrast on the selections is real low, for instance

the comments themselves are not really too visible either -- and they are important -- so, imo, there's room for improvement, and thanks for trying to make it better!

[vmarlier]

I think this is pretty visible (coming from a colorblind guy lol) and this soft contrast approach was I think one of the goal of the creator. Not sure tho.

Can you try to propose some improvement maybe ? On my side I'm just trying to add support for the plugins I use. And I don't have so much understanding of color configuration.

[effinsky]

understood. I think it'd be good to add color configuration overrides so one could, for instance, tweak color contrasts on visual selection, comments, what have you.

[rjshkhr]

Yes, the theme could use improvements. I tested for the TreeSitter issue with a clean config but couldn't reproduce the bug. And as @vmarlier mentioned, the selection colors are an intentional design choice.

[effinsky]

Yes, the theme could use improvements. I tested for the TreeSitter issue with a clean config but couldn't reproduce the bug. And as @vmarlier mentioned, the selection colors are an intentional design choice.

sure, but could the colors not be tweakable as part of the config? else it's you know, forking.

[rjshkhr]

Yes, the theme could use improvements. I tested for the TreeSitter issue with a clean config but couldn't reproduce the bug. And as @vmarlier mentioned, the selection colors are an intentional design choice.

sure, but could the colors not be tweakable as part of the config? else it's you know, forking.

You can already override any highlight groups:
vim.api.nvim_set_hl(0, "Comment", { fg = "#ff0000" })

I plan to add options for customizing colors or changing theme variants.

[effinsky]

Yes, the theme could use improvements. I tested for the TreeSitter issue with a clean config but couldn't reproduce the bug. And as @vmarlier mentioned, the selection colors are an intentional design choice.

sure, but could the colors not be tweakable as part of the config? else it's you know, forking.

You can already override any highlight groups: vim.api.nvim_set_hl(0, "Comment", { fg = "#ff0000" })

I plan to add options for customizing colors or changing theme variants.

Those options are what I am talking about. I've overridden some in the way you are suggesting already, yes.