CompositeUserTypes CANNOT Short-circuit NullSafeSet

[jbtule]

Because this implementation is cited as an example across the internet. I feel it's important to point out a data corrupting bug in this generic implementation.

NullSafeSet needs to get called on each composite property with null when value is null.

If you don't and you have a batch save of objects with said composite type, any null value property will get be updated in the DB with the last nonnull value saved

ncommon/NCommon.NHibernate/src/CompositeUserTypeBase.cs

Lines 149 to 162 in 597f4ef

	public void NullSafeSet(IDbCommand cmd, object value, int index, ISessionImplementor session)
	{
	if (value == null)
	return;
	var propIndex = index;
	for (var i = 0; i < _properties.Count; i++)
	{
	var property = _properties[i];
	var propValue = property.GetValue(value, null);
	NHibernateUtil.GuessType(property.PropertyType).NullSafeSet(cmd, propValue, propIndex, session);
	propIndex++;
	}
	}