Skip to content

Implement From<> trait for actor message enum #161

Description

@elenaf9

The actor macro currently implements Into<#name> for #ty for each message type (#ty) in the message enum (#name), which enables converting from a specific message to the expected message enum.
From my point of view, implementing From<#ty> for #name would also implement the Into trait, but additionally serve more use cases, especially when working with generic message types, e.g. in such a case:

struct MyMessage;

struct MyStruct<T>
where
     T: From<MyMessage>
{
    actor: ActorRef<T>
}

impl<T> MyStruct<T> 
where
     T: From<MyMessage>
{
     fn msg_actor(&self, msg: MyMessage) {
           self.actor.tell(msg, None)
    }
}

Was there a specific reason for implementing Into instead of From?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions