fix snapshots to handle new assumption (files should be committed)

Author: jborkowski

README.md

@@ -130,7 +130,7 @@ To use it, first build using another system, and the run `taskrunner` with `TASK
 - Previous impl no-op tests/scripts/UPDATE: ~1.6s
 - Current impl no-op tests/scripts/UPDATE: ~2.3s
 
-## Snapshot Command Flags
+##  Snapshot Command Flags
 
 The `snapshot` command supports the following flags:
 
@@ -142,3 +142,15 @@ The `snapshot` command supports the following flags:
 - `--cache-version`: Specifies a version string for the cache. `--fuzzy-cache` will not download cache from another version, allowing clean breaks when making big changes, e.g. upgrading a compiler.
 - `--commit-status`: Enables reporting of the task's status to a commit status system, such as GitHub checks.
 - `--long-running`: Indicates that the task is expected to run for a long time (e.g. a server). Currently doens't have any effect though, TODO: can we remove it?
+
+
+## Tests: Update Golden Files
+
+This project uses [tasty-golden](https://github.com/UnkindPartition/tasty-golden) for snapshot-based testing.
+
+To update the golden files, run the test suite with the `--accept` flag passed to the test executable.
+If you're using stack, the full command is:
+
+```sh
+stack test --test-arguments --accept
+```

src/App.hs

@@ -457,7 +457,7 @@ snapshot appState args = do
 
     logInfo appState "Inputs changed, running task"
 
-    when (not force && hasRemoteCache args && args.fuzzyCache && mainBranchCommitChanged savedHashInfo hashInfo && inputsAreClean) do
+    when (not force && hasRemoteCache args && args.fuzzyCache && mainBranchCommitChanged savedHashInfo hashInfo) do
       success <- tryRestoreFuzzyCache appState args
       when success do
         -- Save change in mainBranchCommit, even if the task didn't succeed yet.

src/Utils.hs

@@ -81,6 +81,7 @@ bytesfmt formatter bs = printf (formatter <> " %s")
   bytesSuffix = bytesSuffixes !! i
 
 isDirtyAtPaths :: AppState -> [FilePath] -> IO Bool
+isDirtyAtPaths _ [] = pure False
 isDirtyAtPaths appState paths =
   bracket (hDuplicate appState.subprocessStderr) hClose \stderr_ -> do
     output <-

test/t/cache-success-unchanged.txt

@@ -10,6 +10,7 @@ mkdir a
   echo foo > input.txt
   git init -q
   git add input.txt
+  git commit -qm "Add input.txt"
 )
 
 cp -r a b

test/t/prime-cache-mode.txt

@@ -10,6 +10,7 @@ mkdir a
   echo foo > input.txt
   git init -q
   git add input.txt
+  git commit -qm "Add input.txt"
 )
 
 cp -r a b

test/t/remote-cache-changed.txt

@@ -10,6 +10,7 @@ mkdir a
   echo foo > input.txt
   git init -q
   git add input.txt
+  git commit -qm "Add input.txt"
 )
 
 cp -r a b

test/t/remote-cache-post-unpack.txt

@@ -10,6 +10,7 @@ mkdir a
   echo foo > input.txt
   git init -q
   git add input.txt
+  git commit -qm "Add input.txt"
 )
 
 cp -r a b

test/t/remote-cache-unchanged-force.txt

@@ -10,6 +10,7 @@ mkdir a
   echo foo > input.txt
   git init -q
   git add input.txt
+  git commit -qm "Add input.txt"
 )
 
 cp -r a b

test/t/remote-cache-unchanged-nested-dir.txt

@@ -15,6 +15,7 @@ mkdir -p a
   cd nested
   echo foo > input.txt
   git add input.txt
+  git commit -qm "Add input.txt"
 )
 
 cp -r a b

test/t/remote-cache-unchanged-out-of-repo.txt

@@ -10,6 +10,7 @@ mkdir a
   echo foo > input.txt
   git init -q
   git add input.txt
+  git commit -qm "Add input.txt"
 )
 
 cp -r a b