Commit c707272
authored
fix(ci): inline the PyPI publish step instead of a composite action (#93)
* fix(ci): inline the PyPI publish step instead of a composite action
pypa/gh-action-pypi-publish is a Docker container action. Nested inside
reqstool/.github's actions/publish-to-pypi composite action, GitHub
resolved its image using the composite action's own repo and pinned
ref instead of the Docker action's, and every real publish failed with
`docker: invalid reference format`. The action's own maintainers say
this usage is untested and unsupported.
Both steps -- download-artifact and the actual publish -- are now
inline, matching the pattern the upstream workaround comment already
showed (see reqstool/.github#95 for the full writeup). There is no
shared action for this step in the org at all now; what remained after
removing the publish call wasn't enough to justify one.
Needs reqstool/.github#94 merged first.
Signed-off-by: Jimisola Laursen <jimisola@jimisola.com>
* refactor(ci): use download-dists for the artifact half
Reworks the previous commit. Composite actions were not the problem --
one creates no new workflow context, so the job keeps this repo's own
OIDC identity, which is why it works where a reusable workflow does not.
Only pypa/gh-action-pypi-publish had to come out of it, because nesting
a Docker container action makes GitHub resolve its image against the
wrapping action's repository.
So the download goes back to a shared action, renamed download-dists
now that it no longer publishes, and only the publish step stays inline.
Still pinned at @main here; reqstool/.github#94 has to merge before a
commit SHA exists to pin to. That pin lands before this PR merges.
Signed-off-by: Jimisola Laursen <jimisola@jimisola.com>
---------
Signed-off-by: Jimisola Laursen <jimisola@jimisola.com>1 parent 88a0d25 commit c707272
1 file changed
Lines changed: 7 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
109 | 109 | | |
110 | 110 | | |
111 | 111 | | |
112 | | - | |
| 112 | + | |
113 | 113 | | |
114 | 114 | | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
115 | 121 | | |
116 | 122 | | |
117 | 123 | | |
| |||
0 commit comments