From c26943f72bb016765b2e9235b3f8e0d32780b72f Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:15:53 -0300 Subject: [PATCH 001/112] feat: add tenant foundation contracts --- .../Common/Tenancy/TenancyContracts.cs | 84 +++++++++++++++++++ 1 file changed, 84 insertions(+) create mode 100644 src/server/RemoteTickets.Application/Common/Tenancy/TenancyContracts.cs diff --git a/src/server/RemoteTickets.Application/Common/Tenancy/TenancyContracts.cs b/src/server/RemoteTickets.Application/Common/Tenancy/TenancyContracts.cs new file mode 100644 index 0000000..a538ed9 --- /dev/null +++ b/src/server/RemoteTickets.Application/Common/Tenancy/TenancyContracts.cs @@ -0,0 +1,84 @@ +namespace RemoteTickets.Application.Common.Tenancy; + +/// Contains the application roles used by the tenant-aware authorization model. +public static class TenantRoles +{ + /// Gets the role that can administer the complete installation and every tenant. + public const string SysAdmin = "sysadmin"; + /// Gets the role that can administer a single tenant. + public const string TenantAdmin = "tenadmin"; + /// Gets the role that can operate the cash register and other non-configuration business functions. + public const string TenantOperator = "tenop"; + /// Gets the role that can perform attendance and non-critical business operations. + public const string TenantAttendant = "tenat"; +} + +/// Contains claim names used by the tenant-aware security model. +public static class TenantClaimTypes +{ + /// Gets the claim containing the tenant identifier assigned to a user. + public const string TenantId = "tenant_id"; +} + +/// Contains authorization policy names used by tenant-aware endpoints. +public static class TenantPolicies +{ + /// Gets the policy requiring system administration privileges. + public const string SysAdmin = "tenant.sysadmin"; + /// Gets the policy requiring tenant administration privileges. + public const string TenantAdmin = "tenant.admin"; + /// Gets the policy requiring operator privileges. + public const string TenantOperator = "tenant.operator"; + /// Gets the policy requiring attendant privileges. + public const string TenantAttendant = "tenant.attendant"; +} + +/// Represents the setup state of a tenant database. +/// Indicates whether tenant setup is still required. +/// Indicates whether tenant setup has completed. +public sealed record TenantSetupStatusResponse(bool IsSetupRequired, bool IsSetupComplete); + +/// Represents a tenant exposed to system administrators. +/// The stable tenant identifier used in routes. +/// The tenant display name. +/// The database name assigned to the tenant. +/// Indicates whether the tenant accepts normal operations. +/// Indicates whether tenant setup has completed. +public sealed record TenantResponse(string Id, string Name, string DatabaseName, bool IsActive, bool IsSetupComplete); + +/// Represents a request to provision a tenant and its first administrator. +/// The tenant identifier. +/// The tenant display name. +/// The SQL Server database name. +/// The connection string for the tenant database. +/// The first tenant administrator email. +/// The first tenant administrator password. +public sealed record CreateTenantRequest(string Id, string Name, string DatabaseName, string ConnectionString, string AdminEmail, string AdminPassword); + +/// Provides tenant registration and setup operations. +public interface ITenantManagementService +{ + /// Gets a tenant by its route identifier. + /// The tenant route identifier. + /// The token used to cancel the operation. + /// The tenant, or when it does not exist. + Task GetAsync(string tenantId, CancellationToken cancellationToken); + + /// Creates a tenant database and its first tenant administrator. + /// The tenant provisioning request. + /// The token used to cancel the operation. + /// The provisioned tenant. + Task CreateAsync(CreateTenantRequest request, CancellationToken cancellationToken); + + /// Gets the setup state stored in a tenant database. + /// The tenant route identifier. + /// The token used to cancel the operation. + /// The tenant setup state. + Task GetSetupStatusAsync(string tenantId, CancellationToken cancellationToken); + + /// Completes tenant setup after all tenant initialization checks have succeeded. + /// The tenant route identifier. + /// The token used to cancel the operation. + /// The resulting setup state. + Task CompleteSetupAsync(string tenantId, CancellationToken cancellationToken); +} From 83ee3dfea2bca8ae4a7b6237810ad027d4d9e5a9 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:15:58 -0300 Subject: [PATCH 002/112] feat: associate identity users with tenants --- .../Identity/Models/User.cs | 28 ++++++++----------- 1 file changed, 11 insertions(+), 17 deletions(-) diff --git a/src/server/RemoteTickets.Infrastructure/Identity/Models/User.cs b/src/server/RemoteTickets.Infrastructure/Identity/Models/User.cs index 6670520..29b5e51 100644 --- a/src/server/RemoteTickets.Infrastructure/Identity/Models/User.cs +++ b/src/server/RemoteTickets.Infrastructure/Identity/Models/User.cs @@ -1,8 +1,6 @@ namespace RemoteTickets.Infrastructure.Identity.Models; -/// -/// Represents a user in the RemoteTickets application. -/// +/// Represents a user in the RemoteTickets application. public class User : IdentityUser, ISoftDeletable { /// User name displayed in the application. @@ -11,21 +9,17 @@ public class User : IdentityUser, ISoftDeletable public string? FirstName { get; set; } = string.Empty; /// Surname of the user. public string? SurName { get; set; } = string.Empty; + /// Gets or sets the tenant to which the user belongs. A null value identifies a system administrator. + public string? TenantId { get; set; } /// Indicates whether the user is deleted. - public bool IsDeleted { get; set; } + public bool IsDeleted { get; set; } /// Gets or sets the date and time when the user was deleted. - public DateTimeOffset? DeletedAt { get; set; } = null!; + public DateTimeOffset? DeletedAt { get; set; } - /// - /// Initializes a new instance of the class. - /// - public User() : base() - { - Id = Guid.CreateVersion7().ToString(); - } - /// - public User(string name) : base(name) - { - Id = Guid.CreateVersion7().ToString(); - } + /// Initializes a new instance of the class. + public User() : base() => Id = Guid.CreateVersion7().ToString(); + + /// Initializes a new user with the supplied user name. + /// The user name. + public User(string name) : base(name) => Id = Guid.CreateVersion7().ToString(); } From ec74abfd5eb6d7d4858eeee03419de199f2e2203 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:16:03 -0300 Subject: [PATCH 003/112] feat: add tenant catalog entity --- .../Tenancy/Models/Tenant.cs | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 src/server/RemoteTickets.Infrastructure/Tenancy/Models/Tenant.cs diff --git a/src/server/RemoteTickets.Infrastructure/Tenancy/Models/Tenant.cs b/src/server/RemoteTickets.Infrastructure/Tenancy/Models/Tenant.cs new file mode 100644 index 0000000..979028d --- /dev/null +++ b/src/server/RemoteTickets.Infrastructure/Tenancy/Models/Tenant.cs @@ -0,0 +1,20 @@ +namespace RemoteTickets.Infrastructure.Tenancy.Models; + +/// Represents a tenant registered in the installation catalog. +public sealed class Tenant +{ + /// Gets or sets the stable tenant identifier used by routes and tokens. + public string Id { get; set; } = string.Empty; + /// Gets or sets the display name of the tenant. + public string Name { get; set; } = string.Empty; + /// Gets or sets the SQL Server database name assigned to the tenant. + public string DatabaseName { get; set; } = string.Empty; + /// Gets or sets the connection string used to access the tenant database. + public string ConnectionString { get; set; } = string.Empty; + /// Gets or sets whether the tenant accepts normal requests. + public bool IsActive { get; set; } = true; + /// Gets or sets whether tenant setup has completed. + public bool IsSetupComplete { get; set; } + /// Gets or sets the tenant creation timestamp. + public DateTimeOffset CreatedAt { get; set; } = DateTimeOffset.UtcNow; +} From 99796310acb43cfc21524155726c4ed54129af99 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:16:06 -0300 Subject: [PATCH 004/112] feat: add tenant setup state --- .../Tenancy/Models/TenantSetupState.cs | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 src/server/RemoteTickets.Infrastructure/Tenancy/Models/TenantSetupState.cs diff --git a/src/server/RemoteTickets.Infrastructure/Tenancy/Models/TenantSetupState.cs b/src/server/RemoteTickets.Infrastructure/Tenancy/Models/TenantSetupState.cs new file mode 100644 index 0000000..7cf0ddc --- /dev/null +++ b/src/server/RemoteTickets.Infrastructure/Tenancy/Models/TenantSetupState.cs @@ -0,0 +1,12 @@ +namespace RemoteTickets.Infrastructure.Tenancy.Models; + +/// Stores the initialization state of a tenant database. +public sealed class TenantSetupState +{ + /// Gets or sets the singleton setup-state identifier. + public int Id { get; set; } = 1; + /// Gets or sets whether the tenant database setup has completed. + public bool IsComplete { get; set; } + /// Gets or sets the last setup validation timestamp. + public DateTimeOffset? CompletedAt { get; set; } +} From 4b63bd4c2565b579399d2d99175b710a80aabbc3 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:16:10 -0300 Subject: [PATCH 005/112] feat: add tenant setup db context --- .../Tenancy/TenantSetupDbContext.cs | 21 +++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 src/server/RemoteTickets.Infrastructure/Tenancy/TenantSetupDbContext.cs diff --git a/src/server/RemoteTickets.Infrastructure/Tenancy/TenantSetupDbContext.cs b/src/server/RemoteTickets.Infrastructure/Tenancy/TenantSetupDbContext.cs new file mode 100644 index 0000000..205dcb3 --- /dev/null +++ b/src/server/RemoteTickets.Infrastructure/Tenancy/TenantSetupDbContext.cs @@ -0,0 +1,21 @@ +using RemoteTickets.Infrastructure.Tenancy.Models; + +namespace RemoteTickets.Infrastructure.Tenancy; + +/// Provides persistence for tenant-database initialization state. +public sealed class TenantSetupDbContext(DbContextOptions options) : DbContext(options) +{ + /// Gets the singleton tenant setup state. + public DbSet SetupStates => Set(); + + /// + protected override void OnModelCreating(ModelBuilder modelBuilder) + { + modelBuilder.Entity(entity => + { + entity.ToTable("TenantSetupState"); + entity.HasKey(x => x.Id); + entity.Property(x => x.IsComplete).IsRequired(); + }); + } +} From 7b2428aa0a56e0fd726c3c6d7dfa423c6a7be150 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:16:16 -0300 Subject: [PATCH 006/112] feat: add tenant catalog persistence --- .../Persistence/InvisibleSPDbContext.cs | 27 +++++++++++++------ 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/src/server/RemoteTickets.Infrastructure/Persistence/InvisibleSPDbContext.cs b/src/server/RemoteTickets.Infrastructure/Persistence/InvisibleSPDbContext.cs index ab37dd2..a2345ae 100644 --- a/src/server/RemoteTickets.Infrastructure/Persistence/InvisibleSPDbContext.cs +++ b/src/server/RemoteTickets.Infrastructure/Persistence/InvisibleSPDbContext.cs @@ -1,18 +1,30 @@ using Microsoft.EntityFrameworkCore.ChangeTracking; +using RemoteTickets.Infrastructure.Tenancy.Models; namespace RemoteTickets.Infrastructure.Persistence; -/// -/// Represents the database context for the RemoteTickets application. -/// -public sealed class RemoteTicketsDbContext( - DbContextOptions options) : IdentityDbContext(options) +/// Represents the central database context for RemoteTickets identity and tenant catalog data. +public sealed class RemoteTicketsDbContext(DbContextOptions options) : IdentityDbContext(options) { + /// Gets the registered tenants. + public DbSet Tenants => Set(); + /// protected override void OnModelCreating(ModelBuilder builder) { base.OnModelCreating(builder); + builder.Entity(entity => + { + entity.ToTable("Tenants"); + entity.HasKey(x => x.Id); + entity.Property(x => x.Id).HasMaxLength(128); + entity.Property(x => x.Name).HasMaxLength(256).IsRequired(); + entity.Property(x => x.DatabaseName).HasMaxLength(128).IsRequired(); + entity.Property(x => x.ConnectionString).IsRequired(); + entity.HasIndex(x => x.DatabaseName).IsUnique(); + }); + foreach (var entityType in builder.Model.GetEntityTypes()) { if (!typeof(ISoftDeletable).IsAssignableFrom(entityType.ClrType)) @@ -25,6 +37,7 @@ protected override void OnModelCreating(ModelBuilder builder) var filter = Expression.Lambda(Expression.Not(property), parameter); builder.Entity(entityType.ClrType).HasQueryFilter(filter); } + builder.ApplyConfigurationsFromAssembly(typeof(RemoteTicketsDbContext).Assembly); } @@ -43,9 +56,7 @@ public override int SaveChanges() } /// - public override Task SaveChangesAsync( - bool acceptAllChangesOnSuccess, - CancellationToken cancellationToken = default) + public override Task SaveChangesAsync(bool acceptAllChangesOnSuccess, CancellationToken cancellationToken = default) { ApplySoftDelete(); return base.SaveChangesAsync(acceptAllChangesOnSuccess, cancellationToken); From 9b5c1daf9a31eb9619f8ff30f9bc79dc06157f94 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:16:29 -0300 Subject: [PATCH 007/112] feat: implement tenant provisioning and setup --- .../Tenancy/TenantManagementService.cs | 140 ++++++++++++++++++ 1 file changed, 140 insertions(+) create mode 100644 src/server/RemoteTickets.Infrastructure/Tenancy/TenantManagementService.cs diff --git a/src/server/RemoteTickets.Infrastructure/Tenancy/TenantManagementService.cs b/src/server/RemoteTickets.Infrastructure/Tenancy/TenantManagementService.cs new file mode 100644 index 0000000..4134bf4 --- /dev/null +++ b/src/server/RemoteTickets.Infrastructure/Tenancy/TenantManagementService.cs @@ -0,0 +1,140 @@ +using Microsoft.Data.SqlClient; +using RemoteTickets.Application.Common.Tenancy; +using RemoteTickets.Infrastructure.Tenancy.Models; + +namespace RemoteTickets.Infrastructure.Tenancy; + +/// Implements tenant catalog, database provisioning, and tenant setup operations. +public sealed class TenantManagementService( + RemoteTicketsDbContext catalog, + IIdentityService identityService, + ILogger logger) : ITenantManagementService +{ + /// + public async Task GetAsync(string tenantId, CancellationToken cancellationToken) + { + var tenant = await catalog.Tenants.AsNoTracking().SingleOrDefaultAsync(x => x.Id == tenantId, cancellationToken); + return tenant is null ? null : Map(tenant); + } + + /// + public async Task CreateAsync(CreateTenantRequest request, CancellationToken cancellationToken) + { + Validate(request); + if (await catalog.Tenants.AnyAsync(x => x.Id == request.Id, cancellationToken)) + { + throw new InvalidOperationException($"Tenant '{request.Id}' already exists."); + } + + await CreateDatabaseAsync(request.ConnectionString, request.DatabaseName, cancellationToken); + await InitializeTenantDatabaseAsync(request.ConnectionString, cancellationToken); + + var tenant = new Tenant + { + Id = request.Id, + Name = request.Name, + DatabaseName = request.DatabaseName, + ConnectionString = request.ConnectionString, + IsActive = true, + IsSetupComplete = false + }; + + catalog.Tenants.Add(tenant); + await catalog.SaveChangesAsync(cancellationToken); + + var adminResult = await identityService.CreateTenantAdminAsync(request.Id, request.AdminEmail, request.AdminPassword, cancellationToken); + if (!adminResult.Succeeded) + { + catalog.Tenants.Remove(tenant); + await catalog.SaveChangesAsync(cancellationToken); + throw new InvalidOperationException(string.Join(" ", adminResult.Errors)); + } + + logger.LogInformation("Tenant {TenantId} was provisioned with database {DatabaseName}.", request.Id, request.DatabaseName); + return Map(tenant); + } + + /// + public async Task GetSetupStatusAsync(string tenantId, CancellationToken cancellationToken) + { + var tenant = await GetTenantEntityAsync(tenantId, cancellationToken); + await using var context = CreateSetupContext(tenant.ConnectionString); + await context.Database.EnsureCreatedAsync(cancellationToken); + var state = await context.SetupStates.SingleOrDefaultAsync(x => x.Id == 1, cancellationToken); + return new TenantSetupStatusResponse(state is null || !state.IsComplete, state?.IsComplete == true); + } + + /// + public async Task CompleteSetupAsync(string tenantId, CancellationToken cancellationToken) + { + var tenant = await GetTenantEntityAsync(tenantId, cancellationToken); + await using var context = CreateSetupContext(tenant.ConnectionString); + await context.Database.EnsureCreatedAsync(cancellationToken); + var state = await context.SetupStates.SingleOrDefaultAsync(x => x.Id == 1, cancellationToken); + if (state is null) + { + state = new TenantSetupState { Id = 1 }; + context.SetupStates.Add(state); + } + + state.IsComplete = true; + state.CompletedAt = DateTimeOffset.UtcNow; + await context.SaveChangesAsync(cancellationToken); + + tenant.IsSetupComplete = true; + await catalog.SaveChangesAsync(cancellationToken); + return new TenantSetupStatusResponse(false, true); + } + + private async Task GetTenantEntityAsync(string tenantId, CancellationToken cancellationToken) + { + return await catalog.Tenants.SingleOrDefaultAsync(x => x.Id == tenantId, cancellationToken) + ?? throw new KeyNotFoundException($"Tenant '{tenantId}' was not found."); + } + + private static TenantSetupDbContext CreateSetupContext(string connectionString) + { + var options = new DbContextOptionsBuilder() + .UseSqlServer(connectionString) + .Options; + return new TenantSetupDbContext(options); + } + + private static async Task CreateDatabaseAsync(string connectionString, string databaseName, CancellationToken cancellationToken) + { + var builder = new SqlConnectionStringBuilder(connectionString); + builder.InitialCatalog = "master"; + await using var connection = new SqlConnection(builder.ConnectionString); + await connection.OpenAsync(cancellationToken); + var escaped = $"[{databaseName.Replace("]", "]]", StringComparison.Ordinal)}]"; + await using var command = connection.CreateCommand(); + command.CommandText = $"IF DB_ID(@databaseName) IS NULL CREATE DATABASE {escaped};"; + command.Parameters.AddWithValue("@databaseName", databaseName); + await command.ExecuteNonQueryAsync(cancellationToken); + } + + private static async Task InitializeTenantDatabaseAsync(string connectionString, CancellationToken cancellationToken) + { + await using var context = CreateSetupContext(connectionString); + // The repository currently has no EF migration history. EnsureCreated creates the foundation schema; + // the same tenant connection is used by the future migration runner when migrations are introduced. + await context.Database.MigrateAsync(cancellationToken); + await context.Database.EnsureCreatedAsync(cancellationToken); + } + + private static void Validate(CreateTenantRequest request) + { + if (string.IsNullOrWhiteSpace(request.Id) || string.IsNullOrWhiteSpace(request.DatabaseName)) + { + throw new ArgumentException("Tenant id and database name are required."); + } + + if (string.IsNullOrWhiteSpace(request.ConnectionString)) + { + throw new ArgumentException("A tenant database connection string is required."); + } + } + + private static TenantResponse Map(Tenant tenant) => + new(tenant.Id, tenant.Name, tenant.DatabaseName, tenant.IsActive, tenant.IsSetupComplete); +} From 7d66c8269fa69ac41f99f15686276dcf7f3d7a17 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:16:33 -0300 Subject: [PATCH 008/112] feat: register tenant infrastructure namespaces --- src/server/RemoteTickets.Infrastructure/GlobalUsings.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/server/RemoteTickets.Infrastructure/GlobalUsings.cs b/src/server/RemoteTickets.Infrastructure/GlobalUsings.cs index 5d848bd..54289f1 100644 --- a/src/server/RemoteTickets.Infrastructure/GlobalUsings.cs +++ b/src/server/RemoteTickets.Infrastructure/GlobalUsings.cs @@ -9,9 +9,11 @@ global using System.Threading; global using System.Threading.Tasks; global using RemoteTickets.Application.Common.Identity; +global using RemoteTickets.Application.Common.Tenancy; global using RemoteTickets.Application.Identity; global using RemoteTickets.Domain.Common; global using RemoteTickets.Infrastructure.Identity.Models; +global using RemoteTickets.Infrastructure.Persistence; global using Microsoft.AspNetCore.Identity; global using Microsoft.AspNetCore.Identity.EntityFrameworkCore; global using Microsoft.EntityFrameworkCore; From 6691c27657585b73298c65b40d3fe686c84fd99f Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:16:50 -0300 Subject: [PATCH 009/112] feat: extend identity contract for tenant authorization --- .../Identity/IIdentityService.cs | 22 +++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/src/server/RemoteTickets.Application/Identity/IIdentityService.cs b/src/server/RemoteTickets.Application/Identity/IIdentityService.cs index be2c2e8..110a380 100644 --- a/src/server/RemoteTickets.Application/Identity/IIdentityService.cs +++ b/src/server/RemoteTickets.Application/Identity/IIdentityService.cs @@ -19,6 +19,24 @@ public interface IIdentityService /// The token pair, or when authentication fails. Task LoginAsync(string email, string password, string? twoFactorCode, string? twoFactorRecoveryCode, CancellationToken cancellationToken); + /// Authenticates a user against a tenant route and rejects users assigned to another tenant. + /// The tenant identifier supplied by the route. + /// The user's email address. + /// The user's password. + /// The authenticator code, when two-factor authentication is enabled. + /// The recovery code, when a recovery code is used instead of an authenticator code. + /// The token used to cancel the operation. + /// The token pair, or when the credentials or tenant assignment are invalid. + Task LoginAsync(string tenantId, string email, string password, string? twoFactorCode, string? twoFactorRecoveryCode, CancellationToken cancellationToken); + + /// Creates the first administrator account for a tenant in the central identity store. + /// The tenant identifier assigned to the user. + /// The administrator email address. + /// The administrator password. + /// The token used to cancel the operation. + /// The user creation result. + Task CreateTenantAdminAsync(string tenantId, string email, string password, CancellationToken cancellationToken); + /// Exchanges a valid refresh token for a new token pair. /// The refresh token to exchange. /// The token used to cancel the operation. @@ -79,8 +97,8 @@ public interface IIdentityService /// Whether to enable or disable two-factor authentication. /// The authenticator code used to validate enabling two-factor authentication. /// Whether recovery codes should be regenerated. - /// Whether the authenticator shared key should be regenerated. - /// Whether the current machine should be forgotten. + /// Whether the shared authenticator key should be regenerated. + /// Whether the remembered machine state should be cleared. /// The token used to cancel the operation. /// The current configuration, or when the operation cannot be completed. Task ConfigureTwoFactorAsync(string userId, bool? enable, string? twoFactorCode, bool resetRecoveryCodes, bool resetSharedKey, bool forgetMachine, CancellationToken cancellationToken); From dc126ff37785041047d1a507ed4bfa2464126ecb Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:17:04 -0300 Subject: [PATCH 010/112] feat: integrate tenant roles into identity setup --- .../Identity/Services/IdentityService.cs | 392 ++++-------------- 1 file changed, 72 insertions(+), 320 deletions(-) diff --git a/src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.cs b/src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.cs index 464f47d..1bce21a 100644 --- a/src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.cs +++ b/src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.cs @@ -10,7 +10,7 @@ namespace RemoteTickets.Infrastructure.Identity.Services; /// The store used to track revoked tokens. /// The service used to send identity-related email messages. /// The logger used to record operational identity events. -public sealed class IdentityService( +public sealed partial class IdentityService( UserManager userManager, RoleManager roleManager, SignInManager signInManager, @@ -22,407 +22,174 @@ public sealed class IdentityService( private const string AdministratorRole = "Administrator"; private const string AdministratorPermission = "system.admin"; - /// - /// Registers a new user and sends an email confirmation link. - /// - /// The email address of the user. - /// The password to assign to the user. - /// The token used to cancel the operation. - /// The result of the registration operation. + /// Registers a new user and sends an email confirmation link. public async Task RegisterAsync(string email, string password, CancellationToken cancellationToken) { - var user = new User(email) - { - Email = email, - DisplayName = "", - FirstName = "", - SurName = "", - EmailConfirmed = false - }; - + var user = new User(email) { Email = email, DisplayName = "", FirstName = "", SurName = "", EmailConfirmed = false }; var result = await userManager.CreateAsync(user, password); - if (!result.Succeeded) - { - return Failure(result); - } - + if (!result.Succeeded) return Failure(result); var code = await userManager.GenerateEmailConfirmationTokenAsync(user); - await emailSender.SendConfirmationAsync( - email, - $"/confirmEmail?userId={Uri.EscapeDataString(user.Id)}&code={Uri.EscapeDataString(code)}", - cancellationToken); - + await emailSender.SendConfirmationAsync(email, $"/confirmEmail?userId={Uri.EscapeDataString(user.Id)}&code={Uri.EscapeDataString(code)}", cancellationToken); return IdentityResultResponse.Success(); } - /// - /// Authenticates a user and issues JWT access and refresh tokens when all required authentication factors are valid. - /// - /// The user's email address. - /// The user's password. - /// The authenticator application code, when two-factor authentication is enabled. - /// The recovery code, when two-factor authentication is enabled and a recovery code is used. - /// The token used to cancel the operation. - /// The issued tokens, or when authentication fails. - public async Task LoginAsync( - string email, - string password, - string? twoFactorCode, - string? twoFactorRecoveryCode, - CancellationToken cancellationToken) + /// Authenticates a user and issues JWT access and refresh tokens when all required authentication factors are valid. + public async Task LoginAsync(string email, string password, string? twoFactorCode, string? twoFactorRecoveryCode, CancellationToken cancellationToken) { var user = await userManager.FindByEmailAsync(email); - if (user is null) - { - return null; - } - + if (user is null) return null; var passwordResult = await signInManager.CheckPasswordSignInAsync(user, password, true); - if (passwordResult.IsLockedOut || passwordResult.IsNotAllowed || !passwordResult.Succeeded) - { - return null; - } - + if (passwordResult.IsLockedOut || passwordResult.IsNotAllowed || !passwordResult.Succeeded) return null; if (await userManager.GetTwoFactorEnabledAsync(user)) { var valid = !string.IsNullOrWhiteSpace(twoFactorCode) - ? await userManager.VerifyTwoFactorTokenAsync( - user, - userManager.Options.Tokens.AuthenticatorTokenProvider, - twoFactorCode) - : !string.IsNullOrWhiteSpace(twoFactorRecoveryCode) && - (await userManager.RedeemTwoFactorRecoveryCodeAsync(user, twoFactorRecoveryCode)).Succeeded; - - if (!valid) - { - return null; - } + ? await userManager.VerifyTwoFactorTokenAsync(user, userManager.Options.Tokens.AuthenticatorTokenProvider, twoFactorCode) + : !string.IsNullOrWhiteSpace(twoFactorRecoveryCode) && (await userManager.RedeemTwoFactorRecoveryCodeAsync(user, twoFactorRecoveryCode)).Succeeded; + if (!valid) return null; } - return await CreateUserTokensAsync(user, cancellationToken); } - /// - /// Exchanges a valid refresh token for a new access and refresh token pair and revokes the previous refresh token. - /// - /// The refresh token to exchange. - /// The token used to cancel the operation. - /// The new token pair, or when the refresh token is invalid. + /// Exchanges a valid refresh token for a new access and refresh token pair and revokes the previous refresh token. public async Task RefreshAsync(string refreshToken, CancellationToken cancellationToken) { var principal = tokenService.ValidateToken(refreshToken); - if (principal is null || !string.Equals(principal.FindFirstValue("token_type"), JwtTokenTypes.Refresh, StringComparison.Ordinal)) - { - return null; - } - - var userId = principal.FindFirstValue(JwtRegisteredClaimNames.Sub); - if (string.IsNullOrWhiteSpace(userId)) - { - userId = principal.FindFirstValue(ClaimTypes.NameIdentifier); - } - - if (string.IsNullOrWhiteSpace(userId)) - { - return null; - } - + if (principal is null || !string.Equals(principal.FindFirstValue("token_type"), JwtTokenTypes.Refresh, StringComparison.Ordinal)) return null; + var userId = principal.FindFirstValue(JwtRegisteredClaimNames.Sub) ?? principal.FindFirstValue(ClaimTypes.NameIdentifier); + if (string.IsNullOrWhiteSpace(userId)) return null; var user = await userManager.FindByIdAsync(userId); - if (user is null) - { - return null; - } - + if (user is null) return null; var tokenId = tokenService.GetTokenId(refreshToken); var expiration = tokenService.GetExpiration(refreshToken); var tokens = await CreateUserTokensAsync(user, cancellationToken); - - if (!string.IsNullOrWhiteSpace(tokenId) && expiration.HasValue) - { - revokedTokenStore.Revoke(tokenId, expiration.Value); - } - + if (!string.IsNullOrWhiteSpace(tokenId) && expiration.HasValue) revokedTokenStore.Revoke(tokenId, expiration.Value); return tokens; } - /// - /// Revokes a valid access token until its natural expiration. - /// - /// The access token to revoke. - /// The token used to cancel the operation. - /// when the token was revoked; otherwise, . + /// Revokes a valid access token until its natural expiration. public Task RevokeAsync(string accessToken, CancellationToken cancellationToken) { var principal = tokenService.ValidateToken(accessToken); var tokenId = tokenService.GetTokenId(accessToken); var expiration = tokenService.GetExpiration(accessToken); - - if (principal is null || string.IsNullOrWhiteSpace(tokenId) || !expiration.HasValue) - { - return Task.FromResult(false); - } - + if (principal is null || string.IsNullOrWhiteSpace(tokenId) || !expiration.HasValue) return Task.FromResult(false); revokedTokenStore.Revoke(tokenId, expiration.Value); return Task.FromResult(true); } - /// - /// Confirms a user's email address or confirms a changed email address using a supplied Identity token. - /// - /// The identifier of the user. - /// The confirmation token. - /// The new email address when confirming an email change; otherwise . - /// The token used to cancel the operation. - /// when confirmation succeeds; otherwise, . + /// Confirms a user's email address or confirms a changed email address using a supplied Identity token. public async Task ConfirmEmailAsync(string userId, string code, string? changedEmail, CancellationToken cancellationToken) { var user = await userManager.FindByIdAsync(userId); - if (user is null) - { - return false; - } - - var result = !string.IsNullOrWhiteSpace(changedEmail) - ? await userManager.ChangeEmailAsync(user, changedEmail, code) - : await userManager.ConfirmEmailAsync(user, code); - + if (user is null) return false; + var result = !string.IsNullOrWhiteSpace(changedEmail) ? await userManager.ChangeEmailAsync(user, changedEmail, code) : await userManager.ConfirmEmailAsync(user, code); return result.Succeeded; } - /// - /// Resends an email confirmation link when the specified user exists and remains unconfirmed. - /// - /// The email address of the user. - /// The token used to cancel the operation. - /// The result of the resend operation. + /// Resends an email confirmation link when the specified user exists and remains unconfirmed. public async Task ResendConfirmationEmailAsync(string email, CancellationToken cancellationToken) { var user = await userManager.FindByEmailAsync(email); - if (user is null || await userManager.IsEmailConfirmedAsync(user)) - { - return IdentityResultResponse.Success(); - } - + if (user is null || await userManager.IsEmailConfirmedAsync(user)) return IdentityResultResponse.Success(); var code = await userManager.GenerateEmailConfirmationTokenAsync(user); - await emailSender.SendConfirmationAsync( - email, - $"/confirmEmail?userId={Uri.EscapeDataString(user.Id)}&code={Uri.EscapeDataString(code)}", - cancellationToken); - + await emailSender.SendConfirmationAsync(email, $"/confirmEmail?userId={Uri.EscapeDataString(user.Id)}&code={Uri.EscapeDataString(code)}", cancellationToken); return IdentityResultResponse.Success(); } - /// - /// Starts a password recovery operation for a user with a password. - /// - /// The email address of the user. - /// The token used to cancel the operation. - /// A successful result whether or not a matching password-bearing user exists. + /// Starts a password recovery operation for a user with a password. public async Task ForgotPasswordAsync(string email, CancellationToken cancellationToken) { var user = await userManager.FindByEmailAsync(email); - if (user is null || !await userManager.HasPasswordAsync(user)) - { - return IdentityResultResponse.Success(); - } - + if (user is null || !await userManager.HasPasswordAsync(user)) return IdentityResultResponse.Success(); var code = await userManager.GeneratePasswordResetTokenAsync(user); - await emailSender.SendPasswordResetAsync( - email, - $"/resetPassword?email={Uri.EscapeDataString(email)}&code={Uri.EscapeDataString(code)}", - cancellationToken); - + await emailSender.SendPasswordResetAsync(email, $"/resetPassword?email={Uri.EscapeDataString(email)}&code={Uri.EscapeDataString(code)}", cancellationToken); return IdentityResultResponse.Success(); } - /// - /// Resets a user's password using a valid password-reset token. - /// - /// The email address of the user. - /// The password-reset token. - /// The new password. - /// The token used to cancel the operation. - /// The result of the password reset operation. + /// Resets a user's password using a valid password-reset token. public async Task ResetPasswordAsync(string email, string resetCode, string newPassword, CancellationToken cancellationToken) { var user = await userManager.FindByEmailAsync(email); - if (user is null) - { - return IdentityResultResponse.Failure(["Invalid password reset request."]); - } - + if (user is null) return IdentityResultResponse.Failure(["Invalid password reset request."]); var result = await userManager.ResetPasswordAsync(user, resetCode, newPassword); return result.Succeeded ? IdentityResultResponse.Success() : Failure(result); } - /// - /// Gets basic identity information for a user. - /// - /// The identifier of the user. - /// The token used to cancel the operation. - /// The user's identity information, or when the user does not exist. + /// Gets basic identity information for a user. public async Task GetInfoAsync(string userId, CancellationToken cancellationToken) { var user = await userManager.FindByIdAsync(userId); - return user is null - ? null - : new IdentityInfoResponse(user.Email ?? string.Empty, await userManager.IsEmailConfirmedAsync(user)); + return user is null ? null : new IdentityInfoResponse(user.Email ?? string.Empty, await userManager.IsEmailConfirmedAsync(user)); } - /// - /// Updates a user's email address and password after validating the current password. - /// - /// The identifier of the user. - /// The new email address, or to leave it unchanged. - /// The new password, or to leave it unchanged. - /// The current password. - /// The token used to cancel the operation. - /// The result of the update operation. + /// Updates a user's email address and password after validating the current password. public async Task UpdateInfoAsync(string userId, string? newEmail, string? newPassword, string oldPassword, CancellationToken cancellationToken) { var user = await userManager.FindByIdAsync(userId); - if (user is null || !await userManager.CheckPasswordAsync(user, oldPassword)) - { - return IdentityResultResponse.Failure(["The current credentials are invalid."]); - } - + if (user is null || !await userManager.CheckPasswordAsync(user, oldPassword)) return IdentityResultResponse.Failure(["The current credentials are invalid."]); if (!string.IsNullOrWhiteSpace(newEmail) && !string.Equals(user.Email, newEmail, StringComparison.OrdinalIgnoreCase)) { - var emailCode = await userManager.GenerateChangeEmailTokenAsync(user, newEmail); - var emailResult = await userManager.ChangeEmailAsync(user, newEmail, emailCode); - if (!emailResult.Succeeded) - { - return Failure(emailResult); - } + var emailResult = await userManager.ChangeEmailAsync(user, newEmail, await userManager.GenerateChangeEmailTokenAsync(user, newEmail)); + if (!emailResult.Succeeded) return Failure(emailResult); } - if (!string.IsNullOrWhiteSpace(newPassword)) { var passwordResult = await userManager.ChangePasswordAsync(user, oldPassword, newPassword); - if (!passwordResult.Succeeded) - { - return Failure(passwordResult); - } + if (!passwordResult.Succeeded) return Failure(passwordResult); } - return IdentityResultResponse.Success(); } - /// - /// Configures authenticator-based two-factor authentication and optionally rotates its recovery material. - /// - /// The identifier of the user. - /// Whether to enable or disable two-factor authentication. - /// The authenticator code used to validate enabling two-factor authentication. - /// Whether new recovery codes should be generated. - /// Whether the authenticator shared key should be regenerated. - /// Whether the current machine should be forgotten; reserved for parity with the Identity API contract. - /// The token used to cancel the operation. - /// The current two-factor configuration, or when the user does not exist or an enable operation fails. + /// Configures authenticator-based two-factor authentication and optionally rotates its recovery material. public async Task ConfigureTwoFactorAsync(string userId, bool? enable, string? twoFactorCode, bool resetRecoveryCodes, bool resetSharedKey, bool forgetMachine, CancellationToken cancellationToken) { var user = await userManager.FindByIdAsync(userId); - if (user is null) - { - return null; - } - + if (user is null) return null; if (enable == true) { - if (string.IsNullOrWhiteSpace(twoFactorCode) || !await userManager.VerifyTwoFactorTokenAsync(user, userManager.Options.Tokens.AuthenticatorTokenProvider, twoFactorCode)) - { - return null; - } - + if (string.IsNullOrWhiteSpace(twoFactorCode) || !await userManager.VerifyTwoFactorTokenAsync(user, userManager.Options.Tokens.AuthenticatorTokenProvider, twoFactorCode)) return null; await userManager.SetTwoFactorEnabledAsync(user, true); } - else if (enable == false || resetSharedKey) - { - await userManager.SetTwoFactorEnabledAsync(user, false); - } - - if (resetSharedKey) - { - await userManager.ResetAuthenticatorKeyAsync(user); - } - + else if (enable == false || resetSharedKey) await userManager.SetTwoFactorEnabledAsync(user, false); + if (resetSharedKey) await userManager.ResetAuthenticatorKeyAsync(user); string[]? recoveryCodes = null; - if (resetRecoveryCodes || (enable == true && await userManager.CountRecoveryCodesAsync(user) == 0)) - { - recoveryCodes = (await userManager.GenerateNewTwoFactorRecoveryCodesAsync(user, 10))?.ToArray(); - } - + if (resetRecoveryCodes || (enable == true && await userManager.CountRecoveryCodesAsync(user) == 0)) recoveryCodes = (await userManager.GenerateNewTwoFactorRecoveryCodesAsync(user, 10))?.ToArray(); var key = await userManager.GetAuthenticatorKeyAsync(user); - if (string.IsNullOrWhiteSpace(key)) - { - await userManager.ResetAuthenticatorKeyAsync(user); - key = await userManager.GetAuthenticatorKeyAsync(user); - } - - var recoveryCodesLeft = await userManager.CountRecoveryCodesAsync(user); - return new TwoFactorResponse(key, recoveryCodesLeft, recoveryCodes, await userManager.GetTwoFactorEnabledAsync(user), false); + if (string.IsNullOrWhiteSpace(key)) { await userManager.ResetAuthenticatorKeyAsync(user); key = await userManager.GetAuthenticatorKeyAsync(user); } + return new TwoFactorResponse(key, await userManager.CountRecoveryCodesAsync(user), recoveryCodes, await userManager.GetTwoFactorEnabledAsync(user), false); } - /// - /// Gets whether initial system setup is required or has already been completed. - /// - /// The token used to cancel the operation. - /// The current setup status. + /// Gets whether initial system setup is required or has already been completed. public async Task GetSetupStatusAsync(CancellationToken cancellationToken) { var hasUsers = await userManager.Users.AsNoTracking().AnyAsync(cancellationToken); return new SetupStatusResponse(!hasUsers, hasUsers); } - /// - /// Creates the initial administrator account when system setup has not yet been completed. - /// - /// The administrator email address. - /// The administrator password. - /// The token used to cancel the operation. - /// The result of the setup operation. + /// Creates the initial system administrator account when setup has not yet been completed. public async Task InitializeSetupAsync(string email, string password, CancellationToken cancellationToken) { - if (await userManager.Users.AsNoTracking().AnyAsync(cancellationToken)) - { - return IdentityResultResponse.Failure(["The system setup has already been completed."]); - } - + if (await userManager.Users.AsNoTracking().AnyAsync(cancellationToken)) return IdentityResultResponse.Failure(["The system setup has already been completed."]); + await EnsureRoleAsync(TenantRoles.SysAdmin, cancellationToken); + await EnsureRoleAsync(TenantRoles.TenantAdmin, cancellationToken); + await EnsureRoleAsync(TenantRoles.TenantOperator, cancellationToken); + await EnsureRoleAsync(TenantRoles.TenantAttendant, cancellationToken); var role = await roleManager.FindByNameAsync(AdministratorRole); if (role is null) { role = new Role(AdministratorRole); var roleResult = await roleManager.CreateAsync(role); - if (!roleResult.Succeeded) - { - return Failure(roleResult); - } - + if (!roleResult.Succeeded) return Failure(roleResult); var claimResult = await roleManager.AddClaimAsync(role, new Claim(IdentityClaimTypes.Permission, AdministratorPermission)); - if (!claimResult.Succeeded) - { - return Failure(claimResult); - } + if (!claimResult.Succeeded) return Failure(claimResult); } - - var user = new User(email) - { - Email = email, - EmailConfirmed = true - }; - + var user = new User(email) { Email = email, EmailConfirmed = true }; var userResult = await userManager.CreateAsync(user, password); - if (!userResult.Succeeded) - { - return Failure(userResult); - } - - var membershipResult = await userManager.AddToRoleAsync(user, AdministratorRole); - if (!membershipResult.Succeeded) - { - return Failure(membershipResult); - } - + if (!userResult.Succeeded) return Failure(userResult); + var membershipResult = await userManager.AddToRoleAsync(user, TenantRoles.SysAdmin); + if (!membershipResult.Succeeded) return Failure(membershipResult); + membershipResult = await userManager.AddToRoleAsync(user, AdministratorRole); + if (!membershipResult.Succeeded) return Failure(membershipResult); logger.LogInformation("Initial system setup completed for user {UserId}.", user.Id); return IdentityResultResponse.Success(); } @@ -431,50 +198,35 @@ private async Task CreateUserTokensAsync(User user, CancellationT { var roles = await userManager.GetRolesAsync(user); var claims = await userManager.GetClaimsAsync(user); - foreach (var roleName in roles) { var role = await roleManager.FindByNameAsync(roleName); - if (role is null) - { - continue; - } - - claims = claims.Concat(await roleManager.GetClaimsAsync(role)).ToList(); + if (role is not null) claims = claims.Concat(await roleManager.GetClaimsAsync(role)).ToList(); } - return tokenService.CreateTokens(user.Id, user.Email ?? user.UserName ?? user.Id, roles, claims); } + private async Task EnsureRoleAsync(string roleName, CancellationToken cancellationToken) + { + if (await roleManager.RoleExistsAsync(roleName)) return; + var result = await roleManager.CreateAsync(new Role(roleName)); + if (!result.Succeeded) throw new InvalidOperationException(string.Join(" ", result.Errors.Select(x => x.Description))); + } + private static IdentityResultResponse Failure(IdentityResult result) => IdentityResultResponse.Failure(result.Errors.Select(error => error.Description)); } -/// -/// Logs identity email messages instead of delivering them through an external email provider. -/// -/// The logger used to record email messages. +/// Logs identity email messages instead of delivering them through an external email provider. public sealed class LoggingIdentityEmailSender(ILogger logger) : IIdentityEmailSender { - /// - /// Logs an email confirmation message. - /// - /// The recipient email address. - /// The confirmation link. - /// The token used to cancel the operation. - /// A completed task. + /// Logs an email confirmation message. public Task SendConfirmationAsync(string email, string confirmationLink, CancellationToken cancellationToken) { logger.LogInformation("Identity confirmation link for {Email}: {Link}", email, confirmationLink); return Task.CompletedTask; } - /// - /// Logs a password reset message. - /// - /// The recipient email address. - /// The password reset link. - /// The token used to cancel the operation. - /// A completed task. + /// Logs a password reset message. public Task SendPasswordResetAsync(string email, string resetLink, CancellationToken cancellationToken) { logger.LogInformation("Identity password reset link for {Email}: {Link}", email, resetLink); From d2bca05f50445ed08a076c2cace212c8d8fa0275 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:17:11 -0300 Subject: [PATCH 011/112] feat: enforce tenant-aware identity login --- .../Services/IdentityService.Tenancy.cs | 79 +++++++++++++++++++ 1 file changed, 79 insertions(+) create mode 100644 src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.Tenancy.cs diff --git a/src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.Tenancy.cs b/src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.Tenancy.cs new file mode 100644 index 0000000..bbb52a3 --- /dev/null +++ b/src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.Tenancy.cs @@ -0,0 +1,79 @@ +namespace RemoteTickets.Infrastructure.Identity.Services; + +/// Contains tenant-aware identity operations implemented by . +public sealed partial class IdentityService +{ + /// + public async Task LoginAsync( + string tenantId, + string email, + string password, + string? twoFactorCode, + string? twoFactorRecoveryCode, + CancellationToken cancellationToken) + { + var user = await userManager.FindByEmailAsync(email); + if (user is null || (user.TenantId is not null && !string.Equals(user.TenantId, tenantId, StringComparison.OrdinalIgnoreCase) && !await userManager.IsInRoleAsync(user, TenantRoles.SysAdmin))) + { + return null; + } + + if (user.TenantId is null && !await userManager.IsInRoleAsync(user, TenantRoles.SysAdmin)) return null; + if (user.TenantId is not null && !string.Equals(user.TenantId, tenantId, StringComparison.OrdinalIgnoreCase) && !await userManager.IsInRoleAsync(user, TenantRoles.SysAdmin)) return null; + + var passwordResult = await signInManager.CheckPasswordSignInAsync(user, password, true); + if (passwordResult.IsLockedOut || passwordResult.IsNotAllowed || !passwordResult.Succeeded) return null; + + if (await userManager.GetTwoFactorEnabledAsync(user)) + { + var valid = !string.IsNullOrWhiteSpace(twoFactorCode) + ? await userManager.VerifyTwoFactorTokenAsync(user, userManager.Options.Tokens.AuthenticatorTokenProvider, twoFactorCode) + : !string.IsNullOrWhiteSpace(twoFactorRecoveryCode) && (await userManager.RedeemTwoFactorRecoveryCodeAsync(user, twoFactorRecoveryCode)).Succeeded; + if (!valid) return null; + } + + var roles = await userManager.GetRolesAsync(user); + var claims = await userManager.GetClaimsAsync(user); + foreach (var roleName in roles) + { + var role = await roleManager.FindByNameAsync(roleName); + if (role is not null) claims = claims.Concat(await roleManager.GetClaimsAsync(role)).ToList(); + } + + if (!roles.Contains(TenantRoles.SysAdmin, StringComparer.OrdinalIgnoreCase)) + { + claims = claims.Append(new Claim(TenantClaimTypes.TenantId, tenantId)).ToList(); + } + else if (user.TenantId is not null) + { + claims = claims.Append(new Claim(TenantClaimTypes.TenantId, user.TenantId)).ToList(); + } + + return tokenService.CreateTokens(user.Id, user.Email ?? user.UserName ?? user.Id, roles, claims); + } + + /// + public async Task CreateTenantAdminAsync(string tenantId, string email, string password, CancellationToken cancellationToken) + { + if (string.IsNullOrWhiteSpace(tenantId)) return IdentityResultResponse.Failure(["A tenant identifier is required."]); + if (await userManager.FindByEmailAsync(email) is not null) return IdentityResultResponse.Failure(["The email address is already registered."]); + + var role = await roleManager.FindByNameAsync(TenantRoles.TenantAdmin); + if (role is null) + { + var roleResult = await roleManager.CreateAsync(new Role(TenantRoles.TenantAdmin)); + if (!roleResult.Succeeded) return IdentityResultResponse.Failure(roleResult.Errors.Select(x => x.Description)); + } + + var user = new User(email) + { + Email = email, + EmailConfirmed = true, + TenantId = tenantId + }; + var userResult = await userManager.CreateAsync(user, password); + if (!userResult.Succeeded) return IdentityResultResponse.Failure(userResult.Errors.Select(x => x.Description)); + var membership = await userManager.AddToRoleAsync(user, TenantRoles.TenantAdmin); + return membership.Succeeded ? IdentityResultResponse.Success() : IdentityResultResponse.Failure(membership.Errors.Select(x => x.Description)); + } +} From 108f74d56042598766a5193e397254cc14df5386 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:17:18 -0300 Subject: [PATCH 012/112] feat: include tenant context in login command --- .../Identity/Requests/IdentityRequests.cs | 23 ++++--------------- 1 file changed, 5 insertions(+), 18 deletions(-) diff --git a/src/server/RemoteTickets.Application/Identity/Requests/IdentityRequests.cs b/src/server/RemoteTickets.Application/Identity/Requests/IdentityRequests.cs index 8a79fef..ed2aec7 100644 --- a/src/server/RemoteTickets.Application/Identity/Requests/IdentityRequests.cs +++ b/src/server/RemoteTickets.Application/Identity/Requests/IdentityRequests.cs @@ -10,11 +10,8 @@ public sealed record RegisterCommand(string Email, string Password) : IRequest; /// The user's password. /// The authenticator code, when required. /// The recovery code, when used instead of an authenticator code. -public sealed record LoginCommand( - string Email, - string Password, - string? TwoFactorCode = null, - string? TwoFactorRecoveryCode = null) : IRequest; +/// The tenant route identifier. When supplied, the identity must belong to this tenant or be a system administrator. +public sealed record LoginCommand(string Email, string Password, string? TwoFactorCode = null, string? TwoFactorRecoveryCode = null, string? TenantId = null) : IRequest; /// Requests exchange of a refresh token. /// The refresh token to exchange. @@ -53,26 +50,16 @@ public sealed record GetIdentityInfoQuery(string UserId) : IRequest; /// The replacement email address, or to keep the current address. /// The replacement password, or to keep the current password. /// The current password used to authorize the change. -public sealed record UpdateIdentityInfoCommand( - string UserId, - string? NewEmail, - string? NewPassword, - string OldPassword) : IRequest; +public sealed record UpdateIdentityInfoCommand(string UserId, string? NewEmail, string? NewPassword, string OldPassword) : IRequest; /// Requests a change to authenticator-based two-factor authentication. /// The user identifier. /// Whether to enable or disable two-factor authentication. /// The authenticator code used when enabling two-factor authentication. /// Whether recovery codes should be regenerated. -/// Whether the authenticator shared key should be regenerated. +/// Whether the shared authenticator key should be regenerated. /// Whether the remembered machine state should be cleared. -public sealed record ConfigureTwoFactorCommand( - string UserId, - bool? Enable, - string? TwoFactorCode, - bool ResetRecoveryCodes, - bool ResetSharedKey, - bool ForgetMachine) : IRequest; +public sealed record ConfigureTwoFactorCommand(string UserId, bool? Enable, string? TwoFactorCode, bool ResetRecoveryCodes, bool ResetSharedKey, bool ForgetMachine) : IRequest; /// Requests the current first-time setup status. public sealed record GetSetupStatusQuery : IRequest; From 3e209c6506bfe1367201066d5b548b4ab6a772be Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:17:25 -0300 Subject: [PATCH 013/112] feat: enforce tenant scope during identity login --- .../Identity/Handlers/IdentityHandlers.cs | 80 +++++-------------- 1 file changed, 18 insertions(+), 62 deletions(-) diff --git a/src/server/RemoteTickets.Application/Identity/Handlers/IdentityHandlers.cs b/src/server/RemoteTickets.Application/Identity/Handlers/IdentityHandlers.cs index e3d27f7..846d330 100644 --- a/src/server/RemoteTickets.Application/Identity/Handlers/IdentityHandlers.cs +++ b/src/server/RemoteTickets.Application/Identity/Handlers/IdentityHandlers.cs @@ -1,8 +1,8 @@ namespace RemoteTickets.Application.Identity.Handlers; /// Handles the identity requests. -/// The identity service that performs registration. -public sealed class IdentityHandlers(IIdentityService identityService) : +/// The identity service that performs registration and authentication. +public sealed class IdentityHandlers(IIdentityService identityService) : IRequestHandler, IRequestHandler>, IRequestHandler>, @@ -18,69 +18,41 @@ public sealed class IdentityHandlers(IIdentityService identityService) : IRequestHandler { /// Executes the registration request. - /// The message context containing the registration request. - /// The token used to cancel the operation. - /// The registration result. - public Task Handle(IReceiveContext context, CancellationToken cancellationToken) => - identityService.RegisterAsync(context.Message.Email, context.Message.Password, cancellationToken); - + public Task Handle(IReceiveContext context, CancellationToken cancellationToken) => identityService.RegisterAsync(context.Message.Email, context.Message.Password, cancellationToken); + /// Executes the login request and converts authentication failure to an application response. - /// The message context containing the login request. - /// The token used to cancel the operation. - /// The authentication response containing tokens when successful. public async Task> Handle(IReceiveContext context, CancellationToken cancellationToken) { - var result = await identityService.LoginAsync(context.Message.Email, context.Message.Password, context.Message.TwoFactorCode, context.Message.TwoFactorRecoveryCode, cancellationToken); + var message = context.Message; + var result = message.TenantId is null + ? await identityService.LoginAsync(message.Email, message.Password, message.TwoFactorCode, message.TwoFactorRecoveryCode, cancellationToken) + : await identityService.LoginAsync(message.TenantId, message.Email, message.Password, message.TwoFactorCode, message.TwoFactorRecoveryCode, cancellationToken); return result is null ? Response.Failure(["Invalid credentials."]) : Response.Success(result); } + /// Executes a refresh-token exchange. - /// The message context containing the refresh token. - /// The token used to cancel the operation. - /// The refreshed token response. public async Task> Handle(IReceiveContext context, CancellationToken cancellationToken) { var result = await identityService.RefreshAsync(context.Message.RefreshToken, cancellationToken); return result is null ? Response.Failure(["Invalid refresh token."]) : Response.Success(result); } + /// Executes token revocation. - /// The message context containing the access token. - /// The token used to cancel the operation. - /// A response indicating whether revocation succeeded. - public async Task> Handle(IReceiveContext context, CancellationToken cancellationToken) => - Response.Success(await identityService.RevokeAsync(context.Message.AccessToken, cancellationToken)); + public async Task> Handle(IReceiveContext context, CancellationToken cancellationToken) => Response.Success(await identityService.RevokeAsync(context.Message.AccessToken, cancellationToken)); /// Executes email confirmation. - /// The message context containing the confirmation request. - /// The token used to cancel the operation. - /// A response indicating whether confirmation succeeded. - public async Task> Handle(IReceiveContext context, CancellationToken cancellationToken) => - Response.Success(await identityService.ConfirmEmailAsync(context.Message.UserId, context.Message.Code, context.Message.ChangedEmail, cancellationToken)); + public async Task> Handle(IReceiveContext context, CancellationToken cancellationToken) => Response.Success(await identityService.ConfirmEmailAsync(context.Message.UserId, context.Message.Code, context.Message.ChangedEmail, cancellationToken)); /// Executes a confirmation-email resend request. - /// The message context containing the email address. - /// The token used to cancel the operation. - /// The resend result. - public Task Handle(IReceiveContext context, CancellationToken cancellationToken) => - identityService.ResendConfirmationEmailAsync(context.Message.Email, cancellationToken); + public Task Handle(IReceiveContext context, CancellationToken cancellationToken) => identityService.ResendConfirmationEmailAsync(context.Message.Email, cancellationToken); /// Executes a password-recovery request. - /// The message context containing the email address. - /// The token used to cancel the operation. - /// The recovery result. - public Task Handle(IReceiveContext context, CancellationToken cancellationToken) => - identityService.ForgotPasswordAsync(context.Message.Email, cancellationToken); + public Task Handle(IReceiveContext context, CancellationToken cancellationToken) => identityService.ForgotPasswordAsync(context.Message.Email, cancellationToken); /// Executes a password reset. - /// The message context containing the reset request. - /// The token used to cancel the operation. - /// The reset result. - public Task Handle(IReceiveContext context, CancellationToken cancellationToken) => - identityService.ResetPasswordAsync(context.Message.Email, context.Message.ResetCode, context.Message.NewPassword, cancellationToken); + public Task Handle(IReceiveContext context, CancellationToken cancellationToken) => identityService.ResetPasswordAsync(context.Message.Email, context.Message.ResetCode, context.Message.NewPassword, cancellationToken); /// Executes an identity information query. - /// The message context containing the user identifier. - /// The token used to cancel the operation. - /// The identity information response. public async Task> Handle(IReceiveContext context, CancellationToken cancellationToken) { var result = await identityService.GetInfoAsync(context.Message.UserId, cancellationToken); @@ -88,16 +60,9 @@ public async Task> Handle(IReceiveContextExecutes an identity information update. - /// The message context containing the update request. - /// The token used to cancel the operation. - /// The update result. - public Task Handle(IReceiveContext context, CancellationToken cancellationToken) => - identityService.UpdateInfoAsync(context.Message.UserId, context.Message.NewEmail, context.Message.NewPassword, context.Message.OldPassword, cancellationToken); + public Task Handle(IReceiveContext context, CancellationToken cancellationToken) => identityService.UpdateInfoAsync(context.Message.UserId, context.Message.NewEmail, context.Message.NewPassword, context.Message.OldPassword, cancellationToken); /// Executes two-factor configuration. - /// The message context containing the configuration request. - /// The token used to cancel the operation. - /// The resulting two-factor configuration. public async Task> Handle(IReceiveContext context, CancellationToken cancellationToken) { var result = await identityService.ConfigureTwoFactorAsync(context.Message.UserId, context.Message.Enable, context.Message.TwoFactorCode, context.Message.ResetRecoveryCodes, context.Message.ResetSharedKey, context.Message.ForgetMachine, cancellationToken); @@ -105,17 +70,8 @@ public async Task> Handle(IReceiveContextReads the current setup status. - /// The message context containing the query. - /// The token used to cancel the operation. - /// The current setup status. - public Task Handle(IReceiveContext context, CancellationToken cancellationToken) => - identityService.GetSetupStatusAsync(cancellationToken); - + public Task Handle(IReceiveContext context, CancellationToken cancellationToken) => identityService.GetSetupStatusAsync(cancellationToken); /// Executes first-time setup initialization. - /// The message context containing setup credentials. - /// The token used to cancel the operation. - /// The setup result. - public Task Handle(IReceiveContext context, CancellationToken cancellationToken) => - identityService.InitializeSetupAsync(context.Message.Email, context.Message.Password, cancellationToken); + public Task Handle(IReceiveContext context, CancellationToken cancellationToken) => identityService.InitializeSetupAsync(context.Message.Email, context.Message.Password, cancellationToken); } From fc69adefa30d1cc51dc29cf202b5ad5ba0788b9d Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:17:41 -0300 Subject: [PATCH 014/112] feat: persist master database setup configuration --- .../Setup/SetupConfigurationStore.cs | 49 +++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 src/server/RemoteTickets.Infrastructure/Setup/SetupConfigurationStore.cs diff --git a/src/server/RemoteTickets.Infrastructure/Setup/SetupConfigurationStore.cs b/src/server/RemoteTickets.Infrastructure/Setup/SetupConfigurationStore.cs new file mode 100644 index 0000000..692be23 --- /dev/null +++ b/src/server/RemoteTickets.Infrastructure/Setup/SetupConfigurationStore.cs @@ -0,0 +1,49 @@ +using System.Text.Json; + +namespace RemoteTickets.Infrastructure.Setup; + +/// Persists the installation master-database connection string used by the tenant catalog. +public interface ISetupConfigurationStore +{ + /// Gets the configured master-database connection string. + /// The configured connection string, or when setup has not stored one. + string? GetMasterConnectionString(); + + /// Validates and persists the master-database connection string. + /// The SQL Server connection string. + /// The cancellation token. + /// A completed task when persistence succeeds. + Task SetMasterConnectionStringAsync(string connectionString, CancellationToken cancellationToken); +} + +/// Stores setup configuration in an application-local file until a dedicated secrets store is configured. +public sealed class SetupConfigurationStore : ISetupConfigurationStore +{ + private readonly string _path = Path.Combine(AppContext.BaseDirectory, "data", "setup.json"); + + /// + public string? GetMasterConnectionString() + { + if (!File.Exists(_path)) return null; + try + { + var state = JsonSerializer.Deserialize(File.ReadAllText(_path)); + return state?.MasterConnectionString; + } + catch (JsonException) + { + return null; + } + } + + /// + public async Task SetMasterConnectionStringAsync(string connectionString, CancellationToken cancellationToken) + { + if (string.IsNullOrWhiteSpace(connectionString)) throw new ArgumentException("A master database connection string is required.", nameof(connectionString)); + Directory.CreateDirectory(Path.GetDirectoryName(_path)!); + var json = JsonSerializer.Serialize(new State(connectionString)); + await File.WriteAllTextAsync(_path, json, cancellationToken); + } + + private sealed record State(string MasterConnectionString); +} From 666bde55dd5f93f17ad95868ea1598d5b5b57793 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:17:44 -0300 Subject: [PATCH 015/112] feat: register setup configuration services --- src/server/RemoteTickets.Infrastructure/GlobalUsings.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/server/RemoteTickets.Infrastructure/GlobalUsings.cs b/src/server/RemoteTickets.Infrastructure/GlobalUsings.cs index 54289f1..97a4b87 100644 --- a/src/server/RemoteTickets.Infrastructure/GlobalUsings.cs +++ b/src/server/RemoteTickets.Infrastructure/GlobalUsings.cs @@ -14,6 +14,8 @@ global using RemoteTickets.Domain.Common; global using RemoteTickets.Infrastructure.Identity.Models; global using RemoteTickets.Infrastructure.Persistence; +global using RemoteTickets.Infrastructure.Setup; +global using RemoteTickets.Infrastructure.Identity.Services; global using Microsoft.AspNetCore.Identity; global using Microsoft.AspNetCore.Identity.EntityFrameworkCore; global using Microsoft.EntityFrameworkCore; From f5ceaceb928e9146eb277026419c6ca9191285ff Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:17:51 -0300 Subject: [PATCH 016/112] feat: enforce tenant isolation and setup gate --- .../Tenancy/TenantAccessMiddleware.cs | 87 +++++++++++++++++++ 1 file changed, 87 insertions(+) create mode 100644 src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs diff --git a/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs b/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs new file mode 100644 index 0000000..52f336d --- /dev/null +++ b/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs @@ -0,0 +1,87 @@ +using Microsoft.AspNetCore.Authorization; +using Microsoft.AspNetCore.Http; +using RemoteTickets.Application.Common.Tenancy; + +namespace RemoteTickets.Infrastructure.Tenancy; + +/// Enforces tenant route isolation and mandatory setup state for HTTP requests. +public sealed class TenantAccessMiddleware( + RequestDelegate next, + ITenantManagementService tenants, + IIdentityService identityService) +{ + /// Processes the current request and enforces tenant isolation when a tenant route is present. + /// The current HTTP context. + /// The asynchronous middleware operation. + public async Task InvokeAsync(HttpContext context) + { + var endpoint = context.GetEndpoint(); + if (endpoint?.Metadata.GetMetadata() is not null) + { + await next(context); + return; + } + + var systemStatus = await identityService.GetSetupStatusAsync(context.RequestAborted); + if (systemStatus.IsSetupRequired) + { + if (IsSetupEndpoint(context)) + { + await next(context); + return; + } + + await RejectOrRedirectAsync(context, "/setup", StatusCodes.Status503ServiceUnavailable); + return; + } + + if (!context.Request.RouteValues.TryGetValue("tenantId", out var value) || string.IsNullOrWhiteSpace(value?.ToString())) + { + await next(context); + return; + } + + var tenantId = value.ToString()!; + var tenant = await tenants.GetAsync(tenantId, context.RequestAborted); + if (tenant is null || !tenant.IsActive) + { + await RejectOrRedirectAsync(context, "/not-found", StatusCodes.Status404NotFound); + return; + } + + if (context.User.Identity?.IsAuthenticated == true && !context.User.IsInRole(TenantRoles.SysAdmin)) + { + var assignedTenant = context.User.FindFirst(TenantClaimTypes.TenantId)?.Value; + if (!string.Equals(assignedTenant, tenantId, StringComparison.OrdinalIgnoreCase)) + { + await RejectOrRedirectAsync(context, $"/{assignedTenant ?? tenantId}", StatusCodes.Status403Forbidden); + return; + } + } + + if (!tenant.IsSetupComplete && !IsTenantSetupEndpoint(context)) + { + await RejectOrRedirectAsync(context, $"/{tenantId}/setup", StatusCodes.Status409Conflict); + return; + } + + await next(context); + } + + private static bool IsSetupEndpoint(HttpContext context) => context.Request.Path.StartsWithSegments("/api/setup", StringComparison.OrdinalIgnoreCase) || context.Request.Path.Equals("/setup", StringComparison.OrdinalIgnoreCase); + + private static bool IsTenantSetupEndpoint(HttpContext context) => context.Request.Path.StartsWithSegments($"/{context.Request.RouteValues["tenantId"]}/setup", StringComparison.OrdinalIgnoreCase) || context.Request.Path.StartsWithSegments("/api/v1/", StringComparison.OrdinalIgnoreCase) && context.Request.Path.Value?.EndsWith("/setup", StringComparison.OrdinalIgnoreCase) == true; + + private static async Task RejectOrRedirectAsync(HttpContext context, string location, int statusCode) + { + if (HttpMethods.IsGet(context.Request.Method) && context.Request.Headers.Accept.Any(x => x.Contains("text/html", StringComparison.OrdinalIgnoreCase))) + { + context.Response.Redirect(location); + return; + } + + context.Response.StatusCode = statusCode; + context.Response.ContentType = "application/problem+json"; + await context.Response.WriteAsJsonAsync(new { title = "Setup required", detail = "Complete the required setup before using this endpoint.", setup = location }, context.RequestAborted); + } +} From df013426d6b78879ed369824cf328df4a350f002 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:17:59 -0300 Subject: [PATCH 017/112] feat: compose tenant-aware identity and middleware --- .../InvisibleSPCompositionExtensions.cs | 118 ++++++++---------- 1 file changed, 54 insertions(+), 64 deletions(-) diff --git a/src/server/RemoteTickets.Composition/InvisibleSPCompositionExtensions.cs b/src/server/RemoteTickets.Composition/InvisibleSPCompositionExtensions.cs index 17b6292..b4d2572 100644 --- a/src/server/RemoteTickets.Composition/InvisibleSPCompositionExtensions.cs +++ b/src/server/RemoteTickets.Composition/InvisibleSPCompositionExtensions.cs @@ -5,7 +5,7 @@ public static class RemoteTicketsCompositionExtensions { extension (WebApplicationBuilder builder) { - /// Registers all application, persistence, identity, validation, authentication, and authorization services. + /// Registers all application, persistence, identity, validation, authentication, authorization, and tenant services. /// The same application builder for fluent composition. /// Thrown when required JWT configuration is missing or its secret key is too short. public WebApplicationBuilder AddRemoteTickets() @@ -13,16 +13,20 @@ public WebApplicationBuilder AddRemoteTickets() var services = builder.Services; var configuration = builder.Configuration; - services.AddRazorComponents() - .AddInteractiveServerComponents(); + services.AddRazorComponents().AddInteractiveServerComponents(); services.AddControllers(); - services.Configure(configuration.GetSection(JwtOptions.SectionName)); + services.AddSingleton(); services.AddDbContext(options => - options.UseSqlServer(configuration.GetConnectionString("Identity"))); + { + var setup = services.BuildServiceProvider().GetService(); + var connectionString = setup?.GetMasterConnectionString() ?? configuration.GetConnectionString("Identity") ?? configuration.GetConnectionString("Master"); + if (string.IsNullOrWhiteSpace(connectionString)) throw new InvalidOperationException("A master database connection string is required."); + options.UseSqlServer(connectionString); + }); - services.AddIdentityCore(options => + services.AddIdentityCore(options => { options.User.RequireUniqueEmail = true; options.SignIn.RequireConfirmedEmail = false; @@ -33,80 +37,72 @@ public WebApplicationBuilder AddRemoteTickets() options.Password.RequireNonAlphanumeric = true; options.Lockout.MaxFailedAccessAttempts = 5; options.Lockout.DefaultLockoutTimeSpan = TimeSpan.FromMinutes(15); - }).AddRoles() - .AddEntityFrameworkStores() - .AddSignInManager() - .AddDefaultTokenProviders(); + }) + .AddRoles() + .AddEntityFrameworkStores() + .AddSignInManager() + .AddDefaultTokenProviders(); services.AddScoped(); + services.AddScoped(); + services.AddScoped(); services.AddScoped(); services.AddSingleton(); services.AddScoped(); services.AddScoped(); services.AddValidatorsFromAssemblyContaining(); - services.AddAuthentication(JwtBearerDefaults.AuthenticationScheme) - .AddJwtBearer(options => + services.AddAuthentication(JwtBearerDefaults.AuthenticationScheme).AddJwtBearer(options => + { + var jwt = configuration.GetSection(JwtOptions.SectionName).Get() ?? throw new InvalidOperationException("JWT configuration is missing."); + if (Encoding.UTF8.GetByteCount(jwt.SecretKey) < 32) throw new InvalidOperationException("Authentication:Jwt:SecretKey must contain at least 256 bits."); + options.TokenValidationParameters = new TokenValidationParameters { - var jwt = configuration.GetSection(JwtOptions.SectionName).Get() - ?? throw new InvalidOperationException("JWT configuration is missing."); - - if (Encoding.UTF8.GetByteCount(jwt.SecretKey) < 32) - { - throw new InvalidOperationException("Authentication:Jwt:SecretKey must contain at least 256 bits."); - } - - options.TokenValidationParameters = new TokenValidationParameters - { - ValidateIssuerSigningKey = true, - IssuerSigningKey = new SymmetricSecurityKey(Encoding.UTF8.GetBytes(jwt.SecretKey)), - ValidateIssuer = true, - ValidIssuer = jwt.Issuer, - ValidateAudience = true, - ValidAudience = jwt.Audience, - ValidateLifetime = true, - ClockSkew = TimeSpan.FromSeconds(30) - }; - - options.Events = new JwtBearerEvents + ValidateIssuerSigningKey = true, + IssuerSigningKey = new SymmetricSecurityKey(Encoding.UTF8.GetBytes(jwt.SecretKey)), + ValidateIssuer = true, + ValidIssuer = jwt.Issuer, + ValidateAudience = true, + ValidAudience = jwt.Audience, + ValidateLifetime = true, + ClockSkew = TimeSpan.FromSeconds(30) + }; + options.Events = new JwtBearerEvents + { + OnTokenValidated = context => { - OnTokenValidated = context => + var token = context.SecurityToken as JwtSecurityToken; + var tokenType = token?.Claims.FirstOrDefault(x => x.Type == JwtRegisteredClaimNames.Typ)?.Value; + if (!string.Equals(tokenType, JwtTokenTypes.Access, StringComparison.Ordinal)) { - var token = context.SecurityToken as JwtSecurityToken; - var tokenType = token?.Claims.FirstOrDefault(x => x.Type == JwtRegisteredClaimNames.Typ)?.Value; - if (!string.Equals(tokenType, "access", StringComparison.Ordinal)) - { - context.Fail("The supplied token is not an access token."); - return Task.CompletedTask; - } - - if (token is not null && context.HttpContext.RequestServices.GetRequiredService().IsRevoked(token.Id)) - { - context.Fail("The supplied token has been revoked."); - } - + context.Fail("The supplied token is not an access token."); return Task.CompletedTask; } - }; - }); + if (token is not null && context.HttpContext.RequestServices.GetRequiredService().IsRevoked(token.Id)) context.Fail("The supplied token has been revoked."); + return Task.CompletedTask; + } + }; + }); services.AddAuthorizationBuilder() - .AddPolicy(IdentityPolicies.Administrator, policy => - policy.RequireClaim(IdentityClaimTypes.Permission, AdministratorPermission)); + .AddPolicy(TenantPolicies.SysAdmin, policy => policy.RequireRole(TenantRoles.SysAdmin)) + .AddPolicy(TenantPolicies.TenantAdmin, policy => policy.RequireRole(TenantRoles.SysAdmin, TenantRoles.TenantAdmin)) + .AddPolicy(TenantPolicies.TenantOperator, policy => policy.RequireRole(TenantRoles.SysAdmin, TenantRoles.TenantAdmin, TenantRoles.TenantOperator)) + .AddPolicy(TenantPolicies.TenantAttendant, policy => policy.RequireRole(TenantRoles.SysAdmin, TenantRoles.TenantAdmin, TenantRoles.TenantOperator, TenantRoles.TenantAttendant)) + .AddPolicy(IdentityPolicies.Administrator, policy => policy.RequireRole(TenantRoles.SysAdmin)); + var mb = new Mediator.Net.MediatorBuilder(); mb.RegisterHandlers(typeof(IdentityHandlers).Assembly) .ConfigureCommandReceivePipe(pipe => pipe.UseValidation()) .ConfigureRequestPipe(pipe => pipe.UseValidation()); - services.RegisterMediator(mb); - return builder; } } extension (WebApplication app) { - /// Configures middleware, authentication, authorization, controllers, static assets, and Blazor endpoints. + /// Configures middleware, authentication, tenant isolation, authorization, controllers, static assets, and Blazor endpoints. /// The Blazor root component used by the application. /// The same web application for fluent startup composition. public WebApplication UseRemoteTickets() where TApp : IComponent @@ -116,25 +112,19 @@ public WebApplication UseRemoteTickets() where TApp : IComponent app.UseExceptionHandler("/Error", createScopeForErrors: true); app.UseHsts(); } - else - { - app.UseDeveloperExceptionPage(); - } + else app.UseDeveloperExceptionPage(); app.UseStatusCodePagesWithReExecute("/not-found", createScopeForStatusCodePages: true); app.UseHttpsRedirection(); + app.UseRouting(); app.UseAuthentication(); + app.UseMiddleware(); app.UseAuthorization(); app.UseAntiforgery(); - app.MapControllers(); app.MapStaticAssets(); - app.MapRazorComponents() - .AddInteractiveServerRenderMode(); - + app.MapRazorComponents().AddInteractiveServerRenderMode(); return app; } } - - private const string AdministratorPermission = "system.admin"; } From 0c3e0aae986be48708034574a86243d70fde4583 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:18:10 -0300 Subject: [PATCH 018/112] feat: move identity endpoints under tenant API route --- .../Controllers/IdentityController.cs | 117 +++++------------- 1 file changed, 32 insertions(+), 85 deletions(-) diff --git a/src/server/RemoteTickets/Controllers/IdentityController.cs b/src/server/RemoteTickets/Controllers/IdentityController.cs index 6614883..51f79b3 100644 --- a/src/server/RemoteTickets/Controllers/IdentityController.cs +++ b/src/server/RemoteTickets/Controllers/IdentityController.cs @@ -1,161 +1,114 @@ namespace RemoteTickets.Controllers; -/// Exposes HTTP endpoints for registration, authentication, account management, and two-factor authentication. +/// Exposes HTTP endpoints for tenant-scoped registration, authentication, account management, and two-factor authentication. /// The mediator used to dispatch application requests. [ApiController] +[Route("/api/v1/{tenantId}")] public sealed class IdentityController(IMediator mediator) : ControllerBase { - /// Registers a new user. - /// The registration payload. - /// The token used to cancel the request. - /// An HTTP response representing the registration result. - [HttpPost("/register")] + /// Registers a new user in the requested tenant. + [HttpPost("register")] [AllowAnonymous] - public async Task Register(RegisterRequest request, CancellationToken cancellationToken) + public async Task Register([FromRoute] string tenantId, RegisterRequest request, CancellationToken cancellationToken) { var result = await mediator.RequestAsync(new RegisterCommand(request.Email, request.Password)); return result.Succeeded ? Ok() : BadRequest(result); } - /// Authenticates a user with a password and optional second factor. - /// The login payload. - /// The token used to cancel the request. - /// An HTTP response containing tokens when authentication succeeds. - [HttpPost("/login")] + /// Authenticates a user against the requested tenant. + [HttpPost("login")] [AllowAnonymous] - public async Task Login(LoginRequest request, CancellationToken cancellationToken) + public async Task Login([FromRoute] string tenantId, LoginRequest request, CancellationToken cancellationToken) { - var result = await mediator.RequestAsync>( - new LoginCommand(request.Email, request.Password, request.TwoFactorCode, request.TwoFactorRecoveryCode)); + var result = await mediator.RequestAsync>(new LoginCommand(request.Email, request.Password, request.TwoFactorCode, request.TwoFactorRecoveryCode, tenantId), cancellationToken); return result.Succeeded ? Ok(result.Data) : Unauthorized(result); } - /// Exchanges a refresh token for a new token pair. - /// The refresh-token payload. - /// The token used to cancel the request. - /// An HTTP response containing the refreshed tokens. - [HttpPost("/refresh")] + /// Exchanges a refresh token for a new token pair in the requested tenant context. + [HttpPost("refresh")] [AllowAnonymous] public async Task Refresh(RefreshRequest request, CancellationToken cancellationToken) { - var result = await mediator.RequestAsync>(new RefreshTokenCommand(request.RefreshToken)); + var result = await mediator.RequestAsync>(new RefreshTokenCommand(request.RefreshToken), cancellationToken); return result.Succeeded ? Ok(result.Data) : Unauthorized(result); } /// Revokes the access token supplied by the authenticated caller. - /// The token used to cancel the request. - /// An HTTP response indicating whether revocation succeeded. - [HttpPost("/revoke")] + [HttpPost("revoke")] [Authorize] public async Task Revoke(CancellationToken cancellationToken) { var accessToken = Request.Headers.Authorization.ToString().Replace("Bearer ", string.Empty, StringComparison.OrdinalIgnoreCase); - var result = await mediator.RequestAsync>(new RevokeTokenCommand(accessToken)); + var result = await mediator.RequestAsync>(new RevokeTokenCommand(accessToken), cancellationToken); return result.Data == true ? Ok() : Unauthorized(result); } /// Confirms a user's email address. - /// The user identifier from the confirmation link. - /// The confirmation token. - /// The replacement email address when confirming an email change. - /// The token used to cancel the request. - /// An HTTP response indicating whether confirmation succeeded. - [HttpGet("/confirmEmail")] + [HttpGet("confirmEmail")] [AllowAnonymous] public async Task ConfirmEmail([FromQuery] string userId, [FromQuery] string code, [FromQuery] string? changedEmail, CancellationToken cancellationToken) { - var result = await mediator.RequestAsync>(new ConfirmEmailCommand(userId, code, changedEmail)); + var result = await mediator.RequestAsync>(new ConfirmEmailCommand(userId, code, changedEmail), cancellationToken); return result.Data == true ? Ok("Thank you for confirming your email.") : BadRequest(result); } /// Resends a user's email confirmation link. - /// The email payload. - /// The token used to cancel the request. - /// An HTTP response representing the resend result. - [HttpPost("/resendConfirmationEmail")] + [HttpPost("resendConfirmationEmail")] [AllowAnonymous] public async Task ResendConfirmationEmail(EmailRequest request, CancellationToken cancellationToken) { - var result = await mediator.RequestAsync(new ResendConfirmationEmailCommand(request.Email)); + var result = await mediator.RequestAsync(new ResendConfirmationEmailCommand(request.Email), cancellationToken); return result.Succeeded ? Ok() : BadRequest(result); } /// Starts password recovery for an email address. - /// The email payload. - /// The token used to cancel the request. - /// An HTTP response representing the recovery result. - [HttpPost("/forgotPassword")] + [HttpPost("forgotPassword")] [AllowAnonymous] public async Task ForgotPassword(EmailRequest request, CancellationToken cancellationToken) { - var result = await mediator.RequestAsync(new ForgotPasswordCommand(request.Email)); + var result = await mediator.RequestAsync(new ForgotPasswordCommand(request.Email), cancellationToken); return result.Succeeded ? Ok() : BadRequest(result); } /// Resets a user's password using a reset token. - /// The password reset payload. - /// The token used to cancel the request. - /// An HTTP response representing the reset result. - [HttpPost("/resetPassword")] + [HttpPost("resetPassword")] [AllowAnonymous] public async Task ResetPassword(ResetPasswordRequest request, CancellationToken cancellationToken) { - var result = await mediator.RequestAsync(new ResetPasswordCommand(request.Email, request.ResetCode, request.NewPassword)); + var result = await mediator.RequestAsync(new ResetPasswordCommand(request.Email, request.ResetCode, request.NewPassword), cancellationToken); return result.Succeeded ? Ok() : BadRequest(result); } /// Gets identity information for the authenticated user. - /// The token used to cancel the request. - /// An HTTP response containing identity information. - [HttpGet("/manage/info")] + [HttpGet("manage/info")] [Authorize] public async Task GetInfo(CancellationToken cancellationToken) { var userId = GetUserId(); - if (userId is null) - { - return Unauthorized(); - } - - var result = await mediator.RequestAsync>(new GetIdentityInfoQuery(userId)); + if (userId is null) return Unauthorized(); + var result = await mediator.RequestAsync>(new GetIdentityInfoQuery(userId), cancellationToken); return result.Succeeded ? Ok(result.Data) : NotFound(result); } /// Updates identity information for the authenticated user. - /// The identity update payload. - /// The token used to cancel the request. - /// An HTTP response representing the update result. - [HttpPost("/manage/info")] + [HttpPost("manage/info")] [Authorize] public async Task UpdateInfo(InfoRequest request, CancellationToken cancellationToken) { var userId = GetUserId(); - if (userId is null) - { - return Unauthorized(); - } - - var result = await mediator.RequestAsync( - new UpdateIdentityInfoCommand(userId, request.NewEmail, request.NewPassword, request.OldPassword)); + if (userId is null) return Unauthorized(); + var result = await mediator.RequestAsync(new UpdateIdentityInfoCommand(userId, request.NewEmail, request.NewPassword, request.OldPassword), cancellationToken); return result.Succeeded ? Ok() : BadRequest(result); } /// Configures authenticator-based two-factor authentication for the authenticated user. - /// The two-factor configuration payload. - /// The token used to cancel the request. - /// An HTTP response containing the resulting two-factor configuration. - [HttpPost("/manage/2fa")] + [HttpPost("manage/2fa")] [Authorize] public async Task ConfigureTwoFactor(TwoFactorRequest request, CancellationToken cancellationToken) { var userId = GetUserId(); - if (userId is null) - { - return Unauthorized(); - } - - var result = await mediator.RequestAsync>( - new ConfigureTwoFactorCommand(userId, request.Enable, request.TwoFactorCode, request.ResetRecoveryCodes, request.ResetSharedKey, request.ForgetMachine)); + if (userId is null) return Unauthorized(); + var result = await mediator.RequestAsync>(new ConfigureTwoFactorCommand(userId, request.Enable, request.TwoFactorCode, request.ResetRecoveryCodes, request.ResetSharedKey, request.ForgetMachine), cancellationToken); return result.Succeeded ? Ok(result.Data) : BadRequest(result); } @@ -166,34 +119,28 @@ public async Task ConfigureTwoFactor(TwoFactorRequest request, Ca /// The user's email address. /// The user's password. public sealed record RegisterRequest(string Email, string Password); - /// Represents the login request payload. /// The user's email address. /// The user's password. /// The authenticator code, when required. /// The recovery code, when used instead of an authenticator code. public sealed record LoginRequest(string Email, string Password, string? TwoFactorCode = null, string? TwoFactorRecoveryCode = null); - /// Represents a refresh-token request payload. /// The refresh token to exchange. public sealed record RefreshRequest(string RefreshToken); - /// Represents an email-only request payload. /// The email address. public sealed record EmailRequest(string Email); - /// Represents a password reset request payload. /// The user's email address. /// The password reset token. /// The replacement password. public sealed record ResetPasswordRequest(string Email, string ResetCode, string NewPassword); - /// Represents an authenticated identity information update payload. /// The replacement email address. /// The replacement password. -/// The current password. +/// The replacement password. public sealed record InfoRequest(string? NewEmail, string? NewPassword, string OldPassword); - /// Represents an authenticator-based two-factor configuration request. /// Whether to enable or disable two-factor authentication. /// The authenticator code used when enabling two-factor authentication. From 69d405ec45dc3c07ddc11b5593646dc78271f877 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:18:14 -0300 Subject: [PATCH 019/112] feat: expose tenancy contracts to web host --- src/server/RemoteTickets/GlobalUsings.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/server/RemoteTickets/GlobalUsings.cs b/src/server/RemoteTickets/GlobalUsings.cs index 6bcf26f..9f833b3 100644 --- a/src/server/RemoteTickets/GlobalUsings.cs +++ b/src/server/RemoteTickets/GlobalUsings.cs @@ -4,9 +4,11 @@ global using System.Threading; global using System.Threading.Tasks; global using RemoteTickets.Application.Common.Identity; +global using RemoteTickets.Application.Common.Tenancy; global using RemoteTickets.Application.Identity.Requests; global using RemoteTickets.Composition; global using RemoteTickets.Components; +global using RemoteTickets.Infrastructure.Setup; global using Mediator.Net; global using Microsoft.AspNetCore.Authorization; global using Microsoft.AspNetCore.Builder; From 3fe0c90038b5e51ffbfcbb9f256a90be3fa14005 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:18:19 -0300 Subject: [PATCH 020/112] feat: make master database configuration part of setup --- .../Controllers/SetupController.cs | 31 ++++++++++++------- 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/src/server/RemoteTickets/Controllers/SetupController.cs b/src/server/RemoteTickets/Controllers/SetupController.cs index 6d0d4e6..796a994 100644 --- a/src/server/RemoteTickets/Controllers/SetupController.cs +++ b/src/server/RemoteTickets/Controllers/SetupController.cs @@ -2,33 +2,40 @@ namespace RemoteTickets.Controllers; /// Exposes anonymous endpoints used during first-time application setup. /// The mediator used to dispatch setup requests. +/// The store used to persist the master database connection. [ApiController] [Route("api/setup")] -public sealed class SetupController(IMediator mediator) : ControllerBase +public sealed class SetupController(IMediator mediator, ISetupConfigurationStore configurationStore) : ControllerBase { /// Gets the current first-time setup status. - /// The token used to cancel the request. - /// The current setup status. [HttpGet("status")] [AllowAnonymous] - public Task GetStatus(CancellationToken cancellationToken) => - mediator.RequestAsync(new GetSetupStatusQuery(), cancellationToken); + public Task GetStatus(CancellationToken cancellationToken) => mediator.RequestAsync(new GetSetupStatusQuery(), cancellationToken); - /// Initializes the application with its first administrator account. - /// The initial administrator credentials. - /// The token used to cancel the request. - /// An HTTP response indicating whether initialization succeeded. + /// Persists the master database connection string used to administer tenants. + [HttpPost("master-database")] + [AllowAnonymous] + public async Task ConfigureMasterDatabase(MasterDatabaseSetupRequest request, CancellationToken cancellationToken) + { + if (string.IsNullOrWhiteSpace(request.ConnectionString)) return BadRequest(new { error = "A master database connection string is required." }); + await configurationStore.SetMasterConnectionStringAsync(request.ConnectionString, cancellationToken); + return Ok(); + } + + /// Initializes the application with its first system administrator account. [HttpPost("initialize")] [AllowAnonymous] public async Task Initialize(InitializeSetupRequest request, CancellationToken cancellationToken) { - var result = await mediator.RequestAsync( - new InitializeSetupCommand(request.Email, request.Password), cancellationToken); - + var result = await mediator.RequestAsync(new InitializeSetupCommand(request.Email, request.Password), cancellationToken); return result.Succeeded ? Ok(result) : Conflict(result); } } +/// Represents the master database setup payload. +/// The SQL Server connection string used by the tenant catalog. +public sealed record MasterDatabaseSetupRequest(string ConnectionString); + /// Represents the first-time setup administrator credentials. /// The administrator email address. /// The administrator password. From d52268d373198697bcc5b85600bdb79a4f9f6b4d Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:18:28 -0300 Subject: [PATCH 021/112] feat: add system tenant provisioning controller --- .../Controllers/TenantController.cs | 42 +++++++++++++++++++ 1 file changed, 42 insertions(+) create mode 100644 src/server/RemoteTickets/Controllers/TenantController.cs diff --git a/src/server/RemoteTickets/Controllers/TenantController.cs b/src/server/RemoteTickets/Controllers/TenantController.cs new file mode 100644 index 0000000..d37f888 --- /dev/null +++ b/src/server/RemoteTickets/Controllers/TenantController.cs @@ -0,0 +1,42 @@ +namespace RemoteTickets.Controllers; + +/// Exposes system-level tenant provisioning endpoints. +/// The tenant management service. +[ApiController] +[Route("/api/v1/system/tenants")] +[Authorize(Policy = TenantPolicies.SysAdmin)] +public sealed class TenantController(ITenantManagementService tenants) : ControllerBase +{ + /// Provisions a tenant database and its first tenant administrator. + /// The tenant provisioning request. + /// The token used to cancel the request. + /// The newly provisioned tenant. + [HttpPost] + public async Task Create(CreateTenantRequest request, CancellationToken cancellationToken) + { + try + { + var tenant = await tenants.CreateAsync(request, cancellationToken); + return Created($"/api/v1/{tenant.Id}/setup", tenant); + } + catch (ArgumentException exception) + { + return BadRequest(new { error = exception.Message }); + } + catch (InvalidOperationException exception) + { + return Conflict(new { error = exception.Message }); + } + } + + /// Gets a tenant from the central catalog. + /// The tenant identifier. + /// The token used to cancel the request. + /// The tenant metadata. + [HttpGet("{tenantId}")] + public async Task Get(string tenantId, CancellationToken cancellationToken) + { + var tenant = await tenants.GetAsync(tenantId, cancellationToken); + return tenant is null ? NotFound() : Ok(tenant); + } +} From a1cd144405db1d80d8a71fa9ed8fadead20b8e2f Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:18:34 -0300 Subject: [PATCH 022/112] feat: add per-tenant setup controller --- .../Controllers/TenantSetupController.cs | 28 +++++++++++++++++++ 1 file changed, 28 insertions(+) create mode 100644 src/server/RemoteTickets/Controllers/TenantSetupController.cs diff --git a/src/server/RemoteTickets/Controllers/TenantSetupController.cs b/src/server/RemoteTickets/Controllers/TenantSetupController.cs new file mode 100644 index 0000000..f9d6bd2 --- /dev/null +++ b/src/server/RemoteTickets/Controllers/TenantSetupController.cs @@ -0,0 +1,28 @@ +namespace RemoteTickets.Controllers; + +/// Exposes setup and validation operations for an individual tenant database. +/// The tenant management service. +[ApiController] +[Route("/api/v1/{tenantId}/setup")] +public sealed class TenantSetupController(ITenantManagementService tenants) : ControllerBase +{ + /// Gets the current tenant setup state. + /// The tenant identifier. + /// The token used to cancel the request. + /// The tenant setup state. + [HttpGet] + [AllowAnonymous] + public Task GetStatus(string tenantId, CancellationToken cancellationToken) => tenants.GetSetupStatusAsync(tenantId, cancellationToken); + + /// Completes tenant setup after the required tenant validations have passed. + /// The tenant identifier. + /// The token used to cancel the request. + /// The resulting tenant setup state. + [HttpPost("complete")] + [Authorize(Policy = TenantPolicies.TenantAdmin)] + public async Task Complete(string tenantId, CancellationToken cancellationToken) + { + var result = await tenants.CompleteSetupAsync(tenantId, cancellationToken); + return Ok(result); + } +} From c4e056d57218abaabbf4b7c98f51b5d3dbbe4316 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:18:39 -0300 Subject: [PATCH 023/112] feat: add system setup razor page --- .../Components/Pages/Setup.razor | 63 +++++++++++++++++++ 1 file changed, 63 insertions(+) create mode 100644 src/server/RemoteTickets/Components/Pages/Setup.razor diff --git a/src/server/RemoteTickets/Components/Pages/Setup.razor b/src/server/RemoteTickets/Components/Pages/Setup.razor new file mode 100644 index 0000000..93cd0b6 --- /dev/null +++ b/src/server/RemoteTickets/Components/Pages/Setup.razor @@ -0,0 +1,63 @@ +@page "/setup" +@using System.Net.Http.Json +@inject IHttpClientFactory HttpClientFactory +@inject NavigationManager Navigation + +System setup + +

System setup

+

Configure the master SQL Server database and create the first system administrator before using the application.

+ +
+ + +
+
+ + +
+
+ + +
+ +@if (!string.IsNullOrWhiteSpace(Message)) +{ +

@Message

+} + +@code { + private bool Busy; + private string ConnectionString = string.Empty; + private string Email = string.Empty; + private string Password = string.Empty; + private string Message = string.Empty; + + private async Task InitializeAsync() + { + Busy = true; + Message = string.Empty; + try + { + var client = HttpClientFactory.CreateClient(); + client.BaseAddress = new Uri(Navigation.BaseUri); + var configure = await client.PostAsJsonAsync("api/setup/master-database", new { ConnectionString }); + if (!configure.IsSuccessStatusCode) + { + Message = "The master database configuration could not be stored."; + return; + } + + var initialize = await client.PostAsJsonAsync("api/setup/initialize", new { Email, Password }); + Message = initialize.IsSuccessStatusCode ? "Setup completed. You can now sign in." : await initialize.Content.ReadAsStringAsync(); + } + catch (Exception exception) + { + Message = exception.Message; + } + finally + { + Busy = false; + } + } +} From 6f2ff8ec4c263abe605bb7241d8808189cb20f9e Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:18:43 -0300 Subject: [PATCH 024/112] feat: add tenant setup razor page --- .../Components/Pages/TenantSetup.razor | 46 +++++++++++++++++++ 1 file changed, 46 insertions(+) create mode 100644 src/server/RemoteTickets/Components/Pages/TenantSetup.razor diff --git a/src/server/RemoteTickets/Components/Pages/TenantSetup.razor b/src/server/RemoteTickets/Components/Pages/TenantSetup.razor new file mode 100644 index 0000000..b895486 --- /dev/null +++ b/src/server/RemoteTickets/Components/Pages/TenantSetup.razor @@ -0,0 +1,46 @@ +@page "/{tenantId}/setup" +@using System.Net.Http.Json +@inject IHttpClientFactory HttpClientFactory +@inject NavigationManager Navigation + +Tenant setup + +

Tenant setup

+

Tenant @tenantId is not ready for normal operations. Run the database validation and complete setup.

+ + +@if (!string.IsNullOrWhiteSpace(Message)) +{ +

@Message

+} + +@code { + [Parameter] public string tenantId { get; set; } = string.Empty; + private bool Busy; + private string Message = string.Empty; + + private async Task CompleteAsync() + { + Busy = true; + try + { + var client = HttpClientFactory.CreateClient(); + client.BaseAddress = new Uri(Navigation.BaseUri); + var response = await client.PostAsync($"api/v1/{Uri.EscapeDataString(tenantId)}/setup/complete", null); + if (response.IsSuccessStatusCode) + { + Navigation.NavigateTo($"/{tenantId}", true); + return; + } + Message = await response.Content.ReadAsStringAsync(); + } + catch (Exception exception) + { + Message = exception.Message; + } + finally + { + Busy = false; + } + } +} From fa06ad7d6684ef3e73582a50c0644384701749ca Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:18:49 -0300 Subject: [PATCH 025/112] feat: scope home page to tenant route --- .../RemoteTickets/Components/Pages/Home.razor | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/server/RemoteTickets/Components/Pages/Home.razor b/src/server/RemoteTickets/Components/Pages/Home.razor index df05023..e2dda88 100644 --- a/src/server/RemoteTickets/Components/Pages/Home.razor +++ b/src/server/RemoteTickets/Components/Pages/Home.razor @@ -1,7 +1,6 @@ -@page "/" - -Home - -

Hello, world!

- -Welcome to your new app. +@page "/{tenantId}" + +Home + +

RemoteTickets

+

Tenant: @tenantId

From 462b42f6f31bdf22ca27801195b3861948eb784f Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:18:53 -0300 Subject: [PATCH 026/112] feat: scope counter page to tenant route --- .../Components/Pages/Counter.razor | 34 ++++++++----------- 1 file changed, 15 insertions(+), 19 deletions(-) diff --git a/src/server/RemoteTickets/Components/Pages/Counter.razor b/src/server/RemoteTickets/Components/Pages/Counter.razor index ba08d04..df64c8a 100644 --- a/src/server/RemoteTickets/Components/Pages/Counter.razor +++ b/src/server/RemoteTickets/Components/Pages/Counter.razor @@ -1,19 +1,15 @@ -@page "/counter" -@rendermode InteractiveServer - -Counter - -

Counter

- -

Current count: @currentCount

- - - -@code { - private int currentCount = 0; - - private void IncrementCount() - { - currentCount++; - } -} +@page "/{tenantId}/counter" +@rendermode InteractiveServer + +Counter + +

Counter

+

Tenant: @tenantId

+

Current count: @currentCount

+ + +@code { + [Parameter] public string tenantId { get; set; } = string.Empty; + private int currentCount; + private void IncrementCount() => currentCount++; +} From b303d16be36951aa0011aeeb2215dd7e87fe086e Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:18:59 -0300 Subject: [PATCH 027/112] feat: scope weather page to tenant route --- .../Components/Pages/Weather.razor | 114 ++++++++---------- 1 file changed, 50 insertions(+), 64 deletions(-) diff --git a/src/server/RemoteTickets/Components/Pages/Weather.razor b/src/server/RemoteTickets/Components/Pages/Weather.razor index d00febb..2788543 100644 --- a/src/server/RemoteTickets/Components/Pages/Weather.razor +++ b/src/server/RemoteTickets/Components/Pages/Weather.razor @@ -1,64 +1,50 @@ -@page "/weather" -@attribute [StreamRendering] - -Weather - -

Weather

- -

This component demonstrates showing data.

- -@if (forecasts == null) -{ -

Loading...

-} -else -{ - - - - - - - - - - - @foreach (var forecast in forecasts) - { - - - - - - - } - -
DateTemp. (C)Temp. (F)Summary
@forecast.Date.ToShortDateString()@forecast.TemperatureC@forecast.TemperatureF@forecast.Summary
-} - -@code { - private WeatherForecast[]? forecasts; - - protected override async Task OnInitializedAsync() - { - // Simulate asynchronous loading to demonstrate streaming rendering - await Task.Delay(500); - - var startDate = DateOnly.FromDateTime(DateTime.Now); - var summaries = new[] { "Freezing", "Bracing", "Chilly", "Cool", "Mild", "Warm", "Balmy", "Hot", "Sweltering", "Scorching" }; - forecasts = Enumerable.Range(1, 5).Select(index => new WeatherForecast - { - Date = startDate.AddDays(index), - TemperatureC = Random.Shared.Next(-20, 55), - Summary = summaries[Random.Shared.Next(summaries.Length)] - }).ToArray(); - } - - private class WeatherForecast - { - public DateOnly Date { get; set; } - public int TemperatureC { get; set; } - public string? Summary { get; set; } - public int TemperatureF => 32 + (int)(TemperatureC / 0.5556); - } -} +@page "/{tenantId}/weather" +@attribute [StreamRendering] + +Weather + +

Weather

+

Tenant: @tenantId

+ +@if (forecasts == null) +{ +

Loading...

+} +else +{ + + + + @foreach (var forecast in forecasts) + { + + } + +
DateTemp. (C)Temp. (F)Summary
@forecast.Date.ToShortDateString()@forecast.TemperatureC@forecast.TemperatureF@forecast.Summary
+} + +@code { + [Parameter] public string tenantId { get; set; } = string.Empty; + private WeatherForecast[]? forecasts; + + protected override async Task OnInitializedAsync() + { + await Task.Delay(500); + var startDate = DateOnly.FromDateTime(DateTime.Now); + var summaries = new[] { "Freezing", "Bracing", "Chilly", "Cool", "Mild", "Warm", "Balmy", "Hot", "Sweltering", "Scorching" }; + forecasts = Enumerable.Range(1, 5).Select(index => new WeatherForecast + { + Date = startDate.AddDays(index), + TemperatureC = Random.Shared.Next(-20, 55), + Summary = summaries[Random.Shared.Next(summaries.Length)] + }).ToArray(); + } + + private sealed class WeatherForecast + { + public DateOnly Date { get; set; } + public int TemperatureC { get; set; } + public string? Summary { get; set; } + public int TemperatureF => 32 + (int)(TemperatureC / 0.5556); + } +} From 9ac97b1f778a53db898a603d37c43eb24f098b2d Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:19:08 -0300 Subject: [PATCH 028/112] fix: resolve master connection store through dependency injection --- .../InvisibleSPCompositionExtensions.cs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/server/RemoteTickets.Composition/InvisibleSPCompositionExtensions.cs b/src/server/RemoteTickets.Composition/InvisibleSPCompositionExtensions.cs index b4d2572..91b9aa9 100644 --- a/src/server/RemoteTickets.Composition/InvisibleSPCompositionExtensions.cs +++ b/src/server/RemoteTickets.Composition/InvisibleSPCompositionExtensions.cs @@ -12,16 +12,16 @@ public WebApplicationBuilder AddRemoteTickets() { var services = builder.Services; var configuration = builder.Configuration; - services.AddRazorComponents().AddInteractiveServerComponents(); services.AddControllers(); + services.AddHttpClient(); services.Configure(configuration.GetSection(JwtOptions.SectionName)); services.AddSingleton(); - services.AddDbContext(options => + services.AddDbContext((sp, options) => { - var setup = services.BuildServiceProvider().GetService(); - var connectionString = setup?.GetMasterConnectionString() ?? configuration.GetConnectionString("Identity") ?? configuration.GetConnectionString("Master"); + var setup = sp.GetRequiredService(); + var connectionString = setup.GetMasterConnectionString() ?? configuration.GetConnectionString("Identity") ?? configuration.GetConnectionString("Master"); if (string.IsNullOrWhiteSpace(connectionString)) throw new InvalidOperationException("A master database connection string is required."); options.UseSqlServer(connectionString); }); From 674f2ffa92aa1b0eb950fc8f1feb0e86488ad5f2 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:19:23 -0300 Subject: [PATCH 029/112] fix: register tenant middleware namespaces --- src/server/RemoteTickets.Composition/GlobalUsings.cs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/server/RemoteTickets.Composition/GlobalUsings.cs b/src/server/RemoteTickets.Composition/GlobalUsings.cs index 4b9d898..2baca0e 100644 --- a/src/server/RemoteTickets.Composition/GlobalUsings.cs +++ b/src/server/RemoteTickets.Composition/GlobalUsings.cs @@ -5,12 +5,15 @@ global using System.Threading.Tasks; global using FluentValidation; global using RemoteTickets.Application.Common.Identity; +global using RemoteTickets.Application.Common.Tenancy; global using RemoteTickets.Application.Identity; global using RemoteTickets.Application.Identity.Handlers; global using RemoteTickets.Application.Identity.Validators; global using RemoteTickets.Application.Pipeline.Validation; global using RemoteTickets.Infrastructure.Persistence; global using RemoteTickets.Infrastructure.Identity.Services; +global using RemoteTickets.Infrastructure.Setup; +global using RemoteTickets.Infrastructure.Tenancy; global using Mediator.Net.MicrosoftDependencyInjection; global using Microsoft.AspNetCore.Authentication.JwtBearer; global using Microsoft.AspNetCore.Builder; From c71008d524a3a4ffefc00d1df34be6b15a6659f9 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:19:39 -0300 Subject: [PATCH 030/112] fix: harden tenant setup route detection --- .../Tenancy/TenantAccessMiddleware.cs | 35 ++++++++++++------- 1 file changed, 23 insertions(+), 12 deletions(-) diff --git a/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs b/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs index 52f336d..f58cf3d 100644 --- a/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs +++ b/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs @@ -5,10 +5,7 @@ namespace RemoteTickets.Infrastructure.Tenancy; /// Enforces tenant route isolation and mandatory setup state for HTTP requests. -public sealed class TenantAccessMiddleware( - RequestDelegate next, - ITenantManagementService tenants, - IIdentityService identityService) +public sealed class TenantAccessMiddleware(RequestDelegate next, ITenantManagementService tenants, IIdentityService identityService) { /// Processes the current request and enforces tenant isolation when a tenant route is present. /// The current HTTP context. @@ -25,12 +22,7 @@ public async Task InvokeAsync(HttpContext context) var systemStatus = await identityService.GetSetupStatusAsync(context.RequestAborted); if (systemStatus.IsSetupRequired) { - if (IsSetupEndpoint(context)) - { - await next(context); - return; - } - + if (IsSystemSetupEndpoint(context)) { await next(context); return; } await RejectOrRedirectAsync(context, "/setup", StatusCodes.Status503ServiceUnavailable); return; } @@ -42,6 +34,17 @@ public async Task InvokeAsync(HttpContext context) } var tenantId = value.ToString()!; + if (string.Equals(tenantId, "system", StringComparison.OrdinalIgnoreCase)) + { + if (context.User.Identity?.IsAuthenticated != true || !context.User.IsInRole(TenantRoles.SysAdmin)) + { + context.Response.StatusCode = StatusCodes.Status403Forbidden; + return; + } + await next(context); + return; + } + var tenant = await tenants.GetAsync(tenantId, context.RequestAborted); if (tenant is null || !tenant.IsActive) { @@ -68,9 +71,17 @@ public async Task InvokeAsync(HttpContext context) await next(context); } - private static bool IsSetupEndpoint(HttpContext context) => context.Request.Path.StartsWithSegments("/api/setup", StringComparison.OrdinalIgnoreCase) || context.Request.Path.Equals("/setup", StringComparison.OrdinalIgnoreCase); + private static bool IsSystemSetupEndpoint(HttpContext context) => context.Request.Path.StartsWithSegments("/api/setup") || string.Equals(context.Request.Path.Value, "/setup", StringComparison.OrdinalIgnoreCase); - private static bool IsTenantSetupEndpoint(HttpContext context) => context.Request.Path.StartsWithSegments($"/{context.Request.RouteValues["tenantId"]}/setup", StringComparison.OrdinalIgnoreCase) || context.Request.Path.StartsWithSegments("/api/v1/", StringComparison.OrdinalIgnoreCase) && context.Request.Path.Value?.EndsWith("/setup", StringComparison.OrdinalIgnoreCase) == true; + private static bool IsTenantSetupEndpoint(HttpContext context) + { + var tenantId = context.Request.RouteValues.TryGetValue("tenantId", out var value) ? value?.ToString() : null; + if (string.IsNullOrWhiteSpace(tenantId)) return false; + var path = context.Request.Path.Value; + return string.Equals(path, $"/{tenantId}/setup", StringComparison.OrdinalIgnoreCase) + || string.Equals(path, $"/api/v1/{tenantId}/setup", StringComparison.OrdinalIgnoreCase) + || string.Equals(path, $"/api/v1/{tenantId}/setup/complete", StringComparison.OrdinalIgnoreCase); + } private static async Task RejectOrRedirectAsync(HttpContext context, string location, int statusCode) { From 709d94a8eadf4d434c44c4e159b367e4c105c2a1 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:19:49 -0300 Subject: [PATCH 031/112] fix: enforce setup before anonymous endpoints --- .../Tenancy/TenantAccessMiddleware.cs | 32 +++++++++++++------ 1 file changed, 23 insertions(+), 9 deletions(-) diff --git a/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs b/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs index f58cf3d..80d0b9b 100644 --- a/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs +++ b/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs @@ -13,12 +13,7 @@ public sealed class TenantAccessMiddleware(RequestDelegate next, ITenantManageme public async Task InvokeAsync(HttpContext context) { var endpoint = context.GetEndpoint(); - if (endpoint?.Metadata.GetMetadata() is not null) - { - await next(context); - return; - } - + var anonymous = endpoint?.Metadata.GetMetadata() is not null; var systemStatus = await identityService.GetSetupStatusAsync(context.RequestAborted); if (systemStatus.IsSetupRequired) { @@ -29,7 +24,8 @@ public async Task InvokeAsync(HttpContext context) if (!context.Request.RouteValues.TryGetValue("tenantId", out var value) || string.IsNullOrWhiteSpace(value?.ToString())) { - await next(context); + if (anonymous) await next(context); + else await RejectOrRedirectAsync(context, "/setup", StatusCodes.Status503ServiceUnavailable); return; } @@ -52,7 +48,24 @@ public async Task InvokeAsync(HttpContext context) return; } - if (context.User.Identity?.IsAuthenticated == true && !context.User.IsInRole(TenantRoles.SysAdmin)) + if (anonymous) + { + if (!tenant.IsSetupComplete && !IsTenantSetupEndpoint(context) && !IsTenantLoginEndpoint(context)) + { + await RejectOrRedirectAsync(context, $"/{tenantId}/setup", StatusCodes.Status409Conflict); + return; + } + await next(context); + return; + } + + if (context.User.Identity?.IsAuthenticated != true) + { + context.Response.StatusCode = StatusCodes.Status401Unauthorized; + return; + } + + if (!context.User.IsInRole(TenantRoles.SysAdmin)) { var assignedTenant = context.User.FindFirst(TenantClaimTypes.TenantId)?.Value; if (!string.Equals(assignedTenant, tenantId, StringComparison.OrdinalIgnoreCase)) @@ -73,6 +86,8 @@ public async Task InvokeAsync(HttpContext context) private static bool IsSystemSetupEndpoint(HttpContext context) => context.Request.Path.StartsWithSegments("/api/setup") || string.Equals(context.Request.Path.Value, "/setup", StringComparison.OrdinalIgnoreCase); + private static bool IsTenantLoginEndpoint(HttpContext context) => string.Equals(context.Request.Path.Value, $"/api/v1/{context.Request.RouteValues["tenantId"]}/login", StringComparison.OrdinalIgnoreCase); + private static bool IsTenantSetupEndpoint(HttpContext context) { var tenantId = context.Request.RouteValues.TryGetValue("tenantId", out var value) ? value?.ToString() : null; @@ -90,7 +105,6 @@ private static async Task RejectOrRedirectAsync(HttpContext context, string loca context.Response.Redirect(location); return; } - context.Response.StatusCode = statusCode; context.Response.ContentType = "application/problem+json"; await context.Response.WriteAsJsonAsync(new { title = "Setup required", detail = "Complete the required setup before using this endpoint.", setup = location }, context.RequestAborted); From 7dd76b6ff3b4b0bb8742d8769ecbe31cd5ca8f06 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:20:02 -0300 Subject: [PATCH 032/112] feat: initialize master schema during setup --- src/server/RemoteTickets/Controllers/SetupController.cs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/server/RemoteTickets/Controllers/SetupController.cs b/src/server/RemoteTickets/Controllers/SetupController.cs index 796a994..ce0c058 100644 --- a/src/server/RemoteTickets/Controllers/SetupController.cs +++ b/src/server/RemoteTickets/Controllers/SetupController.cs @@ -3,22 +3,24 @@ namespace RemoteTickets.Controllers; /// Exposes anonymous endpoints used during first-time application setup. /// The mediator used to dispatch setup requests. /// The store used to persist the master database connection. +/// The central database context used to initialize the master schema. [ApiController] [Route("api/setup")] -public sealed class SetupController(IMediator mediator, ISetupConfigurationStore configurationStore) : ControllerBase +public sealed class SetupController(IMediator mediator, ISetupConfigurationStore configurationStore, RemoteTicketsDbContext dbContext) : ControllerBase { /// Gets the current first-time setup status. [HttpGet("status")] [AllowAnonymous] public Task GetStatus(CancellationToken cancellationToken) => mediator.RequestAsync(new GetSetupStatusQuery(), cancellationToken); - /// Persists the master database connection string used to administer tenants. + /// Persists the master database connection string and initializes its schema. [HttpPost("master-database")] [AllowAnonymous] public async Task ConfigureMasterDatabase(MasterDatabaseSetupRequest request, CancellationToken cancellationToken) { if (string.IsNullOrWhiteSpace(request.ConnectionString)) return BadRequest(new { error = "A master database connection string is required." }); await configurationStore.SetMasterConnectionStringAsync(request.ConnectionString, cancellationToken); + await dbContext.Database.EnsureCreatedAsync(cancellationToken); return Ok(); } From 36900c85d41fec0075f9a66c61df506abc085352 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:20:07 -0300 Subject: [PATCH 033/112] fix: allow setup controller to initialize a selected database --- src/server/RemoteTickets/GlobalUsings.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/server/RemoteTickets/GlobalUsings.cs b/src/server/RemoteTickets/GlobalUsings.cs index 9f833b3..4a01f27 100644 --- a/src/server/RemoteTickets/GlobalUsings.cs +++ b/src/server/RemoteTickets/GlobalUsings.cs @@ -8,8 +8,10 @@ global using RemoteTickets.Application.Identity.Requests; global using RemoteTickets.Composition; global using RemoteTickets.Components; +global using RemoteTickets.Infrastructure.Persistence; global using RemoteTickets.Infrastructure.Setup; global using Mediator.Net; global using Microsoft.AspNetCore.Authorization; global using Microsoft.AspNetCore.Builder; global using Microsoft.AspNetCore.Mvc; +global using Microsoft.EntityFrameworkCore; From ce280d8bcfe31341090209fcf02f20e66834d94f Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:20:13 -0300 Subject: [PATCH 034/112] fix: initialize the selected master database before identity setup --- src/server/RemoteTickets/Controllers/SetupController.cs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/server/RemoteTickets/Controllers/SetupController.cs b/src/server/RemoteTickets/Controllers/SetupController.cs index ce0c058..18aaeab 100644 --- a/src/server/RemoteTickets/Controllers/SetupController.cs +++ b/src/server/RemoteTickets/Controllers/SetupController.cs @@ -3,10 +3,9 @@ namespace RemoteTickets.Controllers; /// Exposes anonymous endpoints used during first-time application setup. /// The mediator used to dispatch setup requests. /// The store used to persist the master database connection. -/// The central database context used to initialize the master schema. [ApiController] [Route("api/setup")] -public sealed class SetupController(IMediator mediator, ISetupConfigurationStore configurationStore, RemoteTicketsDbContext dbContext) : ControllerBase +public sealed class SetupController(IMediator mediator, ISetupConfigurationStore configurationStore) : ControllerBase { /// Gets the current first-time setup status. [HttpGet("status")] @@ -20,6 +19,8 @@ public async Task ConfigureMasterDatabase(MasterDatabaseSetupRequ { if (string.IsNullOrWhiteSpace(request.ConnectionString)) return BadRequest(new { error = "A master database connection string is required." }); await configurationStore.SetMasterConnectionStringAsync(request.ConnectionString, cancellationToken); + var options = new DbContextOptionsBuilder().UseSqlServer(request.ConnectionString).Options; + await using var dbContext = new RemoteTicketsDbContext(options); await dbContext.Database.EnsureCreatedAsync(cancellationToken); return Ok(); } From a1b49f3b547d4c5dfaddb191323e1dc8025ee7e5 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:20:25 -0300 Subject: [PATCH 035/112] fix: bind tenant scope to refresh tokens --- .../Identity/Services/JwtTokenService.cs | 97 ++++--------------- 1 file changed, 17 insertions(+), 80 deletions(-) diff --git a/src/server/RemoteTickets.Infrastructure/Identity/Services/JwtTokenService.cs b/src/server/RemoteTickets.Infrastructure/Identity/Services/JwtTokenService.cs index ed649df..b50a229 100644 --- a/src/server/RemoteTickets.Infrastructure/Identity/Services/JwtTokenService.cs +++ b/src/server/RemoteTickets.Infrastructure/Identity/Services/JwtTokenService.cs @@ -11,24 +11,16 @@ public sealed class JwtTokenService(IOptions options, IRevokedTokenS public TokenResponse CreateTokens(string userId, string email, IEnumerable roles, IEnumerable claims) { var now = DateTimeOffset.UtcNow; - var access = CreateToken(userId, email, roles, claims, JwtTokenTypes.Access, now, _options.AccessTokenLifetime); - var refresh = CreateToken(userId, email, roles, Array.Empty(), JwtTokenTypes.Refresh, now, _options.RefreshTokenLifetime); - - return new TokenResponse( - "Bearer", - new JwtSecurityTokenHandler().WriteToken(access), - (int)_options.AccessTokenLifetime.TotalSeconds, - new JwtSecurityTokenHandler().WriteToken(refresh)); + var claimSet = claims.ToArray(); + var access = CreateToken(userId, email, roles, claimSet, JwtTokenTypes.Access, now, _options.AccessTokenLifetime); + var refresh = CreateToken(userId, email, roles, claimSet, JwtTokenTypes.Refresh, now, _options.RefreshTokenLifetime); + return new TokenResponse("Bearer", new JwtSecurityTokenHandler().WriteToken(access), (int)_options.AccessTokenLifetime.TotalSeconds, new JwtSecurityTokenHandler().WriteToken(refresh)); } /// public ClaimsPrincipal? ValidateToken(string token, bool validateLifetime = true) { - if (string.IsNullOrWhiteSpace(token)) - { - return null; - } - + if (string.IsNullOrWhiteSpace(token)) return null; var parameters = new TokenValidationParameters { ValidateIssuerSigningKey = true, @@ -40,39 +32,21 @@ public TokenResponse CreateTokens(string userId, string email, IEnumerable public string? GetTokenId(string token) { - try - { - return new JwtSecurityTokenHandler().ReadJwtToken(token).Id; - } - catch (ArgumentException) - { - return null; - } + try { return new JwtSecurityTokenHandler().ReadJwtToken(token).Id; } + catch (ArgumentException) { return null; } } /// @@ -83,20 +57,10 @@ public TokenResponse CreateTokens(string userId, string email, IEnumerable roles, - IEnumerable claims, - string tokenType, - DateTimeOffset issuedAt, - TimeSpan lifetime) + private JwtSecurityToken CreateToken(string userId, string email, IEnumerable roles, IEnumerable claims, string tokenType, DateTimeOffset issuedAt, TimeSpan lifetime) { var tokenClaims = new List { @@ -105,29 +69,15 @@ private JwtSecurityToken CreateToken( new(JwtRegisteredClaimNames.Jti, Guid.NewGuid().ToString("N")), new("token_type", tokenType) }; - tokenClaims.AddRange(roles.Select(role => new Claim(ClaimTypes.Role, role))); tokenClaims.AddRange(claims); - - var credentials = new SigningCredentials(CreateSecurityKey(), SecurityAlgorithms.HmacSha256); - - return new JwtSecurityToken( - issuer: _options.Issuer, - audience: _options.Audience, - claims: tokenClaims, - notBefore: issuedAt.UtcDateTime, - expires: issuedAt.Add(lifetime).UtcDateTime, - signingCredentials: credentials); + return new JwtSecurityToken(issuer: _options.Issuer, audience: _options.Audience, claims: tokenClaims, notBefore: issuedAt.UtcDateTime, expires: issuedAt.Add(lifetime).UtcDateTime, signingCredentials: new SigningCredentials(CreateSecurityKey(), SecurityAlgorithms.HmacSha256)); } private SymmetricSecurityKey CreateSecurityKey() { var bytes = Encoding.UTF8.GetBytes(_options.SecretKey); - if (bytes.Length < 32) - { - throw new InvalidOperationException("Authentication:Jwt:SecretKey must contain at least 256 bits."); - } - + if (bytes.Length < 32) throw new InvalidOperationException("Authentication:Jwt:SecretKey must contain at least 256 bits."); return new SymmetricSecurityKey(bytes); } } @@ -136,30 +86,17 @@ private SymmetricSecurityKey CreateSecurityKey() public sealed class RevokedTokenStore : IRevokedTokenStore { private readonly ConcurrentDictionary _tokens = new(); - /// public bool IsRevoked(string tokenId) { - if (!_tokens.TryGetValue(tokenId, out var expiresAt)) - { - return false; - } - - if (expiresAt > DateTimeOffset.UtcNow) - { - return true; - } - + if (!_tokens.TryGetValue(tokenId, out var expiresAt)) return false; + if (expiresAt > DateTimeOffset.UtcNow) return true; _tokens.TryRemove(tokenId, out _); return false; } - /// public void Revoke(string tokenId, DateTimeOffset expiresAt) { - if (expiresAt > DateTimeOffset.UtcNow) - { - _tokens[tokenId] = expiresAt; - } + if (expiresAt > DateTimeOffset.UtcNow) _tokens[tokenId] = expiresAt; } } From 6ca4736e0ae7da06f3039635ddf5d50d6576ee9f Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:20:33 -0300 Subject: [PATCH 036/112] fix: validate tenant binding on refresh tokens --- .../Tenancy/TenantAccessMiddleware.cs | 65 +++++++------------ 1 file changed, 25 insertions(+), 40 deletions(-) diff --git a/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs b/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs index 80d0b9b..a6676df 100644 --- a/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs +++ b/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs @@ -1,11 +1,12 @@ using Microsoft.AspNetCore.Authorization; using Microsoft.AspNetCore.Http; +using RemoteTickets.Application.Common.Identity; using RemoteTickets.Application.Common.Tenancy; namespace RemoteTickets.Infrastructure.Tenancy; /// Enforces tenant route isolation and mandatory setup state for HTTP requests. -public sealed class TenantAccessMiddleware(RequestDelegate next, ITenantManagementService tenants, IIdentityService identityService) +public sealed class TenantAccessMiddleware(RequestDelegate next, ITenantManagementService tenants, IIdentityService identityService, IJwtTokenService tokenService) { /// Processes the current request and enforces tenant isolation when a tenant route is present. /// The current HTTP context. @@ -24,69 +25,57 @@ public async Task InvokeAsync(HttpContext context) if (!context.Request.RouteValues.TryGetValue("tenantId", out var value) || string.IsNullOrWhiteSpace(value?.ToString())) { - if (anonymous) await next(context); - else await RejectOrRedirectAsync(context, "/setup", StatusCodes.Status503ServiceUnavailable); + if (anonymous) await next(context); else await RejectOrRedirectAsync(context, "/setup", StatusCodes.Status503ServiceUnavailable); return; } var tenantId = value.ToString()!; if (string.Equals(tenantId, "system", StringComparison.OrdinalIgnoreCase)) { - if (context.User.Identity?.IsAuthenticated != true || !context.User.IsInRole(TenantRoles.SysAdmin)) - { - context.Response.StatusCode = StatusCodes.Status403Forbidden; - return; - } + if (context.User.Identity?.IsAuthenticated != true || !context.User.IsInRole(TenantRoles.SysAdmin)) { context.Response.StatusCode = StatusCodes.Status403Forbidden; return; } await next(context); return; } var tenant = await tenants.GetAsync(tenantId, context.RequestAborted); - if (tenant is null || !tenant.IsActive) - { - await RejectOrRedirectAsync(context, "/not-found", StatusCodes.Status404NotFound); - return; - } + if (tenant is null || !tenant.IsActive) { await RejectOrRedirectAsync(context, "/not-found", StatusCodes.Status404NotFound); return; } if (anonymous) { - if (!tenant.IsSetupComplete && !IsTenantSetupEndpoint(context) && !IsTenantLoginEndpoint(context)) - { - await RejectOrRedirectAsync(context, $"/{tenantId}/setup", StatusCodes.Status409Conflict); - return; - } + if (IsTenantRefreshEndpoint(context) && !IsRefreshTokenForTenant(context, tenantId)) { context.Response.StatusCode = StatusCodes.Status401Unauthorized; return; } + if (!tenant.IsSetupComplete && !IsTenantSetupEndpoint(context) && !IsTenantLoginEndpoint(context)) { await RejectOrRedirectAsync(context, $"/{tenantId}/setup", StatusCodes.Status409Conflict); return; } await next(context); return; } - if (context.User.Identity?.IsAuthenticated != true) - { - context.Response.StatusCode = StatusCodes.Status401Unauthorized; - return; - } - + if (context.User.Identity?.IsAuthenticated != true) { context.Response.StatusCode = StatusCodes.Status401Unauthorized; return; } if (!context.User.IsInRole(TenantRoles.SysAdmin)) { var assignedTenant = context.User.FindFirst(TenantClaimTypes.TenantId)?.Value; - if (!string.Equals(assignedTenant, tenantId, StringComparison.OrdinalIgnoreCase)) - { - await RejectOrRedirectAsync(context, $"/{assignedTenant ?? tenantId}", StatusCodes.Status403Forbidden); - return; - } + if (!string.Equals(assignedTenant, tenantId, StringComparison.OrdinalIgnoreCase)) { await RejectOrRedirectAsync(context, $"/{assignedTenant ?? tenantId}", StatusCodes.Status403Forbidden); return; } } - if (!tenant.IsSetupComplete && !IsTenantSetupEndpoint(context)) + if (!tenant.IsSetupComplete && !IsTenantSetupEndpoint(context)) { await RejectOrRedirectAsync(context, $"/{tenantId}/setup", StatusCodes.Status409Conflict); return; } + await next(context); + } + + private bool IsRefreshTokenForTenant(HttpContext context, string tenantId) + { + var token = context.Request.Headers.Authorization.ToString().Replace("Bearer ", string.Empty, StringComparison.OrdinalIgnoreCase); + if (string.IsNullOrWhiteSpace(token)) { - await RejectOrRedirectAsync(context, $"/{tenantId}/setup", StatusCodes.Status409Conflict); - return; + var body = context.Request.Form; + token = body["refreshToken"].ToString(); } - - await next(context); + var principal = tokenService.ValidateToken(token); + if (principal is null || !string.Equals(principal.FindFirst("token_type")?.Value, JwtTokenTypes.Refresh, StringComparison.Ordinal)) return false; + if (principal.IsInRole(TenantRoles.SysAdmin)) return true; + return string.Equals(principal.FindFirst(TenantClaimTypes.TenantId)?.Value, tenantId, StringComparison.OrdinalIgnoreCase); } private static bool IsSystemSetupEndpoint(HttpContext context) => context.Request.Path.StartsWithSegments("/api/setup") || string.Equals(context.Request.Path.Value, "/setup", StringComparison.OrdinalIgnoreCase); - private static bool IsTenantLoginEndpoint(HttpContext context) => string.Equals(context.Request.Path.Value, $"/api/v1/{context.Request.RouteValues["tenantId"]}/login", StringComparison.OrdinalIgnoreCase); + private static bool IsTenantRefreshEndpoint(HttpContext context) => string.Equals(context.Request.Path.Value, $"/api/v1/{context.Request.RouteValues["tenantId"]}/refresh", StringComparison.OrdinalIgnoreCase); private static bool IsTenantSetupEndpoint(HttpContext context) { @@ -100,11 +89,7 @@ private static bool IsTenantSetupEndpoint(HttpContext context) private static async Task RejectOrRedirectAsync(HttpContext context, string location, int statusCode) { - if (HttpMethods.IsGet(context.Request.Method) && context.Request.Headers.Accept.Any(x => x.Contains("text/html", StringComparison.OrdinalIgnoreCase))) - { - context.Response.Redirect(location); - return; - } + if (HttpMethods.IsGet(context.Request.Method) && context.Request.Headers.Accept.Any(x => x.Contains("text/html", StringComparison.OrdinalIgnoreCase))) { context.Response.Redirect(location); return; } context.Response.StatusCode = statusCode; context.Response.ContentType = "application/problem+json"; await context.Response.WriteAsJsonAsync(new { title = "Setup required", detail = "Complete the required setup before using this endpoint.", setup = location }, context.RequestAborted); From 71e7d55892b22bdb5b0cc49bf349ecadf19c8e12 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:20:42 -0300 Subject: [PATCH 037/112] feat: add tenant-bound refresh identity operation --- .../Identity/IIdentityService.cs | 83 +------------------ 1 file changed, 2 insertions(+), 81 deletions(-) diff --git a/src/server/RemoteTickets.Application/Identity/IIdentityService.cs b/src/server/RemoteTickets.Application/Identity/IIdentityService.cs index 110a380..b263b25 100644 --- a/src/server/RemoteTickets.Application/Identity/IIdentityService.cs +++ b/src/server/RemoteTickets.Application/Identity/IIdentityService.cs @@ -4,114 +4,35 @@ namespace RemoteTickets.Application.Identity; public interface IIdentityService { /// Registers a user and starts email confirmation. - /// The user's email address. - /// The user's password. - /// The token used to cancel the operation. - /// The registration result. Task RegisterAsync(string email, string password, CancellationToken cancellationToken); - /// Authenticates a user and issues JWT tokens when all required factors are valid. - /// The user's email address. - /// The user's password. - /// The authenticator code, when two-factor authentication is enabled. - /// The recovery code, when a recovery code is used instead of an authenticator code. - /// The token used to cancel the operation. - /// The token pair, or when authentication fails. Task LoginAsync(string email, string password, string? twoFactorCode, string? twoFactorRecoveryCode, CancellationToken cancellationToken); - /// Authenticates a user against a tenant route and rejects users assigned to another tenant. - /// The tenant identifier supplied by the route. - /// The user's email address. - /// The user's password. - /// The authenticator code, when two-factor authentication is enabled. - /// The recovery code, when a recovery code is used instead of an authenticator code. - /// The token used to cancel the operation. - /// The token pair, or when the credentials or tenant assignment are invalid. Task LoginAsync(string tenantId, string email, string password, string? twoFactorCode, string? twoFactorRecoveryCode, CancellationToken cancellationToken); - /// Creates the first administrator account for a tenant in the central identity store. - /// The tenant identifier assigned to the user. - /// The administrator email address. - /// The administrator password. - /// The token used to cancel the operation. - /// The user creation result. Task CreateTenantAdminAsync(string tenantId, string email, string password, CancellationToken cancellationToken); - /// Exchanges a valid refresh token for a new token pair. - /// The refresh token to exchange. - /// The token used to cancel the operation. - /// The new token pair, or when the refresh token is invalid. Task RefreshAsync(string refreshToken, CancellationToken cancellationToken); - + /// Exchanges a refresh token while enforcing its tenant route binding. + Task RefreshAsync(string tenantId, string refreshToken, CancellationToken cancellationToken); /// Revokes an access token until its natural expiration. - /// The access token to revoke. - /// The token used to cancel the operation. - /// when revocation succeeds; otherwise . Task RevokeAsync(string accessToken, CancellationToken cancellationToken); - /// Confirms a user's email address or a changed email address. - /// The user's identifier. - /// The confirmation token. - /// The replacement email address when confirming an email change. - /// The token used to cancel the operation. - /// when confirmation succeeds; otherwise . Task ConfirmEmailAsync(string userId, string code, string? changedEmail, CancellationToken cancellationToken); - /// Resends email confirmation when required. - /// The user's email address. - /// The token used to cancel the operation. - /// The resend operation result. Task ResendConfirmationEmailAsync(string email, CancellationToken cancellationToken); - /// Starts password recovery for a password-bearing user. - /// The user's email address. - /// The token used to cancel the operation. - /// A result that does not reveal whether an email is registered. Task ForgotPasswordAsync(string email, CancellationToken cancellationToken); - /// Resets a user's password with a valid reset token. - /// The user's email address. - /// The password reset token. - /// The replacement password. - /// The token used to cancel the operation. - /// The reset operation result. Task ResetPasswordAsync(string email, string resetCode, string newPassword, CancellationToken cancellationToken); - /// Gets basic identity information for a user. - /// The user's identifier. - /// The token used to cancel the operation. - /// The identity information, or when the user does not exist. Task GetInfoAsync(string userId, CancellationToken cancellationToken); - /// Updates identity information after validating the current password. - /// The user's identifier. - /// The replacement email address, or to keep the current address. - /// The replacement password, or to keep the current password. - /// The current password. - /// The token used to cancel the operation. - /// The update operation result. Task UpdateInfoAsync(string userId, string? newEmail, string? newPassword, string oldPassword, CancellationToken cancellationToken); - /// Configures authenticator-based two-factor authentication and recovery material. - /// The user's identifier. - /// Whether to enable or disable two-factor authentication. - /// The authenticator code used to validate enabling two-factor authentication. - /// Whether recovery codes should be regenerated. - /// Whether the shared authenticator key should be regenerated. - /// Whether the remembered machine state should be cleared. - /// The token used to cancel the operation. - /// The current configuration, or when the operation cannot be completed. Task ConfigureTwoFactorAsync(string userId, bool? enable, string? twoFactorCode, bool resetRecoveryCodes, bool resetSharedKey, bool forgetMachine, CancellationToken cancellationToken); - /// Gets the current first-time setup status. - /// The token used to cancel the operation. - /// The setup status. Task GetSetupStatusAsync(CancellationToken cancellationToken); - /// Creates the initial administrator account when setup has not yet completed. - /// The administrator email address. - /// The administrator password. - /// The token used to cancel the operation. - /// The setup operation result. Task InitializeSetupAsync(string email, string password, CancellationToken cancellationToken); } From 43cc127902bf8db0c78f020e5000d3335dc5a1ca Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:21:18 -0300 Subject: [PATCH 038/112] feat: include tenant scope in refresh command --- .../Identity/Requests/IdentityRequests.cs | 26 +++++++------------ 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/src/server/RemoteTickets.Application/Identity/Requests/IdentityRequests.cs b/src/server/RemoteTickets.Application/Identity/Requests/IdentityRequests.cs index ed2aec7..33c1360 100644 --- a/src/server/RemoteTickets.Application/Identity/Requests/IdentityRequests.cs +++ b/src/server/RemoteTickets.Application/Identity/Requests/IdentityRequests.cs @@ -10,60 +10,52 @@ public sealed record RegisterCommand(string Email, string Password) : IRequest; /// The user's password. /// The authenticator code, when required. /// The recovery code, when used instead of an authenticator code. -/// The tenant route identifier. When supplied, the identity must belong to this tenant or be a system administrator. +/// The tenant route identifier. public sealed record LoginCommand(string Email, string Password, string? TwoFactorCode = null, string? TwoFactorRecoveryCode = null, string? TenantId = null) : IRequest; /// Requests exchange of a refresh token. /// The refresh token to exchange. -public sealed record RefreshTokenCommand(string RefreshToken) : IRequest; +/// The tenant route identifier used to validate token scope. +public sealed record RefreshTokenCommand(string RefreshToken, string? TenantId = null) : IRequest; /// Requests revocation of an access token. /// The access token to revoke. public sealed record RevokeTokenCommand(string AccessToken) : IRequest; - /// Requests confirmation of a user's email address. /// The user identifier. /// The confirmation token. /// The replacement email address when confirming an email change. public sealed record ConfirmEmailCommand(string UserId, string Code, string? ChangedEmail = null) : IRequest; - /// Requests that an email confirmation link be sent again. /// The user's email address. public sealed record ResendConfirmationEmailCommand(string Email) : IRequest; - /// Starts password recovery for an email address. /// The email address to recover. public sealed record ForgotPasswordCommand(string Email) : IRequest; - /// Requests a password reset. /// The user's email address. /// The password reset token. /// The replacement password. public sealed record ResetPasswordCommand(string Email, string ResetCode, string NewPassword) : IRequest; - /// Requests basic identity information for a user. /// The user identifier. public sealed record GetIdentityInfoQuery(string UserId) : IRequest; - /// Requests an update to identity information. /// The user identifier. -/// The replacement email address, or to keep the current address. -/// The replacement password, or to keep the current password. -/// The current password used to authorize the change. +/// The replacement email address. +/// The replacement password. +/// The current password. public sealed record UpdateIdentityInfoCommand(string UserId, string? NewEmail, string? NewPassword, string OldPassword) : IRequest; - /// Requests a change to authenticator-based two-factor authentication. /// The user identifier. /// Whether to enable or disable two-factor authentication. -/// The authenticator code used when enabling two-factor authentication. +/// The authenticator code. /// Whether recovery codes should be regenerated. -/// Whether the shared authenticator key should be regenerated. -/// Whether the remembered machine state should be cleared. +/// Whether the shared key should be regenerated. +/// Whether remembered-machine state should be cleared. public sealed record ConfigureTwoFactorCommand(string UserId, bool? Enable, string? TwoFactorCode, bool ResetRecoveryCodes, bool ResetSharedKey, bool ForgetMachine) : IRequest; - /// Requests the current first-time setup status. public sealed record GetSetupStatusQuery : IRequest; - /// Requests creation of the initial administrator account. /// The administrator email address. /// The administrator password. From 54029328aa09849909ced338b2bada29e6588531 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:21:26 -0300 Subject: [PATCH 039/112] feat: enforce tenant binding in refresh handler --- .../Identity/Handlers/IdentityHandlers.cs | 23 ++++--------------- 1 file changed, 5 insertions(+), 18 deletions(-) diff --git a/src/server/RemoteTickets.Application/Identity/Handlers/IdentityHandlers.cs b/src/server/RemoteTickets.Application/Identity/Handlers/IdentityHandlers.cs index 846d330..346b15a 100644 --- a/src/server/RemoteTickets.Application/Identity/Handlers/IdentityHandlers.cs +++ b/src/server/RemoteTickets.Application/Identity/Handlers/IdentityHandlers.cs @@ -19,59 +19,46 @@ public sealed class IdentityHandlers(IIdentityService identityService) : { /// Executes the registration request. public Task Handle(IReceiveContext context, CancellationToken cancellationToken) => identityService.RegisterAsync(context.Message.Email, context.Message.Password, cancellationToken); - - /// Executes the login request and converts authentication failure to an application response. + /// Executes the login request. public async Task> Handle(IReceiveContext context, CancellationToken cancellationToken) { var message = context.Message; - var result = message.TenantId is null - ? await identityService.LoginAsync(message.Email, message.Password, message.TwoFactorCode, message.TwoFactorRecoveryCode, cancellationToken) - : await identityService.LoginAsync(message.TenantId, message.Email, message.Password, message.TwoFactorCode, message.TwoFactorRecoveryCode, cancellationToken); + var result = message.TenantId is null ? await identityService.LoginAsync(message.Email, message.Password, message.TwoFactorCode, message.TwoFactorRecoveryCode, cancellationToken) : await identityService.LoginAsync(message.TenantId, message.Email, message.Password, message.TwoFactorCode, message.TwoFactorRecoveryCode, cancellationToken); return result is null ? Response.Failure(["Invalid credentials."]) : Response.Success(result); } - - /// Executes a refresh-token exchange. + /// Executes a tenant-bound refresh-token exchange. public async Task> Handle(IReceiveContext context, CancellationToken cancellationToken) { - var result = await identityService.RefreshAsync(context.Message.RefreshToken, cancellationToken); + var message = context.Message; + var result = message.TenantId is null ? await identityService.RefreshAsync(message.RefreshToken, cancellationToken) : await identityService.RefreshAsync(message.TenantId, message.RefreshToken, cancellationToken); return result is null ? Response.Failure(["Invalid refresh token."]) : Response.Success(result); } - /// Executes token revocation. public async Task> Handle(IReceiveContext context, CancellationToken cancellationToken) => Response.Success(await identityService.RevokeAsync(context.Message.AccessToken, cancellationToken)); - /// Executes email confirmation. public async Task> Handle(IReceiveContext context, CancellationToken cancellationToken) => Response.Success(await identityService.ConfirmEmailAsync(context.Message.UserId, context.Message.Code, context.Message.ChangedEmail, cancellationToken)); - /// Executes a confirmation-email resend request. public Task Handle(IReceiveContext context, CancellationToken cancellationToken) => identityService.ResendConfirmationEmailAsync(context.Message.Email, cancellationToken); - /// Executes a password-recovery request. public Task Handle(IReceiveContext context, CancellationToken cancellationToken) => identityService.ForgotPasswordAsync(context.Message.Email, cancellationToken); - /// Executes a password reset. public Task Handle(IReceiveContext context, CancellationToken cancellationToken) => identityService.ResetPasswordAsync(context.Message.Email, context.Message.ResetCode, context.Message.NewPassword, cancellationToken); - /// Executes an identity information query. public async Task> Handle(IReceiveContext context, CancellationToken cancellationToken) { var result = await identityService.GetInfoAsync(context.Message.UserId, cancellationToken); return result is null ? Response.Failure(["User not found."]) : Response.Success(result); } - /// Executes an identity information update. public Task Handle(IReceiveContext context, CancellationToken cancellationToken) => identityService.UpdateInfoAsync(context.Message.UserId, context.Message.NewEmail, context.Message.NewPassword, context.Message.OldPassword, cancellationToken); - /// Executes two-factor configuration. public async Task> Handle(IReceiveContext context, CancellationToken cancellationToken) { var result = await identityService.ConfigureTwoFactorAsync(context.Message.UserId, context.Message.Enable, context.Message.TwoFactorCode, context.Message.ResetRecoveryCodes, context.Message.ResetSharedKey, context.Message.ForgetMachine, cancellationToken); return result is null ? Response.Failure(["The two-factor configuration request is invalid."]) : Response.Success(result); } - /// Reads the current setup status. public Task Handle(IReceiveContext context, CancellationToken cancellationToken) => identityService.GetSetupStatusAsync(cancellationToken); - /// Executes first-time setup initialization. public Task Handle(IReceiveContext context, CancellationToken cancellationToken) => identityService.InitializeSetupAsync(context.Message.Email, context.Message.Password, cancellationToken); } From a032ba31ed0e0de59fbb7cb11259637451b105c0 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:22:09 -0300 Subject: [PATCH 040/112] fix: bind refresh endpoint to tenant route --- .../Controllers/IdentityController.cs | 19 ++++--------------- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/src/server/RemoteTickets/Controllers/IdentityController.cs b/src/server/RemoteTickets/Controllers/IdentityController.cs index 51f79b3..f3b2ec0 100644 --- a/src/server/RemoteTickets/Controllers/IdentityController.cs +++ b/src/server/RemoteTickets/Controllers/IdentityController.cs @@ -11,10 +11,9 @@ public sealed class IdentityController(IMediator mediator) : ControllerBase [AllowAnonymous] public async Task Register([FromRoute] string tenantId, RegisterRequest request, CancellationToken cancellationToken) { - var result = await mediator.RequestAsync(new RegisterCommand(request.Email, request.Password)); + var result = await mediator.RequestAsync(new RegisterCommand(request.Email, request.Password), cancellationToken); return result.Succeeded ? Ok() : BadRequest(result); } - /// Authenticates a user against the requested tenant. [HttpPost("login")] [AllowAnonymous] @@ -23,16 +22,14 @@ public async Task Login([FromRoute] string tenantId, LoginRequest var result = await mediator.RequestAsync>(new LoginCommand(request.Email, request.Password, request.TwoFactorCode, request.TwoFactorRecoveryCode, tenantId), cancellationToken); return result.Succeeded ? Ok(result.Data) : Unauthorized(result); } - /// Exchanges a refresh token for a new token pair in the requested tenant context. [HttpPost("refresh")] [AllowAnonymous] - public async Task Refresh(RefreshRequest request, CancellationToken cancellationToken) + public async Task Refresh([FromRoute] string tenantId, RefreshRequest request, CancellationToken cancellationToken) { - var result = await mediator.RequestAsync>(new RefreshTokenCommand(request.RefreshToken), cancellationToken); + var result = await mediator.RequestAsync>(new RefreshTokenCommand(request.RefreshToken, tenantId), cancellationToken); return result.Succeeded ? Ok(result.Data) : Unauthorized(result); } - /// Revokes the access token supplied by the authenticated caller. [HttpPost("revoke")] [Authorize] @@ -42,7 +39,6 @@ public async Task Revoke(CancellationToken cancellationToken) var result = await mediator.RequestAsync>(new RevokeTokenCommand(accessToken), cancellationToken); return result.Data == true ? Ok() : Unauthorized(result); } - /// Confirms a user's email address. [HttpGet("confirmEmail")] [AllowAnonymous] @@ -51,7 +47,6 @@ public async Task ConfirmEmail([FromQuery] string userId, [FromQu var result = await mediator.RequestAsync>(new ConfirmEmailCommand(userId, code, changedEmail), cancellationToken); return result.Data == true ? Ok("Thank you for confirming your email.") : BadRequest(result); } - /// Resends a user's email confirmation link. [HttpPost("resendConfirmationEmail")] [AllowAnonymous] @@ -60,7 +55,6 @@ public async Task ResendConfirmationEmail(EmailRequest request, C var result = await mediator.RequestAsync(new ResendConfirmationEmailCommand(request.Email), cancellationToken); return result.Succeeded ? Ok() : BadRequest(result); } - /// Starts password recovery for an email address. [HttpPost("forgotPassword")] [AllowAnonymous] @@ -69,7 +63,6 @@ public async Task ForgotPassword(EmailRequest request, Cancellati var result = await mediator.RequestAsync(new ForgotPasswordCommand(request.Email), cancellationToken); return result.Succeeded ? Ok() : BadRequest(result); } - /// Resets a user's password using a reset token. [HttpPost("resetPassword")] [AllowAnonymous] @@ -78,7 +71,6 @@ public async Task ResetPassword(ResetPasswordRequest request, Can var result = await mediator.RequestAsync(new ResetPasswordCommand(request.Email, request.ResetCode, request.NewPassword), cancellationToken); return result.Succeeded ? Ok() : BadRequest(result); } - /// Gets identity information for the authenticated user. [HttpGet("manage/info")] [Authorize] @@ -89,7 +81,6 @@ public async Task GetInfo(CancellationToken cancellationToken) var result = await mediator.RequestAsync>(new GetIdentityInfoQuery(userId), cancellationToken); return result.Succeeded ? Ok(result.Data) : NotFound(result); } - /// Updates identity information for the authenticated user. [HttpPost("manage/info")] [Authorize] @@ -100,7 +91,6 @@ public async Task UpdateInfo(InfoRequest request, CancellationTok var result = await mediator.RequestAsync(new UpdateIdentityInfoCommand(userId, request.NewEmail, request.NewPassword, request.OldPassword), cancellationToken); return result.Succeeded ? Ok() : BadRequest(result); } - /// Configures authenticator-based two-factor authentication for the authenticated user. [HttpPost("manage/2fa")] [Authorize] @@ -111,7 +101,6 @@ public async Task ConfigureTwoFactor(TwoFactorRequest request, Ca var result = await mediator.RequestAsync>(new ConfigureTwoFactorCommand(userId, request.Enable, request.TwoFactorCode, request.ResetRecoveryCodes, request.ResetSharedKey, request.ForgetMachine), cancellationToken); return result.Succeeded ? Ok(result.Data) : BadRequest(result); } - private string? GetUserId() => User.FindFirstValue(JwtRegisteredClaimNames.Sub) ?? User.FindFirstValue(ClaimTypes.NameIdentifier); } @@ -139,7 +128,7 @@ public sealed record ResetPasswordRequest(string Email, string ResetCode, string /// Represents an authenticated identity information update payload. /// The replacement email address. /// The replacement password. -/// The replacement password. +/// The current password. public sealed record InfoRequest(string? NewEmail, string? NewPassword, string OldPassword); /// Represents an authenticator-based two-factor configuration request. /// Whether to enable or disable two-factor authentication. From d4d3b291c08cb4cebced2f290db8eb924b22ab47 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:22:38 -0300 Subject: [PATCH 041/112] feat: implement tenant-bound refresh token service --- .../Services/IdentityService.Refresh.cs | 34 +++++++++++++++++++ 1 file changed, 34 insertions(+) create mode 100644 src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.Refresh.cs diff --git a/src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.Refresh.cs b/src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.Refresh.cs new file mode 100644 index 0000000..5dad526 --- /dev/null +++ b/src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.Refresh.cs @@ -0,0 +1,34 @@ +namespace RemoteTickets.Infrastructure.Identity.Services; + +/// Provides tenant-bound refresh-token handling for . +public sealed partial class IdentityService +{ + /// + public async Task RefreshAsync(string tenantId, string refreshToken, CancellationToken cancellationToken) + { + var principal = tokenService.ValidateToken(refreshToken); + if (principal is null || !string.Equals(principal.FindFirstValue("token_type"), JwtTokenTypes.Refresh, StringComparison.Ordinal)) return null; + + var roles = principal.FindAll(ClaimTypes.Role).Select(x => x.Value).ToArray(); + if (!roles.Contains(TenantRoles.SysAdmin, StringComparer.OrdinalIgnoreCase) && !string.Equals(principal.FindFirst(TenantClaimTypes.TenantId)?.Value, tenantId, StringComparison.OrdinalIgnoreCase)) return null; + + var userId = principal.FindFirstValue(JwtRegisteredClaimNames.Sub) ?? principal.FindFirstValue(ClaimTypes.NameIdentifier); + if (string.IsNullOrWhiteSpace(userId)) return null; + var user = await userManager.FindByIdAsync(userId); + if (user is null) return null; + + var claims = await userManager.GetClaimsAsync(user); + foreach (var roleName in roles) + { + var role = await roleManager.FindByNameAsync(roleName); + if (role is not null) claims = claims.Concat(await roleManager.GetClaimsAsync(role)).ToList(); + } + if (user.TenantId is not null) claims = claims.Append(new Claim(TenantClaimTypes.TenantId, user.TenantId)).ToList(); + + var tokenId = tokenService.GetTokenId(refreshToken); + var expiration = tokenService.GetExpiration(refreshToken); + var tokens = tokenService.CreateTokens(user.Id, user.Email ?? user.UserName ?? user.Id, roles, claims); + if (!string.IsNullOrWhiteSpace(tokenId) && expiration.HasValue) revokedTokenStore.Revoke(tokenId, expiration.Value); + return tokens; + } +} From ade245e440c270eaeb1d84137e0774e88c7882d6 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:22:48 -0300 Subject: [PATCH 042/112] test: cover tenant identity isolation and refresh binding --- .../TenantIdentityTests.cs | 52 +++++++++++++++++++ 1 file changed, 52 insertions(+) create mode 100644 tests/server/RemoteTickets.UnitTests/TenantIdentityTests.cs diff --git a/tests/server/RemoteTickets.UnitTests/TenantIdentityTests.cs b/tests/server/RemoteTickets.UnitTests/TenantIdentityTests.cs new file mode 100644 index 0000000..7c8d787 --- /dev/null +++ b/tests/server/RemoteTickets.UnitTests/TenantIdentityTests.cs @@ -0,0 +1,52 @@ +namespace RemoteTickets.UnitTests; + +/// Verifies tenant isolation and system-administrator cross-tenant access. +public sealed class TenantIdentityTests +{ + /// Verifies that a tenant user cannot authenticate against another tenant by changing only the route tenant identifier. + [Fact] + public async Task Tenant_user_should_not_login_to_another_tenant() + { + await using var fixture = await IdentityFixture.CreateAsync(); + await fixture.Service.InitializeSetupAsync("sysadmin@example.com", "Password1!", CancellationToken.None); + var created = await fixture.Service.CreateTenantAdminAsync("tenant-a", "admin-a@example.com", "Password1!", CancellationToken.None); + created.Succeeded.Should().BeTrue(); + + var valid = await fixture.Service.LoginAsync("tenant-a", "admin-a@example.com", "Password1!", null, null, CancellationToken.None); + valid.Should().NotBeNull(); + + var wrongTenant = await fixture.Service.LoginAsync("tenant-b", "admin-a@example.com", "Password1!", null, null, CancellationToken.None); + wrongTenant.Should().BeNull(); + } + + /// Verifies that a system administrator can authenticate through any tenant route. + [Fact] + public async Task Sysadmin_should_login_through_any_tenant_route() + { + await using var fixture = await IdentityFixture.CreateAsync(); + await fixture.Service.InitializeSetupAsync("sysadmin@example.com", "Password1!", CancellationToken.None); + await fixture.Service.CreateTenantAdminAsync("tenant-a", "admin-a@example.com", "Password1!", CancellationToken.None); + + var tokens = await fixture.Service.LoginAsync("tenant-b", "sysadmin@example.com", "Password1!", null, null, CancellationToken.None); + tokens.Should().NotBeNull(); + fixture.TokenService.ValidateToken(tokens!.AccessToken)!.IsInRole(TenantRoles.SysAdmin).Should().BeTrue(); + } + + /// Verifies that a refresh token cannot be replayed through another tenant route. + [Fact] + public async Task Refresh_token_should_remain_bound_to_its_tenant() + { + await using var fixture = await IdentityFixture.CreateAsync(); + await fixture.Service.InitializeSetupAsync("sysadmin@example.com", "Password1!", CancellationToken.None); + await fixture.Service.CreateTenantAdminAsync("tenant-a", "admin-a@example.com", "Password1!", CancellationToken.None); + var tokens = await fixture.Service.LoginAsync("tenant-a", "admin-a@example.com", "Password1!", null, null, CancellationToken.None); + tokens.Should().NotBeNull(); + + var invalid = await fixture.Service.RefreshAsync("tenant-b", tokens!.RefreshToken, CancellationToken.None); + invalid.Should().BeNull(); + + var refreshed = await fixture.Service.RefreshAsync("tenant-a", tokens.RefreshToken, CancellationToken.None); + refreshed.Should().NotBeNull(); + fixture.TokenService.ValidateToken(refreshed!.AccessToken)!.FindFirst(TenantClaimTypes.TenantId)!.Value.Should().Be("tenant-a"); + } +} From c0da9c68093ba85d1cc546b62f0285442f65c963 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:23:17 -0300 Subject: [PATCH 043/112] fix: include filesystem APIs required by setup persistence --- src/server/RemoteTickets.Infrastructure/GlobalUsings.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/server/RemoteTickets.Infrastructure/GlobalUsings.cs b/src/server/RemoteTickets.Infrastructure/GlobalUsings.cs index 97a4b87..387160e 100644 --- a/src/server/RemoteTickets.Infrastructure/GlobalUsings.cs +++ b/src/server/RemoteTickets.Infrastructure/GlobalUsings.cs @@ -2,6 +2,7 @@ global using System.Collections.Concurrent; global using System.Collections.Generic; global using System.IdentityModel.Tokens.Jwt; +global using System.IO; global using System.Linq; global using System.Linq.Expressions; global using System.Security.Claims; From 1da884b4e0f6ff06ced8df5c53eddb31559f8dc2 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:23:25 -0300 Subject: [PATCH 044/112] fix: exempt Blazor infrastructure requests from tenant gate --- .../Tenancy/TenantAccessMiddleware.cs | 33 +++---------------- 1 file changed, 4 insertions(+), 29 deletions(-) diff --git a/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs b/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs index a6676df..f1fa438 100644 --- a/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs +++ b/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs @@ -1,18 +1,18 @@ using Microsoft.AspNetCore.Authorization; using Microsoft.AspNetCore.Http; -using RemoteTickets.Application.Common.Identity; using RemoteTickets.Application.Common.Tenancy; namespace RemoteTickets.Infrastructure.Tenancy; /// Enforces tenant route isolation and mandatory setup state for HTTP requests. -public sealed class TenantAccessMiddleware(RequestDelegate next, ITenantManagementService tenants, IIdentityService identityService, IJwtTokenService tokenService) +public sealed class TenantAccessMiddleware(RequestDelegate next, ITenantManagementService tenants, IIdentityService identityService) { /// Processes the current request and enforces tenant isolation when a tenant route is present. /// The current HTTP context. /// The asynchronous middleware operation. public async Task InvokeAsync(HttpContext context) { + if (IsInfrastructurePath(context.Request.Path)) { await next(context); return; } var endpoint = context.GetEndpoint(); var anonymous = endpoint?.Metadata.GetMetadata() is not null; var systemStatus = await identityService.GetSetupStatusAsync(context.RequestAborted); @@ -22,13 +22,11 @@ public async Task InvokeAsync(HttpContext context) await RejectOrRedirectAsync(context, "/setup", StatusCodes.Status503ServiceUnavailable); return; } - if (!context.Request.RouteValues.TryGetValue("tenantId", out var value) || string.IsNullOrWhiteSpace(value?.ToString())) { if (anonymous) await next(context); else await RejectOrRedirectAsync(context, "/setup", StatusCodes.Status503ServiceUnavailable); return; } - var tenantId = value.ToString()!; if (string.Equals(tenantId, "system", StringComparison.OrdinalIgnoreCase)) { @@ -36,57 +34,34 @@ public async Task InvokeAsync(HttpContext context) await next(context); return; } - var tenant = await tenants.GetAsync(tenantId, context.RequestAborted); if (tenant is null || !tenant.IsActive) { await RejectOrRedirectAsync(context, "/not-found", StatusCodes.Status404NotFound); return; } - if (anonymous) { - if (IsTenantRefreshEndpoint(context) && !IsRefreshTokenForTenant(context, tenantId)) { context.Response.StatusCode = StatusCodes.Status401Unauthorized; return; } if (!tenant.IsSetupComplete && !IsTenantSetupEndpoint(context) && !IsTenantLoginEndpoint(context)) { await RejectOrRedirectAsync(context, $"/{tenantId}/setup", StatusCodes.Status409Conflict); return; } await next(context); return; } - if (context.User.Identity?.IsAuthenticated != true) { context.Response.StatusCode = StatusCodes.Status401Unauthorized; return; } if (!context.User.IsInRole(TenantRoles.SysAdmin)) { var assignedTenant = context.User.FindFirst(TenantClaimTypes.TenantId)?.Value; if (!string.Equals(assignedTenant, tenantId, StringComparison.OrdinalIgnoreCase)) { await RejectOrRedirectAsync(context, $"/{assignedTenant ?? tenantId}", StatusCodes.Status403Forbidden); return; } } - if (!tenant.IsSetupComplete && !IsTenantSetupEndpoint(context)) { await RejectOrRedirectAsync(context, $"/{tenantId}/setup", StatusCodes.Status409Conflict); return; } await next(context); } - private bool IsRefreshTokenForTenant(HttpContext context, string tenantId) - { - var token = context.Request.Headers.Authorization.ToString().Replace("Bearer ", string.Empty, StringComparison.OrdinalIgnoreCase); - if (string.IsNullOrWhiteSpace(token)) - { - var body = context.Request.Form; - token = body["refreshToken"].ToString(); - } - var principal = tokenService.ValidateToken(token); - if (principal is null || !string.Equals(principal.FindFirst("token_type")?.Value, JwtTokenTypes.Refresh, StringComparison.Ordinal)) return false; - if (principal.IsInRole(TenantRoles.SysAdmin)) return true; - return string.Equals(principal.FindFirst(TenantClaimTypes.TenantId)?.Value, tenantId, StringComparison.OrdinalIgnoreCase); - } - + private static bool IsInfrastructurePath(PathString path) => path.StartsWithSegments("/_blazor") || path.StartsWithSegments("/_framework") || path.StartsWithSegments("/_content") || path.StartsWithSegments("/favicon") || path.StartsWithSegments("/css") || path.StartsWithSegments("/lib"); private static bool IsSystemSetupEndpoint(HttpContext context) => context.Request.Path.StartsWithSegments("/api/setup") || string.Equals(context.Request.Path.Value, "/setup", StringComparison.OrdinalIgnoreCase); private static bool IsTenantLoginEndpoint(HttpContext context) => string.Equals(context.Request.Path.Value, $"/api/v1/{context.Request.RouteValues["tenantId"]}/login", StringComparison.OrdinalIgnoreCase); - private static bool IsTenantRefreshEndpoint(HttpContext context) => string.Equals(context.Request.Path.Value, $"/api/v1/{context.Request.RouteValues["tenantId"]}/refresh", StringComparison.OrdinalIgnoreCase); - private static bool IsTenantSetupEndpoint(HttpContext context) { var tenantId = context.Request.RouteValues.TryGetValue("tenantId", out var value) ? value?.ToString() : null; if (string.IsNullOrWhiteSpace(tenantId)) return false; var path = context.Request.Path.Value; - return string.Equals(path, $"/{tenantId}/setup", StringComparison.OrdinalIgnoreCase) - || string.Equals(path, $"/api/v1/{tenantId}/setup", StringComparison.OrdinalIgnoreCase) - || string.Equals(path, $"/api/v1/{tenantId}/setup/complete", StringComparison.OrdinalIgnoreCase); + return string.Equals(path, $"/{tenantId}/setup", StringComparison.OrdinalIgnoreCase) || string.Equals(path, $"/api/v1/{tenantId}/setup", StringComparison.OrdinalIgnoreCase) || string.Equals(path, $"/api/v1/{tenantId}/setup/complete", StringComparison.OrdinalIgnoreCase); } - private static async Task RejectOrRedirectAsync(HttpContext context, string location, int statusCode) { if (HttpMethods.IsGet(context.Request.Method) && context.Request.Headers.Accept.Any(x => x.Contains("text/html", StringComparison.OrdinalIgnoreCase))) { context.Response.Redirect(location); return; } From 29d2adc0a4500c7226238557187b4e3da94ab6b1 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:23:33 -0300 Subject: [PATCH 045/112] feat: persist system setup state --- .../Setup/SystemSetupState.cs | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 src/server/RemoteTickets.Infrastructure/Setup/SystemSetupState.cs diff --git a/src/server/RemoteTickets.Infrastructure/Setup/SystemSetupState.cs b/src/server/RemoteTickets.Infrastructure/Setup/SystemSetupState.cs new file mode 100644 index 0000000..347fa2e --- /dev/null +++ b/src/server/RemoteTickets.Infrastructure/Setup/SystemSetupState.cs @@ -0,0 +1,12 @@ +namespace RemoteTickets.Infrastructure.Setup; + +/// Stores the singleton installation setup state in the master database. +public sealed class SystemSetupState +{ + /// Gets or sets the singleton setup-state identifier. + public int Id { get; set; } = 1; + /// Gets or sets whether the installation is ready for normal use. + public bool IsComplete { get; set; } + /// Gets or sets the completion timestamp. + public DateTimeOffset? CompletedAt { get; set; } +} From fa432eb5a31e2aa712b45ca55a61652b1bec2971 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:23:42 -0300 Subject: [PATCH 046/112] feat: persist installation setup state in master database --- .../Persistence/InvisibleSPDbContext.cs | 52 ++++++------------- 1 file changed, 15 insertions(+), 37 deletions(-) diff --git a/src/server/RemoteTickets.Infrastructure/Persistence/InvisibleSPDbContext.cs b/src/server/RemoteTickets.Infrastructure/Persistence/InvisibleSPDbContext.cs index a2345ae..434253c 100644 --- a/src/server/RemoteTickets.Infrastructure/Persistence/InvisibleSPDbContext.cs +++ b/src/server/RemoteTickets.Infrastructure/Persistence/InvisibleSPDbContext.cs @@ -1,19 +1,21 @@ using Microsoft.EntityFrameworkCore.ChangeTracking; +using RemoteTickets.Infrastructure.Setup; using RemoteTickets.Infrastructure.Tenancy.Models; namespace RemoteTickets.Infrastructure.Persistence; -/// Represents the central database context for RemoteTickets identity and tenant catalog data. +/// Represents the central database context for RemoteTickets identity, setup, and tenant catalog data. public sealed class RemoteTicketsDbContext(DbContextOptions options) : IdentityDbContext(options) { /// Gets the registered tenants. public DbSet Tenants => Set(); + /// Gets the singleton system setup state. + public DbSet SystemSetup => Set(); /// protected override void OnModelCreating(ModelBuilder builder) { base.OnModelCreating(builder); - builder.Entity(entity => { entity.ToTable("Tenants"); @@ -24,60 +26,36 @@ protected override void OnModelCreating(ModelBuilder builder) entity.Property(x => x.ConnectionString).IsRequired(); entity.HasIndex(x => x.DatabaseName).IsUnique(); }); - + builder.Entity(entity => + { + entity.ToTable("SystemSetupState"); + entity.HasKey(x => x.Id); + }); foreach (var entityType in builder.Model.GetEntityTypes()) { - if (!typeof(ISoftDeletable).IsAssignableFrom(entityType.ClrType)) - { - continue; - } - + if (!typeof(ISoftDeletable).IsAssignableFrom(entityType.ClrType)) continue; var parameter = Expression.Parameter(entityType.ClrType, "entity"); var property = Expression.Property(parameter, nameof(ISoftDeletable.IsDeleted)); var filter = Expression.Lambda(Expression.Not(property), parameter); builder.Entity(entityType.ClrType).HasQueryFilter(filter); } - builder.ApplyConfigurationsFromAssembly(typeof(RemoteTicketsDbContext).Assembly); } /// - public override int SaveChanges(bool acceptAllChangesOnSuccess) - { - ApplySoftDelete(); - return base.SaveChanges(acceptAllChangesOnSuccess); - } - + public override int SaveChanges(bool acceptAllChangesOnSuccess) { ApplySoftDelete(); return base.SaveChanges(acceptAllChangesOnSuccess); } /// - public override int SaveChanges() - { - ApplySoftDelete(); - return base.SaveChanges(); - } - + public override int SaveChanges() { ApplySoftDelete(); return base.SaveChanges(); } /// - public override Task SaveChangesAsync(bool acceptAllChangesOnSuccess, CancellationToken cancellationToken = default) - { - ApplySoftDelete(); - return base.SaveChangesAsync(acceptAllChangesOnSuccess, cancellationToken); - } - + public override Task SaveChangesAsync(bool acceptAllChangesOnSuccess, CancellationToken cancellationToken = default) { ApplySoftDelete(); return base.SaveChangesAsync(acceptAllChangesOnSuccess, cancellationToken); } /// - public override Task SaveChangesAsync(CancellationToken cancellationToken = default) - { - ApplySoftDelete(); - return base.SaveChangesAsync(cancellationToken); - } + public override Task SaveChangesAsync(CancellationToken cancellationToken = default) { ApplySoftDelete(); return base.SaveChangesAsync(cancellationToken); } private void ApplySoftDelete() { foreach (EntityEntry entry in ChangeTracker.Entries()) { - if (entry.State != EntityState.Deleted) - { - continue; - } - + if (entry.State != EntityState.Deleted) continue; entry.State = EntityState.Modified; entry.Entity.IsDeleted = true; entry.Entity.DeletedAt = DateTimeOffset.UtcNow; From 11c894cb2fda2822b1049a419de8b191c7e5b415 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:23:51 -0300 Subject: [PATCH 047/112] fix: gate requests on persisted system setup state --- .../Tenancy/TenantAccessMiddleware.cs | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs b/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs index f1fa438..f2c055a 100644 --- a/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs +++ b/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs @@ -5,7 +5,7 @@ namespace RemoteTickets.Infrastructure.Tenancy; /// Enforces tenant route isolation and mandatory setup state for HTTP requests. -public sealed class TenantAccessMiddleware(RequestDelegate next, ITenantManagementService tenants, IIdentityService identityService) +public sealed class TenantAccessMiddleware(RequestDelegate next, ITenantManagementService tenants, IIdentityService identityService, RemoteTicketsDbContext masterDb) { /// Processes the current request and enforces tenant isolation when a tenant route is present. /// The current HTTP context. @@ -15,8 +15,9 @@ public async Task InvokeAsync(HttpContext context) if (IsInfrastructurePath(context.Request.Path)) { await next(context); return; } var endpoint = context.GetEndpoint(); var anonymous = endpoint?.Metadata.GetMetadata() is not null; - var systemStatus = await identityService.GetSetupStatusAsync(context.RequestAborted); - if (systemStatus.IsSetupRequired) + var setupState = await masterDb.SystemSetup.AsNoTracking().SingleOrDefaultAsync(x => x.Id == 1, context.RequestAborted); + var systemSetupRequired = setupState is null || !setupState.IsComplete; + if (systemSetupRequired) { if (IsSystemSetupEndpoint(context)) { await next(context); return; } await RejectOrRedirectAsync(context, "/setup", StatusCodes.Status503ServiceUnavailable); From decb8d2779f2d372e753281f55687804b02279eb Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:23:57 -0300 Subject: [PATCH 048/112] refactor: remove unused identity dependency from tenant gate --- .../Tenancy/TenantAccessMiddleware.cs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs b/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs index f2c055a..10ddf33 100644 --- a/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs +++ b/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs @@ -5,7 +5,7 @@ namespace RemoteTickets.Infrastructure.Tenancy; /// Enforces tenant route isolation and mandatory setup state for HTTP requests. -public sealed class TenantAccessMiddleware(RequestDelegate next, ITenantManagementService tenants, IIdentityService identityService, RemoteTicketsDbContext masterDb) +public sealed class TenantAccessMiddleware(RequestDelegate next, ITenantManagementService tenants, RemoteTicketsDbContext masterDb) { /// Processes the current request and enforces tenant isolation when a tenant route is present. /// The current HTTP context. @@ -16,8 +16,7 @@ public async Task InvokeAsync(HttpContext context) var endpoint = context.GetEndpoint(); var anonymous = endpoint?.Metadata.GetMetadata() is not null; var setupState = await masterDb.SystemSetup.AsNoTracking().SingleOrDefaultAsync(x => x.Id == 1, context.RequestAborted); - var systemSetupRequired = setupState is null || !setupState.IsComplete; - if (systemSetupRequired) + if (setupState is null || !setupState.IsComplete) { if (IsSystemSetupEndpoint(context)) { await next(context); return; } await RejectOrRedirectAsync(context, "/setup", StatusCodes.Status503ServiceUnavailable); From 771f2caa36b6ca30c09c0128f5a4f61ddb41549e Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:24:04 -0300 Subject: [PATCH 049/112] feat: mark persisted system setup complete after initialization --- .../Controllers/SetupController.cs | 20 +++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/src/server/RemoteTickets/Controllers/SetupController.cs b/src/server/RemoteTickets/Controllers/SetupController.cs index 18aaeab..c31c464 100644 --- a/src/server/RemoteTickets/Controllers/SetupController.cs +++ b/src/server/RemoteTickets/Controllers/SetupController.cs @@ -31,14 +31,30 @@ public async Task ConfigureMasterDatabase(MasterDatabaseSetupRequ public async Task Initialize(InitializeSetupRequest request, CancellationToken cancellationToken) { var result = await mediator.RequestAsync(new InitializeSetupCommand(request.Email, request.Password), cancellationToken); - return result.Succeeded ? Ok(result) : Conflict(result); + if (!result.Succeeded) return Conflict(result); + + var connectionString = configurationStore.GetMasterConnectionString(); + if (!string.IsNullOrWhiteSpace(connectionString)) + { + var options = new DbContextOptionsBuilder().UseSqlServer(connectionString).Options; + await using var dbContext = new RemoteTicketsDbContext(options); + var state = await dbContext.SystemSetup.SingleOrDefaultAsync(x => x.Id == 1, cancellationToken); + if (state is null) + { + state = new SystemSetupState { Id = 1 }; + dbContext.SystemSetup.Add(state); + } + state.IsComplete = true; + state.CompletedAt = DateTimeOffset.UtcNow; + await dbContext.SaveChangesAsync(cancellationToken); + } + return Ok(result); } } /// Represents the master database setup payload. /// The SQL Server connection string used by the tenant catalog. public sealed record MasterDatabaseSetupRequest(string ConnectionString); - /// Represents the first-time setup administrator credentials. /// The administrator email address. /// The administrator password. From 2461b6522ca1e9f5a88a15ca35e39d7f82e8490f Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:24:43 -0300 Subject: [PATCH 050/112] fix: import tenant contracts into identity tests --- tests/server/RemoteTickets.UnitTests/GlobalUsings.cs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/server/RemoteTickets.UnitTests/GlobalUsings.cs b/tests/server/RemoteTickets.UnitTests/GlobalUsings.cs index e35a1b2..aa8fefd 100644 --- a/tests/server/RemoteTickets.UnitTests/GlobalUsings.cs +++ b/tests/server/RemoteTickets.UnitTests/GlobalUsings.cs @@ -9,7 +9,8 @@ global using FluentAssertions; global using FluentValidation; global using RemoteTickets.Application.Common.Identity; -global using RemoteTickets.Application.Identity; +global using RemoteTickets.Application.Common.Tenancy; +global using RemoteTickets.Application.Identity; global using RemoteTickets.Application.Identity.Handlers; global using RemoteTickets.Application.Identity.Requests; global using RemoteTickets.Application.Identity.Validators; @@ -23,4 +24,4 @@ global using Microsoft.Extensions.DependencyInjection; global using Microsoft.Extensions.Logging; global using Microsoft.Extensions.Options; -global using Xunit; \ No newline at end of file +global using Xunit; From 7eaffbf553446157d3251988bed982ab0f390b69 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Sun, 16 Aug 2026 21:25:28 -0300 Subject: [PATCH 051/112] fix: lock system setup mutations after initialization --- .../Tenancy/TenantAccessMiddleware.cs | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs b/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs index 10ddf33..91bd336 100644 --- a/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs +++ b/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs @@ -16,12 +16,19 @@ public async Task InvokeAsync(HttpContext context) var endpoint = context.GetEndpoint(); var anonymous = endpoint?.Metadata.GetMetadata() is not null; var setupState = await masterDb.SystemSetup.AsNoTracking().SingleOrDefaultAsync(x => x.Id == 1, context.RequestAborted); - if (setupState is null || !setupState.IsComplete) + var systemSetupRequired = setupState is null || !setupState.IsComplete; + if (systemSetupRequired) { if (IsSystemSetupEndpoint(context)) { await next(context); return; } await RejectOrRedirectAsync(context, "/setup", StatusCodes.Status503ServiceUnavailable); return; } + if (IsSystemSetupEndpoint(context) && HttpMethods.IsPost(context.Request.Method)) + { + context.Response.StatusCode = StatusCodes.Status409Conflict; + await context.Response.WriteAsJsonAsync(new { error = "System setup is already complete." }, context.RequestAborted); + return; + } if (!context.Request.RouteValues.TryGetValue("tenantId", out var value) || string.IsNullOrWhiteSpace(value?.ToString())) { if (anonymous) await next(context); else await RejectOrRedirectAsync(context, "/setup", StatusCodes.Status503ServiceUnavailable); From ee787e723656dbf1bead45e5f81ddb98c8cb4310 Mon Sep 17 00:00:00 2001 From: Weslley Murdock Date: Sun, 16 Aug 2026 22:17:25 -0300 Subject: [PATCH 052/112] fix: build and tests compile and pass --- .../RemoteTickets.Composition/GlobalUsings.cs | 2 + .../RemoteTickets.Composition.csproj | 3 ++ ....cs => WebApplicationBuilderExtensions.cs} | 40 ++++--------------- .../WebApplicationExtensions.cs | 37 +++++++++++++++++ .../GlobalUsings.cs | 6 ++- .../Identity/IdentityrConfigurations.cs | 2 - .../Persistence/InvisibleSPDbContext.cs | 4 -- .../Configurations/TenancyConfigurations.cs | 12 ++++++ .../Tenancy/TenantManagementService.cs | 4 -- .../Tenancy/TenantSetupDbContext.cs | 9 +---- src/server/RemoteTickets/Components/App.razor | 8 +++- .../RemoteTickets/Components/Pages/Home.razor | 7 +++- .../RemoteTickets/Components/_Imports.razor | 1 + src/server/RemoteTickets/Program.cs | 4 +- src/server/RemoteTickets/RemoteTickets.csproj | 5 +++ .../IdentityHandlerTests.cs | 3 ++ 16 files changed, 88 insertions(+), 59 deletions(-) rename src/server/RemoteTickets.Composition/{InvisibleSPCompositionExtensions.cs => WebApplicationBuilderExtensions.cs} (80%) create mode 100644 src/server/RemoteTickets.Composition/WebApplicationExtensions.cs create mode 100644 src/server/RemoteTickets.Infrastructure/Tenancy/Configurations/TenancyConfigurations.cs diff --git a/src/server/RemoteTickets.Composition/GlobalUsings.cs b/src/server/RemoteTickets.Composition/GlobalUsings.cs index 2baca0e..898b1e1 100644 --- a/src/server/RemoteTickets.Composition/GlobalUsings.cs +++ b/src/server/RemoteTickets.Composition/GlobalUsings.cs @@ -11,6 +11,7 @@ global using RemoteTickets.Application.Identity.Validators; global using RemoteTickets.Application.Pipeline.Validation; global using RemoteTickets.Infrastructure.Persistence; +global using RemoteTickets.Infrastructure.Identity.Models; global using RemoteTickets.Infrastructure.Identity.Services; global using RemoteTickets.Infrastructure.Setup; global using RemoteTickets.Infrastructure.Tenancy; @@ -24,3 +25,4 @@ global using Microsoft.Extensions.DependencyInjection; global using Microsoft.Extensions.Hosting; global using Microsoft.IdentityModel.Tokens; +global using MudBlazor.Services; \ No newline at end of file diff --git a/src/server/RemoteTickets.Composition/RemoteTickets.Composition.csproj b/src/server/RemoteTickets.Composition/RemoteTickets.Composition.csproj index 7cc596d..c26ee4a 100644 --- a/src/server/RemoteTickets.Composition/RemoteTickets.Composition.csproj +++ b/src/server/RemoteTickets.Composition/RemoteTickets.Composition.csproj @@ -1,5 +1,8 @@ + + + diff --git a/src/server/RemoteTickets.Composition/InvisibleSPCompositionExtensions.cs b/src/server/RemoteTickets.Composition/WebApplicationBuilderExtensions.cs similarity index 80% rename from src/server/RemoteTickets.Composition/InvisibleSPCompositionExtensions.cs rename to src/server/RemoteTickets.Composition/WebApplicationBuilderExtensions.cs index 91b9aa9..55633d5 100644 --- a/src/server/RemoteTickets.Composition/InvisibleSPCompositionExtensions.cs +++ b/src/server/RemoteTickets.Composition/WebApplicationBuilderExtensions.cs @@ -1,23 +1,25 @@ namespace RemoteTickets.Composition; /// Provides extension methods that compose RemoteTickets application services and HTTP middleware. -public static class RemoteTicketsCompositionExtensions +public static class WebApplicationBuilderExtensions { extension (WebApplicationBuilder builder) { /// Registers all application, persistence, identity, validation, authentication, authorization, and tenant services. /// The same application builder for fluent composition. /// Thrown when required JWT configuration is missing or its secret key is too short. - public WebApplicationBuilder AddRemoteTickets() + public WebApplication BuildRemoteTickets() { var services = builder.Services; var configuration = builder.Configuration; - services.AddRazorComponents().AddInteractiveServerComponents(); + + services.AddRazorComponents() + .AddInteractiveServerComponents(); + services.AddMudServices(); services.AddControllers(); services.AddHttpClient(); services.Configure(configuration.GetSection(JwtOptions.SectionName)); services.AddSingleton(); - services.AddDbContext((sp, options) => { var setup = sp.GetRequiredService(); @@ -96,35 +98,7 @@ public WebApplicationBuilder AddRemoteTickets() .ConfigureCommandReceivePipe(pipe => pipe.UseValidation()) .ConfigureRequestPipe(pipe => pipe.UseValidation()); services.RegisterMediator(mb); - return builder; - } - } - - extension (WebApplication app) - { - /// Configures middleware, authentication, tenant isolation, authorization, controllers, static assets, and Blazor endpoints. - /// The Blazor root component used by the application. - /// The same web application for fluent startup composition. - public WebApplication UseRemoteTickets() where TApp : IComponent - { - if (!app.Environment.IsDevelopment()) - { - app.UseExceptionHandler("/Error", createScopeForErrors: true); - app.UseHsts(); - } - else app.UseDeveloperExceptionPage(); - - app.UseStatusCodePagesWithReExecute("/not-found", createScopeForStatusCodePages: true); - app.UseHttpsRedirection(); - app.UseRouting(); - app.UseAuthentication(); - app.UseMiddleware(); - app.UseAuthorization(); - app.UseAntiforgery(); - app.MapControllers(); - app.MapStaticAssets(); - app.MapRazorComponents().AddInteractiveServerRenderMode(); - return app; + return builder.Build(); } } } diff --git a/src/server/RemoteTickets.Composition/WebApplicationExtensions.cs b/src/server/RemoteTickets.Composition/WebApplicationExtensions.cs new file mode 100644 index 0000000..0ab8e93 --- /dev/null +++ b/src/server/RemoteTickets.Composition/WebApplicationExtensions.cs @@ -0,0 +1,37 @@ +namespace RemoteTickets.Composition; + +/// Provides extension methods that compose RemoteTickets application services and HTTP middleware. +public static class WebApplicationExtensions +{ + extension (WebApplication app) + { + /// Configures middleware, authentication, tenant isolation, authorization, controllers, static assets, and Blazor endpoints. + /// The Blazor root component used by the application. + /// The same web application for fluent startup composition. + public async Task RunRemoteTickets() where TApp : IComponent + { + if (!app.Environment.IsDevelopment()) + { + app.UseExceptionHandler("/Error", createScopeForErrors: true); + app.UseHsts(); + } + else + { + app.UseDeveloperExceptionPage(); + } + + app.UseStatusCodePagesWithReExecute("/not-found", createScopeForStatusCodePages: true); + app.UseHttpsRedirection(); + app.UseRouting(); + app.UseAuthentication(); + app.UseMiddleware(); + app.UseAuthorization(); + app.UseAntiforgery(); + app.MapControllers(); + app.MapStaticAssets(); + app.MapRazorComponents() + .AddInteractiveServerRenderMode(); + await app.RunAsync(); + } + } +} diff --git a/src/server/RemoteTickets.Infrastructure/GlobalUsings.cs b/src/server/RemoteTickets.Infrastructure/GlobalUsings.cs index 387160e..519a76c 100644 --- a/src/server/RemoteTickets.Infrastructure/GlobalUsings.cs +++ b/src/server/RemoteTickets.Infrastructure/GlobalUsings.cs @@ -16,10 +16,14 @@ global using RemoteTickets.Infrastructure.Identity.Models; global using RemoteTickets.Infrastructure.Persistence; global using RemoteTickets.Infrastructure.Setup; -global using RemoteTickets.Infrastructure.Identity.Services; +global using RemoteTickets.Infrastructure.Tenancy.Configurations; +global using RemoteTickets.Infrastructure.Tenancy.Models; global using Microsoft.AspNetCore.Identity; global using Microsoft.AspNetCore.Identity.EntityFrameworkCore; +global using Microsoft.Data.SqlClient; global using Microsoft.EntityFrameworkCore; +global using Microsoft.EntityFrameworkCore.ChangeTracking; +global using Microsoft.EntityFrameworkCore.Metadata.Builders; global using Microsoft.Extensions.Logging; global using Microsoft.Extensions.Options; global using Microsoft.IdentityModel.Tokens; diff --git a/src/server/RemoteTickets.Infrastructure/Persistence/Configurations/Identity/IdentityrConfigurations.cs b/src/server/RemoteTickets.Infrastructure/Persistence/Configurations/Identity/IdentityrConfigurations.cs index a478ef1..c8784e9 100644 --- a/src/server/RemoteTickets.Infrastructure/Persistence/Configurations/Identity/IdentityrConfigurations.cs +++ b/src/server/RemoteTickets.Infrastructure/Persistence/Configurations/Identity/IdentityrConfigurations.cs @@ -1,5 +1,3 @@ -using Microsoft.EntityFrameworkCore.Metadata.Builders; - namespace RemoteTickets.Infrastructure.Persistence.Configurations.Identity; internal sealed class IdentityrConfigurations : IEntityTypeConfiguration, IEntityTypeConfiguration diff --git a/src/server/RemoteTickets.Infrastructure/Persistence/InvisibleSPDbContext.cs b/src/server/RemoteTickets.Infrastructure/Persistence/InvisibleSPDbContext.cs index 434253c..b439f37 100644 --- a/src/server/RemoteTickets.Infrastructure/Persistence/InvisibleSPDbContext.cs +++ b/src/server/RemoteTickets.Infrastructure/Persistence/InvisibleSPDbContext.cs @@ -1,7 +1,3 @@ -using Microsoft.EntityFrameworkCore.ChangeTracking; -using RemoteTickets.Infrastructure.Setup; -using RemoteTickets.Infrastructure.Tenancy.Models; - namespace RemoteTickets.Infrastructure.Persistence; /// Represents the central database context for RemoteTickets identity, setup, and tenant catalog data. diff --git a/src/server/RemoteTickets.Infrastructure/Tenancy/Configurations/TenancyConfigurations.cs b/src/server/RemoteTickets.Infrastructure/Tenancy/Configurations/TenancyConfigurations.cs new file mode 100644 index 0000000..562fea2 --- /dev/null +++ b/src/server/RemoteTickets.Infrastructure/Tenancy/Configurations/TenancyConfigurations.cs @@ -0,0 +1,12 @@ +namespace RemoteTickets.Infrastructure.Tenancy.Configurations; + +internal sealed class TenancyConfigurations : IEntityTypeConfiguration +{ + public void Configure(EntityTypeBuilder builder) + { + builder.ToTable("TenantSetupState"); + builder.HasKey(x => x.Id); + builder.Property(x => x.IsComplete).IsRequired(); + } + +} diff --git a/src/server/RemoteTickets.Infrastructure/Tenancy/TenantManagementService.cs b/src/server/RemoteTickets.Infrastructure/Tenancy/TenantManagementService.cs index 4134bf4..5ac8912 100644 --- a/src/server/RemoteTickets.Infrastructure/Tenancy/TenantManagementService.cs +++ b/src/server/RemoteTickets.Infrastructure/Tenancy/TenantManagementService.cs @@ -1,7 +1,3 @@ -using Microsoft.Data.SqlClient; -using RemoteTickets.Application.Common.Tenancy; -using RemoteTickets.Infrastructure.Tenancy.Models; - namespace RemoteTickets.Infrastructure.Tenancy; /// Implements tenant catalog, database provisioning, and tenant setup operations. diff --git a/src/server/RemoteTickets.Infrastructure/Tenancy/TenantSetupDbContext.cs b/src/server/RemoteTickets.Infrastructure/Tenancy/TenantSetupDbContext.cs index 205dcb3..2487574 100644 --- a/src/server/RemoteTickets.Infrastructure/Tenancy/TenantSetupDbContext.cs +++ b/src/server/RemoteTickets.Infrastructure/Tenancy/TenantSetupDbContext.cs @@ -1,5 +1,3 @@ -using RemoteTickets.Infrastructure.Tenancy.Models; - namespace RemoteTickets.Infrastructure.Tenancy; /// Provides persistence for tenant-database initialization state. @@ -11,11 +9,6 @@ public sealed class TenantSetupDbContext(DbContextOptions /// protected override void OnModelCreating(ModelBuilder modelBuilder) { - modelBuilder.Entity(entity => - { - entity.ToTable("TenantSetupState"); - entity.HasKey(x => x.Id); - entity.Property(x => x.IsComplete).IsRequired(); - }); + modelBuilder.ApplyConfigurationsFromAssembly(typeof(TenancyConfigurations).Assembly); } } diff --git a/src/server/RemoteTickets/Components/App.razor b/src/server/RemoteTickets/Components/App.razor index 7b5551b..da3cde8 100644 --- a/src/server/RemoteTickets/Components/App.razor +++ b/src/server/RemoteTickets/Components/App.razor @@ -11,13 +11,17 @@ - + + + - + + + diff --git a/src/server/RemoteTickets/Components/Pages/Home.razor b/src/server/RemoteTickets/Components/Pages/Home.razor index e2dda88..16f5960 100644 --- a/src/server/RemoteTickets/Components/Pages/Home.razor +++ b/src/server/RemoteTickets/Components/Pages/Home.razor @@ -1,6 +1,9 @@ -@page "/{tenantId}" +@page "/{TenantId}" Home

RemoteTickets

-

Tenant: @tenantId

+

Tenant: @TenantId

+@code{ + [Parameter] public string TenantId { get; set; } = string.Empty; +} \ No newline at end of file diff --git a/src/server/RemoteTickets/Components/_Imports.razor b/src/server/RemoteTickets/Components/_Imports.razor index 7a23693..91a45d2 100644 --- a/src/server/RemoteTickets/Components/_Imports.razor +++ b/src/server/RemoteTickets/Components/_Imports.razor @@ -11,3 +11,4 @@ @using RemoteTickets.Components @using RemoteTickets.Components.Layout @using System.Diagnostics +@using MudBlazor \ No newline at end of file diff --git a/src/server/RemoteTickets/Program.cs b/src/server/RemoteTickets/Program.cs index 1b52a10..6200486 100644 --- a/src/server/RemoteTickets/Program.cs +++ b/src/server/RemoteTickets/Program.cs @@ -1,6 +1,4 @@ await WebApplication .CreateBuilder(args) - .AddRemoteTickets() - .Build() - .UseRemoteTickets() + .BuildRemoteTickets() .RunAsync(); diff --git a/src/server/RemoteTickets/RemoteTickets.csproj b/src/server/RemoteTickets/RemoteTickets.csproj index 968a0f4..696f3c5 100644 --- a/src/server/RemoteTickets/RemoteTickets.csproj +++ b/src/server/RemoteTickets/RemoteTickets.csproj @@ -3,6 +3,11 @@ + + + + + net10.0 enable diff --git a/tests/server/RemoteTickets.UnitTests/IdentityHandlerTests.cs b/tests/server/RemoteTickets.UnitTests/IdentityHandlerTests.cs index 05fe20f..5fc9656 100644 --- a/tests/server/RemoteTickets.UnitTests/IdentityHandlerTests.cs +++ b/tests/server/RemoteTickets.UnitTests/IdentityHandlerTests.cs @@ -40,5 +40,8 @@ private sealed class FakeIdentityService : IIdentityService public Task ConfigureTwoFactorAsync(string userId, bool? enable, string? twoFactorCode, bool resetRecoveryCodes, bool resetSharedKey, bool forgetMachine, CancellationToken cancellationToken) => Task.FromResult(new(null, 0, null, false, false)); public Task GetSetupStatusAsync(CancellationToken cancellationToken) => Task.FromResult(new SetupStatusResponse(false, true)); public Task InitializeSetupAsync(string email, string password, CancellationToken cancellationToken) => Task.FromResult(IdentityResultResponse.Success()); + public Task LoginAsync(string tenantId, string email, string password, string? twoFactorCode, string? twoFactorRecoveryCode, CancellationToken cancellationToken) => Task.FromResult(new("Bearer", "access", 900, "refresh")); + public Task CreateTenantAdminAsync(string tenantId, string email, string password, CancellationToken cancellationToken) => Task.FromResult(IdentityResultResponse.Success()); + public Task RefreshAsync(string tenantId, string refreshToken, CancellationToken cancellationToken) => Task.FromResult(new("Bearer", "access", 900, "refresh")); } } From e927bcc8ef92e56c43a5b53e2bdacf56b25aaf0c Mon Sep 17 00:00:00 2001 From: Weslley Murdock Date: Sun, 16 Aug 2026 22:28:03 -0300 Subject: [PATCH 053/112] feat: improve program.cs and DI composition extensions --- .../WebApplicationBuilderExtensions.cs | 14 +++++++++----- src/server/RemoteTickets/Program.cs | 3 +-- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/src/server/RemoteTickets.Composition/WebApplicationBuilderExtensions.cs b/src/server/RemoteTickets.Composition/WebApplicationBuilderExtensions.cs index 55633d5..e9a5731 100644 --- a/src/server/RemoteTickets.Composition/WebApplicationBuilderExtensions.cs +++ b/src/server/RemoteTickets.Composition/WebApplicationBuilderExtensions.cs @@ -8,7 +8,7 @@ public static class WebApplicationBuilderExtensions /// Registers all application, persistence, identity, validation, authentication, authorization, and tenant services. /// The same application builder for fluent composition. /// Thrown when required JWT configuration is missing or its secret key is too short. - public WebApplication BuildRemoteTickets() + public async Task RunRemoteTicketsAsync() where T : IComponent { var services = builder.Services; var configuration = builder.Configuration; @@ -22,9 +22,13 @@ public WebApplication BuildRemoteTickets() services.AddSingleton(); services.AddDbContext((sp, options) => { - var setup = sp.GetRequiredService(); - var connectionString = setup.GetMasterConnectionString() ?? configuration.GetConnectionString("Identity") ?? configuration.GetConnectionString("Master"); - if (string.IsNullOrWhiteSpace(connectionString)) throw new InvalidOperationException("A master database connection string is required."); + ISetupConfigurationStore setup = sp.GetRequiredService(); + string connectionString = setup.GetMasterConnectionString() ?? configuration.GetConnectionString("Identity") ?? configuration.GetConnectionString("Master") ?? ""; + if (string.IsNullOrWhiteSpace(connectionString)) + { + throw new InvalidOperationException("A master database connection string is required."); + } + options.UseSqlServer(connectionString); }); @@ -98,7 +102,7 @@ public WebApplication BuildRemoteTickets() .ConfigureCommandReceivePipe(pipe => pipe.UseValidation()) .ConfigureRequestPipe(pipe => pipe.UseValidation()); services.RegisterMediator(mb); - return builder.Build(); + await builder.Build().RunRemoteTickets(); } } } diff --git a/src/server/RemoteTickets/Program.cs b/src/server/RemoteTickets/Program.cs index 6200486..d206b18 100644 --- a/src/server/RemoteTickets/Program.cs +++ b/src/server/RemoteTickets/Program.cs @@ -1,4 +1,3 @@ await WebApplication .CreateBuilder(args) - .BuildRemoteTickets() - .RunAsync(); + .RunRemoteTicketsAsync(); \ No newline at end of file From f5f584043756ecc36c610db535929384294396cd Mon Sep 17 00:00:00 2001 From: Weslley Murdock Date: Sun, 16 Aug 2026 22:48:38 -0300 Subject: [PATCH 054/112] fix: tests --- .../WebApplicationBuilderExtensions.cs | 10 +++++-- .../Services/IdentityService.Refresh.cs | 8 +++--- .../Services/IdentityService.Tenancy.cs | 4 +-- .../Identity/Services/IdentityService.cs | 20 ++++++------- .../Identity/Services/JwtTokenService.cs | 2 +- .../Setup/SetupConfigurationStore.cs | 2 +- .../Tenancy/TenantAccessMiddleware.cs | 14 +++++----- .../Tenancy/TenantManagementService.cs | 2 +- .../Controllers/IdentityController.cs | 8 +++--- .../Controllers/SetupController.cs | 2 +- .../IdentityBranchTests.cs | 28 +++++++++---------- .../IdentityServiceTests.cs | 6 ++-- .../IdentityTwoFactorTests.cs | 28 +++++++++---------- .../JwtTokenServiceTests.cs | 2 +- 14 files changed, 70 insertions(+), 66 deletions(-) diff --git a/src/server/RemoteTickets.Composition/WebApplicationBuilderExtensions.cs b/src/server/RemoteTickets.Composition/WebApplicationBuilderExtensions.cs index e9a5731..120aff7 100644 --- a/src/server/RemoteTickets.Composition/WebApplicationBuilderExtensions.cs +++ b/src/server/RemoteTickets.Composition/WebApplicationBuilderExtensions.cs @@ -58,7 +58,7 @@ public async Task RunRemoteTicketsAsync() where T : IComponent services.AddScoped(); services.AddValidatorsFromAssemblyContaining(); - services.AddAuthentication(JwtBearerDefaults.AuthenticationScheme).AddJwtBearer(options => + _ = services.AddAuthentication(JwtBearerDefaults.AuthenticationScheme).AddJwtBearer(options => { var jwt = configuration.GetSection(JwtOptions.SectionName).Get() ?? throw new InvalidOperationException("JWT configuration is missing."); if (Encoding.UTF8.GetByteCount(jwt.SecretKey) < 32) throw new InvalidOperationException("Authentication:Jwt:SecretKey must contain at least 256 bits."); @@ -78,13 +78,17 @@ public async Task RunRemoteTicketsAsync() where T : IComponent OnTokenValidated = context => { var token = context.SecurityToken as JwtSecurityToken; - var tokenType = token?.Claims.FirstOrDefault(x => x.Type == JwtRegisteredClaimNames.Typ)?.Value; + string? tokenType = token?.Claims.FirstOrDefault(x => x.Type == JwtRegisteredClaimNames.Typ)?.Value; if (!string.Equals(tokenType, JwtTokenTypes.Access, StringComparison.Ordinal)) { context.Fail("The supplied token is not an access token."); return Task.CompletedTask; } - if (token is not null && context.HttpContext.RequestServices.GetRequiredService().IsRevoked(token.Id)) context.Fail("The supplied token has been revoked."); + if (token is not null && context.HttpContext.RequestServices.GetRequiredService().IsRevoked(token.Id)) + { + context.Fail("The supplied token has been revoked."); + } + return Task.CompletedTask; } }; diff --git a/src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.Refresh.cs b/src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.Refresh.cs index 5dad526..012c8d1 100644 --- a/src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.Refresh.cs +++ b/src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.Refresh.cs @@ -9,23 +9,23 @@ public sealed partial class IdentityService var principal = tokenService.ValidateToken(refreshToken); if (principal is null || !string.Equals(principal.FindFirstValue("token_type"), JwtTokenTypes.Refresh, StringComparison.Ordinal)) return null; - var roles = principal.FindAll(ClaimTypes.Role).Select(x => x.Value).ToArray(); + string[] roles = principal.FindAll(ClaimTypes.Role).Select(x => x.Value).ToArray(); if (!roles.Contains(TenantRoles.SysAdmin, StringComparer.OrdinalIgnoreCase) && !string.Equals(principal.FindFirst(TenantClaimTypes.TenantId)?.Value, tenantId, StringComparison.OrdinalIgnoreCase)) return null; - var userId = principal.FindFirstValue(JwtRegisteredClaimNames.Sub) ?? principal.FindFirstValue(ClaimTypes.NameIdentifier); + string? userId = principal.FindFirstValue(JwtRegisteredClaimNames.Sub) ?? principal.FindFirstValue(ClaimTypes.NameIdentifier); if (string.IsNullOrWhiteSpace(userId)) return null; var user = await userManager.FindByIdAsync(userId); if (user is null) return null; var claims = await userManager.GetClaimsAsync(user); - foreach (var roleName in roles) + foreach (string? roleName in roles) { var role = await roleManager.FindByNameAsync(roleName); if (role is not null) claims = claims.Concat(await roleManager.GetClaimsAsync(role)).ToList(); } if (user.TenantId is not null) claims = claims.Append(new Claim(TenantClaimTypes.TenantId, user.TenantId)).ToList(); - var tokenId = tokenService.GetTokenId(refreshToken); + string? tokenId = tokenService.GetTokenId(refreshToken); var expiration = tokenService.GetExpiration(refreshToken); var tokens = tokenService.CreateTokens(user.Id, user.Email ?? user.UserName ?? user.Id, roles, claims); if (!string.IsNullOrWhiteSpace(tokenId) && expiration.HasValue) revokedTokenStore.Revoke(tokenId, expiration.Value); diff --git a/src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.Tenancy.cs b/src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.Tenancy.cs index bbb52a3..d4c33bc 100644 --- a/src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.Tenancy.cs +++ b/src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.Tenancy.cs @@ -26,7 +26,7 @@ public sealed partial class IdentityService if (await userManager.GetTwoFactorEnabledAsync(user)) { - var valid = !string.IsNullOrWhiteSpace(twoFactorCode) + bool valid = !string.IsNullOrWhiteSpace(twoFactorCode) ? await userManager.VerifyTwoFactorTokenAsync(user, userManager.Options.Tokens.AuthenticatorTokenProvider, twoFactorCode) : !string.IsNullOrWhiteSpace(twoFactorRecoveryCode) && (await userManager.RedeemTwoFactorRecoveryCodeAsync(user, twoFactorRecoveryCode)).Succeeded; if (!valid) return null; @@ -34,7 +34,7 @@ public sealed partial class IdentityService var roles = await userManager.GetRolesAsync(user); var claims = await userManager.GetClaimsAsync(user); - foreach (var roleName in roles) + foreach (string roleName in roles) { var role = await roleManager.FindByNameAsync(roleName); if (role is not null) claims = claims.Concat(await roleManager.GetClaimsAsync(role)).ToList(); diff --git a/src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.cs b/src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.cs index 1bce21a..681c857 100644 --- a/src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.cs +++ b/src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.cs @@ -28,7 +28,7 @@ public async Task RegisterAsync(string email, string pas var user = new User(email) { Email = email, DisplayName = "", FirstName = "", SurName = "", EmailConfirmed = false }; var result = await userManager.CreateAsync(user, password); if (!result.Succeeded) return Failure(result); - var code = await userManager.GenerateEmailConfirmationTokenAsync(user); + string code = await userManager.GenerateEmailConfirmationTokenAsync(user); await emailSender.SendConfirmationAsync(email, $"/confirmEmail?userId={Uri.EscapeDataString(user.Id)}&code={Uri.EscapeDataString(code)}", cancellationToken); return IdentityResultResponse.Success(); } @@ -42,7 +42,7 @@ public async Task RegisterAsync(string email, string pas if (passwordResult.IsLockedOut || passwordResult.IsNotAllowed || !passwordResult.Succeeded) return null; if (await userManager.GetTwoFactorEnabledAsync(user)) { - var valid = !string.IsNullOrWhiteSpace(twoFactorCode) + bool valid = !string.IsNullOrWhiteSpace(twoFactorCode) ? await userManager.VerifyTwoFactorTokenAsync(user, userManager.Options.Tokens.AuthenticatorTokenProvider, twoFactorCode) : !string.IsNullOrWhiteSpace(twoFactorRecoveryCode) && (await userManager.RedeemTwoFactorRecoveryCodeAsync(user, twoFactorRecoveryCode)).Succeeded; if (!valid) return null; @@ -55,11 +55,11 @@ public async Task RegisterAsync(string email, string pas { var principal = tokenService.ValidateToken(refreshToken); if (principal is null || !string.Equals(principal.FindFirstValue("token_type"), JwtTokenTypes.Refresh, StringComparison.Ordinal)) return null; - var userId = principal.FindFirstValue(JwtRegisteredClaimNames.Sub) ?? principal.FindFirstValue(ClaimTypes.NameIdentifier); + string? userId = principal.FindFirstValue(JwtRegisteredClaimNames.Sub) ?? principal.FindFirstValue(ClaimTypes.NameIdentifier); if (string.IsNullOrWhiteSpace(userId)) return null; var user = await userManager.FindByIdAsync(userId); if (user is null) return null; - var tokenId = tokenService.GetTokenId(refreshToken); + string? tokenId = tokenService.GetTokenId(refreshToken); var expiration = tokenService.GetExpiration(refreshToken); var tokens = await CreateUserTokensAsync(user, cancellationToken); if (!string.IsNullOrWhiteSpace(tokenId) && expiration.HasValue) revokedTokenStore.Revoke(tokenId, expiration.Value); @@ -70,7 +70,7 @@ public async Task RegisterAsync(string email, string pas public Task RevokeAsync(string accessToken, CancellationToken cancellationToken) { var principal = tokenService.ValidateToken(accessToken); - var tokenId = tokenService.GetTokenId(accessToken); + string? tokenId = tokenService.GetTokenId(accessToken); var expiration = tokenService.GetExpiration(accessToken); if (principal is null || string.IsNullOrWhiteSpace(tokenId) || !expiration.HasValue) return Task.FromResult(false); revokedTokenStore.Revoke(tokenId, expiration.Value); @@ -91,7 +91,7 @@ public async Task ResendConfirmationEmailAsync(string em { var user = await userManager.FindByEmailAsync(email); if (user is null || await userManager.IsEmailConfirmedAsync(user)) return IdentityResultResponse.Success(); - var code = await userManager.GenerateEmailConfirmationTokenAsync(user); + string code = await userManager.GenerateEmailConfirmationTokenAsync(user); await emailSender.SendConfirmationAsync(email, $"/confirmEmail?userId={Uri.EscapeDataString(user.Id)}&code={Uri.EscapeDataString(code)}", cancellationToken); return IdentityResultResponse.Success(); } @@ -101,7 +101,7 @@ public async Task ForgotPasswordAsync(string email, Canc { var user = await userManager.FindByEmailAsync(email); if (user is null || !await userManager.HasPasswordAsync(user)) return IdentityResultResponse.Success(); - var code = await userManager.GeneratePasswordResetTokenAsync(user); + string code = await userManager.GeneratePasswordResetTokenAsync(user); await emailSender.SendPasswordResetAsync(email, $"/resetPassword?email={Uri.EscapeDataString(email)}&code={Uri.EscapeDataString(code)}", cancellationToken); return IdentityResultResponse.Success(); } @@ -154,7 +154,7 @@ public async Task UpdateInfoAsync(string userId, string? if (resetSharedKey) await userManager.ResetAuthenticatorKeyAsync(user); string[]? recoveryCodes = null; if (resetRecoveryCodes || (enable == true && await userManager.CountRecoveryCodesAsync(user) == 0)) recoveryCodes = (await userManager.GenerateNewTwoFactorRecoveryCodesAsync(user, 10))?.ToArray(); - var key = await userManager.GetAuthenticatorKeyAsync(user); + string? key = await userManager.GetAuthenticatorKeyAsync(user); if (string.IsNullOrWhiteSpace(key)) { await userManager.ResetAuthenticatorKeyAsync(user); key = await userManager.GetAuthenticatorKeyAsync(user); } return new TwoFactorResponse(key, await userManager.CountRecoveryCodesAsync(user), recoveryCodes, await userManager.GetTwoFactorEnabledAsync(user), false); } @@ -162,7 +162,7 @@ public async Task UpdateInfoAsync(string userId, string? /// Gets whether initial system setup is required or has already been completed. public async Task GetSetupStatusAsync(CancellationToken cancellationToken) { - var hasUsers = await userManager.Users.AsNoTracking().AnyAsync(cancellationToken); + bool hasUsers = await userManager.Users.AsNoTracking().AnyAsync(cancellationToken); return new SetupStatusResponse(!hasUsers, hasUsers); } @@ -198,7 +198,7 @@ private async Task CreateUserTokensAsync(User user, CancellationT { var roles = await userManager.GetRolesAsync(user); var claims = await userManager.GetClaimsAsync(user); - foreach (var roleName in roles) + foreach (string roleName in roles) { var role = await roleManager.FindByNameAsync(roleName); if (role is not null) claims = claims.Concat(await roleManager.GetClaimsAsync(role)).ToList(); diff --git a/src/server/RemoteTickets.Infrastructure/Identity/Services/JwtTokenService.cs b/src/server/RemoteTickets.Infrastructure/Identity/Services/JwtTokenService.cs index b50a229..af5ff01 100644 --- a/src/server/RemoteTickets.Infrastructure/Identity/Services/JwtTokenService.cs +++ b/src/server/RemoteTickets.Infrastructure/Identity/Services/JwtTokenService.cs @@ -76,7 +76,7 @@ private JwtSecurityToken CreateToken(string userId, string email, IEnumerable() is not null; + bool anonymous = endpoint?.Metadata.GetMetadata() is not null; var setupState = await masterDb.SystemSetup.AsNoTracking().SingleOrDefaultAsync(x => x.Id == 1, context.RequestAborted); - var systemSetupRequired = setupState is null || !setupState.IsComplete; + bool systemSetupRequired = setupState is null || !setupState.IsComplete; if (systemSetupRequired) { if (IsSystemSetupEndpoint(context)) { await next(context); return; } @@ -29,12 +29,12 @@ public async Task InvokeAsync(HttpContext context) await context.Response.WriteAsJsonAsync(new { error = "System setup is already complete." }, context.RequestAborted); return; } - if (!context.Request.RouteValues.TryGetValue("tenantId", out var value) || string.IsNullOrWhiteSpace(value?.ToString())) + if (!context.Request.RouteValues.TryGetValue("tenantId", out object? value) || string.IsNullOrWhiteSpace(value?.ToString())) { if (anonymous) await next(context); else await RejectOrRedirectAsync(context, "/setup", StatusCodes.Status503ServiceUnavailable); return; } - var tenantId = value.ToString()!; + string tenantId = value.ToString()!; if (string.Equals(tenantId, "system", StringComparison.OrdinalIgnoreCase)) { if (context.User.Identity?.IsAuthenticated != true || !context.User.IsInRole(TenantRoles.SysAdmin)) { context.Response.StatusCode = StatusCodes.Status403Forbidden; return; } @@ -52,7 +52,7 @@ public async Task InvokeAsync(HttpContext context) if (context.User.Identity?.IsAuthenticated != true) { context.Response.StatusCode = StatusCodes.Status401Unauthorized; return; } if (!context.User.IsInRole(TenantRoles.SysAdmin)) { - var assignedTenant = context.User.FindFirst(TenantClaimTypes.TenantId)?.Value; + string? assignedTenant = context.User.FindFirst(TenantClaimTypes.TenantId)?.Value; if (!string.Equals(assignedTenant, tenantId, StringComparison.OrdinalIgnoreCase)) { await RejectOrRedirectAsync(context, $"/{assignedTenant ?? tenantId}", StatusCodes.Status403Forbidden); return; } } if (!tenant.IsSetupComplete && !IsTenantSetupEndpoint(context)) { await RejectOrRedirectAsync(context, $"/{tenantId}/setup", StatusCodes.Status409Conflict); return; } @@ -64,9 +64,9 @@ public async Task InvokeAsync(HttpContext context) private static bool IsTenantLoginEndpoint(HttpContext context) => string.Equals(context.Request.Path.Value, $"/api/v1/{context.Request.RouteValues["tenantId"]}/login", StringComparison.OrdinalIgnoreCase); private static bool IsTenantSetupEndpoint(HttpContext context) { - var tenantId = context.Request.RouteValues.TryGetValue("tenantId", out var value) ? value?.ToString() : null; + string? tenantId = context.Request.RouteValues.TryGetValue("tenantId", out object? value) ? value?.ToString() : null; if (string.IsNullOrWhiteSpace(tenantId)) return false; - var path = context.Request.Path.Value; + string? path = context.Request.Path.Value; return string.Equals(path, $"/{tenantId}/setup", StringComparison.OrdinalIgnoreCase) || string.Equals(path, $"/api/v1/{tenantId}/setup", StringComparison.OrdinalIgnoreCase) || string.Equals(path, $"/api/v1/{tenantId}/setup/complete", StringComparison.OrdinalIgnoreCase); } private static async Task RejectOrRedirectAsync(HttpContext context, string location, int statusCode) diff --git a/src/server/RemoteTickets.Infrastructure/Tenancy/TenantManagementService.cs b/src/server/RemoteTickets.Infrastructure/Tenancy/TenantManagementService.cs index 5ac8912..6e29cb2 100644 --- a/src/server/RemoteTickets.Infrastructure/Tenancy/TenantManagementService.cs +++ b/src/server/RemoteTickets.Infrastructure/Tenancy/TenantManagementService.cs @@ -102,7 +102,7 @@ private static async Task CreateDatabaseAsync(string connectionString, string da builder.InitialCatalog = "master"; await using var connection = new SqlConnection(builder.ConnectionString); await connection.OpenAsync(cancellationToken); - var escaped = $"[{databaseName.Replace("]", "]]", StringComparison.Ordinal)}]"; + string escaped = $"[{databaseName.Replace("]", "]]", StringComparison.Ordinal)}]"; await using var command = connection.CreateCommand(); command.CommandText = $"IF DB_ID(@databaseName) IS NULL CREATE DATABASE {escaped};"; command.Parameters.AddWithValue("@databaseName", databaseName); diff --git a/src/server/RemoteTickets/Controllers/IdentityController.cs b/src/server/RemoteTickets/Controllers/IdentityController.cs index f3b2ec0..255153c 100644 --- a/src/server/RemoteTickets/Controllers/IdentityController.cs +++ b/src/server/RemoteTickets/Controllers/IdentityController.cs @@ -35,7 +35,7 @@ public async Task Refresh([FromRoute] string tenantId, RefreshReq [Authorize] public async Task Revoke(CancellationToken cancellationToken) { - var accessToken = Request.Headers.Authorization.ToString().Replace("Bearer ", string.Empty, StringComparison.OrdinalIgnoreCase); + string accessToken = Request.Headers.Authorization.ToString().Replace("Bearer ", string.Empty, StringComparison.OrdinalIgnoreCase); var result = await mediator.RequestAsync>(new RevokeTokenCommand(accessToken), cancellationToken); return result.Data == true ? Ok() : Unauthorized(result); } @@ -76,7 +76,7 @@ public async Task ResetPassword(ResetPasswordRequest request, Can [Authorize] public async Task GetInfo(CancellationToken cancellationToken) { - var userId = GetUserId(); + string? userId = GetUserId(); if (userId is null) return Unauthorized(); var result = await mediator.RequestAsync>(new GetIdentityInfoQuery(userId), cancellationToken); return result.Succeeded ? Ok(result.Data) : NotFound(result); @@ -86,7 +86,7 @@ public async Task GetInfo(CancellationToken cancellationToken) [Authorize] public async Task UpdateInfo(InfoRequest request, CancellationToken cancellationToken) { - var userId = GetUserId(); + string? userId = GetUserId(); if (userId is null) return Unauthorized(); var result = await mediator.RequestAsync(new UpdateIdentityInfoCommand(userId, request.NewEmail, request.NewPassword, request.OldPassword), cancellationToken); return result.Succeeded ? Ok() : BadRequest(result); @@ -96,7 +96,7 @@ public async Task UpdateInfo(InfoRequest request, CancellationTok [Authorize] public async Task ConfigureTwoFactor(TwoFactorRequest request, CancellationToken cancellationToken) { - var userId = GetUserId(); + string? userId = GetUserId(); if (userId is null) return Unauthorized(); var result = await mediator.RequestAsync>(new ConfigureTwoFactorCommand(userId, request.Enable, request.TwoFactorCode, request.ResetRecoveryCodes, request.ResetSharedKey, request.ForgetMachine), cancellationToken); return result.Succeeded ? Ok(result.Data) : BadRequest(result); diff --git a/src/server/RemoteTickets/Controllers/SetupController.cs b/src/server/RemoteTickets/Controllers/SetupController.cs index c31c464..5d20ae5 100644 --- a/src/server/RemoteTickets/Controllers/SetupController.cs +++ b/src/server/RemoteTickets/Controllers/SetupController.cs @@ -33,7 +33,7 @@ public async Task Initialize(InitializeSetupRequest request, Canc var result = await mediator.RequestAsync(new InitializeSetupCommand(request.Email, request.Password), cancellationToken); if (!result.Succeeded) return Conflict(result); - var connectionString = configurationStore.GetMasterConnectionString(); + string? connectionString = configurationStore.GetMasterConnectionString(); if (!string.IsNullOrWhiteSpace(connectionString)) { var options = new DbContextOptionsBuilder().UseSqlServer(connectionString).Options; diff --git a/tests/server/RemoteTickets.UnitTests/IdentityBranchTests.cs b/tests/server/RemoteTickets.UnitTests/IdentityBranchTests.cs index 9da907f..ae927a8 100644 --- a/tests/server/RemoteTickets.UnitTests/IdentityBranchTests.cs +++ b/tests/server/RemoteTickets.UnitTests/IdentityBranchTests.cs @@ -59,7 +59,7 @@ public async Task Login_should_reject_invalid_two_factor_code_and_recovery_code( twoFactorSetup!.SharedKey.Should().NotBeNullOrWhiteSpace(); // AuthenticatorTokenProvider intentionally does not generate codes; the client authenticator generates TOTP from SharedKey. - var setupCode = GenerateTotp(twoFactorSetup.SharedKey!); + string setupCode = GenerateTotp(twoFactorSetup.SharedKey!); setupCode.Should().NotBeNullOrWhiteSpace(); var configured = await fixture.Service.ConfigureTwoFactorAsync( @@ -92,10 +92,10 @@ public async Task Refresh_should_reject_access_tokens_empty_subjects_and_unknown access.Should().NotBeNull(); (await fixture.Service.RefreshAsync(access!.AccessToken, CancellationToken.None)).Should().BeNull(); - var emptySubject = fixture.TokenService.CreateTokens(string.Empty, "empty@example.com", [], []).RefreshToken; + string emptySubject = fixture.TokenService.CreateTokens(string.Empty, "empty@example.com", [], []).RefreshToken; (await fixture.Service.RefreshAsync(emptySubject, CancellationToken.None)).Should().BeNull(); - var unknownUser = fixture.TokenService.CreateTokens("missing-user", "missing@example.com", [], []).RefreshToken; + string unknownUser = fixture.TokenService.CreateTokens("missing-user", "missing@example.com", [], []).RefreshToken; (await fixture.Service.RefreshAsync(unknownUser, CancellationToken.None)).Should().BeNull(); } @@ -108,7 +108,7 @@ public async Task Confirm_email_should_support_changed_email_and_reject_invalid_ { await using var fixture = await IdentityFixture.CreateAsync(); await fixture.Service.RegisterAsync("old@example.com", "Password1!", CancellationToken.None); - var link = fixture.EmailSender.ConfirmationLinks.Single(); + string link = fixture.EmailSender.ConfirmationLinks.Single(); var query = new Uri("https://localhost" + link).Query.TrimStart('?') .Split('&', StringSplitOptions.RemoveEmptyEntries) .Select(part => part.Split('=', 2)) @@ -116,7 +116,7 @@ public async Task Confirm_email_should_support_changed_email_and_reject_invalid_ var user = await fixture.UserManager.FindByIdAsync(query["userId"]); user.Should().NotBeNull(); - var changeCode = await fixture.UserManager.GenerateChangeEmailTokenAsync(user!, "new@example.com"); + string changeCode = await fixture.UserManager.GenerateChangeEmailTokenAsync(user!, "new@example.com"); (await fixture.Service.ConfirmEmailAsync(user!.Id, changeCode, "new@example.com", CancellationToken.None)).Should().BeTrue(); (await fixture.Service.ConfirmEmailAsync(user.Id, "invalid", null, CancellationToken.None)).Should().BeFalse(); } @@ -211,12 +211,12 @@ private static string GenerateTotp(string sharedKey) { ArgumentException.ThrowIfNullOrWhiteSpace(sharedKey); - var key = DecodeBase32(sharedKey); - var counter = BitConverter.GetBytes(IPAddress.HostToNetworkOrder(DateTimeOffset.UtcNow.ToUnixTimeSeconds() / 30)); + byte[] key = DecodeBase32(sharedKey); + byte[] counter = BitConverter.GetBytes(IPAddress.HostToNetworkOrder(DateTimeOffset.UtcNow.ToUnixTimeSeconds() / 30)); using var hmac = new HMACSHA1(key); - var hash = hmac.ComputeHash(counter); - var offset = hash[^1] & 0x0F; - var binary = ((hash[offset] & 0x7F) << 24) + byte[] hash = hmac.ComputeHash(counter); + int offset = hash[^1] & 0x0F; + int binary = ((hash[offset] & 0x7F) << 24) | ((hash[offset + 1] & 0xFF) << 16) | ((hash[offset + 2] & 0xFF) << 8) | (hash[offset + 3] & 0xFF); @@ -234,13 +234,13 @@ private static byte[] DecodeBase32(string value) { ArgumentException.ThrowIfNullOrWhiteSpace(value); const string alphabet = "ABCDEFGHIJKLMNOPQRSTUVWXYZ234567"; - var buffer = 0; - var bits = 0; + int buffer = 0; + int bits = 0; var bytes = new List(); - foreach (var character in value.TrimEnd('=').ToUpperInvariant()) + foreach (char character in value.TrimEnd('=').ToUpperInvariant()) { - var index = alphabet.IndexOf(character); + int index = alphabet.IndexOf(character); if (index < 0) { throw new ArgumentException("The authenticator shared key is not valid Base32.", nameof(value)); diff --git a/tests/server/RemoteTickets.UnitTests/IdentityServiceTests.cs b/tests/server/RemoteTickets.UnitTests/IdentityServiceTests.cs index 74b2dde..e2dc6ef 100644 --- a/tests/server/RemoteTickets.UnitTests/IdentityServiceTests.cs +++ b/tests/server/RemoteTickets.UnitTests/IdentityServiceTests.cs @@ -29,7 +29,7 @@ public async Task Setup_should_create_administrator_and_issue_revocable_tokens() var refreshed = await service.RefreshAsync(tokens.RefreshToken, CancellationToken.None); refreshed.Should().NotBeNull(); fixture.TokenService.ValidateToken(tokens.RefreshToken).Should().BeNull(); - var revoked = await service.RevokeAsync(refreshed!.AccessToken, CancellationToken.None); + bool revoked = await service.RevokeAsync(refreshed!.AccessToken, CancellationToken.None); revoked.Should().BeTrue(); fixture.TokenService.ValidateToken(refreshed.AccessToken).Should().BeNull(); } @@ -44,7 +44,7 @@ public async Task Registration_confirmation_and_password_reset_should_work() registration.Succeeded.Should().BeTrue(); fixture.EmailSender.ConfirmationLinks.Should().ContainSingle(); var confirmationQuery = ParseQuery(fixture.EmailSender.ConfirmationLinks.Single()); - var confirmed = await fixture.Service.ConfirmEmailAsync(confirmationQuery["userId"], confirmationQuery["code"], null, CancellationToken.None); + bool confirmed = await fixture.Service.ConfirmEmailAsync(confirmationQuery["userId"], confirmationQuery["code"], null, CancellationToken.None); confirmed.Should().BeTrue(); var info = await fixture.Service.GetInfoAsync(confirmationQuery["userId"], CancellationToken.None); info.Should().NotBeNull(); @@ -76,7 +76,7 @@ public async Task Update_info_should_change_email_and_password_after_current_pas private static Dictionary ParseQuery(string uri) { - var query = new Uri("https://localhost" + uri).Query.TrimStart('?'); + string query = new Uri("https://localhost" + uri).Query.TrimStart('?'); return query.Split('&', StringSplitOptions.RemoveEmptyEntries) .Select(part => part.Split('=', 2)) .ToDictionary(part => part[0], part => Uri.UnescapeDataString(part[1])); diff --git a/tests/server/RemoteTickets.UnitTests/IdentityTwoFactorTests.cs b/tests/server/RemoteTickets.UnitTests/IdentityTwoFactorTests.cs index d4bb4aa..54d7c19 100644 --- a/tests/server/RemoteTickets.UnitTests/IdentityTwoFactorTests.cs +++ b/tests/server/RemoteTickets.UnitTests/IdentityTwoFactorTests.cs @@ -15,17 +15,17 @@ public async Task Two_factor_should_be_configurable_and_used_during_login() user.Should().NotBeNull(); await fixture.UserManager.ResetAuthenticatorKeyAsync(user!); - var key = await fixture.UserManager.GetAuthenticatorKeyAsync(user); + string? key = await fixture.UserManager.GetAuthenticatorKeyAsync(user); key.Should().NotBeNullOrWhiteSpace(); - var code = CreateAuthenticatorCode(key!, DateTimeOffset.UtcNow); + string code = CreateAuthenticatorCode(key!, DateTimeOffset.UtcNow); var enabled = await fixture.Service.ConfigureTwoFactorAsync(user!.Id, true, code, true, false, false, CancellationToken.None); enabled.Should().NotBeNull(); enabled!.IsTwoFactorEnabled.Should().BeTrue(); enabled.RecoveryCodes.Should().NotBeNullOrEmpty(); - var loginKey = await fixture.UserManager.GetAuthenticatorKeyAsync(user); - var loginCode = CreateAuthenticatorCode(loginKey!, DateTimeOffset.UtcNow); + string? loginKey = await fixture.UserManager.GetAuthenticatorKeyAsync(user); + string loginCode = CreateAuthenticatorCode(loginKey!, DateTimeOffset.UtcNow); var login = await fixture.Service.LoginAsync("admin@example.com", "Password1!", loginCode, null, CancellationToken.None); login.Should().NotBeNull(); @@ -68,30 +68,30 @@ public async Task Two_factor_should_generate_recovery_codes_when_requested() private static string CreateAuthenticatorCode(string secret, DateTimeOffset timestamp) { - var key = Base32Decode(secret); - var counter = BitConverter.GetBytes(timestamp.ToUnixTimeSeconds() / 30); + byte[] key = Base32Decode(secret); + byte[] counter = BitConverter.GetBytes(timestamp.ToUnixTimeSeconds() / 30); if (BitConverter.IsLittleEndian) { Array.Reverse(counter); } using var hmac = new HMACSHA1(key); - var hash = hmac.ComputeHash(counter); - var offset = hash[^1] & 0x0F; - var binary = ((hash[offset] & 0x7F) << 24) | (hash[offset + 1] << 16) | (hash[offset + 2] << 8) | hash[offset + 3]; + byte[] hash = hmac.ComputeHash(counter); + int offset = hash[^1] & 0x0F; + int binary = ((hash[offset] & 0x7F) << 24) | (hash[offset + 1] << 16) | (hash[offset + 2] << 8) | hash[offset + 3]; return (binary % 1_000_000).ToString("D6"); } private static byte[] Base32Decode(string value) { - var alphabet = "ABCDEFGHIJKLMNOPQRSTUVWXYZ234567"; - var buffer = 0; - var bitsLeft = 0; + string alphabet = "ABCDEFGHIJKLMNOPQRSTUVWXYZ234567"; + int buffer = 0; + int bitsLeft = 0; var result = new List(); - foreach (var character in value.TrimEnd('=').ToUpperInvariant()) + foreach (char character in value.TrimEnd('=').ToUpperInvariant()) { - var index = alphabet.IndexOf(character); + int index = alphabet.IndexOf(character); if (index < 0) { throw new FormatException("Invalid Base32 value."); diff --git a/tests/server/RemoteTickets.UnitTests/JwtTokenServiceTests.cs b/tests/server/RemoteTickets.UnitTests/JwtTokenServiceTests.cs index ac1d59d..fe24e0a 100644 --- a/tests/server/RemoteTickets.UnitTests/JwtTokenServiceTests.cs +++ b/tests/server/RemoteTickets.UnitTests/JwtTokenServiceTests.cs @@ -53,7 +53,7 @@ public void Token_service_should_reject_a_revoked_token() var store = new RevokedTokenStore(); var service = CreateService(store); var tokens = service.CreateTokens("user-id", "user@example.com", [], []); - var tokenId = service.GetTokenId(tokens.AccessToken); + string? tokenId = service.GetTokenId(tokens.AccessToken); tokenId.Should().NotBeNull(); store.Revoke(tokenId!, DateTimeOffset.UtcNow.AddMinutes(1)); From 3be518b79ce37150367a2770e5a01dda0d3b93b4 Mon Sep 17 00:00:00 2001 From: Weslley Murdock Date: Sun, 16 Aug 2026 22:58:18 -0300 Subject: [PATCH 055/112] fix: global usings --- src/server/RemoteTickets.Infrastructure/GlobalUsings.cs | 2 ++ .../Tenancy/TenantAccessMiddleware.cs | 4 ---- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/server/RemoteTickets.Infrastructure/GlobalUsings.cs b/src/server/RemoteTickets.Infrastructure/GlobalUsings.cs index 519a76c..7974578 100644 --- a/src/server/RemoteTickets.Infrastructure/GlobalUsings.cs +++ b/src/server/RemoteTickets.Infrastructure/GlobalUsings.cs @@ -18,6 +18,8 @@ global using RemoteTickets.Infrastructure.Setup; global using RemoteTickets.Infrastructure.Tenancy.Configurations; global using RemoteTickets.Infrastructure.Tenancy.Models; +global using Microsoft.AspNetCore.Authorization; +global using Microsoft.AspNetCore.Http; global using Microsoft.AspNetCore.Identity; global using Microsoft.AspNetCore.Identity.EntityFrameworkCore; global using Microsoft.Data.SqlClient; diff --git a/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs b/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs index 64263a0..66a4500 100644 --- a/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs +++ b/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs @@ -1,7 +1,3 @@ -using Microsoft.AspNetCore.Authorization; -using Microsoft.AspNetCore.Http; -using RemoteTickets.Application.Common.Tenancy; - namespace RemoteTickets.Infrastructure.Tenancy; /// Enforces tenant route isolation and mandatory setup state for HTTP requests. From 42be5fca4938b997fe49314e069d86f1b976fdb2 Mon Sep 17 00:00:00 2001 From: Weslley Murdock Date: Sun, 16 Aug 2026 23:12:06 -0300 Subject: [PATCH 056/112] fix: warnings --- .../Identity/Handlers/IdentityHandlers.cs | 12 +- .../WebApplicationBuilderExtensions.cs | 12 +- .../Services/IdentityService.Refresh.cs | 49 +++- .../Services/IdentityService.Tenancy.cs | 66 +++-- .../Identity/Services/IdentityService.cs | 232 +++++++++++++----- .../Identity/Services/JwtTokenService.cs | 47 +++- .../Identity/IdentityrConfigurations.cs | 4 +- .../Tenancy/TenancyConfigurations.cs | 23 ++ ...DbContext.cs => RemoteTicketsDbContext.cs} | 37 ++- .../Setup/SetupConfigurationStore.cs | 14 +- .../Configurations/TenancyConfigurations.cs | 1 + .../Tenancy/TenantAccessMiddleware.cs | 22 +- .../Tenancy/TenantManagementService.cs | 22 +- .../Controllers/IdentityController.cs | 40 +-- .../Controllers/SetupController.cs | 19 +- .../Controllers/TenantController.cs | 4 +- .../Controllers/TenantSetupController.cs | 2 +- .../IdentityBranchTests.cs | 42 ++-- .../IdentityFailurePathTests.cs | 4 +- .../IdentityServiceTests.cs | 44 ++-- .../IdentityTwoFactorTests.cs | 20 +- .../IdentityValidatorTests.cs | 10 +- .../JwtTokenServiceTests.cs | 12 +- .../PersistenceTests.cs | 6 +- .../TenantIdentityTests.cs | 20 +- .../ValidationMiddlewareTests.cs | 8 +- 26 files changed, 514 insertions(+), 258 deletions(-) create mode 100644 src/server/RemoteTickets.Infrastructure/Persistence/Configurations/Tenancy/TenancyConfigurations.cs rename src/server/RemoteTickets.Infrastructure/Persistence/{InvisibleSPDbContext.cs => RemoteTicketsDbContext.cs} (65%) diff --git a/src/server/RemoteTickets.Application/Identity/Handlers/IdentityHandlers.cs b/src/server/RemoteTickets.Application/Identity/Handlers/IdentityHandlers.cs index 346b15a..607c553 100644 --- a/src/server/RemoteTickets.Application/Identity/Handlers/IdentityHandlers.cs +++ b/src/server/RemoteTickets.Application/Identity/Handlers/IdentityHandlers.cs @@ -22,15 +22,15 @@ public sealed class IdentityHandlers(IIdentityService identityService) : /// Executes the login request. public async Task> Handle(IReceiveContext context, CancellationToken cancellationToken) { - var message = context.Message; - var result = message.TenantId is null ? await identityService.LoginAsync(message.Email, message.Password, message.TwoFactorCode, message.TwoFactorRecoveryCode, cancellationToken) : await identityService.LoginAsync(message.TenantId, message.Email, message.Password, message.TwoFactorCode, message.TwoFactorRecoveryCode, cancellationToken); + LoginCommand message = context.Message; + TokenResponse? result = message.TenantId is null ? await identityService.LoginAsync(message.Email, message.Password, message.TwoFactorCode, message.TwoFactorRecoveryCode, cancellationToken) : await identityService.LoginAsync(message.TenantId, message.Email, message.Password, message.TwoFactorCode, message.TwoFactorRecoveryCode, cancellationToken); return result is null ? Response.Failure(["Invalid credentials."]) : Response.Success(result); } /// Executes a tenant-bound refresh-token exchange. public async Task> Handle(IReceiveContext context, CancellationToken cancellationToken) { - var message = context.Message; - var result = message.TenantId is null ? await identityService.RefreshAsync(message.RefreshToken, cancellationToken) : await identityService.RefreshAsync(message.TenantId, message.RefreshToken, cancellationToken); + RefreshTokenCommand message = context.Message; + TokenResponse? result = message.TenantId is null ? await identityService.RefreshAsync(message.RefreshToken, cancellationToken) : await identityService.RefreshAsync(message.TenantId, message.RefreshToken, cancellationToken); return result is null ? Response.Failure(["Invalid refresh token."]) : Response.Success(result); } /// Executes token revocation. @@ -46,7 +46,7 @@ public async Task> Handle(IReceiveContextExecutes an identity information query. public async Task> Handle(IReceiveContext context, CancellationToken cancellationToken) { - var result = await identityService.GetInfoAsync(context.Message.UserId, cancellationToken); + IdentityInfoResponse? result = await identityService.GetInfoAsync(context.Message.UserId, cancellationToken); return result is null ? Response.Failure(["User not found."]) : Response.Success(result); } /// Executes an identity information update. @@ -54,7 +54,7 @@ public async Task> Handle(IReceiveContextExecutes two-factor configuration. public async Task> Handle(IReceiveContext context, CancellationToken cancellationToken) { - var result = await identityService.ConfigureTwoFactorAsync(context.Message.UserId, context.Message.Enable, context.Message.TwoFactorCode, context.Message.ResetRecoveryCodes, context.Message.ResetSharedKey, context.Message.ForgetMachine, cancellationToken); + TwoFactorResponse? result = await identityService.ConfigureTwoFactorAsync(context.Message.UserId, context.Message.Enable, context.Message.TwoFactorCode, context.Message.ResetRecoveryCodes, context.Message.ResetSharedKey, context.Message.ForgetMachine, cancellationToken); return result is null ? Response.Failure(["The two-factor configuration request is invalid."]) : Response.Success(result); } /// Reads the current setup status. diff --git a/src/server/RemoteTickets.Composition/WebApplicationBuilderExtensions.cs b/src/server/RemoteTickets.Composition/WebApplicationBuilderExtensions.cs index 120aff7..afffcd6 100644 --- a/src/server/RemoteTickets.Composition/WebApplicationBuilderExtensions.cs +++ b/src/server/RemoteTickets.Composition/WebApplicationBuilderExtensions.cs @@ -10,8 +10,8 @@ public static class WebApplicationBuilderExtensions /// Thrown when required JWT configuration is missing or its secret key is too short. public async Task RunRemoteTicketsAsync() where T : IComponent { - var services = builder.Services; - var configuration = builder.Configuration; + IServiceCollection services = builder.Services; + ConfigurationManager configuration = builder.Configuration; services.AddRazorComponents() .AddInteractiveServerComponents(); @@ -60,8 +60,12 @@ public async Task RunRemoteTicketsAsync() where T : IComponent _ = services.AddAuthentication(JwtBearerDefaults.AuthenticationScheme).AddJwtBearer(options => { - var jwt = configuration.GetSection(JwtOptions.SectionName).Get() ?? throw new InvalidOperationException("JWT configuration is missing."); - if (Encoding.UTF8.GetByteCount(jwt.SecretKey) < 32) throw new InvalidOperationException("Authentication:Jwt:SecretKey must contain at least 256 bits."); + JwtOptions jwt = configuration.GetSection(JwtOptions.SectionName).Get() ?? throw new InvalidOperationException("JWT configuration is missing."); + if (Encoding.UTF8.GetByteCount(jwt.SecretKey) < 32) + { + throw new InvalidOperationException("Authentication:Jwt:SecretKey must contain at least 256 bits."); + } + options.TokenValidationParameters = new TokenValidationParameters { ValidateIssuerSigningKey = true, diff --git a/src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.Refresh.cs b/src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.Refresh.cs index 012c8d1..fee94a7 100644 --- a/src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.Refresh.cs +++ b/src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.Refresh.cs @@ -6,29 +6,52 @@ public sealed partial class IdentityService /// public async Task RefreshAsync(string tenantId, string refreshToken, CancellationToken cancellationToken) { - var principal = tokenService.ValidateToken(refreshToken); - if (principal is null || !string.Equals(principal.FindFirstValue("token_type"), JwtTokenTypes.Refresh, StringComparison.Ordinal)) return null; + ClaimsPrincipal? principal = tokenService.ValidateToken(refreshToken); + if (principal is null || !string.Equals(principal.FindFirstValue("token_type"), JwtTokenTypes.Refresh, StringComparison.Ordinal)) + { + return null; + } string[] roles = principal.FindAll(ClaimTypes.Role).Select(x => x.Value).ToArray(); - if (!roles.Contains(TenantRoles.SysAdmin, StringComparer.OrdinalIgnoreCase) && !string.Equals(principal.FindFirst(TenantClaimTypes.TenantId)?.Value, tenantId, StringComparison.OrdinalIgnoreCase)) return null; + if (!roles.Contains(TenantRoles.SysAdmin, StringComparer.OrdinalIgnoreCase) && !string.Equals(principal.FindFirst(TenantClaimTypes.TenantId)?.Value, tenantId, StringComparison.OrdinalIgnoreCase)) + { + return null; + } string? userId = principal.FindFirstValue(JwtRegisteredClaimNames.Sub) ?? principal.FindFirstValue(ClaimTypes.NameIdentifier); - if (string.IsNullOrWhiteSpace(userId)) return null; - var user = await userManager.FindByIdAsync(userId); - if (user is null) return null; + if (string.IsNullOrWhiteSpace(userId)) + { + return null; + } + + User? user = await userManager.FindByIdAsync(userId); + if (user is null) + { + return null; + } - var claims = await userManager.GetClaimsAsync(user); + IList claims = await userManager.GetClaimsAsync(user); foreach (string? roleName in roles) { - var role = await roleManager.FindByNameAsync(roleName); - if (role is not null) claims = claims.Concat(await roleManager.GetClaimsAsync(role)).ToList(); + Role? role = await roleManager.FindByNameAsync(roleName); + if (role is not null) + { + claims = claims.Concat(await roleManager.GetClaimsAsync(role)).ToList(); + } + } + if (user.TenantId is not null) + { + claims = claims.Append(new Claim(TenantClaimTypes.TenantId, user.TenantId)).ToList(); } - if (user.TenantId is not null) claims = claims.Append(new Claim(TenantClaimTypes.TenantId, user.TenantId)).ToList(); string? tokenId = tokenService.GetTokenId(refreshToken); - var expiration = tokenService.GetExpiration(refreshToken); - var tokens = tokenService.CreateTokens(user.Id, user.Email ?? user.UserName ?? user.Id, roles, claims); - if (!string.IsNullOrWhiteSpace(tokenId) && expiration.HasValue) revokedTokenStore.Revoke(tokenId, expiration.Value); + DateTimeOffset? expiration = tokenService.GetExpiration(refreshToken); + TokenResponse tokens = tokenService.CreateTokens(user.Id, user.Email ?? user.UserName ?? user.Id, roles, claims); + if (!string.IsNullOrWhiteSpace(tokenId) && expiration.HasValue) + { + revokedTokenStore.Revoke(tokenId, expiration.Value); + } + return tokens; } } diff --git a/src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.Tenancy.cs b/src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.Tenancy.cs index d4c33bc..c13dbb7 100644 --- a/src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.Tenancy.cs +++ b/src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.Tenancy.cs @@ -12,32 +12,48 @@ public sealed partial class IdentityService string? twoFactorRecoveryCode, CancellationToken cancellationToken) { - var user = await userManager.FindByEmailAsync(email); + User? user = await userManager.FindByEmailAsync(email); if (user is null || (user.TenantId is not null && !string.Equals(user.TenantId, tenantId, StringComparison.OrdinalIgnoreCase) && !await userManager.IsInRoleAsync(user, TenantRoles.SysAdmin))) { return null; } - if (user.TenantId is null && !await userManager.IsInRoleAsync(user, TenantRoles.SysAdmin)) return null; - if (user.TenantId is not null && !string.Equals(user.TenantId, tenantId, StringComparison.OrdinalIgnoreCase) && !await userManager.IsInRoleAsync(user, TenantRoles.SysAdmin)) return null; + if (user.TenantId is null && !await userManager.IsInRoleAsync(user, TenantRoles.SysAdmin)) + { + return null; + } - var passwordResult = await signInManager.CheckPasswordSignInAsync(user, password, true); - if (passwordResult.IsLockedOut || passwordResult.IsNotAllowed || !passwordResult.Succeeded) return null; + if (user.TenantId is not null && !string.Equals(user.TenantId, tenantId, StringComparison.OrdinalIgnoreCase) && !await userManager.IsInRoleAsync(user, TenantRoles.SysAdmin)) + { + return null; + } + + SignInResult passwordResult = await signInManager.CheckPasswordSignInAsync(user, password, true); + if (passwordResult.IsLockedOut || passwordResult.IsNotAllowed || !passwordResult.Succeeded) + { + return null; + } if (await userManager.GetTwoFactorEnabledAsync(user)) { bool valid = !string.IsNullOrWhiteSpace(twoFactorCode) ? await userManager.VerifyTwoFactorTokenAsync(user, userManager.Options.Tokens.AuthenticatorTokenProvider, twoFactorCode) : !string.IsNullOrWhiteSpace(twoFactorRecoveryCode) && (await userManager.RedeemTwoFactorRecoveryCodeAsync(user, twoFactorRecoveryCode)).Succeeded; - if (!valid) return null; + if (!valid) + { + return null; + } } - var roles = await userManager.GetRolesAsync(user); - var claims = await userManager.GetClaimsAsync(user); + IList roles = await userManager.GetRolesAsync(user); + IList claims = await userManager.GetClaimsAsync(user); foreach (string roleName in roles) { - var role = await roleManager.FindByNameAsync(roleName); - if (role is not null) claims = claims.Concat(await roleManager.GetClaimsAsync(role)).ToList(); + Role? role = await roleManager.FindByNameAsync(roleName); + if (role is not null) + { + claims = claims.Concat(await roleManager.GetClaimsAsync(role)).ToList(); + } } if (!roles.Contains(TenantRoles.SysAdmin, StringComparer.OrdinalIgnoreCase)) @@ -55,14 +71,24 @@ public sealed partial class IdentityService /// public async Task CreateTenantAdminAsync(string tenantId, string email, string password, CancellationToken cancellationToken) { - if (string.IsNullOrWhiteSpace(tenantId)) return IdentityResultResponse.Failure(["A tenant identifier is required."]); - if (await userManager.FindByEmailAsync(email) is not null) return IdentityResultResponse.Failure(["The email address is already registered."]); + if (string.IsNullOrWhiteSpace(tenantId)) + { + return IdentityResultResponse.Failure(["A tenant identifier is required."]); + } - var role = await roleManager.FindByNameAsync(TenantRoles.TenantAdmin); + if (await userManager.FindByEmailAsync(email) is not null) + { + return IdentityResultResponse.Failure(["The email address is already registered."]); + } + + Role? role = await roleManager.FindByNameAsync(TenantRoles.TenantAdmin); if (role is null) { - var roleResult = await roleManager.CreateAsync(new Role(TenantRoles.TenantAdmin)); - if (!roleResult.Succeeded) return IdentityResultResponse.Failure(roleResult.Errors.Select(x => x.Description)); + IdentityResult roleResult = await roleManager.CreateAsync(new Role(TenantRoles.TenantAdmin)); + if (!roleResult.Succeeded) + { + return IdentityResultResponse.Failure(roleResult.Errors.Select(x => x.Description)); + } } var user = new User(email) @@ -71,9 +97,13 @@ public async Task CreateTenantAdminAsync(string tenantId EmailConfirmed = true, TenantId = tenantId }; - var userResult = await userManager.CreateAsync(user, password); - if (!userResult.Succeeded) return IdentityResultResponse.Failure(userResult.Errors.Select(x => x.Description)); - var membership = await userManager.AddToRoleAsync(user, TenantRoles.TenantAdmin); + IdentityResult userResult = await userManager.CreateAsync(user, password); + if (!userResult.Succeeded) + { + return IdentityResultResponse.Failure(userResult.Errors.Select(x => x.Description)); + } + + IdentityResult membership = await userManager.AddToRoleAsync(user, TenantRoles.TenantAdmin); return membership.Succeeded ? IdentityResultResponse.Success() : IdentityResultResponse.Failure(membership.Errors.Select(x => x.Description)); } } diff --git a/src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.cs b/src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.cs index 681c857..2239ff2 100644 --- a/src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.cs +++ b/src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.cs @@ -26,8 +26,12 @@ public sealed partial class IdentityService( public async Task RegisterAsync(string email, string password, CancellationToken cancellationToken) { var user = new User(email) { Email = email, DisplayName = "", FirstName = "", SurName = "", EmailConfirmed = false }; - var result = await userManager.CreateAsync(user, password); - if (!result.Succeeded) return Failure(result); + IdentityResult result = await userManager.CreateAsync(user, password); + if (!result.Succeeded) + { + return Failure(result); + } + string code = await userManager.GenerateEmailConfirmationTokenAsync(user); await emailSender.SendConfirmationAsync(email, $"/confirmEmail?userId={Uri.EscapeDataString(user.Id)}&code={Uri.EscapeDataString(code)}", cancellationToken); return IdentityResultResponse.Success(); @@ -36,16 +40,27 @@ public async Task RegisterAsync(string email, string pas /// Authenticates a user and issues JWT access and refresh tokens when all required authentication factors are valid. public async Task LoginAsync(string email, string password, string? twoFactorCode, string? twoFactorRecoveryCode, CancellationToken cancellationToken) { - var user = await userManager.FindByEmailAsync(email); - if (user is null) return null; - var passwordResult = await signInManager.CheckPasswordSignInAsync(user, password, true); - if (passwordResult.IsLockedOut || passwordResult.IsNotAllowed || !passwordResult.Succeeded) return null; + User? user = await userManager.FindByEmailAsync(email); + if (user is null) + { + return null; + } + + SignInResult passwordResult = await signInManager.CheckPasswordSignInAsync(user, password, true); + if (passwordResult.IsLockedOut || passwordResult.IsNotAllowed || !passwordResult.Succeeded) + { + return null; + } + if (await userManager.GetTwoFactorEnabledAsync(user)) { bool valid = !string.IsNullOrWhiteSpace(twoFactorCode) ? await userManager.VerifyTwoFactorTokenAsync(user, userManager.Options.Tokens.AuthenticatorTokenProvider, twoFactorCode) : !string.IsNullOrWhiteSpace(twoFactorRecoveryCode) && (await userManager.RedeemTwoFactorRecoveryCodeAsync(user, twoFactorRecoveryCode)).Succeeded; - if (!valid) return null; + if (!valid) + { + return null; + } } return await CreateUserTokensAsync(user, cancellationToken); } @@ -53,26 +68,46 @@ public async Task RegisterAsync(string email, string pas /// Exchanges a valid refresh token for a new access and refresh token pair and revokes the previous refresh token. public async Task RefreshAsync(string refreshToken, CancellationToken cancellationToken) { - var principal = tokenService.ValidateToken(refreshToken); - if (principal is null || !string.Equals(principal.FindFirstValue("token_type"), JwtTokenTypes.Refresh, StringComparison.Ordinal)) return null; + ClaimsPrincipal? principal = tokenService.ValidateToken(refreshToken); + if (principal is null || !string.Equals(principal.FindFirstValue("token_type"), JwtTokenTypes.Refresh, StringComparison.Ordinal)) + { + return null; + } + string? userId = principal.FindFirstValue(JwtRegisteredClaimNames.Sub) ?? principal.FindFirstValue(ClaimTypes.NameIdentifier); - if (string.IsNullOrWhiteSpace(userId)) return null; - var user = await userManager.FindByIdAsync(userId); - if (user is null) return null; + if (string.IsNullOrWhiteSpace(userId)) + { + return null; + } + + User? user = await userManager.FindByIdAsync(userId); + if (user is null) + { + return null; + } + string? tokenId = tokenService.GetTokenId(refreshToken); - var expiration = tokenService.GetExpiration(refreshToken); - var tokens = await CreateUserTokensAsync(user, cancellationToken); - if (!string.IsNullOrWhiteSpace(tokenId) && expiration.HasValue) revokedTokenStore.Revoke(tokenId, expiration.Value); + DateTimeOffset? expiration = tokenService.GetExpiration(refreshToken); + TokenResponse tokens = await CreateUserTokensAsync(user, cancellationToken); + if (!string.IsNullOrWhiteSpace(tokenId) && expiration.HasValue) + { + revokedTokenStore.Revoke(tokenId, expiration.Value); + } + return tokens; } /// Revokes a valid access token until its natural expiration. public Task RevokeAsync(string accessToken, CancellationToken cancellationToken) { - var principal = tokenService.ValidateToken(accessToken); + ClaimsPrincipal? principal = tokenService.ValidateToken(accessToken); string? tokenId = tokenService.GetTokenId(accessToken); - var expiration = tokenService.GetExpiration(accessToken); - if (principal is null || string.IsNullOrWhiteSpace(tokenId) || !expiration.HasValue) return Task.FromResult(false); + DateTimeOffset? expiration = tokenService.GetExpiration(accessToken); + if (principal is null || string.IsNullOrWhiteSpace(tokenId) || !expiration.HasValue) + { + return Task.FromResult(false); + } + revokedTokenStore.Revoke(tokenId, expiration.Value); return Task.FromResult(true); } @@ -80,17 +115,25 @@ public Task RevokeAsync(string accessToken, CancellationToken cancellation /// Confirms a user's email address or confirms a changed email address using a supplied Identity token. public async Task ConfirmEmailAsync(string userId, string code, string? changedEmail, CancellationToken cancellationToken) { - var user = await userManager.FindByIdAsync(userId); - if (user is null) return false; - var result = !string.IsNullOrWhiteSpace(changedEmail) ? await userManager.ChangeEmailAsync(user, changedEmail, code) : await userManager.ConfirmEmailAsync(user, code); + User? user = await userManager.FindByIdAsync(userId); + if (user is null) + { + return false; + } + + IdentityResult result = !string.IsNullOrWhiteSpace(changedEmail) ? await userManager.ChangeEmailAsync(user, changedEmail, code) : await userManager.ConfirmEmailAsync(user, code); return result.Succeeded; } /// Resends an email confirmation link when the specified user exists and remains unconfirmed. public async Task ResendConfirmationEmailAsync(string email, CancellationToken cancellationToken) { - var user = await userManager.FindByEmailAsync(email); - if (user is null || await userManager.IsEmailConfirmedAsync(user)) return IdentityResultResponse.Success(); + User? user = await userManager.FindByEmailAsync(email); + if (user is null || await userManager.IsEmailConfirmedAsync(user)) + { + return IdentityResultResponse.Success(); + } + string code = await userManager.GenerateEmailConfirmationTokenAsync(user); await emailSender.SendConfirmationAsync(email, $"/confirmEmail?userId={Uri.EscapeDataString(user.Id)}&code={Uri.EscapeDataString(code)}", cancellationToken); return IdentityResultResponse.Success(); @@ -99,8 +142,12 @@ public async Task ResendConfirmationEmailAsync(string em /// Starts a password recovery operation for a user with a password. public async Task ForgotPasswordAsync(string email, CancellationToken cancellationToken) { - var user = await userManager.FindByEmailAsync(email); - if (user is null || !await userManager.HasPasswordAsync(user)) return IdentityResultResponse.Success(); + User? user = await userManager.FindByEmailAsync(email); + if (user is null || !await userManager.HasPasswordAsync(user)) + { + return IdentityResultResponse.Success(); + } + string code = await userManager.GeneratePasswordResetTokenAsync(user); await emailSender.SendPasswordResetAsync(email, $"/resetPassword?email={Uri.EscapeDataString(email)}&code={Uri.EscapeDataString(code)}", cancellationToken); return IdentityResultResponse.Success(); @@ -109,33 +156,47 @@ public async Task ForgotPasswordAsync(string email, Canc /// Resets a user's password using a valid password-reset token. public async Task ResetPasswordAsync(string email, string resetCode, string newPassword, CancellationToken cancellationToken) { - var user = await userManager.FindByEmailAsync(email); - if (user is null) return IdentityResultResponse.Failure(["Invalid password reset request."]); - var result = await userManager.ResetPasswordAsync(user, resetCode, newPassword); + User? user = await userManager.FindByEmailAsync(email); + if (user is null) + { + return IdentityResultResponse.Failure(["Invalid password reset request."]); + } + + IdentityResult result = await userManager.ResetPasswordAsync(user, resetCode, newPassword); return result.Succeeded ? IdentityResultResponse.Success() : Failure(result); } /// Gets basic identity information for a user. public async Task GetInfoAsync(string userId, CancellationToken cancellationToken) { - var user = await userManager.FindByIdAsync(userId); + User? user = await userManager.FindByIdAsync(userId); return user is null ? null : new IdentityInfoResponse(user.Email ?? string.Empty, await userManager.IsEmailConfirmedAsync(user)); } /// Updates a user's email address and password after validating the current password. public async Task UpdateInfoAsync(string userId, string? newEmail, string? newPassword, string oldPassword, CancellationToken cancellationToken) { - var user = await userManager.FindByIdAsync(userId); - if (user is null || !await userManager.CheckPasswordAsync(user, oldPassword)) return IdentityResultResponse.Failure(["The current credentials are invalid."]); + User? user = await userManager.FindByIdAsync(userId); + if (user is null || !await userManager.CheckPasswordAsync(user, oldPassword)) + { + return IdentityResultResponse.Failure(["The current credentials are invalid."]); + } + if (!string.IsNullOrWhiteSpace(newEmail) && !string.Equals(user.Email, newEmail, StringComparison.OrdinalIgnoreCase)) { - var emailResult = await userManager.ChangeEmailAsync(user, newEmail, await userManager.GenerateChangeEmailTokenAsync(user, newEmail)); - if (!emailResult.Succeeded) return Failure(emailResult); + IdentityResult emailResult = await userManager.ChangeEmailAsync(user, newEmail, await userManager.GenerateChangeEmailTokenAsync(user, newEmail)); + if (!emailResult.Succeeded) + { + return Failure(emailResult); + } } if (!string.IsNullOrWhiteSpace(newPassword)) { - var passwordResult = await userManager.ChangePasswordAsync(user, oldPassword, newPassword); - if (!passwordResult.Succeeded) return Failure(passwordResult); + IdentityResult passwordResult = await userManager.ChangePasswordAsync(user, oldPassword, newPassword); + if (!passwordResult.Succeeded) + { + return Failure(passwordResult); + } } return IdentityResultResponse.Success(); } @@ -143,17 +204,37 @@ public async Task UpdateInfoAsync(string userId, string? /// Configures authenticator-based two-factor authentication and optionally rotates its recovery material. public async Task ConfigureTwoFactorAsync(string userId, bool? enable, string? twoFactorCode, bool resetRecoveryCodes, bool resetSharedKey, bool forgetMachine, CancellationToken cancellationToken) { - var user = await userManager.FindByIdAsync(userId); - if (user is null) return null; + User? user = await userManager.FindByIdAsync(userId); + if (user is null) + { + return null; + } + if (enable == true) { - if (string.IsNullOrWhiteSpace(twoFactorCode) || !await userManager.VerifyTwoFactorTokenAsync(user, userManager.Options.Tokens.AuthenticatorTokenProvider, twoFactorCode)) return null; + if (string.IsNullOrWhiteSpace(twoFactorCode) || !await userManager.VerifyTwoFactorTokenAsync(user, userManager.Options.Tokens.AuthenticatorTokenProvider, twoFactorCode)) + { + return null; + } + await userManager.SetTwoFactorEnabledAsync(user, true); } - else if (enable == false || resetSharedKey) await userManager.SetTwoFactorEnabledAsync(user, false); - if (resetSharedKey) await userManager.ResetAuthenticatorKeyAsync(user); + else if (enable == false || resetSharedKey) + { + await userManager.SetTwoFactorEnabledAsync(user, false); + } + + if (resetSharedKey) + { + await userManager.ResetAuthenticatorKeyAsync(user); + } + string[]? recoveryCodes = null; - if (resetRecoveryCodes || (enable == true && await userManager.CountRecoveryCodesAsync(user) == 0)) recoveryCodes = (await userManager.GenerateNewTwoFactorRecoveryCodesAsync(user, 10))?.ToArray(); + if (resetRecoveryCodes || (enable == true && await userManager.CountRecoveryCodesAsync(user) == 0)) + { + recoveryCodes = (await userManager.GenerateNewTwoFactorRecoveryCodesAsync(user, 10))?.ToArray(); + } + string? key = await userManager.GetAuthenticatorKeyAsync(user); if (string.IsNullOrWhiteSpace(key)) { await userManager.ResetAuthenticatorKeyAsync(user); key = await userManager.GetAuthenticatorKeyAsync(user); } return new TwoFactorResponse(key, await userManager.CountRecoveryCodesAsync(user), recoveryCodes, await userManager.GetTwoFactorEnabledAsync(user), false); @@ -169,48 +250,81 @@ public async Task GetSetupStatusAsync(CancellationToken can /// Creates the initial system administrator account when setup has not yet been completed. public async Task InitializeSetupAsync(string email, string password, CancellationToken cancellationToken) { - if (await userManager.Users.AsNoTracking().AnyAsync(cancellationToken)) return IdentityResultResponse.Failure(["The system setup has already been completed."]); + if (await userManager.Users.AsNoTracking().AnyAsync(cancellationToken)) + { + return IdentityResultResponse.Failure(["The system setup has already been completed."]); + } + await EnsureRoleAsync(TenantRoles.SysAdmin, cancellationToken); await EnsureRoleAsync(TenantRoles.TenantAdmin, cancellationToken); await EnsureRoleAsync(TenantRoles.TenantOperator, cancellationToken); await EnsureRoleAsync(TenantRoles.TenantAttendant, cancellationToken); - var role = await roleManager.FindByNameAsync(AdministratorRole); + Role? role = await roleManager.FindByNameAsync(AdministratorRole); if (role is null) { role = new Role(AdministratorRole); - var roleResult = await roleManager.CreateAsync(role); - if (!roleResult.Succeeded) return Failure(roleResult); - var claimResult = await roleManager.AddClaimAsync(role, new Claim(IdentityClaimTypes.Permission, AdministratorPermission)); - if (!claimResult.Succeeded) return Failure(claimResult); + IdentityResult roleResult = await roleManager.CreateAsync(role); + if (!roleResult.Succeeded) + { + return Failure(roleResult); + } + + IdentityResult claimResult = await roleManager.AddClaimAsync(role, new Claim(IdentityClaimTypes.Permission, AdministratorPermission)); + if (!claimResult.Succeeded) + { + return Failure(claimResult); + } } var user = new User(email) { Email = email, EmailConfirmed = true }; - var userResult = await userManager.CreateAsync(user, password); - if (!userResult.Succeeded) return Failure(userResult); - var membershipResult = await userManager.AddToRoleAsync(user, TenantRoles.SysAdmin); - if (!membershipResult.Succeeded) return Failure(membershipResult); + IdentityResult userResult = await userManager.CreateAsync(user, password); + if (!userResult.Succeeded) + { + return Failure(userResult); + } + + IdentityResult membershipResult = await userManager.AddToRoleAsync(user, TenantRoles.SysAdmin); + if (!membershipResult.Succeeded) + { + return Failure(membershipResult); + } + membershipResult = await userManager.AddToRoleAsync(user, AdministratorRole); - if (!membershipResult.Succeeded) return Failure(membershipResult); + if (!membershipResult.Succeeded) + { + return Failure(membershipResult); + } + logger.LogInformation("Initial system setup completed for user {UserId}.", user.Id); return IdentityResultResponse.Success(); } private async Task CreateUserTokensAsync(User user, CancellationToken cancellationToken) { - var roles = await userManager.GetRolesAsync(user); - var claims = await userManager.GetClaimsAsync(user); + IList roles = await userManager.GetRolesAsync(user); + IList claims = await userManager.GetClaimsAsync(user); foreach (string roleName in roles) { - var role = await roleManager.FindByNameAsync(roleName); - if (role is not null) claims = claims.Concat(await roleManager.GetClaimsAsync(role)).ToList(); + Role? role = await roleManager.FindByNameAsync(roleName); + if (role is not null) + { + claims = claims.Concat(await roleManager.GetClaimsAsync(role)).ToList(); + } } return tokenService.CreateTokens(user.Id, user.Email ?? user.UserName ?? user.Id, roles, claims); } private async Task EnsureRoleAsync(string roleName, CancellationToken cancellationToken) { - if (await roleManager.RoleExistsAsync(roleName)) return; - var result = await roleManager.CreateAsync(new Role(roleName)); - if (!result.Succeeded) throw new InvalidOperationException(string.Join(" ", result.Errors.Select(x => x.Description))); + if (await roleManager.RoleExistsAsync(roleName)) + { + return; + } + + IdentityResult result = await roleManager.CreateAsync(new Role(roleName)); + if (!result.Succeeded) + { + throw new InvalidOperationException(string.Join(" ", result.Errors.Select(x => x.Description))); + } } private static IdentityResultResponse Failure(IdentityResult result) => IdentityResultResponse.Failure(result.Errors.Select(error => error.Description)); diff --git a/src/server/RemoteTickets.Infrastructure/Identity/Services/JwtTokenService.cs b/src/server/RemoteTickets.Infrastructure/Identity/Services/JwtTokenService.cs index af5ff01..de64d58 100644 --- a/src/server/RemoteTickets.Infrastructure/Identity/Services/JwtTokenService.cs +++ b/src/server/RemoteTickets.Infrastructure/Identity/Services/JwtTokenService.cs @@ -10,17 +10,21 @@ public sealed class JwtTokenService(IOptions options, IRevokedTokenS /// public TokenResponse CreateTokens(string userId, string email, IEnumerable roles, IEnumerable claims) { - var now = DateTimeOffset.UtcNow; - var claimSet = claims.ToArray(); - var access = CreateToken(userId, email, roles, claimSet, JwtTokenTypes.Access, now, _options.AccessTokenLifetime); - var refresh = CreateToken(userId, email, roles, claimSet, JwtTokenTypes.Refresh, now, _options.RefreshTokenLifetime); + DateTimeOffset now = DateTimeOffset.UtcNow; + Claim[] claimSet = claims.ToArray(); + JwtSecurityToken access = CreateToken(userId, email, roles, claimSet, JwtTokenTypes.Access, now, _options.AccessTokenLifetime); + JwtSecurityToken refresh = CreateToken(userId, email, roles, claimSet, JwtTokenTypes.Refresh, now, _options.RefreshTokenLifetime); return new TokenResponse("Bearer", new JwtSecurityTokenHandler().WriteToken(access), (int)_options.AccessTokenLifetime.TotalSeconds, new JwtSecurityTokenHandler().WriteToken(refresh)); } /// public ClaimsPrincipal? ValidateToken(string token, bool validateLifetime = true) { - if (string.IsNullOrWhiteSpace(token)) return null; + if (string.IsNullOrWhiteSpace(token)) + { + return null; + } + var parameters = new TokenValidationParameters { ValidateIssuerSigningKey = true, @@ -34,8 +38,12 @@ public TokenResponse CreateTokens(string userId, string email, IEnumerable public bool IsRevoked(string tokenId) { - if (!_tokens.TryGetValue(tokenId, out var expiresAt)) return false; - if (expiresAt > DateTimeOffset.UtcNow) return true; + if (!_tokens.TryGetValue(tokenId, out DateTimeOffset expiresAt)) + { + return false; + } + + if (expiresAt > DateTimeOffset.UtcNow) + { + return true; + } + _tokens.TryRemove(tokenId, out _); return false; } /// public void Revoke(string tokenId, DateTimeOffset expiresAt) { - if (expiresAt > DateTimeOffset.UtcNow) _tokens[tokenId] = expiresAt; + if (expiresAt > DateTimeOffset.UtcNow) + { + _tokens[tokenId] = expiresAt; + } } } diff --git a/src/server/RemoteTickets.Infrastructure/Persistence/Configurations/Identity/IdentityrConfigurations.cs b/src/server/RemoteTickets.Infrastructure/Persistence/Configurations/Identity/IdentityrConfigurations.cs index c8784e9..adc076a 100644 --- a/src/server/RemoteTickets.Infrastructure/Persistence/Configurations/Identity/IdentityrConfigurations.cs +++ b/src/server/RemoteTickets.Infrastructure/Persistence/Configurations/Identity/IdentityrConfigurations.cs @@ -1,6 +1,8 @@ namespace RemoteTickets.Infrastructure.Persistence.Configurations.Identity; -internal sealed class IdentityrConfigurations : IEntityTypeConfiguration, IEntityTypeConfiguration +internal sealed class IdentityrConfigurations : +IEntityTypeConfiguration, +IEntityTypeConfiguration { public void Configure(EntityTypeBuilder builder) { diff --git a/src/server/RemoteTickets.Infrastructure/Persistence/Configurations/Tenancy/TenancyConfigurations.cs b/src/server/RemoteTickets.Infrastructure/Persistence/Configurations/Tenancy/TenancyConfigurations.cs new file mode 100644 index 0000000..fe59faf --- /dev/null +++ b/src/server/RemoteTickets.Infrastructure/Persistence/Configurations/Tenancy/TenancyConfigurations.cs @@ -0,0 +1,23 @@ +namespace RemoteTickets.Infrastructure.Persistence.Configurations.Tenancy; + +internal sealed class TenancyConfigurations : +IEntityTypeConfiguration, +IEntityTypeConfiguration +{ + public void Configure(EntityTypeBuilder builder) + { + builder.ToTable("Tenants"); + builder.HasKey(x => x.Id); + builder.Property(x => x.Id).HasMaxLength(128); + builder.Property(x => x.Name).HasMaxLength(256).IsRequired(); + builder.Property(x => x.DatabaseName).HasMaxLength(128).IsRequired(); + builder.Property(x => x.ConnectionString).IsRequired(); + builder.HasIndex(x => x.DatabaseName).IsUnique(); + } + + public void Configure(EntityTypeBuilder builder) + { + builder.ToTable("SystemSetupState"); + builder.HasKey(x => x.Id); + } +} diff --git a/src/server/RemoteTickets.Infrastructure/Persistence/InvisibleSPDbContext.cs b/src/server/RemoteTickets.Infrastructure/Persistence/RemoteTicketsDbContext.cs similarity index 65% rename from src/server/RemoteTickets.Infrastructure/Persistence/InvisibleSPDbContext.cs rename to src/server/RemoteTickets.Infrastructure/Persistence/RemoteTicketsDbContext.cs index b439f37..0403c53 100644 --- a/src/server/RemoteTickets.Infrastructure/Persistence/InvisibleSPDbContext.cs +++ b/src/server/RemoteTickets.Infrastructure/Persistence/RemoteTicketsDbContext.cs @@ -1,3 +1,5 @@ +using Microsoft.EntityFrameworkCore.Metadata; + namespace RemoteTickets.Infrastructure.Persistence; /// Represents the central database context for RemoteTickets identity, setup, and tenant catalog data. @@ -12,27 +14,16 @@ public sealed class RemoteTicketsDbContext(DbContextOptions(entity => - { - entity.ToTable("Tenants"); - entity.HasKey(x => x.Id); - entity.Property(x => x.Id).HasMaxLength(128); - entity.Property(x => x.Name).HasMaxLength(256).IsRequired(); - entity.Property(x => x.DatabaseName).HasMaxLength(128).IsRequired(); - entity.Property(x => x.ConnectionString).IsRequired(); - entity.HasIndex(x => x.DatabaseName).IsUnique(); - }); - builder.Entity(entity => - { - entity.ToTable("SystemSetupState"); - entity.HasKey(x => x.Id); - }); - foreach (var entityType in builder.Model.GetEntityTypes()) + foreach (IMutableEntityType entityType in builder.Model.GetEntityTypes()) { - if (!typeof(ISoftDeletable).IsAssignableFrom(entityType.ClrType)) continue; - var parameter = Expression.Parameter(entityType.ClrType, "entity"); - var property = Expression.Property(parameter, nameof(ISoftDeletable.IsDeleted)); - var filter = Expression.Lambda(Expression.Not(property), parameter); + if (!typeof(ISoftDeletable).IsAssignableFrom(entityType.ClrType)) + { + continue; + } + + ParameterExpression parameter = Expression.Parameter(entityType.ClrType, "entity"); + MemberExpression property = Expression.Property(parameter, nameof(ISoftDeletable.IsDeleted)); + LambdaExpression filter = Expression.Lambda(Expression.Not(property), parameter); builder.Entity(entityType.ClrType).HasQueryFilter(filter); } builder.ApplyConfigurationsFromAssembly(typeof(RemoteTicketsDbContext).Assembly); @@ -51,7 +42,11 @@ private void ApplySoftDelete() { foreach (EntityEntry entry in ChangeTracker.Entries()) { - if (entry.State != EntityState.Deleted) continue; + if (entry.State != EntityState.Deleted) + { + continue; + } + entry.State = EntityState.Modified; entry.Entity.IsDeleted = true; entry.Entity.DeletedAt = DateTimeOffset.UtcNow; diff --git a/src/server/RemoteTickets.Infrastructure/Setup/SetupConfigurationStore.cs b/src/server/RemoteTickets.Infrastructure/Setup/SetupConfigurationStore.cs index 344be29..f869714 100644 --- a/src/server/RemoteTickets.Infrastructure/Setup/SetupConfigurationStore.cs +++ b/src/server/RemoteTickets.Infrastructure/Setup/SetupConfigurationStore.cs @@ -24,10 +24,14 @@ public sealed class SetupConfigurationStore : ISetupConfigurationStore /// public string? GetMasterConnectionString() { - if (!File.Exists(_path)) return null; + if (!File.Exists(_path)) + { + return null; + } + try { - var state = JsonSerializer.Deserialize(File.ReadAllText(_path)); + State? state = JsonSerializer.Deserialize(File.ReadAllText(_path)); return state?.MasterConnectionString; } catch (JsonException) @@ -39,7 +43,11 @@ public sealed class SetupConfigurationStore : ISetupConfigurationStore /// public async Task SetMasterConnectionStringAsync(string connectionString, CancellationToken cancellationToken) { - if (string.IsNullOrWhiteSpace(connectionString)) throw new ArgumentException("A master database connection string is required.", nameof(connectionString)); + if (string.IsNullOrWhiteSpace(connectionString)) + { + throw new ArgumentException("A master database connection string is required.", nameof(connectionString)); + } + Directory.CreateDirectory(Path.GetDirectoryName(_path)!); string json = JsonSerializer.Serialize(new State(connectionString)); await File.WriteAllTextAsync(_path, json, cancellationToken); diff --git a/src/server/RemoteTickets.Infrastructure/Tenancy/Configurations/TenancyConfigurations.cs b/src/server/RemoteTickets.Infrastructure/Tenancy/Configurations/TenancyConfigurations.cs index 562fea2..fda3009 100644 --- a/src/server/RemoteTickets.Infrastructure/Tenancy/Configurations/TenancyConfigurations.cs +++ b/src/server/RemoteTickets.Infrastructure/Tenancy/Configurations/TenancyConfigurations.cs @@ -9,4 +9,5 @@ public void Configure(EntityTypeBuilder builder) builder.Property(x => x.IsComplete).IsRequired(); } + } diff --git a/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs b/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs index 66a4500..4cd67d7 100644 --- a/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs +++ b/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs @@ -9,9 +9,9 @@ public sealed class TenantAccessMiddleware(RequestDelegate next, ITenantManageme public async Task InvokeAsync(HttpContext context) { if (IsInfrastructurePath(context.Request.Path)) { await next(context); return; } - var endpoint = context.GetEndpoint(); + Endpoint? endpoint = context.GetEndpoint(); bool anonymous = endpoint?.Metadata.GetMetadata() is not null; - var setupState = await masterDb.SystemSetup.AsNoTracking().SingleOrDefaultAsync(x => x.Id == 1, context.RequestAborted); + SystemSetupState? setupState = await masterDb.SystemSetup.AsNoTracking().SingleOrDefaultAsync(x => x.Id == 1, context.RequestAborted); bool systemSetupRequired = setupState is null || !setupState.IsComplete; if (systemSetupRequired) { @@ -27,7 +27,15 @@ public async Task InvokeAsync(HttpContext context) } if (!context.Request.RouteValues.TryGetValue("tenantId", out object? value) || string.IsNullOrWhiteSpace(value?.ToString())) { - if (anonymous) await next(context); else await RejectOrRedirectAsync(context, "/setup", StatusCodes.Status503ServiceUnavailable); + if (anonymous) + { + await next(context); + } + else + { + await RejectOrRedirectAsync(context, "/setup", StatusCodes.Status503ServiceUnavailable); + } + return; } string tenantId = value.ToString()!; @@ -37,7 +45,7 @@ public async Task InvokeAsync(HttpContext context) await next(context); return; } - var tenant = await tenants.GetAsync(tenantId, context.RequestAborted); + TenantResponse? tenant = await tenants.GetAsync(tenantId, context.RequestAborted); if (tenant is null || !tenant.IsActive) { await RejectOrRedirectAsync(context, "/not-found", StatusCodes.Status404NotFound); return; } if (anonymous) { @@ -61,7 +69,11 @@ public async Task InvokeAsync(HttpContext context) private static bool IsTenantSetupEndpoint(HttpContext context) { string? tenantId = context.Request.RouteValues.TryGetValue("tenantId", out object? value) ? value?.ToString() : null; - if (string.IsNullOrWhiteSpace(tenantId)) return false; + if (string.IsNullOrWhiteSpace(tenantId)) + { + return false; + } + string? path = context.Request.Path.Value; return string.Equals(path, $"/{tenantId}/setup", StringComparison.OrdinalIgnoreCase) || string.Equals(path, $"/api/v1/{tenantId}/setup", StringComparison.OrdinalIgnoreCase) || string.Equals(path, $"/api/v1/{tenantId}/setup/complete", StringComparison.OrdinalIgnoreCase); } diff --git a/src/server/RemoteTickets.Infrastructure/Tenancy/TenantManagementService.cs b/src/server/RemoteTickets.Infrastructure/Tenancy/TenantManagementService.cs index 6e29cb2..0a1ef56 100644 --- a/src/server/RemoteTickets.Infrastructure/Tenancy/TenantManagementService.cs +++ b/src/server/RemoteTickets.Infrastructure/Tenancy/TenantManagementService.cs @@ -9,7 +9,7 @@ public sealed class TenantManagementService( /// public async Task GetAsync(string tenantId, CancellationToken cancellationToken) { - var tenant = await catalog.Tenants.AsNoTracking().SingleOrDefaultAsync(x => x.Id == tenantId, cancellationToken); + Tenant? tenant = await catalog.Tenants.AsNoTracking().SingleOrDefaultAsync(x => x.Id == tenantId, cancellationToken); return tenant is null ? null : Map(tenant); } @@ -38,7 +38,7 @@ public async Task CreateAsync(CreateTenantRequest request, Cance catalog.Tenants.Add(tenant); await catalog.SaveChangesAsync(cancellationToken); - var adminResult = await identityService.CreateTenantAdminAsync(request.Id, request.AdminEmail, request.AdminPassword, cancellationToken); + IdentityResultResponse adminResult = await identityService.CreateTenantAdminAsync(request.Id, request.AdminEmail, request.AdminPassword, cancellationToken); if (!adminResult.Succeeded) { catalog.Tenants.Remove(tenant); @@ -53,20 +53,20 @@ public async Task CreateAsync(CreateTenantRequest request, Cance /// public async Task GetSetupStatusAsync(string tenantId, CancellationToken cancellationToken) { - var tenant = await GetTenantEntityAsync(tenantId, cancellationToken); - await using var context = CreateSetupContext(tenant.ConnectionString); + Tenant tenant = await GetTenantEntityAsync(tenantId, cancellationToken); + await using TenantSetupDbContext context = CreateSetupContext(tenant.ConnectionString); await context.Database.EnsureCreatedAsync(cancellationToken); - var state = await context.SetupStates.SingleOrDefaultAsync(x => x.Id == 1, cancellationToken); + TenantSetupState? state = await context.SetupStates.SingleOrDefaultAsync(x => x.Id == 1, cancellationToken); return new TenantSetupStatusResponse(state is null || !state.IsComplete, state?.IsComplete == true); } /// public async Task CompleteSetupAsync(string tenantId, CancellationToken cancellationToken) { - var tenant = await GetTenantEntityAsync(tenantId, cancellationToken); - await using var context = CreateSetupContext(tenant.ConnectionString); + Tenant tenant = await GetTenantEntityAsync(tenantId, cancellationToken); + await using TenantSetupDbContext context = CreateSetupContext(tenant.ConnectionString); await context.Database.EnsureCreatedAsync(cancellationToken); - var state = await context.SetupStates.SingleOrDefaultAsync(x => x.Id == 1, cancellationToken); + TenantSetupState? state = await context.SetupStates.SingleOrDefaultAsync(x => x.Id == 1, cancellationToken); if (state is null) { state = new TenantSetupState { Id = 1 }; @@ -90,7 +90,7 @@ private async Task GetTenantEntityAsync(string tenantId, CancellationTok private static TenantSetupDbContext CreateSetupContext(string connectionString) { - var options = new DbContextOptionsBuilder() + DbContextOptions options = new DbContextOptionsBuilder() .UseSqlServer(connectionString) .Options; return new TenantSetupDbContext(options); @@ -103,7 +103,7 @@ private static async Task CreateDatabaseAsync(string connectionString, string da await using var connection = new SqlConnection(builder.ConnectionString); await connection.OpenAsync(cancellationToken); string escaped = $"[{databaseName.Replace("]", "]]", StringComparison.Ordinal)}]"; - await using var command = connection.CreateCommand(); + await using SqlCommand command = connection.CreateCommand(); command.CommandText = $"IF DB_ID(@databaseName) IS NULL CREATE DATABASE {escaped};"; command.Parameters.AddWithValue("@databaseName", databaseName); await command.ExecuteNonQueryAsync(cancellationToken); @@ -111,7 +111,7 @@ private static async Task CreateDatabaseAsync(string connectionString, string da private static async Task InitializeTenantDatabaseAsync(string connectionString, CancellationToken cancellationToken) { - await using var context = CreateSetupContext(connectionString); + await using TenantSetupDbContext context = CreateSetupContext(connectionString); // The repository currently has no EF migration history. EnsureCreated creates the foundation schema; // the same tenant connection is used by the future migration runner when migrations are introduced. await context.Database.MigrateAsync(cancellationToken); diff --git a/src/server/RemoteTickets/Controllers/IdentityController.cs b/src/server/RemoteTickets/Controllers/IdentityController.cs index 255153c..76e4ea6 100644 --- a/src/server/RemoteTickets/Controllers/IdentityController.cs +++ b/src/server/RemoteTickets/Controllers/IdentityController.cs @@ -11,7 +11,7 @@ public sealed class IdentityController(IMediator mediator) : ControllerBase [AllowAnonymous] public async Task Register([FromRoute] string tenantId, RegisterRequest request, CancellationToken cancellationToken) { - var result = await mediator.RequestAsync(new RegisterCommand(request.Email, request.Password), cancellationToken); + IdentityResultResponse result = await mediator.RequestAsync(new RegisterCommand(request.Email, request.Password), cancellationToken); return result.Succeeded ? Ok() : BadRequest(result); } /// Authenticates a user against the requested tenant. @@ -19,7 +19,7 @@ public async Task Register([FromRoute] string tenantId, RegisterR [AllowAnonymous] public async Task Login([FromRoute] string tenantId, LoginRequest request, CancellationToken cancellationToken) { - var result = await mediator.RequestAsync>(new LoginCommand(request.Email, request.Password, request.TwoFactorCode, request.TwoFactorRecoveryCode, tenantId), cancellationToken); + Response result = await mediator.RequestAsync>(new LoginCommand(request.Email, request.Password, request.TwoFactorCode, request.TwoFactorRecoveryCode, tenantId), cancellationToken); return result.Succeeded ? Ok(result.Data) : Unauthorized(result); } /// Exchanges a refresh token for a new token pair in the requested tenant context. @@ -27,7 +27,7 @@ public async Task Login([FromRoute] string tenantId, LoginRequest [AllowAnonymous] public async Task Refresh([FromRoute] string tenantId, RefreshRequest request, CancellationToken cancellationToken) { - var result = await mediator.RequestAsync>(new RefreshTokenCommand(request.RefreshToken, tenantId), cancellationToken); + Response result = await mediator.RequestAsync>(new RefreshTokenCommand(request.RefreshToken, tenantId), cancellationToken); return result.Succeeded ? Ok(result.Data) : Unauthorized(result); } /// Revokes the access token supplied by the authenticated caller. @@ -36,7 +36,7 @@ public async Task Refresh([FromRoute] string tenantId, RefreshReq public async Task Revoke(CancellationToken cancellationToken) { string accessToken = Request.Headers.Authorization.ToString().Replace("Bearer ", string.Empty, StringComparison.OrdinalIgnoreCase); - var result = await mediator.RequestAsync>(new RevokeTokenCommand(accessToken), cancellationToken); + Response result = await mediator.RequestAsync>(new RevokeTokenCommand(accessToken), cancellationToken); return result.Data == true ? Ok() : Unauthorized(result); } /// Confirms a user's email address. @@ -44,7 +44,7 @@ public async Task Revoke(CancellationToken cancellationToken) [AllowAnonymous] public async Task ConfirmEmail([FromQuery] string userId, [FromQuery] string code, [FromQuery] string? changedEmail, CancellationToken cancellationToken) { - var result = await mediator.RequestAsync>(new ConfirmEmailCommand(userId, code, changedEmail), cancellationToken); + Response result = await mediator.RequestAsync>(new ConfirmEmailCommand(userId, code, changedEmail), cancellationToken); return result.Data == true ? Ok("Thank you for confirming your email.") : BadRequest(result); } /// Resends a user's email confirmation link. @@ -52,7 +52,7 @@ public async Task ConfirmEmail([FromQuery] string userId, [FromQu [AllowAnonymous] public async Task ResendConfirmationEmail(EmailRequest request, CancellationToken cancellationToken) { - var result = await mediator.RequestAsync(new ResendConfirmationEmailCommand(request.Email), cancellationToken); + IdentityResultResponse result = await mediator.RequestAsync(new ResendConfirmationEmailCommand(request.Email), cancellationToken); return result.Succeeded ? Ok() : BadRequest(result); } /// Starts password recovery for an email address. @@ -60,7 +60,7 @@ public async Task ResendConfirmationEmail(EmailRequest request, C [AllowAnonymous] public async Task ForgotPassword(EmailRequest request, CancellationToken cancellationToken) { - var result = await mediator.RequestAsync(new ForgotPasswordCommand(request.Email), cancellationToken); + IdentityResultResponse result = await mediator.RequestAsync(new ForgotPasswordCommand(request.Email), cancellationToken); return result.Succeeded ? Ok() : BadRequest(result); } /// Resets a user's password using a reset token. @@ -68,7 +68,7 @@ public async Task ForgotPassword(EmailRequest request, Cancellati [AllowAnonymous] public async Task ResetPassword(ResetPasswordRequest request, CancellationToken cancellationToken) { - var result = await mediator.RequestAsync(new ResetPasswordCommand(request.Email, request.ResetCode, request.NewPassword), cancellationToken); + IdentityResultResponse result = await mediator.RequestAsync(new ResetPasswordCommand(request.Email, request.ResetCode, request.NewPassword), cancellationToken); return result.Succeeded ? Ok() : BadRequest(result); } /// Gets identity information for the authenticated user. @@ -77,8 +77,12 @@ public async Task ResetPassword(ResetPasswordRequest request, Can public async Task GetInfo(CancellationToken cancellationToken) { string? userId = GetUserId(); - if (userId is null) return Unauthorized(); - var result = await mediator.RequestAsync>(new GetIdentityInfoQuery(userId), cancellationToken); + if (userId is null) + { + return Unauthorized(); + } + + Response result = await mediator.RequestAsync>(new GetIdentityInfoQuery(userId), cancellationToken); return result.Succeeded ? Ok(result.Data) : NotFound(result); } /// Updates identity information for the authenticated user. @@ -87,8 +91,12 @@ public async Task GetInfo(CancellationToken cancellationToken) public async Task UpdateInfo(InfoRequest request, CancellationToken cancellationToken) { string? userId = GetUserId(); - if (userId is null) return Unauthorized(); - var result = await mediator.RequestAsync(new UpdateIdentityInfoCommand(userId, request.NewEmail, request.NewPassword, request.OldPassword), cancellationToken); + if (userId is null) + { + return Unauthorized(); + } + + IdentityResultResponse result = await mediator.RequestAsync(new UpdateIdentityInfoCommand(userId, request.NewEmail, request.NewPassword, request.OldPassword), cancellationToken); return result.Succeeded ? Ok() : BadRequest(result); } /// Configures authenticator-based two-factor authentication for the authenticated user. @@ -97,8 +105,12 @@ public async Task UpdateInfo(InfoRequest request, CancellationTok public async Task ConfigureTwoFactor(TwoFactorRequest request, CancellationToken cancellationToken) { string? userId = GetUserId(); - if (userId is null) return Unauthorized(); - var result = await mediator.RequestAsync>(new ConfigureTwoFactorCommand(userId, request.Enable, request.TwoFactorCode, request.ResetRecoveryCodes, request.ResetSharedKey, request.ForgetMachine), cancellationToken); + if (userId is null) + { + return Unauthorized(); + } + + Response result = await mediator.RequestAsync>(new ConfigureTwoFactorCommand(userId, request.Enable, request.TwoFactorCode, request.ResetRecoveryCodes, request.ResetSharedKey, request.ForgetMachine), cancellationToken); return result.Succeeded ? Ok(result.Data) : BadRequest(result); } private string? GetUserId() => User.FindFirstValue(JwtRegisteredClaimNames.Sub) ?? User.FindFirstValue(ClaimTypes.NameIdentifier); diff --git a/src/server/RemoteTickets/Controllers/SetupController.cs b/src/server/RemoteTickets/Controllers/SetupController.cs index 5d20ae5..b61688c 100644 --- a/src/server/RemoteTickets/Controllers/SetupController.cs +++ b/src/server/RemoteTickets/Controllers/SetupController.cs @@ -17,9 +17,13 @@ public sealed class SetupController(IMediator mediator, ISetupConfigurationStore [AllowAnonymous] public async Task ConfigureMasterDatabase(MasterDatabaseSetupRequest request, CancellationToken cancellationToken) { - if (string.IsNullOrWhiteSpace(request.ConnectionString)) return BadRequest(new { error = "A master database connection string is required." }); + if (string.IsNullOrWhiteSpace(request.ConnectionString)) + { + return BadRequest(new { error = "A master database connection string is required." }); + } + await configurationStore.SetMasterConnectionStringAsync(request.ConnectionString, cancellationToken); - var options = new DbContextOptionsBuilder().UseSqlServer(request.ConnectionString).Options; + DbContextOptions options = new DbContextOptionsBuilder().UseSqlServer(request.ConnectionString).Options; await using var dbContext = new RemoteTicketsDbContext(options); await dbContext.Database.EnsureCreatedAsync(cancellationToken); return Ok(); @@ -30,15 +34,18 @@ public async Task ConfigureMasterDatabase(MasterDatabaseSetupRequ [AllowAnonymous] public async Task Initialize(InitializeSetupRequest request, CancellationToken cancellationToken) { - var result = await mediator.RequestAsync(new InitializeSetupCommand(request.Email, request.Password), cancellationToken); - if (!result.Succeeded) return Conflict(result); + IdentityResultResponse result = await mediator.RequestAsync(new InitializeSetupCommand(request.Email, request.Password), cancellationToken); + if (!result.Succeeded) + { + return Conflict(result); + } string? connectionString = configurationStore.GetMasterConnectionString(); if (!string.IsNullOrWhiteSpace(connectionString)) { - var options = new DbContextOptionsBuilder().UseSqlServer(connectionString).Options; + DbContextOptions options = new DbContextOptionsBuilder().UseSqlServer(connectionString).Options; await using var dbContext = new RemoteTicketsDbContext(options); - var state = await dbContext.SystemSetup.SingleOrDefaultAsync(x => x.Id == 1, cancellationToken); + SystemSetupState? state = await dbContext.SystemSetup.SingleOrDefaultAsync(x => x.Id == 1, cancellationToken); if (state is null) { state = new SystemSetupState { Id = 1 }; diff --git a/src/server/RemoteTickets/Controllers/TenantController.cs b/src/server/RemoteTickets/Controllers/TenantController.cs index d37f888..4a8e6a6 100644 --- a/src/server/RemoteTickets/Controllers/TenantController.cs +++ b/src/server/RemoteTickets/Controllers/TenantController.cs @@ -16,7 +16,7 @@ public async Task Create(CreateTenantRequest request, Cancellatio { try { - var tenant = await tenants.CreateAsync(request, cancellationToken); + TenantResponse tenant = await tenants.CreateAsync(request, cancellationToken); return Created($"/api/v1/{tenant.Id}/setup", tenant); } catch (ArgumentException exception) @@ -36,7 +36,7 @@ public async Task Create(CreateTenantRequest request, Cancellatio [HttpGet("{tenantId}")] public async Task Get(string tenantId, CancellationToken cancellationToken) { - var tenant = await tenants.GetAsync(tenantId, cancellationToken); + TenantResponse? tenant = await tenants.GetAsync(tenantId, cancellationToken); return tenant is null ? NotFound() : Ok(tenant); } } diff --git a/src/server/RemoteTickets/Controllers/TenantSetupController.cs b/src/server/RemoteTickets/Controllers/TenantSetupController.cs index f9d6bd2..8dc12b3 100644 --- a/src/server/RemoteTickets/Controllers/TenantSetupController.cs +++ b/src/server/RemoteTickets/Controllers/TenantSetupController.cs @@ -22,7 +22,7 @@ public sealed class TenantSetupController(ITenantManagementService tenants) : Co [Authorize(Policy = TenantPolicies.TenantAdmin)] public async Task Complete(string tenantId, CancellationToken cancellationToken) { - var result = await tenants.CompleteSetupAsync(tenantId, cancellationToken); + TenantSetupStatusResponse result = await tenants.CompleteSetupAsync(tenantId, cancellationToken); return Ok(result); } } diff --git a/tests/server/RemoteTickets.UnitTests/IdentityBranchTests.cs b/tests/server/RemoteTickets.UnitTests/IdentityBranchTests.cs index ae927a8..69dc686 100644 --- a/tests/server/RemoteTickets.UnitTests/IdentityBranchTests.cs +++ b/tests/server/RemoteTickets.UnitTests/IdentityBranchTests.cs @@ -12,10 +12,10 @@ public sealed class IdentityBranchTests [Fact] public async Task Register_should_return_identity_errors_for_duplicate_email() { - await using var fixture = await IdentityFixture.CreateAsync(); + await using IdentityFixture fixture = await IdentityFixture.CreateAsync(); (await fixture.Service.RegisterAsync("user@example.com", "Password1!", CancellationToken.None)).Succeeded.Should().BeTrue(); - var result = await fixture.Service.RegisterAsync("user@example.com", "Password1!", CancellationToken.None); + IdentityResultResponse result = await fixture.Service.RegisterAsync("user@example.com", "Password1!", CancellationToken.None); result.Succeeded.Should().BeFalse(); result.Errors.Should().NotBeEmpty(); @@ -28,7 +28,7 @@ public async Task Register_should_return_identity_errors_for_duplicate_email() [Fact] public async Task Login_should_reject_bad_password_and_unconfirmed_user() { - await using var fixture = await IdentityFixture.CreateAsync(); + await using IdentityFixture fixture = await IdentityFixture.CreateAsync(); await fixture.Service.RegisterAsync("user@example.com", "Password1!", CancellationToken.None); (await fixture.Service.LoginAsync("user@example.com", "WrongPassword1!", null, null, CancellationToken.None)).Should().BeNull(); @@ -42,12 +42,12 @@ public async Task Login_should_reject_bad_password_and_unconfirmed_user() [Fact] public async Task Login_should_reject_invalid_two_factor_code_and_recovery_code() { - await using var fixture = await IdentityFixture.CreateAsync(); + await using IdentityFixture fixture = await IdentityFixture.CreateAsync(); await fixture.Service.InitializeSetupAsync("admin@example.com", "Password1!", CancellationToken.None); - var user = await fixture.UserManager.FindByEmailAsync("admin@example.com"); + User? user = await fixture.UserManager.FindByEmailAsync("admin@example.com"); user.Should().NotBeNull(); - var twoFactorSetup = await fixture.Service.ConfigureTwoFactorAsync( + TwoFactorResponse? twoFactorSetup = await fixture.Service.ConfigureTwoFactorAsync( user!.Id, null, null, @@ -62,7 +62,7 @@ public async Task Login_should_reject_invalid_two_factor_code_and_recovery_code( string setupCode = GenerateTotp(twoFactorSetup.SharedKey!); setupCode.Should().NotBeNullOrWhiteSpace(); - var configured = await fixture.Service.ConfigureTwoFactorAsync( + TwoFactorResponse? configured = await fixture.Service.ConfigureTwoFactorAsync( user.Id, true, setupCode, @@ -84,11 +84,11 @@ public async Task Login_should_reject_invalid_two_factor_code_and_recovery_code( [Fact] public async Task Refresh_should_reject_access_tokens_empty_subjects_and_unknown_users() { - await using var fixture = await IdentityFixture.CreateAsync(); + await using IdentityFixture fixture = await IdentityFixture.CreateAsync(); await fixture.Service.InitializeSetupAsync("admin@example.com", "Password1!", CancellationToken.None); - var user = await fixture.UserManager.FindByEmailAsync("admin@example.com"); + User? user = await fixture.UserManager.FindByEmailAsync("admin@example.com"); user.Should().NotBeNull(); - var access = await fixture.Service.LoginAsync("admin@example.com", "Password1!", null, null, CancellationToken.None); + TokenResponse? access = await fixture.Service.LoginAsync("admin@example.com", "Password1!", null, null, CancellationToken.None); access.Should().NotBeNull(); (await fixture.Service.RefreshAsync(access!.AccessToken, CancellationToken.None)).Should().BeNull(); @@ -106,7 +106,7 @@ public async Task Refresh_should_reject_access_tokens_empty_subjects_and_unknown [Fact] public async Task Confirm_email_should_support_changed_email_and_reject_invalid_code() { - await using var fixture = await IdentityFixture.CreateAsync(); + await using IdentityFixture fixture = await IdentityFixture.CreateAsync(); await fixture.Service.RegisterAsync("old@example.com", "Password1!", CancellationToken.None); string link = fixture.EmailSender.ConfirmationLinks.Single(); var query = new Uri("https://localhost" + link).Query.TrimStart('?') @@ -114,7 +114,7 @@ public async Task Confirm_email_should_support_changed_email_and_reject_invalid_ .Select(part => part.Split('=', 2)) .ToDictionary(part => part[0], part => Uri.UnescapeDataString(part[1])); - var user = await fixture.UserManager.FindByIdAsync(query["userId"]); + User? user = await fixture.UserManager.FindByIdAsync(query["userId"]); user.Should().NotBeNull(); string changeCode = await fixture.UserManager.GenerateChangeEmailTokenAsync(user!, "new@example.com"); (await fixture.Service.ConfirmEmailAsync(user!.Id, changeCode, "new@example.com", CancellationToken.None)).Should().BeTrue(); @@ -128,7 +128,7 @@ public async Task Confirm_email_should_support_changed_email_and_reject_invalid_ [Fact] public async Task Forgot_password_should_not_send_for_a_user_without_password() { - await using var fixture = await IdentityFixture.CreateAsync(); + await using IdentityFixture fixture = await IdentityFixture.CreateAsync(); var user = new User("external@example.com") { Email = "external@example.com", EmailConfirmed = true }; (await fixture.UserManager.CreateAsync(user)).Succeeded.Should().BeTrue(); @@ -143,10 +143,10 @@ public async Task Forgot_password_should_not_send_for_a_user_without_password() [Fact] public async Task Reset_password_should_report_invalid_token_for_existing_user() { - await using var fixture = await IdentityFixture.CreateAsync(); + await using IdentityFixture fixture = await IdentityFixture.CreateAsync(); await fixture.Service.InitializeSetupAsync("admin@example.com", "Password1!", CancellationToken.None); - var result = await fixture.Service.ResetPasswordAsync("admin@example.com", "invalid", "Password2!", CancellationToken.None); + IdentityResultResponse result = await fixture.Service.ResetPasswordAsync("admin@example.com", "invalid", "Password2!", CancellationToken.None); result.Succeeded.Should().BeFalse(); result.Errors.Should().NotBeEmpty(); @@ -159,9 +159,9 @@ public async Task Reset_password_should_report_invalid_token_for_existing_user() [Fact] public async Task Update_info_should_cover_missing_user_wrong_password_and_no_changes() { - await using var fixture = await IdentityFixture.CreateAsync(); + await using IdentityFixture fixture = await IdentityFixture.CreateAsync(); await fixture.Service.InitializeSetupAsync("admin@example.com", "Password1!", CancellationToken.None); - var user = await fixture.UserManager.FindByEmailAsync("admin@example.com"); + User? user = await fixture.UserManager.FindByEmailAsync("admin@example.com"); user.Should().NotBeNull(); (await fixture.Service.UpdateInfoAsync("missing", null, null, "Password1!", CancellationToken.None)).Succeeded.Should().BeFalse(); @@ -176,14 +176,14 @@ public async Task Update_info_should_cover_missing_user_wrong_password_and_no_ch [Fact] public async Task Setup_should_accept_an_existing_administrator_role_and_reject_invalid_password() { - await using var fixture = await IdentityFixture.CreateAsync(); + await using IdentityFixture fixture = await IdentityFixture.CreateAsync(); var role = new Role("Administrator"); (await fixture.RoleManager.CreateAsync(role)).Succeeded.Should().BeTrue(); - var invalid = await fixture.Service.InitializeSetupAsync("admin@example.com", "weak", CancellationToken.None); + IdentityResultResponse invalid = await fixture.Service.InitializeSetupAsync("admin@example.com", "weak", CancellationToken.None); invalid.Succeeded.Should().BeFalse(); - var valid = await fixture.Service.InitializeSetupAsync("admin@example.com", "Password1!", CancellationToken.None); + IdentityResultResponse valid = await fixture.Service.InitializeSetupAsync("admin@example.com", "Password1!", CancellationToken.None); valid.Succeeded.Should().BeTrue(); } @@ -194,7 +194,7 @@ public async Task Setup_should_accept_an_existing_administrator_role_and_reject_ [Fact] public async Task Logging_email_sender_should_complete_both_messages() { - using var provider = new ServiceCollection().AddLogging().BuildServiceProvider(); + using ServiceProvider provider = new ServiceCollection().AddLogging().BuildServiceProvider(); var sender = new LoggingIdentityEmailSender(provider.GetRequiredService>()); await sender.SendConfirmationAsync("user@example.com", "/confirm", CancellationToken.None); diff --git a/tests/server/RemoteTickets.UnitTests/IdentityFailurePathTests.cs b/tests/server/RemoteTickets.UnitTests/IdentityFailurePathTests.cs index 4fee750..b78e72b 100644 --- a/tests/server/RemoteTickets.UnitTests/IdentityFailurePathTests.cs +++ b/tests/server/RemoteTickets.UnitTests/IdentityFailurePathTests.cs @@ -8,7 +8,7 @@ public sealed class IdentityFailurePathTests [Fact] public async Task Identity_service_should_fail_safely_for_invalid_credentials_and_tokens() { - await using var fixture = await IdentityFixture.CreateAsync(); + await using IdentityFixture fixture = await IdentityFixture.CreateAsync(); (await fixture.Service.LoginAsync("missing@example.com", "Password1!", null, null, CancellationToken.None)).Should().BeNull(); (await fixture.Service.RefreshAsync("not-a-token", CancellationToken.None)).Should().BeNull(); @@ -23,7 +23,7 @@ public async Task Identity_service_should_fail_safely_for_invalid_credentials_an [Fact] public async Task Resend_confirmation_should_be_idempotent_for_unknown_or_confirmed_users() { - await using var fixture = await IdentityFixture.CreateAsync(); + await using IdentityFixture fixture = await IdentityFixture.CreateAsync(); (await fixture.Service.ResendConfirmationEmailAsync("missing@example.com", CancellationToken.None)).Succeeded.Should().BeTrue(); await fixture.Service.InitializeSetupAsync("admin@example.com", "Password1!", CancellationToken.None); diff --git a/tests/server/RemoteTickets.UnitTests/IdentityServiceTests.cs b/tests/server/RemoteTickets.UnitTests/IdentityServiceTests.cs index e2dc6ef..2287e97 100644 --- a/tests/server/RemoteTickets.UnitTests/IdentityServiceTests.cs +++ b/tests/server/RemoteTickets.UnitTests/IdentityServiceTests.cs @@ -8,25 +8,25 @@ public sealed class IdentityServiceTests [Fact] public async Task Setup_should_create_administrator_and_issue_revocable_tokens() { - await using var fixture = await IdentityFixture.CreateAsync(); - var service = fixture.Service; - var before = await service.GetSetupStatusAsync(CancellationToken.None); + await using IdentityFixture fixture = await IdentityFixture.CreateAsync(); + IdentityService service = fixture.Service; + SetupStatusResponse before = await service.GetSetupStatusAsync(CancellationToken.None); before.IsSetupRequired.Should().BeTrue(); before.IsSetupComplete.Should().BeFalse(); - var setup = await service.InitializeSetupAsync("admin@example.com", "Password1!", CancellationToken.None); + IdentityResultResponse setup = await service.InitializeSetupAsync("admin@example.com", "Password1!", CancellationToken.None); setup.Succeeded.Should().BeTrue(); - var after = await service.GetSetupStatusAsync(CancellationToken.None); + SetupStatusResponse after = await service.GetSetupStatusAsync(CancellationToken.None); after.IsSetupRequired.Should().BeFalse(); after.IsSetupComplete.Should().BeTrue(); - var duplicate = await service.InitializeSetupAsync("second@example.com", "Password1!", CancellationToken.None); + IdentityResultResponse duplicate = await service.InitializeSetupAsync("second@example.com", "Password1!", CancellationToken.None); duplicate.Succeeded.Should().BeFalse(); - var tokens = await service.LoginAsync("admin@example.com", "Password1!", null, null, CancellationToken.None); + TokenResponse? tokens = await service.LoginAsync("admin@example.com", "Password1!", null, null, CancellationToken.None); tokens.Should().NotBeNull(); - var principal = fixture.TokenService.ValidateToken(tokens!.AccessToken); + ClaimsPrincipal? principal = fixture.TokenService.ValidateToken(tokens!.AccessToken); principal.Should().NotBeNull(); principal!.FindAll(ClaimTypes.Role).Select(x => x.Value).Should().Contain("Administrator"); principal.FindAll(IdentityClaimTypes.Permission).Select(x => x.Value).Should().Contain("system.admin"); - var refreshed = await service.RefreshAsync(tokens.RefreshToken, CancellationToken.None); + TokenResponse? refreshed = await service.RefreshAsync(tokens.RefreshToken, CancellationToken.None); refreshed.Should().NotBeNull(); fixture.TokenService.ValidateToken(tokens.RefreshToken).Should().BeNull(); bool revoked = await service.RevokeAsync(refreshed!.AccessToken, CancellationToken.None); @@ -39,23 +39,23 @@ public async Task Setup_should_create_administrator_and_issue_revocable_tokens() [Fact] public async Task Registration_confirmation_and_password_reset_should_work() { - await using var fixture = await IdentityFixture.CreateAsync(); - var registration = await fixture.Service.RegisterAsync("user@example.com", "Password1!", CancellationToken.None); + await using IdentityFixture fixture = await IdentityFixture.CreateAsync(); + IdentityResultResponse registration = await fixture.Service.RegisterAsync("user@example.com", "Password1!", CancellationToken.None); registration.Succeeded.Should().BeTrue(); fixture.EmailSender.ConfirmationLinks.Should().ContainSingle(); - var confirmationQuery = ParseQuery(fixture.EmailSender.ConfirmationLinks.Single()); + Dictionary confirmationQuery = ParseQuery(fixture.EmailSender.ConfirmationLinks.Single()); bool confirmed = await fixture.Service.ConfirmEmailAsync(confirmationQuery["userId"], confirmationQuery["code"], null, CancellationToken.None); confirmed.Should().BeTrue(); - var info = await fixture.Service.GetInfoAsync(confirmationQuery["userId"], CancellationToken.None); + IdentityInfoResponse? info = await fixture.Service.GetInfoAsync(confirmationQuery["userId"], CancellationToken.None); info.Should().NotBeNull(); info!.IsEmailConfirmed.Should().BeTrue(); - var forgot = await fixture.Service.ForgotPasswordAsync("user@example.com", CancellationToken.None); + IdentityResultResponse forgot = await fixture.Service.ForgotPasswordAsync("user@example.com", CancellationToken.None); forgot.Succeeded.Should().BeTrue(); fixture.EmailSender.PasswordResetLinks.Should().ContainSingle(); - var resetQuery = ParseQuery(fixture.EmailSender.PasswordResetLinks.Single()); - var reset = await fixture.Service.ResetPasswordAsync("user@example.com", resetQuery["code"], "Password2!", CancellationToken.None); + Dictionary resetQuery = ParseQuery(fixture.EmailSender.PasswordResetLinks.Single()); + IdentityResultResponse reset = await fixture.Service.ResetPasswordAsync("user@example.com", resetQuery["code"], "Password2!", CancellationToken.None); reset.Succeeded.Should().BeTrue(); - var login = await fixture.Service.LoginAsync("user@example.com", "Password2!", null, null, CancellationToken.None); + TokenResponse? login = await fixture.Service.LoginAsync("user@example.com", "Password2!", null, null, CancellationToken.None); login.Should().NotBeNull(); } @@ -64,13 +64,13 @@ public async Task Registration_confirmation_and_password_reset_should_work() [Fact] public async Task Update_info_should_change_email_and_password_after_current_password_validation() { - await using var fixture = await IdentityFixture.CreateAsync(); + await using IdentityFixture fixture = await IdentityFixture.CreateAsync(); await fixture.Service.InitializeSetupAsync("admin@example.com", "Password1!", CancellationToken.None); - var user = await fixture.UserManager.FindByEmailAsync("admin@example.com"); + User? user = await fixture.UserManager.FindByEmailAsync("admin@example.com"); user.Should().NotBeNull(); - var result = await fixture.Service.UpdateInfoAsync(user!.Id, "new-admin@example.com", "Password2!", "Password1!", CancellationToken.None); + IdentityResultResponse result = await fixture.Service.UpdateInfoAsync(user!.Id, "new-admin@example.com", "Password2!", "Password1!", CancellationToken.None); result.Succeeded.Should().BeTrue(); - var login = await fixture.Service.LoginAsync("new-admin@example.com", "Password2!", null, null, CancellationToken.None); + TokenResponse? login = await fixture.Service.LoginAsync("new-admin@example.com", "Password2!", null, null, CancellationToken.None); login.Should().NotBeNull(); } @@ -134,7 +134,7 @@ public static async Task CreateAsync() services.AddScoped(); services.AddSingleton(emailSender); services.AddScoped(); - var provider = services.BuildServiceProvider(); + ServiceProvider provider = services.BuildServiceProvider(); await provider.GetRequiredService().Database.EnsureCreatedAsync(); return new IdentityFixture(provider, emailSender); } diff --git a/tests/server/RemoteTickets.UnitTests/IdentityTwoFactorTests.cs b/tests/server/RemoteTickets.UnitTests/IdentityTwoFactorTests.cs index 54d7c19..d23c717 100644 --- a/tests/server/RemoteTickets.UnitTests/IdentityTwoFactorTests.cs +++ b/tests/server/RemoteTickets.UnitTests/IdentityTwoFactorTests.cs @@ -8,10 +8,10 @@ public sealed class IdentityTwoFactorTests [Fact] public async Task Two_factor_should_be_configurable_and_used_during_login() { - await using var fixture = await IdentityFixture.CreateAsync(); + await using IdentityFixture fixture = await IdentityFixture.CreateAsync(); await fixture.Service.InitializeSetupAsync("admin@example.com", "Password1!", CancellationToken.None); - var user = await fixture.UserManager.FindByEmailAsync("admin@example.com"); + User? user = await fixture.UserManager.FindByEmailAsync("admin@example.com"); user.Should().NotBeNull(); await fixture.UserManager.ResetAuthenticatorKeyAsync(user!); @@ -19,17 +19,17 @@ public async Task Two_factor_should_be_configurable_and_used_during_login() key.Should().NotBeNullOrWhiteSpace(); string code = CreateAuthenticatorCode(key!, DateTimeOffset.UtcNow); - var enabled = await fixture.Service.ConfigureTwoFactorAsync(user!.Id, true, code, true, false, false, CancellationToken.None); + TwoFactorResponse? enabled = await fixture.Service.ConfigureTwoFactorAsync(user!.Id, true, code, true, false, false, CancellationToken.None); enabled.Should().NotBeNull(); enabled!.IsTwoFactorEnabled.Should().BeTrue(); enabled.RecoveryCodes.Should().NotBeNullOrEmpty(); string? loginKey = await fixture.UserManager.GetAuthenticatorKeyAsync(user); string loginCode = CreateAuthenticatorCode(loginKey!, DateTimeOffset.UtcNow); - var login = await fixture.Service.LoginAsync("admin@example.com", "Password1!", loginCode, null, CancellationToken.None); + TokenResponse? login = await fixture.Service.LoginAsync("admin@example.com", "Password1!", loginCode, null, CancellationToken.None); login.Should().NotBeNull(); - var disabled = await fixture.Service.ConfigureTwoFactorAsync(user.Id, false, null, false, true, false, CancellationToken.None); + TwoFactorResponse? disabled = await fixture.Service.ConfigureTwoFactorAsync(user.Id, false, null, false, true, false, CancellationToken.None); disabled.Should().NotBeNull(); disabled!.IsTwoFactorEnabled.Should().BeFalse(); } @@ -39,12 +39,12 @@ public async Task Two_factor_should_be_configurable_and_used_during_login() [Fact] public async Task Two_factor_should_reject_unknown_user_and_invalid_code() { - await using var fixture = await IdentityFixture.CreateAsync(); + await using IdentityFixture fixture = await IdentityFixture.CreateAsync(); (await fixture.Service.ConfigureTwoFactorAsync("missing", true, "123456", false, false, false, CancellationToken.None)).Should().BeNull(); await fixture.Service.InitializeSetupAsync("admin@example.com", "Password1!", CancellationToken.None); - var user = await fixture.UserManager.FindByEmailAsync("admin@example.com"); + User? user = await fixture.UserManager.FindByEmailAsync("admin@example.com"); user.Should().NotBeNull(); (await fixture.Service.ConfigureTwoFactorAsync(user!.Id, true, "123456", false, false, false, CancellationToken.None)).Should().BeNull(); @@ -55,12 +55,12 @@ public async Task Two_factor_should_reject_unknown_user_and_invalid_code() [Fact] public async Task Two_factor_should_generate_recovery_codes_when_requested() { - await using var fixture = await IdentityFixture.CreateAsync(); + await using IdentityFixture fixture = await IdentityFixture.CreateAsync(); await fixture.Service.InitializeSetupAsync("admin@example.com", "Password1!", CancellationToken.None); - var user = await fixture.UserManager.FindByEmailAsync("admin@example.com"); + User? user = await fixture.UserManager.FindByEmailAsync("admin@example.com"); user.Should().NotBeNull(); - var result = await fixture.Service.ConfigureTwoFactorAsync(user!.Id, null, null, true, false, true, CancellationToken.None); + TwoFactorResponse? result = await fixture.Service.ConfigureTwoFactorAsync(user!.Id, null, null, true, false, true, CancellationToken.None); result.Should().NotBeNull(); result!.RecoveryCodes.Should().NotBeNullOrEmpty(); result.IsTwoFactorEnabled.Should().BeFalse(); diff --git a/tests/server/RemoteTickets.UnitTests/IdentityValidatorTests.cs b/tests/server/RemoteTickets.UnitTests/IdentityValidatorTests.cs index ce51dc0..4d621cc 100644 --- a/tests/server/RemoteTickets.UnitTests/IdentityValidatorTests.cs +++ b/tests/server/RemoteTickets.UnitTests/IdentityValidatorTests.cs @@ -1,3 +1,5 @@ +using FluentValidation.Results; + namespace RemoteTickets.UnitTests; /// Verifies the validation rules for identity requests. @@ -8,7 +10,7 @@ public sealed class IdentityValidatorTests [Fact] public async Task Register_validator_should_reject_invalid_credentials() { - var result = await new RegisterCommandValidator().ValidateAsync(new RegisterCommand("bad", "short")); + ValidationResult result = await new RegisterCommandValidator().ValidateAsync(new RegisterCommand("bad", "short")); result.IsValid.Should().BeFalse(); result.Errors.Should().NotBeEmpty(); } @@ -18,7 +20,7 @@ public async Task Register_validator_should_reject_invalid_credentials() [Fact] public async Task Login_validator_should_reject_both_two_factor_codes() { - var result = await new LoginCommandValidator().ValidateAsync(new LoginCommand("user@example.com", "Password1!", "123456", "recovery")); + ValidationResult result = await new LoginCommandValidator().ValidateAsync(new LoginCommand("user@example.com", "Password1!", "123456", "recovery")); result.IsValid.Should().BeFalse(); } @@ -27,7 +29,7 @@ public async Task Login_validator_should_reject_both_two_factor_codes() [Fact] public async Task Reset_validator_should_require_email_code_and_password() { - var result = await new ResetPasswordCommandValidator().ValidateAsync(new ResetPasswordCommand("", "", "short")); + ValidationResult result = await new ResetPasswordCommandValidator().ValidateAsync(new ResetPasswordCommand("", "", "short")); result.IsValid.Should().BeFalse(); result.Errors.Select(x => x.PropertyName).Should().Contain(["Email", "ResetCode", "NewPassword"]); } @@ -37,7 +39,7 @@ public async Task Reset_validator_should_require_email_code_and_password() [Fact] public async Task Update_validator_should_allow_optional_email_and_password() { - var result = await new UpdateIdentityInfoCommandValidator().ValidateAsync(new UpdateIdentityInfoCommand("user-id", null, null, "Password1!")); + ValidationResult result = await new UpdateIdentityInfoCommandValidator().ValidateAsync(new UpdateIdentityInfoCommand("user-id", null, null, "Password1!")); result.IsValid.Should().BeTrue(); } diff --git a/tests/server/RemoteTickets.UnitTests/JwtTokenServiceTests.cs b/tests/server/RemoteTickets.UnitTests/JwtTokenServiceTests.cs index fe24e0a..71358b0 100644 --- a/tests/server/RemoteTickets.UnitTests/JwtTokenServiceTests.cs +++ b/tests/server/RemoteTickets.UnitTests/JwtTokenServiceTests.cs @@ -10,7 +10,7 @@ public void Token_service_should_reject_invalid_secret_length() var store = new RevokedTokenStore(); var service = new JwtTokenService(Options.Create(new JwtOptions { SecretKey = "short" }), store); - var action = () => service.CreateTokens("user", "user@example.com", [], []); + Func action = () => service.CreateTokens("user", "user@example.com", [], []); action.Should().Throw(); } @@ -31,10 +31,10 @@ public void Revoked_token_store_should_expire_entries() public void Token_service_should_round_trip_claims_and_metadata() { var store = new RevokedTokenStore(); - var service = CreateService(store); - var tokens = service.CreateTokens("user-id", "user@example.com", ["Administrator"], [new Claim(IdentityClaimTypes.Permission, "system.admin")]); + JwtTokenService service = CreateService(store); + TokenResponse tokens = service.CreateTokens("user-id", "user@example.com", ["Administrator"], [new Claim(IdentityClaimTypes.Permission, "system.admin")]); - var principal = service.ValidateToken(tokens.AccessToken); + ClaimsPrincipal? principal = service.ValidateToken(tokens.AccessToken); principal.Should().NotBeNull(); principal!.FindFirstValue(ClaimTypes.Role).Should().Be("Administrator"); principal.FindFirstValue(IdentityClaimTypes.Permission).Should().Be("system.admin"); @@ -51,8 +51,8 @@ public void Token_service_should_round_trip_claims_and_metadata() public void Token_service_should_reject_a_revoked_token() { var store = new RevokedTokenStore(); - var service = CreateService(store); - var tokens = service.CreateTokens("user-id", "user@example.com", [], []); + JwtTokenService service = CreateService(store); + TokenResponse tokens = service.CreateTokens("user-id", "user@example.com", [], []); string? tokenId = service.GetTokenId(tokens.AccessToken); tokenId.Should().NotBeNull(); diff --git a/tests/server/RemoteTickets.UnitTests/PersistenceTests.cs b/tests/server/RemoteTickets.UnitTests/PersistenceTests.cs index 946ed6a..3fe01b0 100644 --- a/tests/server/RemoteTickets.UnitTests/PersistenceTests.cs +++ b/tests/server/RemoteTickets.UnitTests/PersistenceTests.cs @@ -8,7 +8,7 @@ public sealed class PersistenceTests [Fact] public async Task Soft_deleted_users_should_be_hidden_by_query_filter() { - await using var fixture = await CreateContextAsync(); + await using ContextFixture fixture = await CreateContextAsync(); var user = new User("deleted@example.com") { Email = "deleted@example.com", EmailConfirmed = true }; fixture.Context.Users.Add(user); fixture.Context.SaveChanges(); @@ -27,7 +27,7 @@ public async Task Soft_deleted_users_should_be_hidden_by_query_filter() [Fact] public async Task Async_soft_delete_should_apply_the_same_behavior() { - await using var fixture = await CreateContextAsync(); + await using ContextFixture fixture = await CreateContextAsync(); var user = new User("async@example.com") { Email = "async@example.com", EmailConfirmed = true }; fixture.Context.Users.Add(user); await fixture.Context.SaveChangesAsync(TestContext.Current.CancellationToken); @@ -56,7 +56,7 @@ public void User_and_role_constructors_should_initialize_identity_ids() private static async Task CreateContextAsync() { - var options = new DbContextOptionsBuilder() + DbContextOptions options = new DbContextOptionsBuilder() .UseInMemoryDatabase(Guid.NewGuid().ToString("N")) .Options; var context = new RemoteTicketsDbContext(options); diff --git a/tests/server/RemoteTickets.UnitTests/TenantIdentityTests.cs b/tests/server/RemoteTickets.UnitTests/TenantIdentityTests.cs index 7c8d787..ad58d24 100644 --- a/tests/server/RemoteTickets.UnitTests/TenantIdentityTests.cs +++ b/tests/server/RemoteTickets.UnitTests/TenantIdentityTests.cs @@ -7,15 +7,15 @@ public sealed class TenantIdentityTests [Fact] public async Task Tenant_user_should_not_login_to_another_tenant() { - await using var fixture = await IdentityFixture.CreateAsync(); + await using IdentityFixture fixture = await IdentityFixture.CreateAsync(); await fixture.Service.InitializeSetupAsync("sysadmin@example.com", "Password1!", CancellationToken.None); - var created = await fixture.Service.CreateTenantAdminAsync("tenant-a", "admin-a@example.com", "Password1!", CancellationToken.None); + IdentityResultResponse created = await fixture.Service.CreateTenantAdminAsync("tenant-a", "admin-a@example.com", "Password1!", CancellationToken.None); created.Succeeded.Should().BeTrue(); - var valid = await fixture.Service.LoginAsync("tenant-a", "admin-a@example.com", "Password1!", null, null, CancellationToken.None); + TokenResponse? valid = await fixture.Service.LoginAsync("tenant-a", "admin-a@example.com", "Password1!", null, null, CancellationToken.None); valid.Should().NotBeNull(); - var wrongTenant = await fixture.Service.LoginAsync("tenant-b", "admin-a@example.com", "Password1!", null, null, CancellationToken.None); + TokenResponse? wrongTenant = await fixture.Service.LoginAsync("tenant-b", "admin-a@example.com", "Password1!", null, null, CancellationToken.None); wrongTenant.Should().BeNull(); } @@ -23,11 +23,11 @@ public async Task Tenant_user_should_not_login_to_another_tenant() [Fact] public async Task Sysadmin_should_login_through_any_tenant_route() { - await using var fixture = await IdentityFixture.CreateAsync(); + await using IdentityFixture fixture = await IdentityFixture.CreateAsync(); await fixture.Service.InitializeSetupAsync("sysadmin@example.com", "Password1!", CancellationToken.None); await fixture.Service.CreateTenantAdminAsync("tenant-a", "admin-a@example.com", "Password1!", CancellationToken.None); - var tokens = await fixture.Service.LoginAsync("tenant-b", "sysadmin@example.com", "Password1!", null, null, CancellationToken.None); + TokenResponse? tokens = await fixture.Service.LoginAsync("tenant-b", "sysadmin@example.com", "Password1!", null, null, CancellationToken.None); tokens.Should().NotBeNull(); fixture.TokenService.ValidateToken(tokens!.AccessToken)!.IsInRole(TenantRoles.SysAdmin).Should().BeTrue(); } @@ -36,16 +36,16 @@ public async Task Sysadmin_should_login_through_any_tenant_route() [Fact] public async Task Refresh_token_should_remain_bound_to_its_tenant() { - await using var fixture = await IdentityFixture.CreateAsync(); + await using IdentityFixture fixture = await IdentityFixture.CreateAsync(); await fixture.Service.InitializeSetupAsync("sysadmin@example.com", "Password1!", CancellationToken.None); await fixture.Service.CreateTenantAdminAsync("tenant-a", "admin-a@example.com", "Password1!", CancellationToken.None); - var tokens = await fixture.Service.LoginAsync("tenant-a", "admin-a@example.com", "Password1!", null, null, CancellationToken.None); + TokenResponse? tokens = await fixture.Service.LoginAsync("tenant-a", "admin-a@example.com", "Password1!", null, null, CancellationToken.None); tokens.Should().NotBeNull(); - var invalid = await fixture.Service.RefreshAsync("tenant-b", tokens!.RefreshToken, CancellationToken.None); + TokenResponse? invalid = await fixture.Service.RefreshAsync("tenant-b", tokens!.RefreshToken, CancellationToken.None); invalid.Should().BeNull(); - var refreshed = await fixture.Service.RefreshAsync("tenant-a", tokens.RefreshToken, CancellationToken.None); + TokenResponse? refreshed = await fixture.Service.RefreshAsync("tenant-a", tokens.RefreshToken, CancellationToken.None); refreshed.Should().NotBeNull(); fixture.TokenService.ValidateToken(refreshed!.AccessToken)!.FindFirst(TenantClaimTypes.TenantId)!.Value.Should().Be("tenant-a"); } diff --git a/tests/server/RemoteTickets.UnitTests/ValidationMiddlewareTests.cs b/tests/server/RemoteTickets.UnitTests/ValidationMiddlewareTests.cs index 3f8ef76..c2b6902 100644 --- a/tests/server/RemoteTickets.UnitTests/ValidationMiddlewareTests.cs +++ b/tests/server/RemoteTickets.UnitTests/ValidationMiddlewareTests.cs @@ -10,13 +10,13 @@ public async Task Fluent_message_validator_should_execute_registered_validator() { var services = new ServiceCollection(); services.AddScoped, RegisterCommandValidator>(); - using var provider = services.BuildServiceProvider(); + using ServiceProvider provider = services.BuildServiceProvider(); var validator = new FluentMessageValidator(provider); - var valid = () => validator.ValidateAsync(new RegisterCommand("user@example.com", "Password1!"), CancellationToken.None); + Func valid = () => validator.ValidateAsync(new RegisterCommand("user@example.com", "Password1!"), CancellationToken.None); await valid(); - var invalid = () => validator.ValidateAsync(new RegisterCommand("invalid", "short"), CancellationToken.None); + Func invalid = () => validator.ValidateAsync(new RegisterCommand("invalid", "short"), CancellationToken.None); await invalid.Should().ThrowAsync(); } @@ -25,7 +25,7 @@ public async Task Fluent_message_validator_should_execute_registered_validator() [Fact] public async Task Fluent_message_validator_should_skip_unregistered_messages() { - using var provider = new ServiceCollection().BuildServiceProvider(); + using ServiceProvider provider = new ServiceCollection().BuildServiceProvider(); var validator = new FluentMessageValidator(provider); await validator.ValidateAsync(new object(), CancellationToken.None); From 4d1b0462eb4791a9d248c45483d2f924606e5235 Mon Sep 17 00:00:00 2001 From: Weslley Murdock Date: Sun, 16 Aug 2026 23:31:35 -0300 Subject: [PATCH 057/112] add enforcement steps for line and branch minimum coverage --- .github/workflows/CI-CT-CD.yml | 33 +++++++++++++++++++++++++++++---- 1 file changed, 29 insertions(+), 4 deletions(-) diff --git a/.github/workflows/CI-CT-CD.yml b/.github/workflows/CI-CT-CD.yml index d7714d0..4262fd8 100644 --- a/.github/workflows/CI-CT-CD.yml +++ b/.github/workflows/CI-CT-CD.yml @@ -1,4 +1,4 @@ -name: CI - CT - CD +name: Continuous Integration - Testing - Deploy on: push: @@ -105,21 +105,23 @@ jobs: | --- | ---: | ---: | --- | "@ | Out-File $env:GITHUB_STEP_SUMMARY -Append -Encoding utf8 - if ($lineRate -ge 80) { "| Line coverage | $([math]::Round($lineRate, 2))% | 80% | ✅ |" | Out-File $env:GITHUB_STEP_SUMMARY -Append -Encoding utf8 + "LINE_EXIT_CODE=0" | Out-File -FilePath artifacts/line-rate-code.txt -Encoding utf8 } else { "| Line coverage | $([math]::Round($lineRate, 2))% | 80% | ❌ |" | Out-File $env:GITHUB_STEP_SUMMARY -Append -Encoding utf8 + "LINE_EXIT_CODE=1" | Out-File -FilePath artifacts/line-rate-code.txt -Encoding utf8 } if ($branchRate -ge 80) { "| Branch coverage | $([math]::Round($branchRate, 2))% | 80% | ✅ |" | Out-File $env:GITHUB_STEP_SUMMARY -Append -Encoding utf8 + "BRANCH_EXIT_CODE=0" | Out-File -FilePath artifacts/branch-rate-code.txt -Encoding utf8 + } else { "| Branch coverage | $([math]::Round($branchRate, 2))% | 80% | ❌ |" | Out-File $env:GITHUB_STEP_SUMMARY -Append -Encoding utf8 + "BRANCH_EXIT_CODE=1" | Out-File -FilePath artifacts/branch-rate-code.txt -Encoding utf8 } - - - name: Append test execution report if: always() shell: pwsh @@ -141,3 +143,26 @@ jobs: $exitCode = [int](Get-Content artifacts/test-exit-code.txt -Raw).Replace('TEST_EXIT_CODE=', '').Trim() if ($exitCode -ne 0) { Write-Error "dotnet test failed with exit code $exitCode." } } + + - name: Fail if line rate is above 80% + if: always() + shell: pwsh + run: | + if (Test-Path artifacts/line-rate-code.txt) { + $exitCode = [double](Get-Content artifacts/line-rate-code.txt -Raw).Replace('LINE_EXIT_CODE=', '').Trim() + if ($exitCode -le 80) + { + Write-Error "Line coverage is under rate. Current rate: $" + } + } + + - name: Fail if branch rate is above 80% + if: always() + shell: pwsh + run: | + if (Test-Path artifacts/branch-rate-code.txt) { + $exitCode = [double](Get-Content artifacts/branch-rate-code.txt -Raw).Replace('BRANCH_EXIT_CODE=', '').Trim() + if ($exitCode -le 80) { + Write-Error "Branch coverage is under rate. Current rate: $" + } + } From 91ada13484d63939b2a90522f568efe642e718f7 Mon Sep 17 00:00:00 2001 From: Weslley Murdock Date: Mon, 17 Aug 2026 05:13:55 -0300 Subject: [PATCH 058/112] feat: major refactor --- .../Common/System/SystemContracts.cs | 29 ++++++++ .../Common/Tenancy/TenancyContracts.cs | 15 +++- .../Common/Util/RemoteTicketsConstants.cs | 7 ++ .../RemoteTickets.Application/GlobalUsings.cs | 6 ++ .../Identity/Requests/IdentityRequests.cs | 6 -- .../System/Handlers/SystemHandlers.cs | 7 ++ .../System/Requests/SystemRequests.cs | 17 +++++ .../ConnectionStringPropertyValidator.cs | 42 ++++++++++++ .../ConnectionStringValidationExtensions.cs | 16 +++++ .../MasterDatabaseSetupCommandValidator..cs | 34 ++++++++++ .../Tenant/Handlers/TenantHandlers.cs | 33 +++++++++ .../Tenant/Requests/TenantRequests.cs | 32 +++++++++ .../RemoteTickets.Composition/GlobalUsings.cs | 1 + .../WebApplicationBuilderExtensions.cs | 2 + .../Common/EntityAuditable.cs | 15 ++++ .../RemoteTickets.Domain/Common/EntityBase.cs | 15 ++++ .../GlobalUsings.cs | 3 + .../Identity/Services/IdentityService.cs | 25 +++++-- .../Identity/IdentityConfigurations.cs | 25 +++++++ .../Identity/IdentityrConfigurations.cs | 16 ----- .../Setup/SystemService.cs | 20 ++++++ .../Setup/SystemSetupState.cs | 2 +- .../Configurations/TenancyConfigurations.cs | 2 +- .../Tenancy/Models/Tenant.cs | 6 +- .../Tenancy/Models/TenantSetupState.cs | 4 +- .../Tenancy/TenantAccessMiddleware.cs | 68 +++++++++++++++---- .../Tenancy/TenantManagementService.cs | 8 +-- .../Tenancy/TenantSetupDbContext.cs | 2 +- .../Controllers/SetupController.cs | 68 ------------------- .../Controllers/TenantSetupController.cs | 28 -------- .../{ => v1/Identity}/IdentityController.cs | 0 .../Controllers/v1/System/SetupController.cs | 46 +++++++++++++ .../{ => v1/Tenant}/TenantController.cs | 25 +++++-- .../v1/Tenant/TenantSetupController.cs | 41 +++++++++++ src/server/RemoteTickets/GlobalUsings.cs | 7 +- .../RemoteTickets.UnitTests/GlobalUsings.cs | 2 + .../IdentityServiceTests.cs | 5 +- .../IdentityTwoFactorTests.cs | 4 +- .../IdentityValidatorTests.cs | 2 - 39 files changed, 522 insertions(+), 164 deletions(-) create mode 100644 src/server/RemoteTickets.Application/Common/System/SystemContracts.cs create mode 100644 src/server/RemoteTickets.Application/Common/Util/RemoteTicketsConstants.cs create mode 100644 src/server/RemoteTickets.Application/System/Handlers/SystemHandlers.cs create mode 100644 src/server/RemoteTickets.Application/System/Requests/SystemRequests.cs create mode 100644 src/server/RemoteTickets.Application/System/Validators/ConnectionStringPropertyValidator.cs create mode 100644 src/server/RemoteTickets.Application/System/Validators/ConnectionStringValidationExtensions.cs create mode 100644 src/server/RemoteTickets.Application/System/Validators/MasterDatabaseSetupCommandValidator..cs create mode 100644 src/server/RemoteTickets.Application/Tenant/Handlers/TenantHandlers.cs create mode 100644 src/server/RemoteTickets.Application/Tenant/Requests/TenantRequests.cs create mode 100644 src/server/RemoteTickets.Domain/Common/EntityAuditable.cs create mode 100644 src/server/RemoteTickets.Domain/Common/EntityBase.cs create mode 100644 src/server/RemoteTickets.Infrastructure/Persistence/Configurations/Identity/IdentityConfigurations.cs delete mode 100644 src/server/RemoteTickets.Infrastructure/Persistence/Configurations/Identity/IdentityrConfigurations.cs create mode 100644 src/server/RemoteTickets.Infrastructure/Setup/SystemService.cs delete mode 100644 src/server/RemoteTickets/Controllers/SetupController.cs delete mode 100644 src/server/RemoteTickets/Controllers/TenantSetupController.cs rename src/server/RemoteTickets/Controllers/{ => v1/Identity}/IdentityController.cs (100%) create mode 100644 src/server/RemoteTickets/Controllers/v1/System/SetupController.cs rename src/server/RemoteTickets/Controllers/{ => v1/Tenant}/TenantController.cs (52%) create mode 100644 src/server/RemoteTickets/Controllers/v1/Tenant/TenantSetupController.cs diff --git a/src/server/RemoteTickets.Application/Common/System/SystemContracts.cs b/src/server/RemoteTickets.Application/Common/System/SystemContracts.cs new file mode 100644 index 0000000..34e3552 --- /dev/null +++ b/src/server/RemoteTickets.Application/Common/System/SystemContracts.cs @@ -0,0 +1,29 @@ +namespace RemoteTickets.Application.Common.System; + +/// Represents the master database setup payload. +/// The SQL Server connection string used by the tenant catalog. +/// The value (in seconds) for use for operations timeout in SQL Server. +public sealed record MasterDatabaseSetupRequest( + string ConnectionString, + int CommandTimeout); + +/// Represents the first-time setup administrator credentials. +/// The administrator email address. +/// The administrator password. +public sealed record InitializeSetupRequest(string Email, string Password); + +/// +/// Contract for System Service +/// +public interface ISystemService +{ + /// + /// Performs the setup of master database + /// + /// Connection string of master database + /// Timeout for operations on master database + /// Cancellation token for the operation + /// An with the status of setup operation + Task PerformMasterDatabaseSetup(string connectionString, int commandTimeout, CancellationToken cancellationToken); +} + diff --git a/src/server/RemoteTickets.Application/Common/Tenancy/TenancyContracts.cs b/src/server/RemoteTickets.Application/Common/Tenancy/TenancyContracts.cs index a538ed9..7a6d287 100644 --- a/src/server/RemoteTickets.Application/Common/Tenancy/TenancyContracts.cs +++ b/src/server/RemoteTickets.Application/Common/Tenancy/TenancyContracts.cs @@ -36,7 +36,7 @@ public static class TenantPolicies /// Represents the setup state of a tenant database. /// Indicates whether tenant setup is still required. /// Indicates whether tenant setup has completed. -public sealed record TenantSetupStatusResponse(bool IsSetupRequired, bool IsSetupComplete); +public sealed record TenantSetupStatusResponse(bool IsSetupRequired, bool IsSetupComplete) : IResponse; /// Represents a tenant exposed to system administrators. /// The stable tenant identifier used in routes. @@ -44,7 +44,7 @@ public sealed record TenantSetupStatusResponse(bool IsSetupRequired, bool IsSetu /// The database name assigned to the tenant. /// Indicates whether the tenant accepts normal operations. /// Indicates whether tenant setup has completed. -public sealed record TenantResponse(string Id, string Name, string DatabaseName, bool IsActive, bool IsSetupComplete); +public sealed record TenantResponse(string Id, string Name, string DatabaseName, bool IsActive, bool IsSetupComplete) : IResponse; /// Represents a request to provision a tenant and its first administrator. /// The tenant identifier. @@ -53,7 +53,15 @@ public sealed record TenantResponse(string Id, string Name, string DatabaseName, /// The connection string for the tenant database. /// The first tenant administrator email. /// The first tenant administrator password. -public sealed record CreateTenantRequest(string Id, string Name, string DatabaseName, string ConnectionString, string AdminEmail, string AdminPassword); +public sealed record CreateTenantRequest(string Id, string Name, string DatabaseName, string ConnectionString, string AdminEmail, string AdminPassword) +{ + public CreateTenantCommand ToCommand() + => new ((string.IsNullOrEmpty(Name) || string.IsNullOrWhiteSpace(Name) ? throw new ArgumentNullException(nameof(Name)) : Name), + (string.IsNullOrEmpty(DatabaseName) || string.IsNullOrWhiteSpace(DatabaseName)? throw new ArgumentNullException(nameof(DatabaseName)) : DatabaseName), + (string.IsNullOrEmpty(ConnectionString) || string.IsNullOrWhiteSpace(ConnectionString)? throw new ArgumentNullException(nameof(ConnectionString)) : ConnectionString), + (string.IsNullOrEmpty(AdminEmail) || string.IsNullOrWhiteSpace(AdminEmail)? throw new ArgumentNullException(nameof(AdminEmail)) : AdminEmail), + (string.IsNullOrEmpty(AdminPassword) || string.IsNullOrWhiteSpace(AdminPassword)? throw new ArgumentNullException(nameof(AdminPassword)) : AdminPassword)); +} /// Provides tenant registration and setup operations. public interface ITenantManagementService @@ -82,3 +90,4 @@ public interface ITenantManagementService /// The resulting setup state. Task CompleteSetupAsync(string tenantId, CancellationToken cancellationToken); } + diff --git a/src/server/RemoteTickets.Application/Common/Util/RemoteTicketsConstants.cs b/src/server/RemoteTickets.Application/Common/Util/RemoteTicketsConstants.cs new file mode 100644 index 0000000..f908e76 --- /dev/null +++ b/src/server/RemoteTickets.Application/Common/Util/RemoteTicketsConstants.cs @@ -0,0 +1,7 @@ +namespace RemoteTickets.Application.Common.Util; + +public static class RemoteTicketsConstants +{ + public const string SystemSetupId = "01a00d95-87a3-7d90-b45c-759bf28c5d50"; + public const string TenantSetupId = "01a00e8b-ffe7-7186-aa29-46980b4cdbd7"; +} diff --git a/src/server/RemoteTickets.Application/GlobalUsings.cs b/src/server/RemoteTickets.Application/GlobalUsings.cs index a4a7c89..648656f 100644 --- a/src/server/RemoteTickets.Application/GlobalUsings.cs +++ b/src/server/RemoteTickets.Application/GlobalUsings.cs @@ -1,13 +1,19 @@ global using System; global using System.Collections.Generic; +global using System.Data.Common; global using System.Linq; global using System.Security.Claims; global using System.Threading; global using System.Threading.Tasks; global using FluentValidation; global using FluentValidation.Results; +global using FluentValidation.Validators; global using Mediator.Net.Context; global using Mediator.Net.Contracts; global using Mediator.Net.Pipeline; global using RemoteTickets.Application.Common.Identity; +global using RemoteTickets.Application.Common.System; +global using RemoteTickets.Application.Common.Tenancy; global using RemoteTickets.Application.Identity.Requests; +global using RemoteTickets.Application.System.Requests; +global using RemoteTickets.Application.Tenant.Requests; \ No newline at end of file diff --git a/src/server/RemoteTickets.Application/Identity/Requests/IdentityRequests.cs b/src/server/RemoteTickets.Application/Identity/Requests/IdentityRequests.cs index 33c1360..d3fccec 100644 --- a/src/server/RemoteTickets.Application/Identity/Requests/IdentityRequests.cs +++ b/src/server/RemoteTickets.Application/Identity/Requests/IdentityRequests.cs @@ -54,9 +54,3 @@ public sealed record UpdateIdentityInfoCommand(string UserId, string? NewEmail, /// Whether the shared key should be regenerated. /// Whether remembered-machine state should be cleared. public sealed record ConfigureTwoFactorCommand(string UserId, bool? Enable, string? TwoFactorCode, bool ResetRecoveryCodes, bool ResetSharedKey, bool ForgetMachine) : IRequest; -/// Requests the current first-time setup status. -public sealed record GetSetupStatusQuery : IRequest; -/// Requests creation of the initial administrator account. -/// The administrator email address. -/// The administrator password. -public sealed record InitializeSetupCommand(string Email, string Password) : IRequest; diff --git a/src/server/RemoteTickets.Application/System/Handlers/SystemHandlers.cs b/src/server/RemoteTickets.Application/System/Handlers/SystemHandlers.cs new file mode 100644 index 0000000..d19000a --- /dev/null +++ b/src/server/RemoteTickets.Application/System/Handlers/SystemHandlers.cs @@ -0,0 +1,7 @@ +namespace RemoteTickets.Application.System.Handlers; + +public class SystemHandlers(ISystemService service) : IRequestHandler +{ + public Task Handle(IReceiveContext context, CancellationToken cancellationToken) + => service.PerformMasterDatabaseSetup(context.Message.Request.ConnectionString, context.Message.Request.CommandTimeout, cancellationToken); +} diff --git a/src/server/RemoteTickets.Application/System/Requests/SystemRequests.cs b/src/server/RemoteTickets.Application/System/Requests/SystemRequests.cs new file mode 100644 index 0000000..f9bc8d5 --- /dev/null +++ b/src/server/RemoteTickets.Application/System/Requests/SystemRequests.cs @@ -0,0 +1,17 @@ +namespace RemoteTickets.Application.System.Requests; + +/// Requests the current first-time setup status. +public sealed record GetSetupStatusQuery : IRequest; +/// Requests creation of the initial administrator account. +/// The administrator email address. +/// The administrator password. +public sealed record InitializeSetupCommand(string Email, string Password) : IRequest; + +/// Represents the command for perform setup of master database. +/// The request for this command. +public sealed record MasterDatabaseSetupCommand(MasterDatabaseSetupRequest Request) : IRequest; + +/// Response for a command. +/// The status of command execution. +/// Optional message about the result.. +public sealed record MasterDatabaseSetupResponse(bool Status, string Message) : IResponse; diff --git a/src/server/RemoteTickets.Application/System/Validators/ConnectionStringPropertyValidator.cs b/src/server/RemoteTickets.Application/System/Validators/ConnectionStringPropertyValidator.cs new file mode 100644 index 0000000..13d70d8 --- /dev/null +++ b/src/server/RemoteTickets.Application/System/Validators/ConnectionStringPropertyValidator.cs @@ -0,0 +1,42 @@ +namespace RemoteTickets.Application.System.Validators; + +public class ConnectionStringPropertyValidator : PropertyValidator +{ + private readonly HashSet _allowedKeys; + + public ConnectionStringPropertyValidator(IEnumerable allowedKeys) + { + _allowedKeys = new HashSet(allowedKeys, StringComparer.OrdinalIgnoreCase); + } + + public override string Name => "ConnectionStringValidator"; + + public override bool IsValid(ValidationContext context, string connectionString) + { + if (string.IsNullOrWhiteSpace(connectionString)) { return true; } + + try + { + // The DbConnectionStringBuilder parses any generic connection string + var builder = new DbConnectionStringBuilder { ConnectionString = connectionString }; + + foreach (string key in builder.Keys) + { + if (!_allowedKeys.Contains(key)) + { + context.MessageFormatter.AppendArgument("InvalidKey", key); + return false; + } + } + return true; + } + catch (Exception) + { + return false; + } + } + + protected override string GetDefaultMessageTemplate(string errorCode) + => "The connection string have an not supported property: '{InvalidKey}'"; +} + \ No newline at end of file diff --git a/src/server/RemoteTickets.Application/System/Validators/ConnectionStringValidationExtensions.cs b/src/server/RemoteTickets.Application/System/Validators/ConnectionStringValidationExtensions.cs new file mode 100644 index 0000000..3ab6ba3 --- /dev/null +++ b/src/server/RemoteTickets.Application/System/Validators/ConnectionStringValidationExtensions.cs @@ -0,0 +1,16 @@ +namespace RemoteTickets.Application.System.Validators; + +public static class ConnectionStringValidationExtensions +{ + /// + /// Extension method to be used into ab AbstractValidator to validate connection strings. + /// + /// Rule Builder from abstract validator + /// Allowed keys of connections string according to desired db engine. + /// an instance to be validated + /// + public static IRuleBuilderOptions IsValidConnectionString( + this IRuleBuilder ruleBuilder, IEnumerable allowedKeys) + => ruleBuilder.SetValidator( + new ConnectionStringPropertyValidator(allowedKeys)); +} diff --git a/src/server/RemoteTickets.Application/System/Validators/MasterDatabaseSetupCommandValidator..cs b/src/server/RemoteTickets.Application/System/Validators/MasterDatabaseSetupCommandValidator..cs new file mode 100644 index 0000000..04f89d1 --- /dev/null +++ b/src/server/RemoteTickets.Application/System/Validators/MasterDatabaseSetupCommandValidator..cs @@ -0,0 +1,34 @@ +namespace RemoteTickets.Application.System.Validators; + +public class MasterDatabaseSetupCommandValidator : AbstractValidator +{ + private static readonly string[] SqlServerKeys = + { + "Data Source", "Server", "Initial Catalog", "Database", + "Integrated Security", "User ID", "Password", "Encrypt", + "TrustServerCertificate", "Connection Timeout" + }; + public MasterDatabaseSetupCommandValidator() + { + RuleFor(x => x) + .NotNull() + .NotEmpty() + .WithErrorCode("BAD_REQUEST") + .WithMessage("The request cannot be null or empty."); + + RuleFor(x => x.Request) + .NotNull() + .NotEmpty() + .WithErrorCode("BAD_REQUEST") + .WithMessage("The request data cannot be null or empty."); + + RuleFor(x => x.Request.ConnectionString) + .NotNull() + .NotEmpty() + .WithErrorCode("UNPROCESSABLE_ENTITY") + .WithMessage("The connection string cannot be null or empty") + .IsValidConnectionString(SqlServerKeys) + .WithErrorCode("UNPROCESSABLE_ENTITY") + .WithMessage("The connection string isn't valid"); + } +} diff --git a/src/server/RemoteTickets.Application/Tenant/Handlers/TenantHandlers.cs b/src/server/RemoteTickets.Application/Tenant/Handlers/TenantHandlers.cs new file mode 100644 index 0000000..10bfd14 --- /dev/null +++ b/src/server/RemoteTickets.Application/Tenant/Handlers/TenantHandlers.cs @@ -0,0 +1,33 @@ +namespace RemoteTickets.Application.Tenant.Handlers; + +/// +/// Class that implement all Tenant queries and commands handlers +/// +/// An injected instance. +public class TenantHandlers(ITenantManagementService service) : +IRequestHandler, +IRequestHandler, +IRequestHandler, +IRequestHandler +{ + public async Task Handle( + IReceiveContext context, + CancellationToken cancellationToken) + => await service.GetSetupStatusAsync( + context.Message.TenantId, + cancellationToken); + public async Task Handle( + IReceiveContext context, + CancellationToken cancellationToken) + => await service.CompleteSetupAsync( + context.Message.TenantId, + cancellationToken); + public async Task Handle( + IReceiveContext context, + CancellationToken cancellationToken) + => await service.CreateAsync(context.Message.ToRequest() , cancellationToken); + public async Task Handle( + IReceiveContext context, + CancellationToken cancellationToken) + => await service.GetAsync(context.Message.TenantId, cancellationToken); +} \ No newline at end of file diff --git a/src/server/RemoteTickets.Application/Tenant/Requests/TenantRequests.cs b/src/server/RemoteTickets.Application/Tenant/Requests/TenantRequests.cs new file mode 100644 index 0000000..9deb8d2 --- /dev/null +++ b/src/server/RemoteTickets.Application/Tenant/Requests/TenantRequests.cs @@ -0,0 +1,32 @@ +namespace RemoteTickets.Application.Tenant.Requests; + +/// Query to retrieve tenant setup status +/// Id of tenant to retrieve setup status +public sealed record GetTenantSetupStatusQuery(string TenantId) : IRequest; + +/// Command to complete tenant setup +/// Id of tenant to complete setup +public sealed record CompleteTenantSetupCommand(string TenantId) : IRequest; + +/// Represents a command to provision a tenant and its first administrator. +/// The tenant display name. +/// The SQL Server database name. +/// The connection string for the tenant database. +/// The first tenant administrator email. +/// The first tenant administrator password. +public sealed record CreateTenantCommand(string Name, string DatabaseName, string ConnectionString, string AdminEmail, string AdminPassword) : IRequest +{ + public CreateTenantRequest ToRequest() + => new (null!,(string.IsNullOrEmpty(Name) || string.IsNullOrWhiteSpace(Name) ? throw new ArgumentNullException(nameof(Name)) : Name), + (string.IsNullOrEmpty(DatabaseName) || string.IsNullOrWhiteSpace(DatabaseName)? throw new ArgumentNullException(nameof(DatabaseName)) : DatabaseName), + (string.IsNullOrEmpty(ConnectionString) || string.IsNullOrWhiteSpace(ConnectionString)? throw new ArgumentNullException(nameof(ConnectionString)) : ConnectionString), + (string.IsNullOrEmpty(AdminEmail) || string.IsNullOrWhiteSpace(AdminEmail)? throw new ArgumentNullException(nameof(AdminEmail)) : AdminEmail), + (string.IsNullOrEmpty(AdminPassword) || string.IsNullOrWhiteSpace(AdminPassword)? throw new ArgumentNullException(nameof(AdminPassword)) : AdminPassword)); +} + +/// Query to retrieve an tenant by id +/// The id of tenant to retrieve. +public sealed record GetTenantQuery(string TenantId) : IRequest; + +/// Query to retrieve all tenant +public sealed record GetTenantsQuery() : IRequest; \ No newline at end of file diff --git a/src/server/RemoteTickets.Composition/GlobalUsings.cs b/src/server/RemoteTickets.Composition/GlobalUsings.cs index 898b1e1..a49c65f 100644 --- a/src/server/RemoteTickets.Composition/GlobalUsings.cs +++ b/src/server/RemoteTickets.Composition/GlobalUsings.cs @@ -6,6 +6,7 @@ global using FluentValidation; global using RemoteTickets.Application.Common.Identity; global using RemoteTickets.Application.Common.Tenancy; +global using RemoteTickets.Application.Common.System; global using RemoteTickets.Application.Identity; global using RemoteTickets.Application.Identity.Handlers; global using RemoteTickets.Application.Identity.Validators; diff --git a/src/server/RemoteTickets.Composition/WebApplicationBuilderExtensions.cs b/src/server/RemoteTickets.Composition/WebApplicationBuilderExtensions.cs index afffcd6..cba2a22 100644 --- a/src/server/RemoteTickets.Composition/WebApplicationBuilderExtensions.cs +++ b/src/server/RemoteTickets.Composition/WebApplicationBuilderExtensions.cs @@ -53,6 +53,7 @@ public async Task RunRemoteTicketsAsync() where T : IComponent services.AddScoped(); services.AddScoped(); services.AddScoped(); + services.AddScoped(); services.AddSingleton(); services.AddScoped(); services.AddScoped(); @@ -110,6 +111,7 @@ public async Task RunRemoteTicketsAsync() where T : IComponent .ConfigureCommandReceivePipe(pipe => pipe.UseValidation()) .ConfigureRequestPipe(pipe => pipe.UseValidation()); services.RegisterMediator(mb); + await builder.Build().RunRemoteTickets(); } } diff --git a/src/server/RemoteTickets.Domain/Common/EntityAuditable.cs b/src/server/RemoteTickets.Domain/Common/EntityAuditable.cs new file mode 100644 index 0000000..9127384 --- /dev/null +++ b/src/server/RemoteTickets.Domain/Common/EntityAuditable.cs @@ -0,0 +1,15 @@ +namespace RemoteTickets.Domain.Common; + +public interface IEntityAuditable +{ + DateTimeOffset CreatedAt { get; init; } + string CreatedBy { get; init; } +} + +public interface IEntityUpdateHistory where T : IEntityAuditable +{ + string CurrentEntityState { get; init; } + string PreviousEntityState { get; init; } + DateTimeOffset UpdatedAt { get; init; } + string UpdatedBy { get; set; } +} \ No newline at end of file diff --git a/src/server/RemoteTickets.Domain/Common/EntityBase.cs b/src/server/RemoteTickets.Domain/Common/EntityBase.cs new file mode 100644 index 0000000..4bf6c13 --- /dev/null +++ b/src/server/RemoteTickets.Domain/Common/EntityBase.cs @@ -0,0 +1,15 @@ +namespace RemoteTickets.Domain.Common; + +/// Interface for abstrace base entity +public interface IEntityBase +{ + string Id { get; set; } +} + +/// Abstract base entity for all entities tracked by DbContext. +public abstract class EntityBase(string id = "") : IEntityBase +{ + public string Id { get; set; } = id == "" ? Guid.CreateVersion7().ToString() : id; +} + + \ No newline at end of file diff --git a/src/server/RemoteTickets.Infrastructure/GlobalUsings.cs b/src/server/RemoteTickets.Infrastructure/GlobalUsings.cs index 7974578..efb41ba 100644 --- a/src/server/RemoteTickets.Infrastructure/GlobalUsings.cs +++ b/src/server/RemoteTickets.Infrastructure/GlobalUsings.cs @@ -11,6 +11,9 @@ global using System.Threading.Tasks; global using RemoteTickets.Application.Common.Identity; global using RemoteTickets.Application.Common.Tenancy; +global using RemoteTickets.Application.Common.System; +global using RemoteTickets.Application.Common.Util; +global using RemoteTickets.Application.System.Requests; global using RemoteTickets.Application.Identity; global using RemoteTickets.Domain.Common; global using RemoteTickets.Infrastructure.Identity.Models; diff --git a/src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.cs b/src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.cs index 2239ff2..d1f27c2 100644 --- a/src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.cs +++ b/src/server/RemoteTickets.Infrastructure/Identity/Services/IdentityService.cs @@ -17,6 +17,7 @@ public sealed partial class IdentityService( IJwtTokenService tokenService, IRevokedTokenStore revokedTokenStore, IIdentityEmailSender emailSender, + ISetupConfigurationStore configurationStore, ILogger logger) : IIdentityService { private const string AdministratorRole = "Administrator"; @@ -204,11 +205,9 @@ public async Task UpdateInfoAsync(string userId, string? /// Configures authenticator-based two-factor authentication and optionally rotates its recovery material. public async Task ConfigureTwoFactorAsync(string userId, bool? enable, string? twoFactorCode, bool resetRecoveryCodes, bool resetSharedKey, bool forgetMachine, CancellationToken cancellationToken) { - User? user = await userManager.FindByIdAsync(userId); - if (user is null) - { - return null; - } + User user = await userManager.FindByIdAsync(userId) ?? null!; + + if (user == null) { return null; } if (enable == true) { @@ -216,7 +215,6 @@ public async Task UpdateInfoAsync(string userId, string? { return null; } - await userManager.SetTwoFactorEnabledAsync(user, true); } else if (enable == false || resetSharedKey) @@ -294,6 +292,21 @@ public async Task InitializeSetupAsync(string email, str return Failure(membershipResult); } + string? connectionString = configurationStore.GetMasterConnectionString(); + if (!string.IsNullOrWhiteSpace(connectionString)) + { + DbContextOptions options = new DbContextOptionsBuilder().UseSqlServer(connectionString).Options; + await using var dbContext = new RemoteTicketsDbContext(options); + SystemSetupState? state = await dbContext.SystemSetup.SingleOrDefaultAsync(x => x.Id == RemoteTicketsConstants.SystemSetupId, cancellationToken); + if (state is null) + { + state = new SystemSetupState { Id = RemoteTicketsConstants.SystemSetupId }; + dbContext.SystemSetup.Add(state); + } + state.IsComplete = true; + state.CompletedAt = DateTimeOffset.UtcNow; + await dbContext.SaveChangesAsync(cancellationToken); + } logger.LogInformation("Initial system setup completed for user {UserId}.", user.Id); return IdentityResultResponse.Success(); } diff --git a/src/server/RemoteTickets.Infrastructure/Persistence/Configurations/Identity/IdentityConfigurations.cs b/src/server/RemoteTickets.Infrastructure/Persistence/Configurations/Identity/IdentityConfigurations.cs new file mode 100644 index 0000000..542e31f --- /dev/null +++ b/src/server/RemoteTickets.Infrastructure/Persistence/Configurations/Identity/IdentityConfigurations.cs @@ -0,0 +1,25 @@ +namespace RemoteTickets.Infrastructure.Persistence.Configurations.Identity; + +internal sealed class IdentityConfigurations : +IEntityTypeConfiguration, +IEntityTypeConfiguration, +IEntityTypeConfiguration> +{ + public void Configure(EntityTypeBuilder builder) + { + builder.ToTable("Users"); + builder.HasKey(u => u.Id); + builder.HasIndex(u => new { u.Id, u.TenantId }) + .IsUnique() + .HasDatabaseName("IX_UQ_UID_TID"); + } + + public void Configure(EntityTypeBuilder builder) + { + builder.ToTable("Roles"); + builder.HasKey(r => r.Id); + } + + public void Configure(EntityTypeBuilder> builder) + => builder.ToTable("UserRoles"); +} diff --git a/src/server/RemoteTickets.Infrastructure/Persistence/Configurations/Identity/IdentityrConfigurations.cs b/src/server/RemoteTickets.Infrastructure/Persistence/Configurations/Identity/IdentityrConfigurations.cs deleted file mode 100644 index adc076a..0000000 --- a/src/server/RemoteTickets.Infrastructure/Persistence/Configurations/Identity/IdentityrConfigurations.cs +++ /dev/null @@ -1,16 +0,0 @@ -namespace RemoteTickets.Infrastructure.Persistence.Configurations.Identity; - -internal sealed class IdentityrConfigurations : -IEntityTypeConfiguration, -IEntityTypeConfiguration -{ - public void Configure(EntityTypeBuilder builder) - { - builder.ToTable("Users"); - } - - public void Configure(EntityTypeBuilder builder) - { - builder.ToTable("Roles"); - } -} diff --git a/src/server/RemoteTickets.Infrastructure/Setup/SystemService.cs b/src/server/RemoteTickets.Infrastructure/Setup/SystemService.cs new file mode 100644 index 0000000..16b50b2 --- /dev/null +++ b/src/server/RemoteTickets.Infrastructure/Setup/SystemService.cs @@ -0,0 +1,20 @@ +namespace RemoteTickets.Infrastructure.Setup; + +/// System service implementation. +public sealed class SystemService(ISetupConfigurationStore configurationStore) : ISystemService +{ + /// + public async Task PerformMasterDatabaseSetup(string connectionString, int commandTimeout, CancellationToken cancellationToken) + { + await configurationStore.SetMasterConnectionStringAsync(connectionString, cancellationToken); + DbContextOptions options = new DbContextOptionsBuilder() + .UseSqlServer(connectionString, options => + { + options.CommandTimeout(commandTimeout); + }) + .Options; + await using RemoteTicketsDbContext dbContext = new(options); + bool status = await dbContext.Database.EnsureCreatedAsync(cancellationToken); + return new(status, status? "Master Database Successfully set up!" : "Master Database not set up!"); + } +} diff --git a/src/server/RemoteTickets.Infrastructure/Setup/SystemSetupState.cs b/src/server/RemoteTickets.Infrastructure/Setup/SystemSetupState.cs index 347fa2e..c904361 100644 --- a/src/server/RemoteTickets.Infrastructure/Setup/SystemSetupState.cs +++ b/src/server/RemoteTickets.Infrastructure/Setup/SystemSetupState.cs @@ -4,7 +4,7 @@ namespace RemoteTickets.Infrastructure.Setup; public sealed class SystemSetupState { /// Gets or sets the singleton setup-state identifier. - public int Id { get; set; } = 1; + public string Id { get; set; } = RemoteTicketsConstants.SystemSetupId; /// Gets or sets whether the installation is ready for normal use. public bool IsComplete { get; set; } /// Gets or sets the completion timestamp. diff --git a/src/server/RemoteTickets.Infrastructure/Tenancy/Configurations/TenancyConfigurations.cs b/src/server/RemoteTickets.Infrastructure/Tenancy/Configurations/TenancyConfigurations.cs index fda3009..ee62419 100644 --- a/src/server/RemoteTickets.Infrastructure/Tenancy/Configurations/TenancyConfigurations.cs +++ b/src/server/RemoteTickets.Infrastructure/Tenancy/Configurations/TenancyConfigurations.cs @@ -1,6 +1,6 @@ namespace RemoteTickets.Infrastructure.Tenancy.Configurations; -internal sealed class TenancyConfigurations : IEntityTypeConfiguration +internal sealed class TenantSetupStateConfiguration : IEntityTypeConfiguration { public void Configure(EntityTypeBuilder builder) { diff --git a/src/server/RemoteTickets.Infrastructure/Tenancy/Models/Tenant.cs b/src/server/RemoteTickets.Infrastructure/Tenancy/Models/Tenant.cs index 979028d..882cca6 100644 --- a/src/server/RemoteTickets.Infrastructure/Tenancy/Models/Tenant.cs +++ b/src/server/RemoteTickets.Infrastructure/Tenancy/Models/Tenant.cs @@ -1,7 +1,7 @@ namespace RemoteTickets.Infrastructure.Tenancy.Models; /// Represents a tenant registered in the installation catalog. -public sealed class Tenant +public sealed class Tenant : IEntityBase, ISoftDeletable { /// Gets or sets the stable tenant identifier used by routes and tokens. public string Id { get; set; } = string.Empty; @@ -17,4 +17,8 @@ public sealed class Tenant public bool IsSetupComplete { get; set; } /// Gets or sets the tenant creation timestamp. public DateTimeOffset CreatedAt { get; set; } = DateTimeOffset.UtcNow; + /// Flag to indicate if the entity is deleted. + public bool IsDeleted { get; set; } + /// DateTimeOffset (UTC) of when the entity was deleted.. + public DateTimeOffset? DeletedAt { get; set; } } diff --git a/src/server/RemoteTickets.Infrastructure/Tenancy/Models/TenantSetupState.cs b/src/server/RemoteTickets.Infrastructure/Tenancy/Models/TenantSetupState.cs index 7cf0ddc..3714808 100644 --- a/src/server/RemoteTickets.Infrastructure/Tenancy/Models/TenantSetupState.cs +++ b/src/server/RemoteTickets.Infrastructure/Tenancy/Models/TenantSetupState.cs @@ -1,10 +1,10 @@ namespace RemoteTickets.Infrastructure.Tenancy.Models; /// Stores the initialization state of a tenant database. -public sealed class TenantSetupState +public sealed class TenantSetupState : IEntityBase { /// Gets or sets the singleton setup-state identifier. - public int Id { get; set; } = 1; + public string Id { get; set; } = RemoteTicketsConstants.TenantSetupId; /// Gets or sets whether the tenant database setup has completed. public bool IsComplete { get; set; } /// Gets or sets the last setup validation timestamp. diff --git a/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs b/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs index 4cd67d7..345c373 100644 --- a/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs +++ b/src/server/RemoteTickets.Infrastructure/Tenancy/TenantAccessMiddleware.cs @@ -1,3 +1,5 @@ +using Microsoft.AspNetCore.Mvc; + namespace RemoteTickets.Infrastructure.Tenancy; /// Enforces tenant route isolation and mandatory setup state for HTTP requests. @@ -11,7 +13,7 @@ public async Task InvokeAsync(HttpContext context) if (IsInfrastructurePath(context.Request.Path)) { await next(context); return; } Endpoint? endpoint = context.GetEndpoint(); bool anonymous = endpoint?.Metadata.GetMetadata() is not null; - SystemSetupState? setupState = await masterDb.SystemSetup.AsNoTracking().SingleOrDefaultAsync(x => x.Id == 1, context.RequestAborted); + SystemSetupState? setupState = await masterDb.SystemSetup.AsNoTracking().SingleOrDefaultAsync(x => x.Id == RemoteTicketsConstants.SystemSetupId, context.RequestAborted); bool systemSetupRequired = setupState is null || !setupState.IsComplete; if (systemSetupRequired) { @@ -46,7 +48,10 @@ public async Task InvokeAsync(HttpContext context) return; } TenantResponse? tenant = await tenants.GetAsync(tenantId, context.RequestAborted); - if (tenant is null || !tenant.IsActive) { await RejectOrRedirectAsync(context, "/not-found", StatusCodes.Status404NotFound); return; } + if (tenant is null || !tenant.IsActive) + { + await RejectOrRedirectAsync(context, "/not-found", StatusCodes.Status404NotFound); return; + } if (anonymous) { if (!tenant.IsSetupComplete && !IsTenantSetupEndpoint(context) && !IsTenantLoginEndpoint(context)) { await RejectOrRedirectAsync(context, $"/{tenantId}/setup", StatusCodes.Status409Conflict); return; } @@ -63,25 +68,60 @@ public async Task InvokeAsync(HttpContext context) await next(context); } - private static bool IsInfrastructurePath(PathString path) => path.StartsWithSegments("/_blazor") || path.StartsWithSegments("/_framework") || path.StartsWithSegments("/_content") || path.StartsWithSegments("/favicon") || path.StartsWithSegments("/css") || path.StartsWithSegments("/lib"); - private static bool IsSystemSetupEndpoint(HttpContext context) => context.Request.Path.StartsWithSegments("/api/setup") || string.Equals(context.Request.Path.Value, "/setup", StringComparison.OrdinalIgnoreCase); - private static bool IsTenantLoginEndpoint(HttpContext context) => string.Equals(context.Request.Path.Value, $"/api/v1/{context.Request.RouteValues["tenantId"]}/login", StringComparison.OrdinalIgnoreCase); + private static bool IsInfrastructurePath(PathString path) + => path.StartsWithSegments("/_blazor") || + path.StartsWithSegments("/_framework") || + path.StartsWithSegments("/_content") || + path.StartsWithSegments("/favicon") || + path.StartsWithSegments("/css") || + path.StartsWithSegments("/js") || + path.StartsWithSegments("/lib"); + + private static bool IsSystemSetupEndpoint(HttpContext context) + => context.Request.Path.StartsWithSegments("/api/v1/setup") || + string.Equals(context.Request.Path.Value, "/setup", + StringComparison.OrdinalIgnoreCase); + + private static bool IsTenantLoginEndpoint(HttpContext context) + => string.Equals(context.Request.Path.Value, $"/api/v1/{ + context.Request.RouteValues["tenantId"]}/login", + StringComparison.OrdinalIgnoreCase); + private static bool IsTenantSetupEndpoint(HttpContext context) { - string? tenantId = context.Request.RouteValues.TryGetValue("tenantId", out object? value) ? value?.ToString() : null; - if (string.IsNullOrWhiteSpace(tenantId)) - { - return false; - } - + string? tenantId = context + .Request + .RouteValues + .TryGetValue("tenantId", out object? value) ? + value?.ToString() + : null; + if (string.IsNullOrWhiteSpace(tenantId ) || + string.IsNullOrEmpty(tenantId) || + Guid.TryParse(tenantId, out Guid _)) { return false; } string? path = context.Request.Path.Value; - return string.Equals(path, $"/{tenantId}/setup", StringComparison.OrdinalIgnoreCase) || string.Equals(path, $"/api/v1/{tenantId}/setup", StringComparison.OrdinalIgnoreCase) || string.Equals(path, $"/api/v1/{tenantId}/setup/complete", StringComparison.OrdinalIgnoreCase); + return string.Equals(path, + $"/{tenantId}/setup", + StringComparison.OrdinalIgnoreCase) || + string.Equals(path, + $"/api/v1/{tenantId}/setup", + StringComparison.OrdinalIgnoreCase) || string.Equals(path, + $"/api/v1/{tenantId}/setup/complete", + StringComparison.OrdinalIgnoreCase); } private static async Task RejectOrRedirectAsync(HttpContext context, string location, int statusCode) { - if (HttpMethods.IsGet(context.Request.Method) && context.Request.Headers.Accept.Any(x => x.Contains("text/html", StringComparison.OrdinalIgnoreCase))) { context.Response.Redirect(location); return; } + if (HttpMethods.IsGet(context.Request.Method) && + context.Request.Headers.Accept.Any( + x => x != null && x.Contains("text/html", StringComparison.OrdinalIgnoreCase))) + { context.Response.Redirect(location); return; } context.Response.StatusCode = statusCode; context.Response.ContentType = "application/problem+json"; - await context.Response.WriteAsJsonAsync(new { title = "Setup required", detail = "Complete the required setup before using this endpoint.", setup = location }, context.RequestAborted); + await context.Response.WriteAsJsonAsync( + new ProblemDetails + { + Title = "Setup required", + Detail = $"Complete the required setup at {location} before using this endpoint." + }, + context.RequestAborted); } } diff --git a/src/server/RemoteTickets.Infrastructure/Tenancy/TenantManagementService.cs b/src/server/RemoteTickets.Infrastructure/Tenancy/TenantManagementService.cs index 0a1ef56..b6a7b21 100644 --- a/src/server/RemoteTickets.Infrastructure/Tenancy/TenantManagementService.cs +++ b/src/server/RemoteTickets.Infrastructure/Tenancy/TenantManagementService.cs @@ -27,7 +27,7 @@ public async Task CreateAsync(CreateTenantRequest request, Cance var tenant = new Tenant { - Id = request.Id, + Id = Guid.CreateVersion7().ToString(), Name = request.Name, DatabaseName = request.DatabaseName, ConnectionString = request.ConnectionString, @@ -56,7 +56,7 @@ public async Task GetSetupStatusAsync(string tenantId Tenant tenant = await GetTenantEntityAsync(tenantId, cancellationToken); await using TenantSetupDbContext context = CreateSetupContext(tenant.ConnectionString); await context.Database.EnsureCreatedAsync(cancellationToken); - TenantSetupState? state = await context.SetupStates.SingleOrDefaultAsync(x => x.Id == 1, cancellationToken); + TenantSetupState? state = await context.SetupStates.SingleOrDefaultAsync(x => x.Id == RemoteTicketsConstants.TenantSetupId, cancellationToken); return new TenantSetupStatusResponse(state is null || !state.IsComplete, state?.IsComplete == true); } @@ -66,10 +66,10 @@ public async Task CompleteSetupAsync(string tenantId, Tenant tenant = await GetTenantEntityAsync(tenantId, cancellationToken); await using TenantSetupDbContext context = CreateSetupContext(tenant.ConnectionString); await context.Database.EnsureCreatedAsync(cancellationToken); - TenantSetupState? state = await context.SetupStates.SingleOrDefaultAsync(x => x.Id == 1, cancellationToken); + TenantSetupState? state = await context.SetupStates.SingleOrDefaultAsync(x => x.Id == RemoteTicketsConstants.TenantSetupId, cancellationToken); if (state is null) { - state = new TenantSetupState { Id = 1 }; + state = new TenantSetupState { Id = RemoteTicketsConstants.TenantSetupId }; context.SetupStates.Add(state); } diff --git a/src/server/RemoteTickets.Infrastructure/Tenancy/TenantSetupDbContext.cs b/src/server/RemoteTickets.Infrastructure/Tenancy/TenantSetupDbContext.cs index 2487574..4cb2b2c 100644 --- a/src/server/RemoteTickets.Infrastructure/Tenancy/TenantSetupDbContext.cs +++ b/src/server/RemoteTickets.Infrastructure/Tenancy/TenantSetupDbContext.cs @@ -9,6 +9,6 @@ public sealed class TenantSetupDbContext(DbContextOptions /// protected override void OnModelCreating(ModelBuilder modelBuilder) { - modelBuilder.ApplyConfigurationsFromAssembly(typeof(TenancyConfigurations).Assembly); + modelBuilder.ApplyConfigurationsFromAssembly(typeof(TenantSetupStateConfiguration).Assembly); } } diff --git a/src/server/RemoteTickets/Controllers/SetupController.cs b/src/server/RemoteTickets/Controllers/SetupController.cs deleted file mode 100644 index b61688c..0000000 --- a/src/server/RemoteTickets/Controllers/SetupController.cs +++ /dev/null @@ -1,68 +0,0 @@ -namespace RemoteTickets.Controllers; - -/// Exposes anonymous endpoints used during first-time application setup. -/// The mediator used to dispatch setup requests. -/// The store used to persist the master database connection. -[ApiController] -[Route("api/setup")] -public sealed class SetupController(IMediator mediator, ISetupConfigurationStore configurationStore) : ControllerBase -{ - /// Gets the current first-time setup status. - [HttpGet("status")] - [AllowAnonymous] - public Task GetStatus(CancellationToken cancellationToken) => mediator.RequestAsync(new GetSetupStatusQuery(), cancellationToken); - - /// Persists the master database connection string and initializes its schema. - [HttpPost("master-database")] - [AllowAnonymous] - public async Task ConfigureMasterDatabase(MasterDatabaseSetupRequest request, CancellationToken cancellationToken) - { - if (string.IsNullOrWhiteSpace(request.ConnectionString)) - { - return BadRequest(new { error = "A master database connection string is required." }); - } - - await configurationStore.SetMasterConnectionStringAsync(request.ConnectionString, cancellationToken); - DbContextOptions options = new DbContextOptionsBuilder().UseSqlServer(request.ConnectionString).Options; - await using var dbContext = new RemoteTicketsDbContext(options); - await dbContext.Database.EnsureCreatedAsync(cancellationToken); - return Ok(); - } - - /// Initializes the application with its first system administrator account. - [HttpPost("initialize")] - [AllowAnonymous] - public async Task Initialize(InitializeSetupRequest request, CancellationToken cancellationToken) - { - IdentityResultResponse result = await mediator.RequestAsync(new InitializeSetupCommand(request.Email, request.Password), cancellationToken); - if (!result.Succeeded) - { - return Conflict(result); - } - - string? connectionString = configurationStore.GetMasterConnectionString(); - if (!string.IsNullOrWhiteSpace(connectionString)) - { - DbContextOptions options = new DbContextOptionsBuilder().UseSqlServer(connectionString).Options; - await using var dbContext = new RemoteTicketsDbContext(options); - SystemSetupState? state = await dbContext.SystemSetup.SingleOrDefaultAsync(x => x.Id == 1, cancellationToken); - if (state is null) - { - state = new SystemSetupState { Id = 1 }; - dbContext.SystemSetup.Add(state); - } - state.IsComplete = true; - state.CompletedAt = DateTimeOffset.UtcNow; - await dbContext.SaveChangesAsync(cancellationToken); - } - return Ok(result); - } -} - -/// Represents the master database setup payload. -/// The SQL Server connection string used by the tenant catalog. -public sealed record MasterDatabaseSetupRequest(string ConnectionString); -/// Represents the first-time setup administrator credentials. -/// The administrator email address. -/// The administrator password. -public sealed record InitializeSetupRequest(string Email, string Password); diff --git a/src/server/RemoteTickets/Controllers/TenantSetupController.cs b/src/server/RemoteTickets/Controllers/TenantSetupController.cs deleted file mode 100644 index 8dc12b3..0000000 --- a/src/server/RemoteTickets/Controllers/TenantSetupController.cs +++ /dev/null @@ -1,28 +0,0 @@ -namespace RemoteTickets.Controllers; - -/// Exposes setup and validation operations for an individual tenant database. -/// The tenant management service. -[ApiController] -[Route("/api/v1/{tenantId}/setup")] -public sealed class TenantSetupController(ITenantManagementService tenants) : ControllerBase -{ - /// Gets the current tenant setup state. - /// The tenant identifier. - /// The token used to cancel the request. - /// The tenant setup state. - [HttpGet] - [AllowAnonymous] - public Task GetStatus(string tenantId, CancellationToken cancellationToken) => tenants.GetSetupStatusAsync(tenantId, cancellationToken); - - /// Completes tenant setup after the required tenant validations have passed. - /// The tenant identifier. - /// The token used to cancel the request. - /// The resulting tenant setup state. - [HttpPost("complete")] - [Authorize(Policy = TenantPolicies.TenantAdmin)] - public async Task Complete(string tenantId, CancellationToken cancellationToken) - { - TenantSetupStatusResponse result = await tenants.CompleteSetupAsync(tenantId, cancellationToken); - return Ok(result); - } -} diff --git a/src/server/RemoteTickets/Controllers/IdentityController.cs b/src/server/RemoteTickets/Controllers/v1/Identity/IdentityController.cs similarity index 100% rename from src/server/RemoteTickets/Controllers/IdentityController.cs rename to src/server/RemoteTickets/Controllers/v1/Identity/IdentityController.cs diff --git a/src/server/RemoteTickets/Controllers/v1/System/SetupController.cs b/src/server/RemoteTickets/Controllers/v1/System/SetupController.cs new file mode 100644 index 0000000..5a6b340 --- /dev/null +++ b/src/server/RemoteTickets/Controllers/v1/System/SetupController.cs @@ -0,0 +1,46 @@ +namespace RemoteTickets.Controllers.v1.System; + +/// Exposes anonymous endpoints used during first-time application setup. +/// The mediator used to dispatch setup requests. +[ApiController] +[Route("api/v1/setup")] +[Tags("System", "Setup")] +public sealed class SetupController(IMediator mediator) : ControllerBase +{ + /// Gets the current first-time setup status. + [HttpGet("status")] + [AllowAnonymous] + [ProducesResponseType(StatusCodes.Status200OK)] + public async Task GetStatus(CancellationToken cancellationToken) + => Ok(await mediator.RequestAsync( + new GetSetupStatusQuery(), cancellationToken)); + + /// Persists the master database connection string and initializes its schema. + [HttpPost("database")] + [AllowAnonymous] + [ProducesResponseType(StatusCodes.Status200OK)] + [ProducesResponseType(StatusCodes.Status400BadRequest)] + [ProducesResponseType(StatusCodes.Status405MethodNotAllowed)] + [ProducesResponseType(StatusCodes.Status503ServiceUnavailable)] + public async Task ConfigureMasterDatabase(MasterDatabaseSetupRequest request, CancellationToken cancellationToken) + { + MasterDatabaseSetupResponse response = await mediator.RequestAsync( + new MasterDatabaseSetupCommand(request), cancellationToken); + return response.Status ? Ok(response) : StatusCode(StatusCodes.Status503ServiceUnavailable, response); + } + + /// Initializes the application with its first system administrator account. + [HttpPost("initialize")] + [AllowAnonymous] + [ProducesResponseType(StatusCodes.Status200OK)] + [ProducesResponseType(StatusCodes.Status400BadRequest)] + [ProducesResponseType(StatusCodes.Status405MethodNotAllowed)] + [ProducesResponseType(StatusCodes.Status409Conflict)] + public async Task Initialize(InitializeSetupRequest request, CancellationToken cancellationToken) + { + IdentityResultResponse result = await mediator.RequestAsync( + new InitializeSetupCommand(request.Email, request.Password), + cancellationToken); + return result.Succeeded ? Ok(result) : Conflict(result); + } +} diff --git a/src/server/RemoteTickets/Controllers/TenantController.cs b/src/server/RemoteTickets/Controllers/v1/Tenant/TenantController.cs similarity index 52% rename from src/server/RemoteTickets/Controllers/TenantController.cs rename to src/server/RemoteTickets/Controllers/v1/Tenant/TenantController.cs index 4a8e6a6..5bf71bb 100644 --- a/src/server/RemoteTickets/Controllers/TenantController.cs +++ b/src/server/RemoteTickets/Controllers/v1/Tenant/TenantController.cs @@ -1,31 +1,37 @@ -namespace RemoteTickets.Controllers; +namespace RemoteTickets.Controllers.v1.Tenant; /// Exposes system-level tenant provisioning endpoints. /// The tenant management service. [ApiController] [Route("/api/v1/system/tenants")] [Authorize(Policy = TenantPolicies.SysAdmin)] -public sealed class TenantController(ITenantManagementService tenants) : ControllerBase +public sealed class TenantController(IMediator mediator) : ControllerBase { /// Provisions a tenant database and its first tenant administrator. /// The tenant provisioning request. /// The token used to cancel the request. /// The newly provisioned tenant. [HttpPost] + [ProducesResponseType(StatusCodes.Status201Created)] + [ProducesResponseType(StatusCodes.Status400BadRequest)] + [ProducesResponseType(StatusCodes.Status405MethodNotAllowed)] public async Task Create(CreateTenantRequest request, CancellationToken cancellationToken) { try { - TenantResponse tenant = await tenants.CreateAsync(request, cancellationToken); + TenantResponse tenant = + await mediator.RequestAsync( + request.ToCommand(), + cancellationToken); return Created($"/api/v1/{tenant.Id}/setup", tenant); } catch (ArgumentException exception) { - return BadRequest(new { error = exception.Message }); + return BadRequest(new ProblemDetails{ Title="Argument Exception", Detail = exception.Message }); } catch (InvalidOperationException exception) { - return Conflict(new { error = exception.Message }); + return Conflict(new ProblemDetails { Title = "Invalid Operation Exception", Detail = exception.Message }); } } @@ -34,9 +40,16 @@ public async Task Create(CreateTenantRequest request, Cancellatio /// The token used to cancel the request. /// The tenant metadata. [HttpGet("{tenantId}")] + [ProducesResponseType(StatusCodes.Status200OK)] + [ProducesResponseType(StatusCodes.Status400BadRequest)] + [ProducesResponseType(StatusCodes.Status404NotFound)] + [ProducesResponseType(StatusCodes.Status405MethodNotAllowed)] public async Task Get(string tenantId, CancellationToken cancellationToken) { - TenantResponse? tenant = await tenants.GetAsync(tenantId, cancellationToken); + TenantResponse? tenant = + await mediator.RequestAsync( + new GetTenantQuery(tenantId), + cancellationToken); return tenant is null ? NotFound() : Ok(tenant); } } diff --git a/src/server/RemoteTickets/Controllers/v1/Tenant/TenantSetupController.cs b/src/server/RemoteTickets/Controllers/v1/Tenant/TenantSetupController.cs new file mode 100644 index 0000000..5b327e2 --- /dev/null +++ b/src/server/RemoteTickets/Controllers/v1/Tenant/TenantSetupController.cs @@ -0,0 +1,41 @@ +namespace RemoteTickets.Controllers.v1.Tenant; + +/// Exposes setup and validation operations for an individual tenant database. +/// The tenant management service. +[ApiController] +[Route("/api/v1/{tenantId}/setup")] +[Tags("Tenant", "Setup")] +public sealed class TenantSetupController(IMediator mediator) : ControllerBase +{ + /// Gets the current tenant setup state. + /// The tenant identifier. + /// The token used to cancel the request. + /// The tenant setup state. + [HttpGet] + [AllowAnonymous] + [ProducesResponseType(StatusCodes.Status200OK)] + public async Task GetStatus(string tenantId, CancellationToken cancellationToken) + => Ok(await mediator.RequestAsync( + new GetTenantSetupStatusQuery(tenantId), + cancellationToken)); + + + /// Completes tenant setup after the required tenant validations have passed. + /// The tenant identifier. + /// The token used to cancel the request. + /// The resulting tenant setup state. + [HttpPost("complete")] + [Authorize(Policy = TenantPolicies.TenantAdmin)] + [ProducesResponseType(StatusCodes.Status200OK)] + [ProducesResponseType(StatusCodes.Status401Unauthorized)] + [ProducesResponseType(StatusCodes.Status403Forbidden)] + [ProducesResponseType(StatusCodes.Status405MethodNotAllowed)] + [ProducesResponseType(StatusCodes.Status408RequestTimeout)] + [ProducesResponseType(StatusCodes.Status409Conflict)] + public async Task Complete(string tenantId, CancellationToken cancellationToken) + { + TenantSetupStatusResponse result = await mediator.RequestAsync( + new CompleteTenantSetupCommand(tenantId), cancellationToken); + return Ok(result); + } +} diff --git a/src/server/RemoteTickets/GlobalUsings.cs b/src/server/RemoteTickets/GlobalUsings.cs index 4a01f27..5da70fb 100644 --- a/src/server/RemoteTickets/GlobalUsings.cs +++ b/src/server/RemoteTickets/GlobalUsings.cs @@ -4,14 +4,15 @@ global using System.Threading; global using System.Threading.Tasks; global using RemoteTickets.Application.Common.Identity; +global using RemoteTickets.Application.Common.System; global using RemoteTickets.Application.Common.Tenancy; global using RemoteTickets.Application.Identity.Requests; +global using RemoteTickets.Application.System.Requests; +global using RemoteTickets.Application.Tenant.Requests; global using RemoteTickets.Composition; global using RemoteTickets.Components; -global using RemoteTickets.Infrastructure.Persistence; -global using RemoteTickets.Infrastructure.Setup; global using Mediator.Net; global using Microsoft.AspNetCore.Authorization; global using Microsoft.AspNetCore.Builder; +global using Microsoft.AspNetCore.Http; global using Microsoft.AspNetCore.Mvc; -global using Microsoft.EntityFrameworkCore; diff --git a/tests/server/RemoteTickets.UnitTests/GlobalUsings.cs b/tests/server/RemoteTickets.UnitTests/GlobalUsings.cs index aa8fefd..0e4dbeb 100644 --- a/tests/server/RemoteTickets.UnitTests/GlobalUsings.cs +++ b/tests/server/RemoteTickets.UnitTests/GlobalUsings.cs @@ -8,6 +8,7 @@ global using System.Threading.Tasks; global using FluentAssertions; global using FluentValidation; +global using FluentValidation.Results; global using RemoteTickets.Application.Common.Identity; global using RemoteTickets.Application.Common.Tenancy; global using RemoteTickets.Application.Identity; @@ -15,6 +16,7 @@ global using RemoteTickets.Application.Identity.Requests; global using RemoteTickets.Application.Identity.Validators; global using RemoteTickets.Application.Pipeline.Validation; +global using RemoteTickets.Application.System.Requests; global using RemoteTickets.Infrastructure.Identity.Models; global using RemoteTickets.Infrastructure.Identity.Services; global using RemoteTickets.Infrastructure.Persistence; diff --git a/tests/server/RemoteTickets.UnitTests/IdentityServiceTests.cs b/tests/server/RemoteTickets.UnitTests/IdentityServiceTests.cs index 2287e97..7fc562a 100644 --- a/tests/server/RemoteTickets.UnitTests/IdentityServiceTests.cs +++ b/tests/server/RemoteTickets.UnitTests/IdentityServiceTests.cs @@ -1,3 +1,5 @@ +using RemoteTickets.Infrastructure.Setup; + namespace RemoteTickets.UnitTests; /// Verifies end-to-end identity service workflows using the test Identity infrastructure. @@ -92,7 +94,7 @@ private IdentityFixture(ServiceProvider provider, CapturingEmailSender emailSend _provider = provider; EmailSender = emailSender; } - + public ISetupConfigurationStore ConfigurationStore => _provider.GetRequiredService(); public IdentityService Service => _provider.GetRequiredService(); public IJwtTokenService TokenService => _provider.GetRequiredService(); public UserManager UserManager => _provider.GetRequiredService>(); @@ -133,6 +135,7 @@ public static async Task CreateAsync() services.AddSingleton(); services.AddScoped(); services.AddSingleton(emailSender); + services.AddScoped(); services.AddScoped(); ServiceProvider provider = services.BuildServiceProvider(); await provider.GetRequiredService().Database.EnsureCreatedAsync(); diff --git a/tests/server/RemoteTickets.UnitTests/IdentityTwoFactorTests.cs b/tests/server/RemoteTickets.UnitTests/IdentityTwoFactorTests.cs index d23c717..ecd369b 100644 --- a/tests/server/RemoteTickets.UnitTests/IdentityTwoFactorTests.cs +++ b/tests/server/RemoteTickets.UnitTests/IdentityTwoFactorTests.cs @@ -43,7 +43,9 @@ public async Task Two_factor_should_reject_unknown_user_and_invalid_code() (await fixture.Service.ConfigureTwoFactorAsync("missing", true, "123456", false, false, false, CancellationToken.None)).Should().BeNull(); - await fixture.Service.InitializeSetupAsync("admin@example.com", "Password1!", CancellationToken.None); + IdentityResultResponse setup = await fixture.Service.InitializeSetupAsync("admin@example.com", "Password1!", CancellationToken.None); + setup.Should().NotBeNull(); + setup.Succeeded.Should().BeTrue(); User? user = await fixture.UserManager.FindByEmailAsync("admin@example.com"); user.Should().NotBeNull(); diff --git a/tests/server/RemoteTickets.UnitTests/IdentityValidatorTests.cs b/tests/server/RemoteTickets.UnitTests/IdentityValidatorTests.cs index 4d621cc..d0522a3 100644 --- a/tests/server/RemoteTickets.UnitTests/IdentityValidatorTests.cs +++ b/tests/server/RemoteTickets.UnitTests/IdentityValidatorTests.cs @@ -1,5 +1,3 @@ -using FluentValidation.Results; - namespace RemoteTickets.UnitTests; /// Verifies the validation rules for identity requests. From fbb4873f001e922590133c071306df79b8bdf0d5 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:27:05 -0300 Subject: [PATCH 059/112] feat: document auditable entity contracts --- .../Common/EntityAuditable.cs | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/src/server/RemoteTickets.Domain/Common/EntityAuditable.cs b/src/server/RemoteTickets.Domain/Common/EntityAuditable.cs index 9127384..8ecd62b 100644 --- a/src/server/RemoteTickets.Domain/Common/EntityAuditable.cs +++ b/src/server/RemoteTickets.Domain/Common/EntityAuditable.cs @@ -1,15 +1,28 @@ namespace RemoteTickets.Domain.Common; +/// Defines creation metadata that is persisted with an auditable entity. public interface IEntityAuditable { + /// Gets the UTC timestamp at which the entity was created. DateTimeOffset CreatedAt { get; init; } + + /// Gets the identifier of the actor that created the entity. string CreatedBy { get; init; } } +/// Defines the state transition recorded for an auditable entity. +/// The auditable entity contract represented by the history record. public interface IEntityUpdateHistory where T : IEntityAuditable { + /// Gets the serialized state after the operation. string CurrentEntityState { get; init; } - string PreviousEntityState { get; init; } + + /// Gets the serialized state before the operation. + string PreviousEntityState { get; init; } + + /// Gets the UTC timestamp at which the state transition was recorded. DateTimeOffset UpdatedAt { get; init; } + + /// Gets or sets the identifier of the actor that caused the state transition. string UpdatedBy { get; set; } -} \ No newline at end of file +} From d41eacacc577d6742c62742395fbf85772fb8824 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:27:09 -0300 Subject: [PATCH 060/112] feat: add persistence audit record --- .../Persistence/Auditing/EntityAuditRecord.cs | 29 +++++++++++++++++++ 1 file changed, 29 insertions(+) create mode 100644 src/server/RemoteTickets.Infrastructure/Persistence/Auditing/EntityAuditRecord.cs diff --git a/src/server/RemoteTickets.Infrastructure/Persistence/Auditing/EntityAuditRecord.cs b/src/server/RemoteTickets.Infrastructure/Persistence/Auditing/EntityAuditRecord.cs new file mode 100644 index 0000000..9e32646 --- /dev/null +++ b/src/server/RemoteTickets.Infrastructure/Persistence/Auditing/EntityAuditRecord.cs @@ -0,0 +1,29 @@ +namespace RemoteTickets.Infrastructure.Persistence.Auditing; + +/// Represents a persisted state transition for an auditable entity. +public sealed class EntityAuditRecord : IEntityUpdateHistory +{ + /// Gets or sets the audit record identifier. + public string Id { get; set; } = Guid.CreateVersion7().ToString(); + + /// Gets or sets the CLR entity type name represented by the record. + public string EntityType { get; set; } = string.Empty; + + /// Gets or sets the identifier of the audited entity. + public string EntityId { get; set; } = string.Empty; + + /// Gets or sets the operation that caused the audit entry. + public string Operation { get; set; } = string.Empty; + + /// + public string CurrentEntityState { get; init; } = string.Empty; + + /// + public string PreviousEntityState { get; init; } = string.Empty; + + /// + public DateTimeOffset UpdatedAt { get; init; } = DateTimeOffset.UtcNow; + + /// + public string UpdatedBy { get; set; } = string.Empty; +} From 3ec029b918d1b51b584eb36a20704a0c6bfc3640 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:27:14 -0300 Subject: [PATCH 061/112] feat: map audit history to dedicated schema --- .../EntityAuditRecordConfiguration.cs | 21 +++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 src/server/RemoteTickets.Infrastructure/Persistence/Configurations/Auditing/EntityAuditRecordConfiguration.cs diff --git a/src/server/RemoteTickets.Infrastructure/Persistence/Configurations/Auditing/EntityAuditRecordConfiguration.cs b/src/server/RemoteTickets.Infrastructure/Persistence/Configurations/Auditing/EntityAuditRecordConfiguration.cs new file mode 100644 index 0000000..370a682 --- /dev/null +++ b/src/server/RemoteTickets.Infrastructure/Persistence/Configurations/Auditing/EntityAuditRecordConfiguration.cs @@ -0,0 +1,21 @@ +namespace RemoteTickets.Infrastructure.Persistence.Configurations.Auditing; + +/// Configures the SQL representation of persisted entity audit history. +public sealed class EntityAuditRecordConfiguration : IEntityTypeConfiguration +{ + /// + public void Configure(EntityTypeBuilder builder) + { + builder.ToTable("EntityHistory", "audit"); + builder.HasKey(x => x.Id); + builder.Property(x => x.Id).HasMaxLength(36).IsRequired(); + builder.Property(x => x.EntityType).HasMaxLength(256).IsRequired(); + builder.Property(x => x.EntityId).HasMaxLength(128).IsRequired(); + builder.Property(x => x.Operation).HasMaxLength(32).IsRequired(); + builder.Property(x => x.UpdatedBy).HasMaxLength(256).IsRequired(); + builder.Property(x => x.UpdatedAt).IsRequired(); + builder.Property(x => x.PreviousEntityState).IsRequired(); + builder.Property(x => x.CurrentEntityState).IsRequired(); + builder.HasIndex(x => new { x.EntityType, x.EntityId, x.UpdatedAt }); + } +} From 1985c0e07db686d638e585beda554bc8d857353b Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:27:21 -0300 Subject: [PATCH 062/112] chore: import audit persistence dependencies --- src/server/RemoteTickets.Infrastructure/GlobalUsings.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/server/RemoteTickets.Infrastructure/GlobalUsings.cs b/src/server/RemoteTickets.Infrastructure/GlobalUsings.cs index efb41ba..11d1d41 100644 --- a/src/server/RemoteTickets.Infrastructure/GlobalUsings.cs +++ b/src/server/RemoteTickets.Infrastructure/GlobalUsings.cs @@ -7,6 +7,7 @@ global using System.Linq.Expressions; global using System.Security.Claims; global using System.Text; +global using System.Text.Json; global using System.Threading; global using System.Threading.Tasks; global using RemoteTickets.Application.Common.Identity; @@ -18,6 +19,7 @@ global using RemoteTickets.Domain.Common; global using RemoteTickets.Infrastructure.Identity.Models; global using RemoteTickets.Infrastructure.Persistence; +global using RemoteTickets.Infrastructure.Persistence.Auditing; global using RemoteTickets.Infrastructure.Setup; global using RemoteTickets.Infrastructure.Tenancy.Configurations; global using RemoteTickets.Infrastructure.Tenancy.Models; From 18e17d62de64ef214d98a4d11abb594f38b82a42 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:27:32 -0300 Subject: [PATCH 063/112] feat: add entity audit history to persistence save pipeline --- .../Persistence/RemoteTicketsDbContext.cs | 110 +++++++++++++++++- 1 file changed, 104 insertions(+), 6 deletions(-) diff --git a/src/server/RemoteTickets.Infrastructure/Persistence/RemoteTicketsDbContext.cs b/src/server/RemoteTickets.Infrastructure/Persistence/RemoteTicketsDbContext.cs index 0403c53..8e474c0 100644 --- a/src/server/RemoteTickets.Infrastructure/Persistence/RemoteTicketsDbContext.cs +++ b/src/server/RemoteTickets.Infrastructure/Persistence/RemoteTicketsDbContext.cs @@ -2,14 +2,20 @@ namespace RemoteTickets.Infrastructure.Persistence; -/// Represents the central database context for RemoteTickets identity, setup, and tenant catalog data. -public sealed class RemoteTicketsDbContext(DbContextOptions options) : IdentityDbContext(options) +/// Represents the central database context for RemoteTickets identity, setup, tenant catalog, and audit data. +public sealed class RemoteTicketsDbContext(DbContextOptions options, IHttpContextAccessor? httpContextAccessor = null) : IdentityDbContext(options) { + private readonly IHttpContextAccessor? _httpContextAccessor = httpContextAccessor; + /// Gets the registered tenants. public DbSet Tenants => Set(); + /// Gets the singleton system setup state. public DbSet SystemSetup => Set(); + /// Gets the persisted entity state transitions stored in the audit schema. + public DbSet EntityAuditHistory => Set(); + /// protected override void OnModelCreating(ModelBuilder builder) { @@ -26,17 +32,109 @@ protected override void OnModelCreating(ModelBuilder builder) LambdaExpression filter = Expression.Lambda(Expression.Not(property), parameter); builder.Entity(entityType.ClrType).HasQueryFilter(filter); } + builder.ApplyConfigurationsFromAssembly(typeof(RemoteTicketsDbContext).Assembly); } /// - public override int SaveChanges(bool acceptAllChangesOnSuccess) { ApplySoftDelete(); return base.SaveChanges(acceptAllChangesOnSuccess); } + public override int SaveChanges(bool acceptAllChangesOnSuccess) + { + PreparePersistenceChanges(); + return base.SaveChanges(acceptAllChangesOnSuccess); + } + /// - public override int SaveChanges() { ApplySoftDelete(); return base.SaveChanges(); } + public override int SaveChanges() + { + PreparePersistenceChanges(); + return base.SaveChanges(); + } + /// - public override Task SaveChangesAsync(bool acceptAllChangesOnSuccess, CancellationToken cancellationToken = default) { ApplySoftDelete(); return base.SaveChangesAsync(acceptAllChangesOnSuccess, cancellationToken); } + public override Task SaveChangesAsync(bool acceptAllChangesOnSuccess, CancellationToken cancellationToken = default) + { + PreparePersistenceChanges(); + return base.SaveChangesAsync(acceptAllChangesOnSuccess, cancellationToken); + } + /// - public override Task SaveChangesAsync(CancellationToken cancellationToken = default) { ApplySoftDelete(); return base.SaveChangesAsync(cancellationToken); } + public override Task SaveChangesAsync(CancellationToken cancellationToken = default) + { + PreparePersistenceChanges(); + return base.SaveChangesAsync(cancellationToken); + } + + private void PreparePersistenceChanges() + { + ApplySoftDelete(); + ApplyCreationMetadata(); + AddAuditEntries(); + } + + private void ApplyCreationMetadata() + { + string actor = GetActor(); + DateTimeOffset now = DateTimeOffset.UtcNow; + + foreach (EntityEntry entry in ChangeTracker.Entries().Where(x => x.State == EntityState.Added)) + { + entry.Property(nameof(IEntityAuditable.CreatedAt)).CurrentValue = now; + entry.Property(nameof(IEntityAuditable.CreatedBy)).CurrentValue = actor; + } + } + + private void AddAuditEntries() + { + string actor = GetActor(); + DateTimeOffset now = DateTimeOffset.UtcNow; + List auditEntries = new(); + + foreach (EntityEntry entry in ChangeTracker.Entries().ToArray()) + { + if (entry.Entity is EntityAuditRecord || entry.State is not (EntityState.Added or EntityState.Modified or EntityState.Deleted)) + { + continue; + } + + PropertyEntry? idProperty = entry.Properties.FirstOrDefault(x => string.Equals(x.Metadata.Name, "Id", StringComparison.OrdinalIgnoreCase)); + if (idProperty is null || idProperty.CurrentValue is null) + { + continue; + } + + string operation = entry.State switch + { + EntityState.Added => "Created", + EntityState.Modified => "Updated", + EntityState.Deleted => "Deleted", + _ => throw new InvalidOperationException("Unsupported audit state.") + }; + + object previousState = entry.State == EntityState.Added ? new { } : entry.OriginalValues.ToObject(); + object currentState = entry.State == EntityState.Deleted ? entry.OriginalValues.ToObject() : entry.CurrentValues.ToObject(); + auditEntries.Add(new EntityAuditRecord + { + EntityType = entry.Metadata.ClrType.FullName ?? entry.Metadata.ClrType.Name, + EntityId = idProperty.CurrentValue.ToString() ?? string.Empty, + Operation = operation, + PreviousEntityState = JsonSerializer.Serialize(previousState), + CurrentEntityState = JsonSerializer.Serialize(currentState), + UpdatedAt = now, + UpdatedBy = actor + }); + } + + if (auditEntries.Count != 0) + { + EntityAuditHistory.AddRange(auditEntries); + } + } + + private string GetActor() + => _httpContextAccessor?.HttpContext?.User.FindFirstValue(ClaimTypes.NameIdentifier) + ?? _httpContextAccessor?.HttpContext?.User.FindFirstValue(JwtRegisteredClaimNames.Sub) + ?? _httpContextAccessor?.HttpContext?.User.FindFirstValue(ClaimTypes.Email) + ?? "system"; private void ApplySoftDelete() { From 870544dc2e46258cff5d46097ded96a45a8d1749 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:27:41 -0300 Subject: [PATCH 064/112] fix: avoid auditing non-auditable audit records --- .../Persistence/RemoteTicketsDbContext.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/server/RemoteTickets.Infrastructure/Persistence/RemoteTicketsDbContext.cs b/src/server/RemoteTickets.Infrastructure/Persistence/RemoteTicketsDbContext.cs index 8e474c0..507d911 100644 --- a/src/server/RemoteTickets.Infrastructure/Persistence/RemoteTicketsDbContext.cs +++ b/src/server/RemoteTickets.Infrastructure/Persistence/RemoteTicketsDbContext.cs @@ -91,7 +91,7 @@ private void AddAuditEntries() foreach (EntityEntry entry in ChangeTracker.Entries().ToArray()) { - if (entry.Entity is EntityAuditRecord || entry.State is not (EntityState.Added or EntityState.Modified or EntityState.Deleted)) + if (entry.State is not (EntityState.Added or EntityState.Modified or EntityState.Deleted)) { continue; } From 42294eb2663e22b03685d9d8de66eae7483cf6bd Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:27:46 -0300 Subject: [PATCH 065/112] feat: make users auditable --- .../RemoteTickets.Infrastructure/Identity/Models/User.cs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/server/RemoteTickets.Infrastructure/Identity/Models/User.cs b/src/server/RemoteTickets.Infrastructure/Identity/Models/User.cs index 29b5e51..68783fd 100644 --- a/src/server/RemoteTickets.Infrastructure/Identity/Models/User.cs +++ b/src/server/RemoteTickets.Infrastructure/Identity/Models/User.cs @@ -1,7 +1,7 @@ namespace RemoteTickets.Infrastructure.Identity.Models; /// Represents a user in the RemoteTickets application. -public class User : IdentityUser, ISoftDeletable +public class User : IdentityUser, ISoftDeletable, IEntityAuditable { /// User name displayed in the application. public string? DisplayName { get; set; } = string.Empty; @@ -11,6 +11,10 @@ public class User : IdentityUser, ISoftDeletable public string? SurName { get; set; } = string.Empty; /// Gets or sets the tenant to which the user belongs. A null value identifies a system administrator. public string? TenantId { get; set; } + /// + public DateTimeOffset CreatedAt { get; init; } + /// + public string CreatedBy { get; init; } = string.Empty; /// Indicates whether the user is deleted. public bool IsDeleted { get; set; } /// Gets or sets the date and time when the user was deleted. From ff02f17256b08e0c2cfcb77456f04c009def8ba8 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:27:57 -0300 Subject: [PATCH 066/112] feat: make roles auditable --- .../Identity/Models/Role.cs | 28 +++++++++---------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/src/server/RemoteTickets.Infrastructure/Identity/Models/Role.cs b/src/server/RemoteTickets.Infrastructure/Identity/Models/Role.cs index 04b9c22..bc8b490 100644 --- a/src/server/RemoteTickets.Infrastructure/Identity/Models/Role.cs +++ b/src/server/RemoteTickets.Infrastructure/Identity/Models/Role.cs @@ -1,21 +1,21 @@ namespace RemoteTickets.Infrastructure.Identity.Models; -/// -/// Represents a role in the RemoteTickets application. -/// -public class Role : IdentityRole, ISoftDeletable + +/// Represents a role in the RemoteTickets application. +public class Role : IdentityRole, ISoftDeletable, IEntityAuditable { /// Indicates whether the role is deleted. public bool IsDeleted { get; set; } /// Gets or sets the date and time when the role was deleted. public DateTimeOffset? DeletedAt { get; set; } - /// Role parameterless constructor. - public Role() : base() - { - Id = Guid.CreateVersion7().ToString(); - } - /// Role constructor. - public Role(string name) : base(name) - { - Id = Guid.CreateVersion7().ToString(); - } + /// + public DateTimeOffset CreatedAt { get; init; } + /// + public string CreatedBy { get; init; } = string.Empty; + + /// Initializes a role with a new identifier. + public Role() : base() => Id = Guid.CreateVersion7().ToString(); + + /// Initializes a role with the supplied name. + /// The role name. + public Role(string name) : base(name) => Id = Guid.CreateVersion7().ToString(); } From 59d481a59a730d6cfce6e7eb4264830c9bdafe76 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:28:01 -0300 Subject: [PATCH 067/112] feat: make tenants auditable --- .../Tenancy/Models/Tenant.cs | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/server/RemoteTickets.Infrastructure/Tenancy/Models/Tenant.cs b/src/server/RemoteTickets.Infrastructure/Tenancy/Models/Tenant.cs index 882cca6..2b18976 100644 --- a/src/server/RemoteTickets.Infrastructure/Tenancy/Models/Tenant.cs +++ b/src/server/RemoteTickets.Infrastructure/Tenancy/Models/Tenant.cs @@ -1,7 +1,7 @@ namespace RemoteTickets.Infrastructure.Tenancy.Models; /// Represents a tenant registered in the installation catalog. -public sealed class Tenant : IEntityBase, ISoftDeletable +public sealed class Tenant : IEntityBase, ISoftDeletable, IEntityAuditable { /// Gets or sets the stable tenant identifier used by routes and tokens. public string Id { get; set; } = string.Empty; @@ -15,10 +15,12 @@ public sealed class Tenant : IEntityBase, ISoftDeletable public bool IsActive { get; set; } = true; /// Gets or sets whether tenant setup has completed. public bool IsSetupComplete { get; set; } - /// Gets or sets the tenant creation timestamp. - public DateTimeOffset CreatedAt { get; set; } = DateTimeOffset.UtcNow; + /// + public DateTimeOffset CreatedAt { get; init; } = DateTimeOffset.UtcNow; + /// + public string CreatedBy { get; init; } = string.Empty; /// Flag to indicate if the entity is deleted. - public bool IsDeleted { get; set; } - /// DateTimeOffset (UTC) of when the entity was deleted.. + public bool IsDeleted { get; set; } + /// DateTimeOffset (UTC) of when the entity is deleted. public DateTimeOffset? DeletedAt { get; set; } } From 61b9cd611c3d87900232eb363ea57e5cd80c6cbe Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:28:06 -0300 Subject: [PATCH 068/112] feat: make system setup state auditable --- .../RemoteTickets.Infrastructure/Setup/SystemSetupState.cs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/server/RemoteTickets.Infrastructure/Setup/SystemSetupState.cs b/src/server/RemoteTickets.Infrastructure/Setup/SystemSetupState.cs index c904361..34a51be 100644 --- a/src/server/RemoteTickets.Infrastructure/Setup/SystemSetupState.cs +++ b/src/server/RemoteTickets.Infrastructure/Setup/SystemSetupState.cs @@ -1,7 +1,7 @@ namespace RemoteTickets.Infrastructure.Setup; /// Stores the singleton installation setup state in the master database. -public sealed class SystemSetupState +public sealed class SystemSetupState : IEntityAuditable { /// Gets or sets the singleton setup-state identifier. public string Id { get; set; } = RemoteTicketsConstants.SystemSetupId; @@ -9,4 +9,8 @@ public sealed class SystemSetupState public bool IsComplete { get; set; } /// Gets or sets the completion timestamp. public DateTimeOffset? CompletedAt { get; set; } + /// + public DateTimeOffset CreatedAt { get; init; } + /// + public string CreatedBy { get; init; } = string.Empty; } From 97fafe20fa463ad49d4bf3ffdd8dbbe2b6e14531 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:28:15 -0300 Subject: [PATCH 069/112] feat: expose request actor to persistence auditing --- .../RemoteTickets.Composition/WebApplicationBuilderExtensions.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/server/RemoteTickets.Composition/WebApplicationBuilderExtensions.cs b/src/server/RemoteTickets.Composition/WebApplicationBuilderExtensions.cs index cba2a22..48c265e 100644 --- a/src/server/RemoteTickets.Composition/WebApplicationBuilderExtensions.cs +++ b/src/server/RemoteTickets.Composition/WebApplicationBuilderExtensions.cs @@ -18,6 +18,7 @@ public async Task RunRemoteTicketsAsync() where T : IComponent services.AddMudServices(); services.AddControllers(); services.AddHttpClient(); + services.AddHttpContextAccessor(); services.Configure(configuration.GetSection(JwtOptions.SectionName)); services.AddSingleton(); services.AddDbContext((sp, options) => From 0a5d2d9321db22c2c797711bcfa804ca32948140 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:28:32 -0300 Subject: [PATCH 070/112] refactor: use MudBlazor for application layout --- .../Components/Layout/MainLayout.razor | 58 +++++++++++-------- 1 file changed, 35 insertions(+), 23 deletions(-) diff --git a/src/server/RemoteTickets/Components/Layout/MainLayout.razor b/src/server/RemoteTickets/Components/Layout/MainLayout.razor index 9e253ba..3472392 100644 --- a/src/server/RemoteTickets/Components/Layout/MainLayout.razor +++ b/src/server/RemoteTickets/Components/Layout/MainLayout.razor @@ -1,23 +1,35 @@ -@inherits LayoutComponentBase - -
-
- -
- -
-
- About -
- -
- @Body -
-
-
- -
- An unhandled error has occurred. - Reload - 🗙 -
+@inherits LayoutComponentBase + + + + + + + + + + RemoteTickets + + Tenant-aware ticket management + + + + + + + + @Body + + + + + +@code { + private bool DrawerOpen = true; + + private void ToggleDrawer() => DrawerOpen = !DrawerOpen; +} From 6cf30485718cdc99a450d6eafb1c1fdba67134ec Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:28:37 -0300 Subject: [PATCH 071/112] refactor: replace default navigation with MudBlazor --- .../Components/Layout/NavMenu.razor | 41 +++++-------------- 1 file changed, 11 insertions(+), 30 deletions(-) diff --git a/src/server/RemoteTickets/Components/Layout/NavMenu.razor b/src/server/RemoteTickets/Components/Layout/NavMenu.razor index 83de3a1..c2e04df 100644 --- a/src/server/RemoteTickets/Components/Layout/NavMenu.razor +++ b/src/server/RemoteTickets/Components/Layout/NavMenu.razor @@ -1,30 +1,11 @@ -
-
- RemoteTickets -
-
- - - -
- -
- + + RemoteTickets + + + + Home + Counter + Weather + Setup + + From 832ebbf2180c37aa91ff621898795b6ffbcf2b25 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:28:44 -0300 Subject: [PATCH 072/112] refactor: preserve tenant-scoped navigation in MudBlazor menu --- .../Components/Layout/NavMenu.razor | 21 ++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/src/server/RemoteTickets/Components/Layout/NavMenu.razor b/src/server/RemoteTickets/Components/Layout/NavMenu.razor index c2e04df..09c4421 100644 --- a/src/server/RemoteTickets/Components/Layout/NavMenu.razor +++ b/src/server/RemoteTickets/Components/Layout/NavMenu.razor @@ -1,11 +1,22 @@ - +@inject NavigationManager Navigation + + RemoteTickets - Home - Counter - Weather - Setup + Home + Counter + Weather + System setup + +@code { + private string TenantHref(string suffix) + { + string relativePath = Navigation.ToBaseRelativePath(Navigation.Uri).Trim('/'); + string tenantId = relativePath.Split('/', StringSplitOptions.RemoveEmptyEntries).FirstOrDefault() ?? string.Empty; + return string.IsNullOrWhiteSpace(tenantId) ? "/" : $"/{tenantId}/{suffix}".TrimEnd('/'); + } +} From 5926522a0617d49c6aaf48267309ad1dd09a6ef8 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:28:50 -0300 Subject: [PATCH 073/112] fix: simplify Razor tenant navigation expressions --- src/server/RemoteTickets/Components/Layout/NavMenu.razor | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/server/RemoteTickets/Components/Layout/NavMenu.razor b/src/server/RemoteTickets/Components/Layout/NavMenu.razor index 09c4421..d67017e 100644 --- a/src/server/RemoteTickets/Components/Layout/NavMenu.razor +++ b/src/server/RemoteTickets/Components/Layout/NavMenu.razor @@ -5,7 +5,7 @@ - Home + Home Counter Weather System setup From 1df3aca42574c80d2906c91c208334b7643edb12 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:28:59 -0300 Subject: [PATCH 074/112] refactor: migrate home page to MudBlazor --- .../RemoteTickets/Components/Pages/Home.razor | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/src/server/RemoteTickets/Components/Pages/Home.razor b/src/server/RemoteTickets/Components/Pages/Home.razor index 16f5960..1d92aac 100644 --- a/src/server/RemoteTickets/Components/Pages/Home.razor +++ b/src/server/RemoteTickets/Components/Pages/Home.razor @@ -2,8 +2,17 @@ Home -

RemoteTickets

-

Tenant: @TenantId

-@code{ + + + RemoteTickets + Welcome to the tenant workspace. + + + Tenant: @TenantId + + + + +@code { [Parameter] public string TenantId { get; set; } = string.Empty; -} \ No newline at end of file +} From aa5b417c1c0e84ca5219d1a697ebb388b5f3b52b Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:29:03 -0300 Subject: [PATCH 075/112] refactor: migrate counter page to MudBlazor --- .../Components/Pages/Counter.razor | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/src/server/RemoteTickets/Components/Pages/Counter.razor b/src/server/RemoteTickets/Components/Pages/Counter.razor index df64c8a..d3b3770 100644 --- a/src/server/RemoteTickets/Components/Pages/Counter.razor +++ b/src/server/RemoteTickets/Components/Pages/Counter.razor @@ -1,15 +1,22 @@ -@page "/{tenantId}/counter" +@page "/{TenantId}/counter" @rendermode InteractiveServer Counter -

Counter

-

Tenant: @tenantId

-

Current count: @currentCount

- + + + Counter + Tenant: @TenantId + + Current count: @currentCount + + Increment + + + @code { - [Parameter] public string tenantId { get; set; } = string.Empty; + [Parameter] public string TenantId { get; set; } = string.Empty; private int currentCount; private void IncrementCount() => currentCount++; } From f8a3cdc4cfba72f9019ba1bf080f962724439863 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:29:10 -0300 Subject: [PATCH 076/112] refactor: migrate weather page to MudBlazor --- .../Components/Pages/Weather.razor | 53 ++++++++++++------- 1 file changed, 33 insertions(+), 20 deletions(-) diff --git a/src/server/RemoteTickets/Components/Pages/Weather.razor b/src/server/RemoteTickets/Components/Pages/Weather.razor index 2788543..1b98f63 100644 --- a/src/server/RemoteTickets/Components/Pages/Weather.razor +++ b/src/server/RemoteTickets/Components/Pages/Weather.razor @@ -1,30 +1,43 @@ -@page "/{tenantId}/weather" +@page "/{TenantId}/weather" @attribute [StreamRendering] Weather -

Weather

-

Tenant: @tenantId

+ + + Weather + Tenant: @TenantId + -@if (forecasts == null) -{ -

Loading...

-} -else -{ - - - - @foreach (var forecast in forecasts) - { - - } - -
DateTemp. (C)Temp. (F)Summary
@forecast.Date.ToShortDateString()@forecast.TemperatureC@forecast.TemperatureF@forecast.Summary
-} + @if (forecasts == null) + { + + + Loading... + + } + else + { + + + Date + Temperature (C) + Temperature (F) + Summary + + + @context.Date.ToShortDateString() + @context.TemperatureC + @context.TemperatureF + @context.Summary + + + } + + @code { - [Parameter] public string tenantId { get; set; } = string.Empty; + [Parameter] public string TenantId { get; set; } = string.Empty; private WeatherForecast[]? forecasts; protected override async Task OnInitializedAsync() From 3d587c6a6bdcd0c7faadae5a92ecdc85ea8501f5 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:29:15 -0300 Subject: [PATCH 077/112] refactor: migrate error page to MudBlazor --- .../Components/Pages/Error.razor | 70 +++++++++---------- 1 file changed, 35 insertions(+), 35 deletions(-) diff --git a/src/server/RemoteTickets/Components/Pages/Error.razor b/src/server/RemoteTickets/Components/Pages/Error.razor index 9d7fda1..70ef0f6 100644 --- a/src/server/RemoteTickets/Components/Pages/Error.razor +++ b/src/server/RemoteTickets/Components/Pages/Error.razor @@ -1,35 +1,35 @@ -@page "/Error" - -Error - -

Error.

-

An error occurred while processing your request.

- -@if (ShowRequestId) -{ -

- Request ID: @RequestId -

-} - -

Development Mode

-

- Swapping to Development environment will display more detailed information about the error that occurred. -

-

- The Development environment shouldn't be enabled for deployed applications. - It can result in displaying sensitive information from exceptions to end users. - For local debugging, enable the Development environment by setting the ASPNETCORE_ENVIRONMENT environment variable to Development - and restarting the app. -

- -@code{ - [CascadingParameter] - private HttpContext? HttpContext { get; set; } - - private string? RequestId { get; set; } - private bool ShowRequestId => !string.IsNullOrEmpty(RequestId); - - protected override void OnInitialized() => - RequestId = Activity.Current?.Id ?? HttpContext?.TraceIdentifier; -} +@page "/Error" + +Error + + + + An error occurred while processing your request. + Please retry the operation or reload the application. + + + @if (ShowRequestId) + { + + Request ID + @RequestId + + } + + + + Development details are intentionally hidden from deployed applications because exceptions can expose sensitive information. + + + + +@code { + [CascadingParameter] + private HttpContext? HttpContext { get; set; } + + private string? RequestId { get; set; } + private bool ShowRequestId => !string.IsNullOrEmpty(RequestId); + + protected override void OnInitialized() + => RequestId = Activity.Current?.Id ?? HttpContext?.TraceIdentifier; +} From 5da8e743546ad4000c91110cfbfdfbb2343fe685 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:29:19 -0300 Subject: [PATCH 078/112] refactor: migrate not-found page to MudBlazor --- .../Components/Pages/NotFound.razor | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/src/server/RemoteTickets/Components/Pages/NotFound.razor b/src/server/RemoteTickets/Components/Pages/NotFound.razor index f74a7a3..6bd3df8 100644 --- a/src/server/RemoteTickets/Components/Pages/NotFound.razor +++ b/src/server/RemoteTickets/Components/Pages/NotFound.razor @@ -1,5 +1,14 @@ -@page "/not-found" -@layout MainLayout - -

Not Found

-

Sorry, the content you are looking for does not exist.

\ No newline at end of file +@page "/not-found" +@layout MainLayout + +Not Found + + + + + Not Found + + Sorry, the content you are looking for does not exist. + + + From 7044e0e85e49e491aebfeb58f0e70fc1d9ebfe65 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:29:26 -0300 Subject: [PATCH 079/112] refactor: migrate system setup page to MudBlazor --- .../Components/Pages/Setup.razor | 51 +++++++++++-------- 1 file changed, 29 insertions(+), 22 deletions(-) diff --git a/src/server/RemoteTickets/Components/Pages/Setup.razor b/src/server/RemoteTickets/Components/Pages/Setup.razor index 93cd0b6..5c4bbf7 100644 --- a/src/server/RemoteTickets/Components/Pages/Setup.razor +++ b/src/server/RemoteTickets/Components/Pages/Setup.razor @@ -5,29 +5,34 @@ System setup -

System setup

-

Configure the master SQL Server database and create the first system administrator before using the application.

+ + + System setup + + Configure the master SQL Server database and create the first system administrator before using the application. + -
- - -
-
- - -
-
- - -
- -@if (!string.IsNullOrWhiteSpace(Message)) -{ -

@Message

-} + + + + + + @(Busy ? "Initializing..." : "Initialize") + + + + @if (!string.IsNullOrWhiteSpace(Message)) + { + + @Message + + } + + @code { private bool Busy; + private bool SetupSucceeded; private string ConnectionString = string.Empty; private string Email = string.Empty; private string Password = string.Empty; @@ -36,20 +41,22 @@ private async Task InitializeAsync() { Busy = true; + SetupSucceeded = false; Message = string.Empty; try { var client = HttpClientFactory.CreateClient(); client.BaseAddress = new Uri(Navigation.BaseUri); - var configure = await client.PostAsJsonAsync("api/setup/master-database", new { ConnectionString }); + var configure = await client.PostAsJsonAsync("api/v1/setup/database", new { ConnectionString }); if (!configure.IsSuccessStatusCode) { Message = "The master database configuration could not be stored."; return; } - var initialize = await client.PostAsJsonAsync("api/setup/initialize", new { Email, Password }); - Message = initialize.IsSuccessStatusCode ? "Setup completed. You can now sign in." : await initialize.Content.ReadAsStringAsync(); + var initialize = await client.PostAsJsonAsync("api/v1/setup/initialize", new { Email, Password }); + SetupSucceeded = initialize.IsSuccessStatusCode; + Message = SetupSucceeded ? "Setup completed. You can now sign in." : await initialize.Content.ReadAsStringAsync(); } catch (Exception exception) { From 7ff44a648fa895c4c848af864ab9a39e5efa77b9 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:29:32 -0300 Subject: [PATCH 080/112] refactor: migrate tenant setup page to MudBlazor --- .../Components/Pages/TenantSetup.razor | 38 +++++++++++++------ 1 file changed, 27 insertions(+), 11 deletions(-) diff --git a/src/server/RemoteTickets/Components/Pages/TenantSetup.razor b/src/server/RemoteTickets/Components/Pages/TenantSetup.razor index b895486..8a2ae71 100644 --- a/src/server/RemoteTickets/Components/Pages/TenantSetup.razor +++ b/src/server/RemoteTickets/Components/Pages/TenantSetup.razor @@ -1,35 +1,51 @@ -@page "/{tenantId}/setup" +@page "/{TenantId}/setup" @using System.Net.Http.Json @inject IHttpClientFactory HttpClientFactory @inject NavigationManager Navigation Tenant setup -

Tenant setup

-

Tenant @tenantId is not ready for normal operations. Run the database validation and complete setup.

+ + + Tenant setup + + Tenant @TenantId is not ready for normal operations. Run the database validation and complete setup. + - -@if (!string.IsNullOrWhiteSpace(Message)) -{ -

@Message

-} + + @(Busy ? "Validating..." : "Validate and complete setup") + + + @if (!string.IsNullOrWhiteSpace(Message)) + { + + @Message + + } + + @code { - [Parameter] public string tenantId { get; set; } = string.Empty; + [Parameter] public string TenantId { get; set; } = string.Empty; private bool Busy; + private bool SetupSucceeded; private string Message = string.Empty; private async Task CompleteAsync() { Busy = true; + SetupSucceeded = false; + Message = string.Empty; try { var client = HttpClientFactory.CreateClient(); client.BaseAddress = new Uri(Navigation.BaseUri); - var response = await client.PostAsync($"api/v1/{Uri.EscapeDataString(tenantId)}/setup/complete", null); + var response = await client.PostAsync($"api/v1/{Uri.EscapeDataString(TenantId)}/setup/complete", null); if (response.IsSuccessStatusCode) { - Navigation.NavigateTo($"/{tenantId}", true); + SetupSucceeded = true; + Message = "Tenant setup completed."; + Navigation.NavigateTo($"/{TenantId}", true); return; } Message = await response.Content.ReadAsStringAsync(); From db6214688c8a913817df44ad8d9adba7d9026c1c Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:29:39 -0300 Subject: [PATCH 081/112] refactor: style reconnect component with MudBlazor --- .../Components/Layout/ReconnectModal.razor | 55 ++++++++----------- 1 file changed, 24 insertions(+), 31 deletions(-) diff --git a/src/server/RemoteTickets/Components/Layout/ReconnectModal.razor b/src/server/RemoteTickets/Components/Layout/ReconnectModal.razor index e06eb2f..bce8e41 100644 --- a/src/server/RemoteTickets/Components/Layout/ReconnectModal.razor +++ b/src/server/RemoteTickets/Components/Layout/ReconnectModal.razor @@ -1,31 +1,24 @@ - - - -
- -

- Rejoining the server... -

-

- Rejoin failed... trying again in seconds. -

-

- Failed to rejoin.
Please retry or reload the page. -

- -

- The session has been paused by the server. -

-

- Failed to resume the session.
Please retry or reload the page. -

- -
- + + + + + + + Rejoining the server... + + Rejoin failed... trying again in seconds. + + + Failed to rejoin. Please retry or reload the page. + + + Retry + + The session has been paused by the server. + Failed to resume the session. Please retry or reload the page. + + Resume + + + + From c2d50250bedfdfd20fb2b3a9f7ff173f459776f9 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:29:47 -0300 Subject: [PATCH 082/112] refactor: remove bootstrap styling from MudBlazor host --- src/server/RemoteTickets/Components/App.razor | 49 +++++++++---------- 1 file changed, 22 insertions(+), 27 deletions(-) diff --git a/src/server/RemoteTickets/Components/App.razor b/src/server/RemoteTickets/Components/App.razor index da3cde8..29d8ce7 100644 --- a/src/server/RemoteTickets/Components/App.razor +++ b/src/server/RemoteTickets/Components/App.razor @@ -1,27 +1,22 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + From 34dda56aac9e825f09cacfef8138c66341f119b9 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:30:07 -0300 Subject: [PATCH 083/112] fix: enforce actual line and branch coverage rates --- .github/workflows/CI-CT-CD.yml | 48 +++++++--------------------------- 1 file changed, 9 insertions(+), 39 deletions(-) diff --git a/.github/workflows/CI-CT-CD.yml b/.github/workflows/CI-CT-CD.yml index 4262fd8..ab4f0de 100644 --- a/.github/workflows/CI-CT-CD.yml +++ b/.github/workflows/CI-CT-CD.yml @@ -91,6 +91,7 @@ jobs: if ($coverageFiles.Count -eq 0) { "## Coverage gate`n`nNo Coverlet XML was found under the test-results GUID subdirectories." | Out-File $env:GITHUB_STEP_SUMMARY -Append -Encoding utf8 + Write-Error "Coverage data was not produced." return } @@ -99,29 +100,21 @@ jobs: $lineRate = [double]$coverage.coverage.'line-rate' * 100 $branchRate = [double]$coverage.coverage.'branch-rate' * 100 - @" + @" ## Coverage gate | Metric | Result | Minimum | Status | | --- | ---: | ---: | --- | + | Line coverage | $([math]::Round($lineRate, 2))% | 80% | $(if ($lineRate -ge 80) { '✅' } else { '❌' }) | + | Branch coverage | $([math]::Round($branchRate, 2))% | 80% | $(if ($branchRate -ge 80) { '✅' } else { '❌' }) | "@ | Out-File $env:GITHUB_STEP_SUMMARY -Append -Encoding utf8 - if ($lineRate -ge 80) { - "| Line coverage | $([math]::Round($lineRate, 2))% | 80% | ✅ |" | Out-File $env:GITHUB_STEP_SUMMARY -Append -Encoding utf8 - "LINE_EXIT_CODE=0" | Out-File -FilePath artifacts/line-rate-code.txt -Encoding utf8 - } else { - "| Line coverage | $([math]::Round($lineRate, 2))% | 80% | ❌ |" | Out-File $env:GITHUB_STEP_SUMMARY -Append -Encoding utf8 - "LINE_EXIT_CODE=1" | Out-File -FilePath artifacts/line-rate-code.txt -Encoding utf8 - } + "LINE_COVERAGE=$([math]::Round($lineRate, 2))" | Out-File artifacts/line-rate.txt -Encoding utf8 + "BRANCH_COVERAGE=$([math]::Round($branchRate, 2))" | Out-File artifacts/branch-rate.txt -Encoding utf8 - if ($branchRate -ge 80) { - "| Branch coverage | $([math]::Round($branchRate, 2))% | 80% | ✅ |" | Out-File $env:GITHUB_STEP_SUMMARY -Append -Encoding utf8 - "BRANCH_EXIT_CODE=0" | Out-File -FilePath artifacts/branch-rate-code.txt -Encoding utf8 - - } else { - "| Branch coverage | $([math]::Round($branchRate, 2))% | 80% | ❌ |" | Out-File $env:GITHUB_STEP_SUMMARY -Append -Encoding utf8 - "BRANCH_EXIT_CODE=1" | Out-File -FilePath artifacts/branch-rate-code.txt -Encoding utf8 + if ($lineRate -lt 80 -or $branchRate -lt 80) { + Write-Error "Coverage gate failed. Line coverage: $([math]::Round($lineRate, 2))%; Branch coverage: $([math]::Round($branchRate, 2))%; minimum: 80%." } - + - name: Append test execution report if: always() shell: pwsh @@ -143,26 +136,3 @@ jobs: $exitCode = [int](Get-Content artifacts/test-exit-code.txt -Raw).Replace('TEST_EXIT_CODE=', '').Trim() if ($exitCode -ne 0) { Write-Error "dotnet test failed with exit code $exitCode." } } - - - name: Fail if line rate is above 80% - if: always() - shell: pwsh - run: | - if (Test-Path artifacts/line-rate-code.txt) { - $exitCode = [double](Get-Content artifacts/line-rate-code.txt -Raw).Replace('LINE_EXIT_CODE=', '').Trim() - if ($exitCode -le 80) - { - Write-Error "Line coverage is under rate. Current rate: $" - } - } - - - name: Fail if branch rate is above 80% - if: always() - shell: pwsh - run: | - if (Test-Path artifacts/branch-rate-code.txt) { - $exitCode = [double](Get-Content artifacts/branch-rate-code.txt -Raw).Replace('BRANCH_EXIT_CODE=', '').Trim() - if ($exitCode -le 80) { - Write-Error "Branch coverage is under rate. Current rate: $" - } - } From b10865f153f448bc236095a542af2da3c7f0fd23 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:30:29 -0300 Subject: [PATCH 084/112] test: cover auditable persistence history and actor tracking --- .../PersistenceTests.cs | 61 ++++++++++++++++++- 1 file changed, 58 insertions(+), 3 deletions(-) diff --git a/tests/server/RemoteTickets.UnitTests/PersistenceTests.cs b/tests/server/RemoteTickets.UnitTests/PersistenceTests.cs index 3fe01b0..48608ed 100644 --- a/tests/server/RemoteTickets.UnitTests/PersistenceTests.cs +++ b/tests/server/RemoteTickets.UnitTests/PersistenceTests.cs @@ -1,6 +1,6 @@ namespace RemoteTickets.UnitTests; -/// Verifies Entity Framework Core persistence behavior for soft-deletable identity entities. +/// Verifies Entity Framework Core persistence behavior for soft-deletable and auditable identity entities. public sealed class PersistenceTests { /// Verifies that soft-deleted users are hidden by the configured query filter. @@ -39,6 +39,61 @@ public async Task Async_soft_delete_should_apply_the_same_behavior() user.DeletedAt.Should().NotBeNull(); } + /// Verifies that an added and subsequently modified user produce audit history containing both states. + /// A task representing the asynchronous test operation. + [Fact] + public async Task Auditable_entities_should_record_creation_and_update_states() + { + await using ContextFixture fixture = await CreateContextAsync(); + var user = new User("audit@example.com") { Email = "audit@example.com", EmailConfirmed = true }; + + fixture.Context.Users.Add(user); + await fixture.Context.SaveChangesAsync(TestContext.Current.CancellationToken); + user.DisplayName = "Updated"; + await fixture.Context.SaveChangesAsync(TestContext.Current.CancellationToken); + + List history = await fixture.Context.EntityAuditHistory + .Where(x => x.EntityId == user.Id) + .OrderBy(x => x.UpdatedAt) + .ToListAsync(TestContext.Current.CancellationToken); + + history.Should().HaveCount(2); + history[0].Operation.Should().Be("Created"); + history[0].PreviousEntityState.Should().Be("{}"); + history[0].CurrentEntityState.Should().Contain("audit@example.com"); + history[1].Operation.Should().Be("Updated"); + history[1].PreviousEntityState.Should().Contain("audit@example.com"); + history[1].CurrentEntityState.Should().Contain("Updated"); + user.CreatedAt.Should().NotBe(default); + user.CreatedBy.Should().Be("system"); + } + + /// Verifies that audit records capture the authenticated actor and that the history table belongs to the audit schema. + /// A task representing the asynchronous test operation. + [Fact] + public async Task Audit_history_should_record_authenticated_actor_and_schema() + { + var accessor = new HttpContextAccessor + { + HttpContext = new DefaultHttpContext + { + User = new ClaimsPrincipal(new ClaimsIdentity(new[] { new Claim(ClaimTypes.NameIdentifier, "actor-1") }, "test")) + } + }; + await using ContextFixture fixture = await CreateContextAsync(accessor); + var user = new User("actor@example.com") { Email = "actor@example.com", EmailConfirmed = true }; + + fixture.Context.Users.Add(user); + await fixture.Context.SaveChangesAsync(TestContext.Current.CancellationToken); + + EntityAuditRecord history = await fixture.Context.EntityAuditHistory.SingleAsync(x => x.EntityId == user.Id, TestContext.Current.CancellationToken); + history.UpdatedBy.Should().Be("actor-1"); + var auditEntity = fixture.Context.Model.FindEntityType(typeof(EntityAuditRecord)); + auditEntity.Should().NotBeNull(); + auditEntity!.GetSchema().Should().Be("audit"); + auditEntity.GetTableName().Should().Be("EntityHistory"); + } + /// Verifies that user and role constructors assign non-empty identity identifiers. [Fact] public void User_and_role_constructors_should_initialize_identity_ids() @@ -54,12 +109,12 @@ public void User_and_role_constructors_should_initialize_identity_ids() namedRole.Id.Should().NotBeNullOrWhiteSpace(); } - private static async Task CreateContextAsync() + private static async Task CreateContextAsync(IHttpContextAccessor? accessor = null) { DbContextOptions options = new DbContextOptionsBuilder() .UseInMemoryDatabase(Guid.NewGuid().ToString("N")) .Options; - var context = new RemoteTicketsDbContext(options); + var context = new RemoteTicketsDbContext(options, accessor); await context.Database.EnsureCreatedAsync(TestContext.Current.CancellationToken); return new ContextFixture(context); } From 065a0073ea0c8c3b2a57eb30262eb5a4603b9fde Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:31:08 -0300 Subject: [PATCH 085/112] fix: use shared JSON global import --- .../Setup/SetupConfigurationStore.cs | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/server/RemoteTickets.Infrastructure/Setup/SetupConfigurationStore.cs b/src/server/RemoteTickets.Infrastructure/Setup/SetupConfigurationStore.cs index f869714..87e1ece 100644 --- a/src/server/RemoteTickets.Infrastructure/Setup/SetupConfigurationStore.cs +++ b/src/server/RemoteTickets.Infrastructure/Setup/SetupConfigurationStore.cs @@ -1,5 +1,3 @@ -using System.Text.Json; - namespace RemoteTickets.Infrastructure.Setup; /// Persists the installation master-database connection string used by the tenant catalog. From 90d365c1e627eab99160e59648787f504aa484f8 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:31:35 -0300 Subject: [PATCH 086/112] chore: import audit and HTTP test dependencies --- tests/server/RemoteTickets.UnitTests/GlobalUsings.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/server/RemoteTickets.UnitTests/GlobalUsings.cs b/tests/server/RemoteTickets.UnitTests/GlobalUsings.cs index 0e4dbeb..9243235 100644 --- a/tests/server/RemoteTickets.UnitTests/GlobalUsings.cs +++ b/tests/server/RemoteTickets.UnitTests/GlobalUsings.cs @@ -20,7 +20,9 @@ global using RemoteTickets.Infrastructure.Identity.Models; global using RemoteTickets.Infrastructure.Identity.Services; global using RemoteTickets.Infrastructure.Persistence; +global using RemoteTickets.Infrastructure.Persistence.Auditing; global using Mediator.Net.Context; +global using Microsoft.AspNetCore.Http; global using Microsoft.AspNetCore.Identity; global using Microsoft.EntityFrameworkCore; global using Microsoft.Extensions.DependencyInjection; From 93ffd603cddb37b27e1bac5a716949569ff85797 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:31:43 -0300 Subject: [PATCH 087/112] fix: make tenant menu links Razor-safe --- .../RemoteTickets/Components/Layout/NavMenu.razor | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/server/RemoteTickets/Components/Layout/NavMenu.razor b/src/server/RemoteTickets/Components/Layout/NavMenu.razor index d67017e..5693cb6 100644 --- a/src/server/RemoteTickets/Components/Layout/NavMenu.razor +++ b/src/server/RemoteTickets/Components/Layout/NavMenu.razor @@ -5,14 +5,18 @@ - Home - Counter - Weather + Home + Counter + Weather System setup @code { + private string HomeHref => TenantHref(string.Empty); + private string CounterHref => TenantHref("counter"); + private string WeatherHref => TenantHref("weather"); + private string TenantHref(string suffix) { string relativePath = Navigation.ToBaseRelativePath(Navigation.Uri).Trim('/'); From b842e0ca8fd80b94ea753bb352d044fc84e5630a Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:32:18 -0300 Subject: [PATCH 088/112] fix: classify soft deletes as deleted audit operations --- .../Persistence/RemoteTicketsDbContext.cs | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/server/RemoteTickets.Infrastructure/Persistence/RemoteTicketsDbContext.cs b/src/server/RemoteTickets.Infrastructure/Persistence/RemoteTicketsDbContext.cs index 507d911..29c1659 100644 --- a/src/server/RemoteTickets.Infrastructure/Persistence/RemoteTicketsDbContext.cs +++ b/src/server/RemoteTickets.Infrastructure/Persistence/RemoteTicketsDbContext.cs @@ -105,6 +105,7 @@ private void AddAuditEntries() string operation = entry.State switch { EntityState.Added => "Created", + EntityState.Modified when IsSoftDeleteTransition(entry) => "Deleted", EntityState.Modified => "Updated", EntityState.Deleted => "Deleted", _ => throw new InvalidOperationException("Unsupported audit state.") @@ -130,6 +131,17 @@ private void AddAuditEntries() } } + private static bool IsSoftDeleteTransition(EntityEntry entry) + { + if (!entry.Metadata.ClrType.GetInterfaces().Contains(typeof(ISoftDeletable))) + { + return false; + } + + PropertyEntry? deletedProperty = entry.Properties.FirstOrDefault(x => string.Equals(x.Metadata.Name, nameof(ISoftDeletable.IsDeleted), StringComparison.OrdinalIgnoreCase)); + return deletedProperty?.CurrentValue is true && deletedProperty.OriginalValue is false; + } + private string GetActor() => _httpContextAccessor?.HttpContext?.User.FindFirstValue(ClaimTypes.NameIdentifier) ?? _httpContextAccessor?.HttpContext?.User.FindFirstValue(JwtRegisteredClaimNames.Sub) From 502b16237da83e8cf1c8a9444a4932784cd0ddda Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:32:29 -0300 Subject: [PATCH 089/112] test: verify soft-delete audit operation and state transition --- tests/server/RemoteTickets.UnitTests/PersistenceTests.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/server/RemoteTickets.UnitTests/PersistenceTests.cs b/tests/server/RemoteTickets.UnitTests/PersistenceTests.cs index 48608ed..9f6ea6d 100644 --- a/tests/server/RemoteTickets.UnitTests/PersistenceTests.cs +++ b/tests/server/RemoteTickets.UnitTests/PersistenceTests.cs @@ -3,7 +3,7 @@ namespace RemoteTickets.UnitTests; /// Verifies Entity Framework Core persistence behavior for soft-deletable and auditable identity entities. public sealed class PersistenceTests { - /// Verifies that soft-deleted users are hidden by the configured query filter. + /// Verifies that soft-deleted users are hidden by the configured query filter and audited as deletions. /// A task representing the asynchronous test operation. [Fact] public async Task Soft_deleted_users_should_be_hidden_by_query_filter() @@ -20,6 +20,7 @@ public async Task Soft_deleted_users_should_be_hidden_by_query_filter() user.DeletedAt.Should().NotBeNull(); (await fixture.Context.Users.SingleOrDefaultAsync(x => x.Id == user.Id)).Should().BeNull(); (await fixture.Context.Users.IgnoreQueryFilters().SingleAsync(x => x.Id == user.Id)).IsDeleted.Should().BeTrue(); + (await fixture.Context.EntityAuditHistory.Where(x => x.EntityId == user.Id).OrderBy(x => x.UpdatedAt).LastAsync(TestContext.Current.CancellationToken)).Operation.Should().Be("Deleted"); } /// Verifies that asynchronous save operations apply the same soft-delete behavior. From 7221969a39ae554f095ec95982d074d0c898a3c1 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:33:54 -0300 Subject: [PATCH 090/112] fix: prepare audit entries once per save operation --- .../Persistence/RemoteTicketsDbContext.cs | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/server/RemoteTickets.Infrastructure/Persistence/RemoteTicketsDbContext.cs b/src/server/RemoteTickets.Infrastructure/Persistence/RemoteTicketsDbContext.cs index 29c1659..3dff1ec 100644 --- a/src/server/RemoteTickets.Infrastructure/Persistence/RemoteTicketsDbContext.cs +++ b/src/server/RemoteTickets.Infrastructure/Persistence/RemoteTicketsDbContext.cs @@ -45,10 +45,7 @@ public override int SaveChanges(bool acceptAllChangesOnSuccess) /// public override int SaveChanges() - { - PreparePersistenceChanges(); - return base.SaveChanges(); - } + => SaveChanges(true); /// public override Task SaveChangesAsync(bool acceptAllChangesOnSuccess, CancellationToken cancellationToken = default) @@ -59,10 +56,7 @@ public override Task SaveChangesAsync(bool acceptAllChangesOnSuccess, Cance /// public override Task SaveChangesAsync(CancellationToken cancellationToken = default) - { - PreparePersistenceChanges(); - return base.SaveChangesAsync(cancellationToken); - } + => SaveChangesAsync(true, cancellationToken); private void PreparePersistenceChanges() { From 6b452b3f15c423da97c292cd5f2d1678e9acf45d Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:34:15 -0300 Subject: [PATCH 091/112] test: cover tenant access middleware isolation and setup branches --- .../TenantAccessMiddlewareTests.cs | 348 ++++++++++++++++++ 1 file changed, 348 insertions(+) create mode 100644 tests/server/RemoteTickets.UnitTests/TenantAccessMiddlewareTests.cs diff --git a/tests/server/RemoteTickets.UnitTests/TenantAccessMiddlewareTests.cs b/tests/server/RemoteTickets.UnitTests/TenantAccessMiddlewareTests.cs new file mode 100644 index 0000000..2d133a5 --- /dev/null +++ b/tests/server/RemoteTickets.UnitTests/TenantAccessMiddlewareTests.cs @@ -0,0 +1,348 @@ +namespace RemoteTickets.UnitTests; + +/// Verifies tenant routing, setup gates, authentication, and system-administrator bypass behavior. +public sealed class TenantAccessMiddlewareTests +{ + [Fact] + public async Task Infrastructure_paths_should_bypass_tenant_gate() + { + await using var fixture = await CreateFixtureAsync(setupComplete: false); + var context = CreateContext("/_framework/blazor.web.js", "GET"); + bool called = false; + var middleware = new TenantAccessMiddleware(_ => { called = true; return Task.CompletedTask; }, fixture.Tenants, fixture.Context); + + await middleware.InvokeAsync(context); + + called.Should().BeTrue(); + context.Response.StatusCode.Should().Be(200); + } + + [Fact] + public async Task Incomplete_system_setup_should_redirect_html_requests() + { + await using var fixture = await CreateFixtureAsync(setupComplete: false); + var context = CreateContext("/anything", "GET"); + context.Request.Headers.Accept = "text/html"; + var middleware = CreateMiddleware(fixture, out bool called); + + await middleware.InvokeAsync(context); + + called.Should().BeFalse(); + context.Response.StatusCode.Should().Be(StatusCodes.Status302Found); + context.Response.Headers.Location.ToString().Should().Be("/setup"); + } + + [Fact] + public async Task Incomplete_system_setup_should_return_problem_details_for_api_requests() + { + await using var fixture = await CreateFixtureAsync(setupComplete: false); + var context = CreateContext("/api/v1/foo", "POST"); + var middleware = CreateMiddleware(fixture, out bool called); + + await middleware.InvokeAsync(context); + + called.Should().BeFalse(); + context.Response.StatusCode.Should().Be(StatusCodes.Status503ServiceUnavailable); + context.Response.ContentType.Should().StartWith("application/problem+json"); + } + + [Fact] + public async Task Setup_endpoint_should_remain_available_before_initialization() + { + await using var fixture = await CreateFixtureAsync(setupComplete: false); + var context = CreateContext("/api/v1/setup/status", "GET"); + var middleware = CreateMiddleware(fixture, out bool called); + + await middleware.InvokeAsync(context); + + called.Should().BeTrue(); + } + + [Fact] + public async Task Completed_setup_should_reject_system_setup_post() + { + await using var fixture = await CreateFixtureAsync(setupComplete: true); + var context = CreateContext("/api/v1/setup/database", "POST"); + var middleware = CreateMiddleware(fixture, out bool called); + + await middleware.InvokeAsync(context); + + called.Should().BeFalse(); + context.Response.StatusCode.Should().Be(StatusCodes.Status409Conflict); + } + + [Fact] + public async Task Anonymous_request_without_tenant_should_continue() + { + await using var fixture = await CreateFixtureAsync(setupComplete: true); + var context = CreateContext("/", "GET", anonymous: true); + var middleware = CreateMiddleware(fixture, out bool called); + + await middleware.InvokeAsync(context); + + called.Should().BeTrue(); + } + + [Fact] + public async Task Authenticated_request_without_tenant_should_be_rejected() + { + await using var fixture = await CreateFixtureAsync(setupComplete: true); + var context = CreateContext("/api/v1/products", "GET"); + context.Request.Headers.Accept = "text/html"; + context.User = Principal("user-1", TenantRoles.TenantOperator, "tenant-a"); + var middleware = CreateMiddleware(fixture, out bool called); + + await middleware.InvokeAsync(context); + + called.Should().BeFalse(); + context.Response.StatusCode.Should().Be(StatusCodes.Status302Found); + context.Response.Headers.Location.ToString().Should().Be("/setup"); + } + + [Fact] + public async Task System_route_should_require_sysadmin() + { + await using var fixture = await CreateFixtureAsync(setupComplete: true); + var context = CreateContext("/system", "GET"); + context.Request.RouteValues["tenantId"] = "system"; + var middleware = CreateMiddleware(fixture, out bool called); + + await middleware.InvokeAsync(context); + + called.Should().BeFalse(); + context.Response.StatusCode.Should().Be(StatusCodes.Status403Forbidden); + } + + [Fact] + public async Task Sysadmin_should_be_allowed_on_system_route() + { + await using var fixture = await CreateFixtureAsync(setupComplete: true); + var context = CreateContext("/system", "GET"); + context.Request.RouteValues["tenantId"] = "system"; + context.User = Principal("sys-1", TenantRoles.SysAdmin, null); + var middleware = CreateMiddleware(fixture, out bool called); + + await middleware.InvokeAsync(context); + + called.Should().BeTrue(); + } + + [Fact] + public async Task Missing_tenant_should_be_not_found() + { + await using var fixture = await CreateFixtureAsync(setupComplete: true); + var context = CreateContext("/missing", "GET"); + context.Request.RouteValues["tenantId"] = "missing"; + var middleware = CreateMiddleware(fixture, out bool called); + + await middleware.InvokeAsync(context); + + called.Should().BeFalse(); + context.Response.StatusCode.Should().Be(StatusCodes.Status404NotFound); + } + + [Fact] + public async Task Inactive_tenant_should_be_not_found() + { + await using var fixture = await CreateFixtureAsync(setupComplete: true); + fixture.Tenants.Items["inactive"] = new TenantResponse("inactive", "Inactive", "db", false, true); + var context = CreateContext("/inactive", "GET"); + context.Request.RouteValues["tenantId"] = "inactive"; + var middleware = CreateMiddleware(fixture, out bool called); + + await middleware.InvokeAsync(context); + + called.Should().BeFalse(); + context.Response.StatusCode.Should().Be(StatusCodes.Status404NotFound); + } + + [Fact] + public async Task Anonymous_incomplete_tenant_should_redirect_to_tenant_setup() + { + await using var fixture = await CreateFixtureAsync(setupComplete: true); + fixture.Tenants.Items["tenant-a"] = new TenantResponse("tenant-a", "Tenant A", "db", true, false); + var context = CreateContext("/tenant-a/products", "GET", anonymous: true); + context.Request.RouteValues["tenantId"] = "tenant-a"; + var middleware = CreateMiddleware(fixture, out bool called); + + await middleware.InvokeAsync(context); + + called.Should().BeFalse(); + context.Response.StatusCode.Should().Be(StatusCodes.Status409Conflict); + } + + [Fact] + public async Task Anonymous_tenant_setup_and_login_endpoints_should_continue() + { + await using var fixture = await CreateFixtureAsync(setupComplete: true); + fixture.Tenants.Items["tenant-a"] = new TenantResponse("tenant-a", "Tenant A", "db", true, false); + + var setupContext = CreateContext("/tenant-a/setup", "GET", anonymous: true); + setupContext.Request.RouteValues["tenantId"] = "tenant-a"; + await CreateMiddleware(fixture, out _).InvokeAsync(setupContext); + + var loginContext = CreateContext("/api/v1/tenant-a/login", "POST", anonymous: true); + loginContext.Request.RouteValues["tenantId"] = "tenant-a"; + await CreateMiddleware(fixture, out _).InvokeAsync(loginContext); + + setupContext.Response.StatusCode.Should().Be(200); + loginContext.Response.StatusCode.Should().Be(200); + } + + [Fact] + public async Task Unauthenticated_tenant_request_should_return_unauthorized() + { + await using var fixture = await CreateFixtureAsync(setupComplete: true); + var context = CreateContext("/tenant-a/products", "GET"); + context.Request.RouteValues["tenantId"] = "tenant-a"; + var middleware = CreateMiddleware(fixture, out bool called); + + await middleware.InvokeAsync(context); + + called.Should().BeFalse(); + context.Response.StatusCode.Should().Be(StatusCodes.Status401Unauthorized); + } + + [Fact] + public async Task Authenticated_user_from_another_tenant_should_be_forbidden() + { + await using var fixture = await CreateFixtureAsync(setupComplete: true); + var context = CreateContext("/tenant-b/products", "GET"); + context.Request.RouteValues["tenantId"] = "tenant-b"; + context.User = Principal("user-1", TenantRoles.TenantOperator, "tenant-a"); + var middleware = CreateMiddleware(fixture, out bool called); + + await middleware.InvokeAsync(context); + + called.Should().BeFalse(); + context.Response.StatusCode.Should().Be(StatusCodes.Status403Forbidden); + } + + [Fact] + public async Task Sysadmin_should_bypass_tenant_mismatch() + { + await using var fixture = await CreateFixtureAsync(setupComplete: true); + var context = CreateContext("/tenant-b/products", "GET"); + context.Request.RouteValues["tenantId"] = "tenant-b"; + context.User = Principal("sys-1", TenantRoles.SysAdmin, null); + var middleware = CreateMiddleware(fixture, out bool called); + + await middleware.InvokeAsync(context); + + called.Should().BeTrue(); + } + + [Fact] + public async Task Authenticated_user_should_be_redirected_to_tenant_setup_when_incomplete() + { + await using var fixture = await CreateFixtureAsync(setupComplete: true); + fixture.Tenants.Items["tenant-a"] = new TenantResponse("tenant-a", "Tenant A", "db", true, false); + var context = CreateContext("/tenant-a/products", "GET"); + context.Request.RouteValues["tenantId"] = "tenant-a"; + context.User = Principal("user-1", TenantRoles.TenantOperator, "tenant-a"); + var middleware = CreateMiddleware(fixture, out bool called); + + await middleware.InvokeAsync(context); + + called.Should().BeFalse(); + context.Response.StatusCode.Should().Be(StatusCodes.Status409Conflict); + } + + [Fact] + public async Task Tenant_setup_endpoint_should_continue_for_authenticated_user() + { + await using var fixture = await CreateFixtureAsync(setupComplete: true); + fixture.Tenants.Items["tenant-a"] = new TenantResponse("tenant-a", "Tenant A", "db", true, false); + var context = CreateContext("/api/v1/tenant-a/setup/complete", "POST"); + context.Request.RouteValues["tenantId"] = "tenant-a"; + context.User = Principal("user-1", TenantRoles.TenantAdmin, "tenant-a"); + var middleware = CreateMiddleware(fixture, out bool called); + + await middleware.InvokeAsync(context); + + called.Should().BeTrue(); + } + + [Fact] + public async Task Matching_authenticated_user_should_continue_for_complete_tenant() + { + await using var fixture = await CreateFixtureAsync(setupComplete: true); + var context = CreateContext("/tenant-a/products", "GET"); + context.Request.RouteValues["tenantId"] = "tenant-a"; + context.User = Principal("user-1", TenantRoles.TenantOperator, "tenant-a"); + var middleware = CreateMiddleware(fixture, out bool called); + + await middleware.InvokeAsync(context); + + called.Should().BeTrue(); + } + + private static TenantAccessMiddleware CreateMiddleware(Fixture fixture, out bool called) + { + called = false; + return new TenantAccessMiddleware(_ => { called = true; return Task.CompletedTask; }, fixture.Tenants, fixture.Context); + } + + private static DefaultHttpContext CreateContext(string path, string method, bool anonymous = false) + { + var context = new DefaultHttpContext(); + context.Request.Path = path; + context.Request.Method = method; + if (anonymous) + { + context.SetEndpoint(new Endpoint(_ => Task.CompletedTask, new EndpointMetadataCollection(new AllowAnonymousAttribute()), "anonymous")); + } + return context; + } + + private static ClaimsPrincipal Principal(string id, string role, string? tenantId) + { + List claims = [new(ClaimTypes.NameIdentifier, id), new(ClaimTypes.Role, role)]; + if (tenantId is not null) claims.Add(new Claim(TenantClaimTypes.TenantId, tenantId)); + return new ClaimsPrincipal(new ClaimsIdentity(claims, "test")); + } + + private static async Task CreateFixtureAsync(bool setupComplete) + { + DbContextOptions options = new DbContextOptionsBuilder() + .UseInMemoryDatabase(Guid.NewGuid().ToString("N")) + .Options; + var context = new RemoteTicketsDbContext(options); + context.SystemSetup.Add(new SystemSetupState { Id = RemoteTicketsConstants.SystemSetupId, IsComplete = setupComplete }); + await context.SaveChangesAsync(TestContext.Current.CancellationToken); + return new Fixture(context, new FakeTenantManagementService()); + } + + private sealed class Fixture(RemoteTicketsDbContext context, FakeTenantManagementService tenants) : IAsyncDisposable + { + public RemoteTicketsDbContext Context { get; } = context; + public FakeTenantManagementService Tenants { get; } = tenants; + + public ValueTask DisposeAsync() + { + Context.Dispose(); + return ValueTask.CompletedTask; + } + } + + private sealed class FakeTenantManagementService : ITenantManagementService + { + public Dictionary Items { get; } = new(StringComparer.OrdinalIgnoreCase) + { + ["tenant-a"] = new TenantResponse("tenant-a", "Tenant A", "db", true, true), + ["tenant-b"] = new TenantResponse("tenant-b", "Tenant B", "db", true, true) + }; + + public Task GetAsync(string tenantId, CancellationToken cancellationToken) + => Task.FromResult(Items.GetValueOrDefault(tenantId)); + + public Task CreateAsync(CreateTenantRequest request, CancellationToken cancellationToken) + => throw new NotSupportedException(); + + public Task GetSetupStatusAsync(string tenantId, CancellationToken cancellationToken) + => throw new NotSupportedException(); + + public Task CompleteSetupAsync(string tenantId, CancellationToken cancellationToken) + => throw new NotSupportedException(); + } +} From 8418a878ae117a6f62bde9202fdb2fa8db8132cc Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:35:49 -0300 Subject: [PATCH 092/112] fix: import tenant middleware namespace for tests --- tests/server/RemoteTickets.UnitTests/GlobalUsings.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/server/RemoteTickets.UnitTests/GlobalUsings.cs b/tests/server/RemoteTickets.UnitTests/GlobalUsings.cs index 9243235..5f6fd96 100644 --- a/tests/server/RemoteTickets.UnitTests/GlobalUsings.cs +++ b/tests/server/RemoteTickets.UnitTests/GlobalUsings.cs @@ -21,6 +21,7 @@ global using RemoteTickets.Infrastructure.Identity.Services; global using RemoteTickets.Infrastructure.Persistence; global using RemoteTickets.Infrastructure.Persistence.Auditing; +global using RemoteTickets.Infrastructure.Tenancy; global using Mediator.Net.Context; global using Microsoft.AspNetCore.Http; global using Microsoft.AspNetCore.Identity; From e1f4a1756d16e83c774e51a841ad340bb3c8443c Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:35:59 -0300 Subject: [PATCH 093/112] fix: use MudBlazor-compatible accessibility attribute --- src/server/RemoteTickets/Components/Layout/MainLayout.razor | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/server/RemoteTickets/Components/Layout/MainLayout.razor b/src/server/RemoteTickets/Components/Layout/MainLayout.razor index 3472392..b687392 100644 --- a/src/server/RemoteTickets/Components/Layout/MainLayout.razor +++ b/src/server/RemoteTickets/Components/Layout/MainLayout.razor @@ -25,7 +25,7 @@ @code { From 9203925d2475163ad45f70feedfe6a306c49326d Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:36:44 -0300 Subject: [PATCH 094/112] chore: import authorization, setup and constant contracts for middleware tests --- tests/server/RemoteTickets.UnitTests/GlobalUsings.cs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/server/RemoteTickets.UnitTests/GlobalUsings.cs b/tests/server/RemoteTickets.UnitTests/GlobalUsings.cs index 5f6fd96..bc52465 100644 --- a/tests/server/RemoteTickets.UnitTests/GlobalUsings.cs +++ b/tests/server/RemoteTickets.UnitTests/GlobalUsings.cs @@ -11,6 +11,7 @@ global using FluentValidation.Results; global using RemoteTickets.Application.Common.Identity; global using RemoteTickets.Application.Common.Tenancy; +global using RemoteTickets.Application.Common.Util; global using RemoteTickets.Application.Identity; global using RemoteTickets.Application.Identity.Handlers; global using RemoteTickets.Application.Identity.Requests; @@ -21,8 +22,10 @@ global using RemoteTickets.Infrastructure.Identity.Services; global using RemoteTickets.Infrastructure.Persistence; global using RemoteTickets.Infrastructure.Persistence.Auditing; +global using RemoteTickets.Infrastructure.Setup; global using RemoteTickets.Infrastructure.Tenancy; global using Mediator.Net.Context; +global using Microsoft.AspNetCore.Authorization; global using Microsoft.AspNetCore.Http; global using Microsoft.AspNetCore.Identity; global using Microsoft.EntityFrameworkCore; From 9d6a7ac412580f73e6e4743a81935dcad56cbf85 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:37:02 -0300 Subject: [PATCH 095/112] fix: stabilize tenant middleware test invocation tracking --- .../TenantAccessMiddlewareTests.cs | 315 +++++++----------- 1 file changed, 125 insertions(+), 190 deletions(-) diff --git a/tests/server/RemoteTickets.UnitTests/TenantAccessMiddlewareTests.cs b/tests/server/RemoteTickets.UnitTests/TenantAccessMiddlewareTests.cs index 2d133a5..909ac22 100644 --- a/tests/server/RemoteTickets.UnitTests/TenantAccessMiddlewareTests.cs +++ b/tests/server/RemoteTickets.UnitTests/TenantAccessMiddlewareTests.cs @@ -6,282 +6,209 @@ public sealed class TenantAccessMiddlewareTests [Fact] public async Task Infrastructure_paths_should_bypass_tenant_gate() { - await using var fixture = await CreateFixtureAsync(setupComplete: false); + await using var fixture = await CreateFixtureAsync(false); var context = CreateContext("/_framework/blazor.web.js", "GET"); - bool called = false; - var middleware = new TenantAccessMiddleware(_ => { called = true; return Task.CompletedTask; }, fixture.Tenants, fixture.Context); + var tracker = new InvocationTracker(); + var middleware = CreateMiddleware(fixture, tracker); await middleware.InvokeAsync(context); - called.Should().BeTrue(); - context.Response.StatusCode.Should().Be(200); + tracker.Called.Should().BeTrue(); } [Fact] - public async Task Incomplete_system_setup_should_redirect_html_requests() + public async Task Incomplete_system_setup_should_redirect_html_and_reject_api_requests() { - await using var fixture = await CreateFixtureAsync(setupComplete: false); - var context = CreateContext("/anything", "GET"); - context.Request.Headers.Accept = "text/html"; - var middleware = CreateMiddleware(fixture, out bool called); - - await middleware.InvokeAsync(context); - - called.Should().BeFalse(); - context.Response.StatusCode.Should().Be(StatusCodes.Status302Found); - context.Response.Headers.Location.ToString().Should().Be("/setup"); - } - - [Fact] - public async Task Incomplete_system_setup_should_return_problem_details_for_api_requests() - { - await using var fixture = await CreateFixtureAsync(setupComplete: false); - var context = CreateContext("/api/v1/foo", "POST"); - var middleware = CreateMiddleware(fixture, out bool called); - - await middleware.InvokeAsync(context); - - called.Should().BeFalse(); - context.Response.StatusCode.Should().Be(StatusCodes.Status503ServiceUnavailable); - context.Response.ContentType.Should().StartWith("application/problem+json"); + await using var fixture = await CreateFixtureAsync(false); + var html = CreateContext("/anything", "GET"); + html.Request.Headers.Accept = "text/html"; + var htmlTracker = new InvocationTracker(); + await CreateMiddleware(fixture, htmlTracker).InvokeAsync(html); + + htmlTracker.Called.Should().BeFalse(); + html.Response.StatusCode.Should().Be(StatusCodes.Status302Found); + html.Response.Headers.Location.ToString().Should().Be("/setup"); + + var api = CreateContext("/api/v1/foo", "POST"); + var apiTracker = new InvocationTracker(); + await CreateMiddleware(fixture, apiTracker).InvokeAsync(api); + + apiTracker.Called.Should().BeFalse(); + api.Response.StatusCode.Should().Be(StatusCodes.Status503ServiceUnavailable); } [Fact] public async Task Setup_endpoint_should_remain_available_before_initialization() { - await using var fixture = await CreateFixtureAsync(setupComplete: false); + await using var fixture = await CreateFixtureAsync(false); var context = CreateContext("/api/v1/setup/status", "GET"); - var middleware = CreateMiddleware(fixture, out bool called); + var tracker = new InvocationTracker(); - await middleware.InvokeAsync(context); + await CreateMiddleware(fixture, tracker).InvokeAsync(context); - called.Should().BeTrue(); + tracker.Called.Should().BeTrue(); } [Fact] public async Task Completed_setup_should_reject_system_setup_post() { - await using var fixture = await CreateFixtureAsync(setupComplete: true); + await using var fixture = await CreateFixtureAsync(true); var context = CreateContext("/api/v1/setup/database", "POST"); - var middleware = CreateMiddleware(fixture, out bool called); + var tracker = new InvocationTracker(); - await middleware.InvokeAsync(context); + await CreateMiddleware(fixture, tracker).InvokeAsync(context); - called.Should().BeFalse(); + tracker.Called.Should().BeFalse(); context.Response.StatusCode.Should().Be(StatusCodes.Status409Conflict); } [Fact] - public async Task Anonymous_request_without_tenant_should_continue() + public async Task System_route_should_require_sysadmin_and_allow_sysadmin() { - await using var fixture = await CreateFixtureAsync(setupComplete: true); - var context = CreateContext("/", "GET", anonymous: true); - var middleware = CreateMiddleware(fixture, out bool called); - - await middleware.InvokeAsync(context); - - called.Should().BeTrue(); + await using var fixture = await CreateFixtureAsync(true); + var forbidden = CreateContext("/system", "GET"); + forbidden.Request.RouteValues["tenantId"] = "system"; + var forbiddenTracker = new InvocationTracker(); + await CreateMiddleware(fixture, forbiddenTracker).InvokeAsync(forbidden); + forbiddenTracker.Called.Should().BeFalse(); + forbidden.Response.StatusCode.Should().Be(StatusCodes.Status403Forbidden); + + var allowed = CreateContext("/system", "GET"); + allowed.Request.RouteValues["tenantId"] = "system"; + allowed.User = Principal("sys-1", TenantRoles.SysAdmin, null); + var allowedTracker = new InvocationTracker(); + await CreateMiddleware(fixture, allowedTracker).InvokeAsync(allowed); + allowedTracker.Called.Should().BeTrue(); } [Fact] - public async Task Authenticated_request_without_tenant_should_be_rejected() + public async Task Missing_or_inactive_tenant_should_be_not_found() { - await using var fixture = await CreateFixtureAsync(setupComplete: true); - var context = CreateContext("/api/v1/products", "GET"); - context.Request.Headers.Accept = "text/html"; - context.User = Principal("user-1", TenantRoles.TenantOperator, "tenant-a"); - var middleware = CreateMiddleware(fixture, out bool called); + await using var fixture = await CreateFixtureAsync(true); + var missing = CreateContext("/missing", "GET"); + missing.Request.RouteValues["tenantId"] = "missing"; + var missingTracker = new InvocationTracker(); + await CreateMiddleware(fixture, missingTracker).InvokeAsync(missing); + missingTracker.Called.Should().BeFalse(); + missing.Response.StatusCode.Should().Be(StatusCodes.Status404NotFound); - await middleware.InvokeAsync(context); - - called.Should().BeFalse(); - context.Response.StatusCode.Should().Be(StatusCodes.Status302Found); - context.Response.Headers.Location.ToString().Should().Be("/setup"); - } - - [Fact] - public async Task System_route_should_require_sysadmin() - { - await using var fixture = await CreateFixtureAsync(setupComplete: true); - var context = CreateContext("/system", "GET"); - context.Request.RouteValues["tenantId"] = "system"; - var middleware = CreateMiddleware(fixture, out bool called); - - await middleware.InvokeAsync(context); - - called.Should().BeFalse(); - context.Response.StatusCode.Should().Be(StatusCodes.Status403Forbidden); - } - - [Fact] - public async Task Sysadmin_should_be_allowed_on_system_route() - { - await using var fixture = await CreateFixtureAsync(setupComplete: true); - var context = CreateContext("/system", "GET"); - context.Request.RouteValues["tenantId"] = "system"; - context.User = Principal("sys-1", TenantRoles.SysAdmin, null); - var middleware = CreateMiddleware(fixture, out bool called); - - await middleware.InvokeAsync(context); - - called.Should().BeTrue(); - } - - [Fact] - public async Task Missing_tenant_should_be_not_found() - { - await using var fixture = await CreateFixtureAsync(setupComplete: true); - var context = CreateContext("/missing", "GET"); - context.Request.RouteValues["tenantId"] = "missing"; - var middleware = CreateMiddleware(fixture, out bool called); - - await middleware.InvokeAsync(context); - - called.Should().BeFalse(); - context.Response.StatusCode.Should().Be(StatusCodes.Status404NotFound); - } - - [Fact] - public async Task Inactive_tenant_should_be_not_found() - { - await using var fixture = await CreateFixtureAsync(setupComplete: true); fixture.Tenants.Items["inactive"] = new TenantResponse("inactive", "Inactive", "db", false, true); - var context = CreateContext("/inactive", "GET"); - context.Request.RouteValues["tenantId"] = "inactive"; - var middleware = CreateMiddleware(fixture, out bool called); - - await middleware.InvokeAsync(context); - - called.Should().BeFalse(); - context.Response.StatusCode.Should().Be(StatusCodes.Status404NotFound); + var inactive = CreateContext("/inactive", "GET"); + inactive.Request.RouteValues["tenantId"] = "inactive"; + var inactiveTracker = new InvocationTracker(); + await CreateMiddleware(fixture, inactiveTracker).InvokeAsync(inactive); + inactiveTracker.Called.Should().BeFalse(); + inactive.Response.StatusCode.Should().Be(StatusCodes.Status404NotFound); } [Fact] - public async Task Anonymous_incomplete_tenant_should_redirect_to_tenant_setup() + public async Task Anonymous_incomplete_tenant_should_be_restricted_except_setup_and_login() { - await using var fixture = await CreateFixtureAsync(setupComplete: true); + await using var fixture = await CreateFixtureAsync(true); fixture.Tenants.Items["tenant-a"] = new TenantResponse("tenant-a", "Tenant A", "db", true, false); - var context = CreateContext("/tenant-a/products", "GET", anonymous: true); - context.Request.RouteValues["tenantId"] = "tenant-a"; - var middleware = CreateMiddleware(fixture, out bool called); - - await middleware.InvokeAsync(context); - called.Should().BeFalse(); - context.Response.StatusCode.Should().Be(StatusCodes.Status409Conflict); + var restricted = CreateContext("/tenant-a/products", "GET", true); + restricted.Request.RouteValues["tenantId"] = "tenant-a"; + var restrictedTracker = new InvocationTracker(); + await CreateMiddleware(fixture, restrictedTracker).InvokeAsync(restricted); + restrictedTracker.Called.Should().BeFalse(); + restricted.Response.StatusCode.Should().Be(StatusCodes.Status409Conflict); + + var setup = CreateContext("/tenant-a/setup", "GET", true); + setup.Request.RouteValues["tenantId"] = "tenant-a"; + var setupTracker = new InvocationTracker(); + await CreateMiddleware(fixture, setupTracker).InvokeAsync(setup); + setupTracker.Called.Should().BeTrue(); + + var login = CreateContext("/api/v1/tenant-a/login", "POST", true); + login.Request.RouteValues["tenantId"] = "tenant-a"; + var loginTracker = new InvocationTracker(); + await CreateMiddleware(fixture, loginTracker).InvokeAsync(login); + loginTracker.Called.Should().BeTrue(); } [Fact] - public async Task Anonymous_tenant_setup_and_login_endpoints_should_continue() + public async Task Authenticated_user_without_tenant_should_be_rejected() { - await using var fixture = await CreateFixtureAsync(setupComplete: true); - fixture.Tenants.Items["tenant-a"] = new TenantResponse("tenant-a", "Tenant A", "db", true, false); - - var setupContext = CreateContext("/tenant-a/setup", "GET", anonymous: true); - setupContext.Request.RouteValues["tenantId"] = "tenant-a"; - await CreateMiddleware(fixture, out _).InvokeAsync(setupContext); - - var loginContext = CreateContext("/api/v1/tenant-a/login", "POST", anonymous: true); - loginContext.Request.RouteValues["tenantId"] = "tenant-a"; - await CreateMiddleware(fixture, out _).InvokeAsync(loginContext); - - setupContext.Response.StatusCode.Should().Be(200); - loginContext.Response.StatusCode.Should().Be(200); - } - - [Fact] - public async Task Unauthenticated_tenant_request_should_return_unauthorized() - { - await using var fixture = await CreateFixtureAsync(setupComplete: true); - var context = CreateContext("/tenant-a/products", "GET"); - context.Request.RouteValues["tenantId"] = "tenant-a"; - var middleware = CreateMiddleware(fixture, out bool called); + await using var fixture = await CreateFixtureAsync(true); + var context = CreateContext("/api/v1/products", "GET"); + context.User = Principal("user-1", TenantRoles.TenantOperator, "tenant-a"); + var tracker = new InvocationTracker(); - await middleware.InvokeAsync(context); + await CreateMiddleware(fixture, tracker).InvokeAsync(context); - called.Should().BeFalse(); + tracker.Called.Should().BeFalse(); context.Response.StatusCode.Should().Be(StatusCodes.Status401Unauthorized); } [Fact] public async Task Authenticated_user_from_another_tenant_should_be_forbidden() { - await using var fixture = await CreateFixtureAsync(setupComplete: true); + await using var fixture = await CreateFixtureAsync(true); var context = CreateContext("/tenant-b/products", "GET"); context.Request.RouteValues["tenantId"] = "tenant-b"; context.User = Principal("user-1", TenantRoles.TenantOperator, "tenant-a"); - var middleware = CreateMiddleware(fixture, out bool called); + var tracker = new InvocationTracker(); - await middleware.InvokeAsync(context); + await CreateMiddleware(fixture, tracker).InvokeAsync(context); - called.Should().BeFalse(); + tracker.Called.Should().BeFalse(); context.Response.StatusCode.Should().Be(StatusCodes.Status403Forbidden); } [Fact] public async Task Sysadmin_should_bypass_tenant_mismatch() { - await using var fixture = await CreateFixtureAsync(setupComplete: true); + await using var fixture = await CreateFixtureAsync(true); var context = CreateContext("/tenant-b/products", "GET"); context.Request.RouteValues["tenantId"] = "tenant-b"; context.User = Principal("sys-1", TenantRoles.SysAdmin, null); - var middleware = CreateMiddleware(fixture, out bool called); + var tracker = new InvocationTracker(); - await middleware.InvokeAsync(context); + await CreateMiddleware(fixture, tracker).InvokeAsync(context); - called.Should().BeTrue(); + tracker.Called.Should().BeTrue(); } [Fact] - public async Task Authenticated_user_should_be_redirected_to_tenant_setup_when_incomplete() + public async Task Authenticated_user_should_be_restricted_until_tenant_setup_is_complete() { - await using var fixture = await CreateFixtureAsync(setupComplete: true); + await using var fixture = await CreateFixtureAsync(true); fixture.Tenants.Items["tenant-a"] = new TenantResponse("tenant-a", "Tenant A", "db", true, false); var context = CreateContext("/tenant-a/products", "GET"); context.Request.RouteValues["tenantId"] = "tenant-a"; context.User = Principal("user-1", TenantRoles.TenantOperator, "tenant-a"); - var middleware = CreateMiddleware(fixture, out bool called); + var tracker = new InvocationTracker(); - await middleware.InvokeAsync(context); + await CreateMiddleware(fixture, tracker).InvokeAsync(context); - called.Should().BeFalse(); + tracker.Called.Should().BeFalse(); context.Response.StatusCode.Should().Be(StatusCodes.Status409Conflict); } [Fact] - public async Task Tenant_setup_endpoint_should_continue_for_authenticated_user() + public async Task Tenant_setup_endpoint_and_matching_complete_tenant_should_continue() { - await using var fixture = await CreateFixtureAsync(setupComplete: true); + await using var fixture = await CreateFixtureAsync(true); fixture.Tenants.Items["tenant-a"] = new TenantResponse("tenant-a", "Tenant A", "db", true, false); - var context = CreateContext("/api/v1/tenant-a/setup/complete", "POST"); - context.Request.RouteValues["tenantId"] = "tenant-a"; - context.User = Principal("user-1", TenantRoles.TenantAdmin, "tenant-a"); - var middleware = CreateMiddleware(fixture, out bool called); - - await middleware.InvokeAsync(context); - - called.Should().BeTrue(); - } - - [Fact] - public async Task Matching_authenticated_user_should_continue_for_complete_tenant() - { - await using var fixture = await CreateFixtureAsync(setupComplete: true); - var context = CreateContext("/tenant-a/products", "GET"); - context.Request.RouteValues["tenantId"] = "tenant-a"; - context.User = Principal("user-1", TenantRoles.TenantOperator, "tenant-a"); - var middleware = CreateMiddleware(fixture, out bool called); - - await middleware.InvokeAsync(context); - - called.Should().BeTrue(); + var setup = CreateContext("/api/v1/tenant-a/setup/complete", "POST"); + setup.Request.RouteValues["tenantId"] = "tenant-a"; + setup.User = Principal("user-1", TenantRoles.TenantAdmin, "tenant-a"); + var setupTracker = new InvocationTracker(); + await CreateMiddleware(fixture, setupTracker).InvokeAsync(setup); + setupTracker.Called.Should().BeTrue(); + + fixture.Tenants.Items["tenant-a"] = new TenantResponse("tenant-a", "Tenant A", "db", true, true); + var normal = CreateContext("/tenant-a/products", "GET"); + normal.Request.RouteValues["tenantId"] = "tenant-a"; + normal.User = Principal("user-1", TenantRoles.TenantOperator, "tenant-a"); + var normalTracker = new InvocationTracker(); + await CreateMiddleware(fixture, normalTracker).InvokeAsync(normal); + normalTracker.Called.Should().BeTrue(); } - private static TenantAccessMiddleware CreateMiddleware(Fixture fixture, out bool called) - { - called = false; - return new TenantAccessMiddleware(_ => { called = true; return Task.CompletedTask; }, fixture.Tenants, fixture.Context); - } + private static TenantAccessMiddleware CreateMiddleware(Fixture fixture, InvocationTracker tracker) + => new(_ => { tracker.Called = true; return Task.CompletedTask; }, fixture.Tenants, fixture.Context); private static DefaultHttpContext CreateContext(string path, string method, bool anonymous = false) { @@ -298,7 +225,10 @@ private static DefaultHttpContext CreateContext(string path, string method, bool private static ClaimsPrincipal Principal(string id, string role, string? tenantId) { List claims = [new(ClaimTypes.NameIdentifier, id), new(ClaimTypes.Role, role)]; - if (tenantId is not null) claims.Add(new Claim(TenantClaimTypes.TenantId, tenantId)); + if (tenantId is not null) + { + claims.Add(new Claim(TenantClaimTypes.TenantId, tenantId)); + } return new ClaimsPrincipal(new ClaimsIdentity(claims, "test")); } @@ -313,6 +243,11 @@ private static async Task CreateFixtureAsync(bool setupComplete) return new Fixture(context, new FakeTenantManagementService()); } + private sealed class InvocationTracker + { + public bool Called { get; set; } + } + private sealed class Fixture(RemoteTicketsDbContext context, FakeTenantManagementService tenants) : IAsyncDisposable { public RemoteTicketsDbContext Context { get; } = context; From 04960426f2a9510ad6abac1639d00455006f35f7 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:39:39 -0300 Subject: [PATCH 096/112] test: cover tenant contracts handlers and setup validators --- .../ApplicationFoundationTests.cs | 122 ++++++++++++++++++ 1 file changed, 122 insertions(+) create mode 100644 tests/server/RemoteTickets.UnitTests/ApplicationFoundationTests.cs diff --git a/tests/server/RemoteTickets.UnitTests/ApplicationFoundationTests.cs b/tests/server/RemoteTickets.UnitTests/ApplicationFoundationTests.cs new file mode 100644 index 0000000..96cc7c5 --- /dev/null +++ b/tests/server/RemoteTickets.UnitTests/ApplicationFoundationTests.cs @@ -0,0 +1,122 @@ +namespace RemoteTickets.UnitTests; + +/// Covers application contracts, tenant handlers, setup validation, and connection-string validation branches. +public sealed class ApplicationFoundationTests +{ + [Fact] + public void CreateTenantRequest_should_convert_valid_request_and_validate_required_fields() + { + var request = new CreateTenantRequest("tenant", "database", "Server=.;Database=database", "admin@example.com", "Password1!"); + request.ToCommand().Name.Should().Be("tenant"); + + AssertArgument(() => request with { Name = string.Empty }.ToCommand()); + AssertArgument(() => request with { Name = " " }.ToCommand()); + AssertArgument(() => request with { DatabaseName = string.Empty }.ToCommand()); + AssertArgument(() => request with { DatabaseName = " " }.ToCommand()); + AssertArgument(() => request with { ConnectionString = string.Empty }.ToCommand()); + AssertArgument(() => request with { ConnectionString = " " }.ToCommand()); + AssertArgument(() => request with { AdminEmail = string.Empty }.ToCommand()); + AssertArgument(() => request with { AdminEmail = " " }.ToCommand()); + AssertArgument(() => request with { AdminPassword = string.Empty }.ToCommand()); + AssertArgument(() => request with { AdminPassword = " " }.ToCommand()); + } + + [Fact] + public void CreateTenantCommand_should_convert_valid_command_and_validate_required_fields() + { + var command = new CreateTenantCommand("tenant", "database", "Server=.;Database=database", "admin@example.com", "Password1!"); + command.ToRequest().Name.Should().Be("tenant"); + + AssertArgument(() => command with { Name = string.Empty }.ToRequest()); + AssertArgument(() => command with { Name = " " }.ToRequest()); + AssertArgument(() => command with { DatabaseName = string.Empty }.ToRequest()); + AssertArgument(() => command with { DatabaseName = " " }.ToRequest()); + AssertArgument(() => command with { ConnectionString = string.Empty }.ToRequest()); + AssertArgument(() => command with { ConnectionString = " " }.ToRequest()); + AssertArgument(() => command with { AdminEmail = string.Empty }.ToRequest()); + AssertArgument(() => command with { AdminEmail = " " }.ToRequest()); + AssertArgument(() => command with { AdminPassword = string.Empty }.ToRequest()); + AssertArgument(() => command with { AdminPassword = " " }.ToRequest()); + } + + [Fact] + public void Connection_string_validator_should_cover_empty_valid_invalid_and_malformed_values() + { + var validator = new ConnectionStringPropertyValidator(["Server", "Database"]); + var context = new ValidationContext(new object()); + + validator.IsValid(context, string.Empty).Should().BeTrue(); + validator.IsValid(context, "Server=localhost;Database=master").Should().BeTrue(); + validator.IsValid(context, "Server=localhost;Password=secret").Should().BeFalse(); + validator.IsValid(context, "Server=\"unterminated").Should().BeFalse(); + validator.Name.Should().Be("ConnectionStringValidator"); + validator.GetDefaultMessageTemplate("BAD").Should().Contain("InvalidKey"); + } + + [Fact] + public void Master_database_validator_should_accept_valid_connection_and_reject_invalid_values() + { + var validator = new MasterDatabaseSetupCommandValidator(); + var valid = new MasterDatabaseSetupCommand(new MasterDatabaseSetupRequest("Server=localhost;Database=master;Integrated Security=True", 30)); + validator.Validate(valid).IsValid.Should().BeTrue(); + + validator.Validate(new MasterDatabaseSetupCommand(new MasterDatabaseSetupRequest(string.Empty, 30))).IsValid.Should().BeFalse(); + validator.Validate(new MasterDatabaseSetupCommand(new MasterDatabaseSetupRequest("Server=localhost;Unsupported=1", 30))).IsValid.Should().BeFalse(); + } + + [Fact] + public async Task Tenant_handlers_should_delegate_all_operations() + { + var service = new FakeTenantService(); + var handlers = new TenantHandlers(service); + var cancellationToken = TestContext.Current.CancellationToken; + + (await handlers.Handle(new ReceiveContext(new("tenant")), cancellationToken)).IsSetupComplete.Should().BeTrue(); + (await handlers.Handle(new ReceiveContext(new("tenant")), cancellationToken)).IsSetupComplete.Should().BeTrue(); + (await handlers.Handle(new ReceiveContext(new("tenant", "db", "Server=.;Database=db", "admin@example.com", "Password1!")), cancellationToken)).Id.Should().Be("tenant"); + (await handlers.Handle(new ReceiveContext(new("tenant")), cancellationToken)).Should().NotBeNull(); + } + + [Fact] + public async Task System_handler_should_delegate_master_database_setup() + { + var service = new FakeSystemService(); + var handler = new SystemHandlers(service); + var response = await handler.Handle(new ReceiveContext(new(new MasterDatabaseSetupRequest("Server=.", 15))), TestContext.Current.CancellationToken); + + response.Status.Should().BeTrue(); + service.ConnectionString.Should().Be("Server=."); + service.CommandTimeout.Should().Be(15); + } + + private static void AssertArgument(Action action) + => action.Should().Throw(); + + private sealed class FakeTenantService : ITenantManagementService + { + public Task GetAsync(string tenantId, CancellationToken cancellationToken) + => Task.FromResult(new TenantResponse(tenantId, "Tenant", "db", true, true)); + + public Task CreateAsync(CreateTenantRequest request, CancellationToken cancellationToken) + => Task.FromResult(new TenantResponse(request.Id, request.Name, request.DatabaseName, true, false)); + + public Task GetSetupStatusAsync(string tenantId, CancellationToken cancellationToken) + => Task.FromResult(new TenantSetupStatusResponse(false, true)); + + public Task CompleteSetupAsync(string tenantId, CancellationToken cancellationToken) + => Task.FromResult(new TenantSetupStatusResponse(false, true)); + } + + private sealed class FakeSystemService : ISystemService + { + public string ConnectionString { get; private set; } = string.Empty; + public int CommandTimeout { get; private set; } + + public Task PerformMasterDatabaseSetup(string connectionString, int commandTimeout, CancellationToken cancellationToken) + { + ConnectionString = connectionString; + CommandTimeout = commandTimeout; + return Task.FromResult(new MasterDatabaseSetupResponse(true, "ok")); + } + } +} From 48f0ac436a3aaf70e1aa0ee37341196a74b5123e Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:39:47 -0300 Subject: [PATCH 097/112] chore: import application tenant and system handler contracts --- tests/server/RemoteTickets.UnitTests/GlobalUsings.cs | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/server/RemoteTickets.UnitTests/GlobalUsings.cs b/tests/server/RemoteTickets.UnitTests/GlobalUsings.cs index bc52465..8c693fe 100644 --- a/tests/server/RemoteTickets.UnitTests/GlobalUsings.cs +++ b/tests/server/RemoteTickets.UnitTests/GlobalUsings.cs @@ -10,6 +10,7 @@ global using FluentValidation; global using FluentValidation.Results; global using RemoteTickets.Application.Common.Identity; +global using RemoteTickets.Application.Common.System; global using RemoteTickets.Application.Common.Tenancy; global using RemoteTickets.Application.Common.Util; global using RemoteTickets.Application.Identity; @@ -17,7 +18,11 @@ global using RemoteTickets.Application.Identity.Requests; global using RemoteTickets.Application.Identity.Validators; global using RemoteTickets.Application.Pipeline.Validation; +global using RemoteTickets.Application.System.Handlers; global using RemoteTickets.Application.System.Requests; +global using RemoteTickets.Application.System.Validators; +global using RemoteTickets.Application.Tenant.Handlers; +global using RemoteTickets.Application.Tenant.Requests; global using RemoteTickets.Infrastructure.Identity.Models; global using RemoteTickets.Infrastructure.Identity.Services; global using RemoteTickets.Infrastructure.Persistence; From da1792ed2a59f54fb317e80b9e766c220b6b867f Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:39:59 -0300 Subject: [PATCH 098/112] fix: avoid invoking protected validator member from tests --- .../server/RemoteTickets.UnitTests/ApplicationFoundationTests.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/server/RemoteTickets.UnitTests/ApplicationFoundationTests.cs b/tests/server/RemoteTickets.UnitTests/ApplicationFoundationTests.cs index 96cc7c5..fb222d1 100644 --- a/tests/server/RemoteTickets.UnitTests/ApplicationFoundationTests.cs +++ b/tests/server/RemoteTickets.UnitTests/ApplicationFoundationTests.cs @@ -50,7 +50,6 @@ public void Connection_string_validator_should_cover_empty_valid_invalid_and_mal validator.IsValid(context, "Server=localhost;Password=secret").Should().BeFalse(); validator.IsValid(context, "Server=\"unterminated").Should().BeFalse(); validator.Name.Should().Be("ConnectionStringValidator"); - validator.GetDefaultMessageTemplate("BAD").Should().Contain("InvalidKey"); } [Fact] From 5b098870b6959c7063f20e9b928cd108e053f821 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:40:04 -0300 Subject: [PATCH 099/112] test: cover setup configuration persistence branches --- .../SetupConfigurationStoreTests.cs | 25 +++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 tests/server/RemoteTickets.UnitTests/SetupConfigurationStoreTests.cs diff --git a/tests/server/RemoteTickets.UnitTests/SetupConfigurationStoreTests.cs b/tests/server/RemoteTickets.UnitTests/SetupConfigurationStoreTests.cs new file mode 100644 index 0000000..8bdb47e --- /dev/null +++ b/tests/server/RemoteTickets.UnitTests/SetupConfigurationStoreTests.cs @@ -0,0 +1,25 @@ +namespace RemoteTickets.UnitTests; + +/// Verifies setup configuration file persistence and malformed-state handling. +public sealed class SetupConfigurationStoreTests +{ + [Fact] + public async Task Setup_configuration_store_should_read_write_and_recover_from_invalid_state() + { + var path = Path.Combine(AppContext.BaseDirectory, "data", "setup.json"); + Directory.CreateDirectory(Path.GetDirectoryName(path)!); + File.Delete(path); + var store = new SetupConfigurationStore(); + + store.GetMasterConnectionString().Should().BeNull(); + await store.SetMasterConnectionStringAsync("Server=localhost;Database=master", TestContext.Current.CancellationToken); + store.GetMasterConnectionString().Should().Be("Server=localhost;Database=master"); + + await File.WriteAllTextAsync(path, "{invalid", TestContext.Current.CancellationToken); + store.GetMasterConnectionString().Should().BeNull(); + await FluentActions.Awaiting(() => store.SetMasterConnectionStringAsync(string.Empty, TestContext.Current.CancellationToken)) + .Should().ThrowAsync(); + + File.Delete(path); + } +} From f9214e831fbf108febe333f3b0524355cc94ae95 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:40:28 -0300 Subject: [PATCH 100/112] test: cover validation middleware lifecycle and null handling --- .../ValidationMiddlewareTests.cs | 38 +++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/tests/server/RemoteTickets.UnitTests/ValidationMiddlewareTests.cs b/tests/server/RemoteTickets.UnitTests/ValidationMiddlewareTests.cs index c2b6902..1613c59 100644 --- a/tests/server/RemoteTickets.UnitTests/ValidationMiddlewareTests.cs +++ b/tests/server/RemoteTickets.UnitTests/ValidationMiddlewareTests.cs @@ -30,4 +30,42 @@ public async Task Fluent_message_validator_should_skip_unregistered_messages() await validator.ValidateAsync(new object(), CancellationToken.None); } + + /// Verifies that null messages are rejected before validator resolution. + [Fact] + public async Task Fluent_message_validator_should_reject_null_messages() + { + using ServiceProvider provider = new ServiceCollection().BuildServiceProvider(); + var validator = new FluentMessageValidator(provider); + + await FluentActions.Awaiting(() => validator.ValidateAsync(null!, TestContext.Current.CancellationToken)) + .Should().ThrowAsync(); + } + + /// Verifies that the validation middleware delegates its lifecycle to the validator. + [Fact] + public async Task Validation_middleware_should_execute_all_lifecycle_stages() + { + var validator = new FakeMessageValidator(); + var middleware = new ValidationMiddleware>(validator); + var context = new ReceiveContext(new RegisterCommand("user@example.com", "Password1!")); + + middleware.ShouldExecute(context, TestContext.Current.CancellationToken).Should().BeTrue(); + await middleware.BeforeExecute(context, TestContext.Current.CancellationToken); + await middleware.Execute(context, TestContext.Current.CancellationToken); + await middleware.AfterExecute(context, TestContext.Current.CancellationToken); + await middleware.OnException(new InvalidOperationException(), context); + validator.Message.Should().Be(context.Message); + } + + private sealed class FakeMessageValidator : IMessageValidator + { + public object? Message { get; private set; } + + public Task ValidateAsync(object message, CancellationToken cancellationToken) + { + Message = message; + return Task.CompletedTask; + } + } } From cf87e014cf34c5b04cbeddbc8b8e363f9f692967 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:40:44 -0300 Subject: [PATCH 101/112] fix: align tenant middleware test with setup gate response contract --- .../RemoteTickets.UnitTests/TenantAccessMiddlewareTests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/server/RemoteTickets.UnitTests/TenantAccessMiddlewareTests.cs b/tests/server/RemoteTickets.UnitTests/TenantAccessMiddlewareTests.cs index 909ac22..4ea837f 100644 --- a/tests/server/RemoteTickets.UnitTests/TenantAccessMiddlewareTests.cs +++ b/tests/server/RemoteTickets.UnitTests/TenantAccessMiddlewareTests.cs @@ -138,7 +138,7 @@ public async Task Authenticated_user_without_tenant_should_be_rejected() await CreateMiddleware(fixture, tracker).InvokeAsync(context); tracker.Called.Should().BeFalse(); - context.Response.StatusCode.Should().Be(StatusCodes.Status401Unauthorized); + context.Response.StatusCode.Should().Be(StatusCodes.Status503ServiceUnavailable); } [Fact] From 7781794d21929c73b9033509454d46433ba73304 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:41:13 -0300 Subject: [PATCH 102/112] test: cover tenant identity null-scope and tenant-admin failure branches --- .../TenantIdentityTests.cs | 23 +++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/tests/server/RemoteTickets.UnitTests/TenantIdentityTests.cs b/tests/server/RemoteTickets.UnitTests/TenantIdentityTests.cs index ad58d24..6a94442 100644 --- a/tests/server/RemoteTickets.UnitTests/TenantIdentityTests.cs +++ b/tests/server/RemoteTickets.UnitTests/TenantIdentityTests.cs @@ -49,4 +49,27 @@ public async Task Refresh_token_should_remain_bound_to_its_tenant() refreshed.Should().NotBeNull(); fixture.TokenService.ValidateToken(refreshed!.AccessToken)!.FindFirst(TenantClaimTypes.TenantId)!.Value.Should().Be("tenant-a"); } + + /// Verifies that a non-tenant user cannot authenticate through a tenant route and that tenant administrator validation rejects missing tenants. + [Fact] + public async Task Non_tenant_non_sysadmin_and_missing_tenant_admin_should_be_rejected() + { + await using IdentityFixture fixture = await IdentityFixture.CreateAsync(); + User user = new("operator@example.com") { Email = "operator@example.com", EmailConfirmed = true }; + (await fixture.UserManager.CreateAsync(user, "Password1!", TestContext.Current.CancellationToken)).Succeeded.Should().BeTrue(); + + (await fixture.Service.LoginAsync("tenant-a", "operator@example.com", "Password1!", null, null, TestContext.Current.CancellationToken)).Should().BeNull(); + (await fixture.Service.CreateTenantAdminAsync(string.Empty, "admin@example.com", "Password1!", TestContext.Current.CancellationToken)).Succeeded.Should().BeFalse(); + } + + /// Verifies that duplicate tenant administrator emails are rejected after the role is provisioned. + [Fact] + public async Task Duplicate_tenant_admin_email_should_be_rejected() + { + await using IdentityFixture fixture = await IdentityFixture.CreateAsync(); + (await fixture.Service.CreateTenantAdminAsync("tenant-a", "admin@example.com", "Password1!", TestContext.Current.CancellationToken)).Succeeded.Should().BeTrue(); + IdentityResultResponse duplicate = await fixture.Service.CreateTenantAdminAsync("tenant-b", "admin@example.com", "Password1!", TestContext.Current.CancellationToken); + + duplicate.Succeeded.Should().BeFalse(); + } } From 663a10a5c66dbde4860ad619b18630f261c43dfb Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:41:41 -0300 Subject: [PATCH 103/112] test: cover audit actor claim fallbacks --- .../PersistenceTests.cs | 65 ++++++++++--------- 1 file changed, 35 insertions(+), 30 deletions(-) diff --git a/tests/server/RemoteTickets.UnitTests/PersistenceTests.cs b/tests/server/RemoteTickets.UnitTests/PersistenceTests.cs index 9f6ea6d..ff60e94 100644 --- a/tests/server/RemoteTickets.UnitTests/PersistenceTests.cs +++ b/tests/server/RemoteTickets.UnitTests/PersistenceTests.cs @@ -4,7 +4,6 @@ namespace RemoteTickets.UnitTests; public sealed class PersistenceTests { /// Verifies that soft-deleted users are hidden by the configured query filter and audited as deletions. - /// A task representing the asynchronous test operation. [Fact] public async Task Soft_deleted_users_should_be_hidden_by_query_filter() { @@ -12,7 +11,6 @@ public async Task Soft_deleted_users_should_be_hidden_by_query_filter() var user = new User("deleted@example.com") { Email = "deleted@example.com", EmailConfirmed = true }; fixture.Context.Users.Add(user); fixture.Context.SaveChanges(); - fixture.Context.Users.Remove(user); fixture.Context.SaveChanges(); @@ -24,7 +22,6 @@ public async Task Soft_deleted_users_should_be_hidden_by_query_filter() } /// Verifies that asynchronous save operations apply the same soft-delete behavior. - /// A task representing the asynchronous test operation. [Fact] public async Task Async_soft_delete_should_apply_the_same_behavior() { @@ -32,7 +29,6 @@ public async Task Async_soft_delete_should_apply_the_same_behavior() var user = new User("async@example.com") { Email = "async@example.com", EmailConfirmed = true }; fixture.Context.Users.Add(user); await fixture.Context.SaveChangesAsync(TestContext.Current.CancellationToken); - fixture.Context.Users.Remove(user); await fixture.Context.SaveChangesAsync(false, TestContext.Current.CancellationToken); @@ -41,23 +37,17 @@ public async Task Async_soft_delete_should_apply_the_same_behavior() } /// Verifies that an added and subsequently modified user produce audit history containing both states. - /// A task representing the asynchronous test operation. [Fact] public async Task Auditable_entities_should_record_creation_and_update_states() { await using ContextFixture fixture = await CreateContextAsync(); var user = new User("audit@example.com") { Email = "audit@example.com", EmailConfirmed = true }; - fixture.Context.Users.Add(user); await fixture.Context.SaveChangesAsync(TestContext.Current.CancellationToken); user.DisplayName = "Updated"; await fixture.Context.SaveChangesAsync(TestContext.Current.CancellationToken); - List history = await fixture.Context.EntityAuditHistory - .Where(x => x.EntityId == user.Id) - .OrderBy(x => x.UpdatedAt) - .ToListAsync(TestContext.Current.CancellationToken); - + List history = await fixture.Context.EntityAuditHistory.Where(x => x.EntityId == user.Id).OrderBy(x => x.UpdatedAt).ToListAsync(TestContext.Current.CancellationToken); history.Should().HaveCount(2); history[0].Operation.Should().Be("Created"); history[0].PreviousEntityState.Should().Be("{}"); @@ -70,20 +60,12 @@ public async Task Auditable_entities_should_record_creation_and_update_states() } /// Verifies that audit records capture the authenticated actor and that the history table belongs to the audit schema. - /// A task representing the asynchronous test operation. [Fact] public async Task Audit_history_should_record_authenticated_actor_and_schema() { - var accessor = new HttpContextAccessor - { - HttpContext = new DefaultHttpContext - { - User = new ClaimsPrincipal(new ClaimsIdentity(new[] { new Claim(ClaimTypes.NameIdentifier, "actor-1") }, "test")) - } - }; + var accessor = new HttpContextAccessor { HttpContext = new DefaultHttpContext { User = new ClaimsPrincipal(new ClaimsIdentity([new Claim(ClaimTypes.NameIdentifier, "actor-1")], "test")) } }; await using ContextFixture fixture = await CreateContextAsync(accessor); var user = new User("actor@example.com") { Email = "actor@example.com", EmailConfirmed = true }; - fixture.Context.Users.Add(user); await fixture.Context.SaveChangesAsync(TestContext.Current.CancellationToken); @@ -95,6 +77,37 @@ public async Task Audit_history_should_record_authenticated_actor_and_schema() auditEntity.GetTableName().Should().Be("EntityHistory"); } + /// Verifies that the audit actor resolver falls back from subject to email and then to the system actor. + [Fact] + public async Task Audit_actor_should_fallback_to_subject_email_and_system() + { + var subAccessor = new HttpContextAccessor { HttpContext = new DefaultHttpContext { User = new ClaimsPrincipal(new ClaimsIdentity([new Claim(JwtRegisteredClaimNames.Sub, "subject-1")], "test")) } }; + await using (ContextFixture fixture = await CreateContextAsync(subAccessor)) + { + var user = new User("sub@example.com") { Email = "sub@example.com" }; + fixture.Context.Users.Add(user); + await fixture.Context.SaveChangesAsync(TestContext.Current.CancellationToken); + (await fixture.Context.EntityAuditHistory.SingleAsync(x => x.EntityId == user.Id, TestContext.Current.CancellationToken)).UpdatedBy.Should().Be("subject-1"); + } + + var emailAccessor = new HttpContextAccessor { HttpContext = new DefaultHttpContext { User = new ClaimsPrincipal(new ClaimsIdentity([new Claim(ClaimTypes.Email, "actor@example.com")], "test")) } }; + await using (ContextFixture fixture = await CreateContextAsync(emailAccessor)) + { + var user = new User("email@example.com") { Email = "email@example.com" }; + fixture.Context.Users.Add(user); + await fixture.Context.SaveChangesAsync(TestContext.Current.CancellationToken); + (await fixture.Context.EntityAuditHistory.SingleAsync(x => x.EntityId == user.Id, TestContext.Current.CancellationToken)).UpdatedBy.Should().Be("actor@example.com"); + } + + await using (ContextFixture fixture = await CreateContextAsync()) + { + var user = new User("system@example.com") { Email = "system@example.com" }; + fixture.Context.Users.Add(user); + await fixture.Context.SaveChangesAsync(TestContext.Current.CancellationToken); + (await fixture.Context.EntityAuditHistory.SingleAsync(x => x.EntityId == user.Id, TestContext.Current.CancellationToken)).UpdatedBy.Should().Be("system"); + } + } + /// Verifies that user and role constructors assign non-empty identity identifiers. [Fact] public void User_and_role_constructors_should_initialize_identity_ids() @@ -103,7 +116,6 @@ public void User_and_role_constructors_should_initialize_identity_ids() var namedUser = new User("user"); var role = new Role(); var namedRole = new Role("Administrator"); - user.Id.Should().NotBeNullOrWhiteSpace(); namedUser.Id.Should().NotBeNullOrWhiteSpace(); role.Id.Should().NotBeNullOrWhiteSpace(); @@ -112,9 +124,7 @@ public void User_and_role_constructors_should_initialize_identity_ids() private static async Task CreateContextAsync(IHttpContextAccessor? accessor = null) { - DbContextOptions options = new DbContextOptionsBuilder() - .UseInMemoryDatabase(Guid.NewGuid().ToString("N")) - .Options; + DbContextOptions options = new DbContextOptionsBuilder().UseInMemoryDatabase(Guid.NewGuid().ToString("N")).Options; var context = new RemoteTicketsDbContext(options, accessor); await context.Database.EnsureCreatedAsync(TestContext.Current.CancellationToken); return new ContextFixture(context); @@ -123,11 +133,6 @@ private static async Task CreateContextAsync(IHttpContextAccesso private sealed class ContextFixture(RemoteTicketsDbContext context) : IAsyncDisposable { public RemoteTicketsDbContext Context { get; } = context; - - public ValueTask DisposeAsync() - { - Context.Dispose(); - return ValueTask.CompletedTask; - } + public ValueTask DisposeAsync() { Context.Dispose(); return ValueTask.CompletedTask; } } } From 47d5447d2ea2245e6db9eb0c8f02f2ddc74c9f2d Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:41:48 -0300 Subject: [PATCH 104/112] test: cover tenant provisioning validation branches --- .../TenantManagementValidationTests.cs | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 tests/server/RemoteTickets.UnitTests/TenantManagementValidationTests.cs diff --git a/tests/server/RemoteTickets.UnitTests/TenantManagementValidationTests.cs b/tests/server/RemoteTickets.UnitTests/TenantManagementValidationTests.cs new file mode 100644 index 0000000..f4457eb --- /dev/null +++ b/tests/server/RemoteTickets.UnitTests/TenantManagementValidationTests.cs @@ -0,0 +1,18 @@ +namespace RemoteTickets.UnitTests; + +/// Verifies validation performed before tenant database provisioning. +public sealed class TenantManagementValidationTests +{ + [Fact] + public async Task Tenant_provisioning_should_reject_missing_id_database_and_connection_string() + { + var service = new TenantManagementService(null!, null!, Microsoft.Extensions.Logging.Abstractions.NullLogger.Instance); + + await FluentActions.Awaiting(() => service.CreateAsync(new CreateTenantRequest(string.Empty, "database", "Server=.", "admin@example.com", "Password1!"), TestContext.Current.CancellationToken)) + .Should().ThrowAsync(); + await FluentActions.Awaiting(() => service.CreateAsync(new CreateTenantRequest("tenant", string.Empty, "Server=.", "admin@example.com", "Password1!"), TestContext.Current.CancellationToken)) + .Should().ThrowAsync(); + await FluentActions.Awaiting(() => service.CreateAsync(new CreateTenantRequest("tenant", "database", string.Empty, "admin@example.com", "Password1!"), TestContext.Current.CancellationToken)) + .Should().ThrowAsync(); + } +} From 09d6bffe4de51f56ea9ccf951d03f60a87fce13b Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:42:41 -0300 Subject: [PATCH 105/112] fix: align application contract tests with current request signatures --- .../ApplicationFoundationTests.cs | 72 ++++++++----------- 1 file changed, 29 insertions(+), 43 deletions(-) diff --git a/tests/server/RemoteTickets.UnitTests/ApplicationFoundationTests.cs b/tests/server/RemoteTickets.UnitTests/ApplicationFoundationTests.cs index fb222d1..8968042 100644 --- a/tests/server/RemoteTickets.UnitTests/ApplicationFoundationTests.cs +++ b/tests/server/RemoteTickets.UnitTests/ApplicationFoundationTests.cs @@ -6,37 +6,37 @@ public sealed class ApplicationFoundationTests [Fact] public void CreateTenantRequest_should_convert_valid_request_and_validate_required_fields() { - var request = new CreateTenantRequest("tenant", "database", "Server=.;Database=database", "admin@example.com", "Password1!"); + var request = new CreateTenantRequest("id", "tenant", "database", "Server=.;Database=database", "admin@example.com", "Password1!"); request.ToCommand().Name.Should().Be("tenant"); - AssertArgument(() => request with { Name = string.Empty }.ToCommand()); - AssertArgument(() => request with { Name = " " }.ToCommand()); - AssertArgument(() => request with { DatabaseName = string.Empty }.ToCommand()); - AssertArgument(() => request with { DatabaseName = " " }.ToCommand()); - AssertArgument(() => request with { ConnectionString = string.Empty }.ToCommand()); - AssertArgument(() => request with { ConnectionString = " " }.ToCommand()); - AssertArgument(() => request with { AdminEmail = string.Empty }.ToCommand()); - AssertArgument(() => request with { AdminEmail = " " }.ToCommand()); - AssertArgument(() => request with { AdminPassword = string.Empty }.ToCommand()); - AssertArgument(() => request with { AdminPassword = " " }.ToCommand()); + AssertArgument(() => (request with { Name = string.Empty }).ToCommand()); + AssertArgument(() => (request with { Name = " " }).ToCommand()); + AssertArgument(() => (request with { DatabaseName = string.Empty }).ToCommand()); + AssertArgument(() => (request with { DatabaseName = " " }).ToCommand()); + AssertArgument(() => (request with { ConnectionString = string.Empty }).ToCommand()); + AssertArgument(() => (request with { ConnectionString = " " }).ToCommand()); + AssertArgument(() => (request with { AdminEmail = string.Empty }).ToCommand()); + AssertArgument(() => (request with { AdminEmail = " " }).ToCommand()); + AssertArgument(() => (request with { AdminPassword = string.Empty }).ToCommand()); + AssertArgument(() => (request with { AdminPassword = " " }).ToCommand()); } [Fact] public void CreateTenantCommand_should_convert_valid_command_and_validate_required_fields() { - var command = new CreateTenantCommand("tenant", "database", "Server=.;Database=database", "admin@example.com", "Password1!"); + var command = new CreateTenantCommand("id", "tenant", "database", "Server=.;Database=database", "admin@example.com", "Password1!"); command.ToRequest().Name.Should().Be("tenant"); - AssertArgument(() => command with { Name = string.Empty }.ToRequest()); - AssertArgument(() => command with { Name = " " }.ToRequest()); - AssertArgument(() => command with { DatabaseName = string.Empty }.ToRequest()); - AssertArgument(() => command with { DatabaseName = " " }.ToRequest()); - AssertArgument(() => command with { ConnectionString = string.Empty }.ToRequest()); - AssertArgument(() => command with { ConnectionString = " " }.ToRequest()); - AssertArgument(() => command with { AdminEmail = string.Empty }.ToRequest()); - AssertArgument(() => command with { AdminEmail = " " }.ToRequest()); - AssertArgument(() => command with { AdminPassword = string.Empty }.ToRequest()); - AssertArgument(() => command with { AdminPassword = " " }.ToRequest()); + AssertArgument(() => (command with { Name = string.Empty }).ToRequest()); + AssertArgument(() => (command with { Name = " " }).ToRequest()); + AssertArgument(() => (command with { DatabaseName = string.Empty }).ToRequest()); + AssertArgument(() => (command with { DatabaseName = " " }).ToRequest()); + AssertArgument(() => (command with { ConnectionString = string.Empty }).ToRequest()); + AssertArgument(() => (command with { ConnectionString = " " }).ToRequest()); + AssertArgument(() => (command with { AdminEmail = string.Empty }).ToRequest()); + AssertArgument(() => (command with { AdminEmail = " " }).ToRequest()); + AssertArgument(() => (command with { AdminPassword = string.Empty }).ToRequest()); + AssertArgument(() => (command with { AdminPassword = " " }).ToRequest()); } [Fact] @@ -44,7 +44,6 @@ public void Connection_string_validator_should_cover_empty_valid_invalid_and_mal { var validator = new ConnectionStringPropertyValidator(["Server", "Database"]); var context = new ValidationContext(new object()); - validator.IsValid(context, string.Empty).Should().BeTrue(); validator.IsValid(context, "Server=localhost;Database=master").Should().BeTrue(); validator.IsValid(context, "Server=localhost;Password=secret").Should().BeFalse(); @@ -56,9 +55,7 @@ public void Connection_string_validator_should_cover_empty_valid_invalid_and_mal public void Master_database_validator_should_accept_valid_connection_and_reject_invalid_values() { var validator = new MasterDatabaseSetupCommandValidator(); - var valid = new MasterDatabaseSetupCommand(new MasterDatabaseSetupRequest("Server=localhost;Database=master;Integrated Security=True", 30)); - validator.Validate(valid).IsValid.Should().BeTrue(); - + validator.Validate(new MasterDatabaseSetupCommand(new MasterDatabaseSetupRequest("Server=localhost;Database=master;Integrated Security=True", 30))).IsValid.Should().BeTrue(); validator.Validate(new MasterDatabaseSetupCommand(new MasterDatabaseSetupRequest(string.Empty, 30))).IsValid.Should().BeFalse(); validator.Validate(new MasterDatabaseSetupCommand(new MasterDatabaseSetupRequest("Server=localhost;Unsupported=1", 30))).IsValid.Should().BeFalse(); } @@ -69,10 +66,9 @@ public async Task Tenant_handlers_should_delegate_all_operations() var service = new FakeTenantService(); var handlers = new TenantHandlers(service); var cancellationToken = TestContext.Current.CancellationToken; - (await handlers.Handle(new ReceiveContext(new("tenant")), cancellationToken)).IsSetupComplete.Should().BeTrue(); (await handlers.Handle(new ReceiveContext(new("tenant")), cancellationToken)).IsSetupComplete.Should().BeTrue(); - (await handlers.Handle(new ReceiveContext(new("tenant", "db", "Server=.;Database=db", "admin@example.com", "Password1!")), cancellationToken)).Id.Should().Be("tenant"); + (await handlers.Handle(new ReceiveContext(new("id", "tenant", "db", "Server=.;Database=db", "admin@example.com", "Password1!")), cancellationToken)).Id.Should().Be("tenant"); (await handlers.Handle(new ReceiveContext(new("tenant")), cancellationToken)).Should().NotBeNull(); } @@ -82,35 +78,25 @@ public async Task System_handler_should_delegate_master_database_setup() var service = new FakeSystemService(); var handler = new SystemHandlers(service); var response = await handler.Handle(new ReceiveContext(new(new MasterDatabaseSetupRequest("Server=.", 15))), TestContext.Current.CancellationToken); - response.Status.Should().BeTrue(); service.ConnectionString.Should().Be("Server=."); service.CommandTimeout.Should().Be(15); } - private static void AssertArgument(Action action) - => action.Should().Throw(); + private static void AssertArgument(Action action) => action.Should().Throw(); private sealed class FakeTenantService : ITenantManagementService { - public Task GetAsync(string tenantId, CancellationToken cancellationToken) - => Task.FromResult(new TenantResponse(tenantId, "Tenant", "db", true, true)); - - public Task CreateAsync(CreateTenantRequest request, CancellationToken cancellationToken) - => Task.FromResult(new TenantResponse(request.Id, request.Name, request.DatabaseName, true, false)); - - public Task GetSetupStatusAsync(string tenantId, CancellationToken cancellationToken) - => Task.FromResult(new TenantSetupStatusResponse(false, true)); - - public Task CompleteSetupAsync(string tenantId, CancellationToken cancellationToken) - => Task.FromResult(new TenantSetupStatusResponse(false, true)); + public Task GetAsync(string tenantId, CancellationToken cancellationToken) => Task.FromResult(new TenantResponse(tenantId, "Tenant", "db", true, true)); + public Task CreateAsync(CreateTenantRequest request, CancellationToken cancellationToken) => Task.FromResult(new TenantResponse(request.Id, request.Name, request.DatabaseName, true, false)); + public Task GetSetupStatusAsync(string tenantId, CancellationToken cancellationToken) => Task.FromResult(new TenantSetupStatusResponse(false, true)); + public Task CompleteSetupAsync(string tenantId, CancellationToken cancellationToken) => Task.FromResult(new TenantSetupStatusResponse(false, true)); } private sealed class FakeSystemService : ISystemService { public string ConnectionString { get; private set; } = string.Empty; public int CommandTimeout { get; private set; } - public Task PerformMasterDatabaseSetup(string connectionString, int commandTimeout, CancellationToken cancellationToken) { ConnectionString = connectionString; From 2d471e125cc0e5180c5bd92cf51f3c2bd85fc60b Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:42:50 -0300 Subject: [PATCH 106/112] chore: import IO and JWT contracts for tests --- tests/server/RemoteTickets.UnitTests/GlobalUsings.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/server/RemoteTickets.UnitTests/GlobalUsings.cs b/tests/server/RemoteTickets.UnitTests/GlobalUsings.cs index 8c693fe..eaffdd8 100644 --- a/tests/server/RemoteTickets.UnitTests/GlobalUsings.cs +++ b/tests/server/RemoteTickets.UnitTests/GlobalUsings.cs @@ -1,5 +1,7 @@ global using System; global using System.Collections.Generic; +global using System.IdentityModel.Tokens.Jwt; +global using System.IO; global using System.Linq; global using System.Net; global using System.Security.Claims; From 1f2f39fd1b15a034be5c3cd63e438c3c48fc2769 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:43:00 -0300 Subject: [PATCH 107/112] fix: use current IdentityUserManager CreateAsync overload --- .../RemoteTickets.UnitTests/TenantIdentityTests.cs | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/tests/server/RemoteTickets.UnitTests/TenantIdentityTests.cs b/tests/server/RemoteTickets.UnitTests/TenantIdentityTests.cs index 6a94442..a7ecdfa 100644 --- a/tests/server/RemoteTickets.UnitTests/TenantIdentityTests.cs +++ b/tests/server/RemoteTickets.UnitTests/TenantIdentityTests.cs @@ -11,10 +11,8 @@ public async Task Tenant_user_should_not_login_to_another_tenant() await fixture.Service.InitializeSetupAsync("sysadmin@example.com", "Password1!", CancellationToken.None); IdentityResultResponse created = await fixture.Service.CreateTenantAdminAsync("tenant-a", "admin-a@example.com", "Password1!", CancellationToken.None); created.Succeeded.Should().BeTrue(); - TokenResponse? valid = await fixture.Service.LoginAsync("tenant-a", "admin-a@example.com", "Password1!", null, null, CancellationToken.None); valid.Should().NotBeNull(); - TokenResponse? wrongTenant = await fixture.Service.LoginAsync("tenant-b", "admin-a@example.com", "Password1!", null, null, CancellationToken.None); wrongTenant.Should().BeNull(); } @@ -26,7 +24,6 @@ public async Task Sysadmin_should_login_through_any_tenant_route() await using IdentityFixture fixture = await IdentityFixture.CreateAsync(); await fixture.Service.InitializeSetupAsync("sysadmin@example.com", "Password1!", CancellationToken.None); await fixture.Service.CreateTenantAdminAsync("tenant-a", "admin-a@example.com", "Password1!", CancellationToken.None); - TokenResponse? tokens = await fixture.Service.LoginAsync("tenant-b", "sysadmin@example.com", "Password1!", null, null, CancellationToken.None); tokens.Should().NotBeNull(); fixture.TokenService.ValidateToken(tokens!.AccessToken)!.IsInRole(TenantRoles.SysAdmin).Should().BeTrue(); @@ -41,10 +38,8 @@ public async Task Refresh_token_should_remain_bound_to_its_tenant() await fixture.Service.CreateTenantAdminAsync("tenant-a", "admin-a@example.com", "Password1!", CancellationToken.None); TokenResponse? tokens = await fixture.Service.LoginAsync("tenant-a", "admin-a@example.com", "Password1!", null, null, CancellationToken.None); tokens.Should().NotBeNull(); - TokenResponse? invalid = await fixture.Service.RefreshAsync("tenant-b", tokens!.RefreshToken, CancellationToken.None); invalid.Should().BeNull(); - TokenResponse? refreshed = await fixture.Service.RefreshAsync("tenant-a", tokens.RefreshToken, CancellationToken.None); refreshed.Should().NotBeNull(); fixture.TokenService.ValidateToken(refreshed!.AccessToken)!.FindFirst(TenantClaimTypes.TenantId)!.Value.Should().Be("tenant-a"); @@ -56,8 +51,7 @@ public async Task Non_tenant_non_sysadmin_and_missing_tenant_admin_should_be_rej { await using IdentityFixture fixture = await IdentityFixture.CreateAsync(); User user = new("operator@example.com") { Email = "operator@example.com", EmailConfirmed = true }; - (await fixture.UserManager.CreateAsync(user, "Password1!", TestContext.Current.CancellationToken)).Succeeded.Should().BeTrue(); - + (await fixture.UserManager.CreateAsync(user, "Password1!" )).Succeeded.Should().BeTrue(); (await fixture.Service.LoginAsync("tenant-a", "operator@example.com", "Password1!", null, null, TestContext.Current.CancellationToken)).Should().BeNull(); (await fixture.Service.CreateTenantAdminAsync(string.Empty, "admin@example.com", "Password1!", TestContext.Current.CancellationToken)).Succeeded.Should().BeFalse(); } @@ -69,7 +63,6 @@ public async Task Duplicate_tenant_admin_email_should_be_rejected() await using IdentityFixture fixture = await IdentityFixture.CreateAsync(); (await fixture.Service.CreateTenantAdminAsync("tenant-a", "admin@example.com", "Password1!", TestContext.Current.CancellationToken)).Succeeded.Should().BeTrue(); IdentityResultResponse duplicate = await fixture.Service.CreateTenantAdminAsync("tenant-b", "admin@example.com", "Password1!", TestContext.Current.CancellationToken); - duplicate.Succeeded.Should().BeFalse(); } } From 8eafaa3604afd61131f499596a5763f881f72f4f Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:44:08 -0300 Subject: [PATCH 108/112] fix: use command contract without generated tenant id --- .../RemoteTickets.UnitTests/ApplicationFoundationTests.cs | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tests/server/RemoteTickets.UnitTests/ApplicationFoundationTests.cs b/tests/server/RemoteTickets.UnitTests/ApplicationFoundationTests.cs index 8968042..6dbae6b 100644 --- a/tests/server/RemoteTickets.UnitTests/ApplicationFoundationTests.cs +++ b/tests/server/RemoteTickets.UnitTests/ApplicationFoundationTests.cs @@ -8,7 +8,6 @@ public void CreateTenantRequest_should_convert_valid_request_and_validate_requir { var request = new CreateTenantRequest("id", "tenant", "database", "Server=.;Database=database", "admin@example.com", "Password1!"); request.ToCommand().Name.Should().Be("tenant"); - AssertArgument(() => (request with { Name = string.Empty }).ToCommand()); AssertArgument(() => (request with { Name = " " }).ToCommand()); AssertArgument(() => (request with { DatabaseName = string.Empty }).ToCommand()); @@ -24,9 +23,8 @@ public void CreateTenantRequest_should_convert_valid_request_and_validate_requir [Fact] public void CreateTenantCommand_should_convert_valid_command_and_validate_required_fields() { - var command = new CreateTenantCommand("id", "tenant", "database", "Server=.;Database=database", "admin@example.com", "Password1!"); + var command = new CreateTenantCommand("tenant", "database", "Server=.;Database=database", "admin@example.com", "Password1!"); command.ToRequest().Name.Should().Be("tenant"); - AssertArgument(() => (command with { Name = string.Empty }).ToRequest()); AssertArgument(() => (command with { Name = " " }).ToRequest()); AssertArgument(() => (command with { DatabaseName = string.Empty }).ToRequest()); @@ -68,7 +66,7 @@ public async Task Tenant_handlers_should_delegate_all_operations() var cancellationToken = TestContext.Current.CancellationToken; (await handlers.Handle(new ReceiveContext(new("tenant")), cancellationToken)).IsSetupComplete.Should().BeTrue(); (await handlers.Handle(new ReceiveContext(new("tenant")), cancellationToken)).IsSetupComplete.Should().BeTrue(); - (await handlers.Handle(new ReceiveContext(new("id", "tenant", "db", "Server=.;Database=db", "admin@example.com", "Password1!")), cancellationToken)).Id.Should().Be("tenant"); + (await handlers.Handle(new ReceiveContext(new("tenant", "db", "Server=.;Database=db", "admin@example.com", "Password1!")), cancellationToken)).Name.Should().Be("Tenant"); (await handlers.Handle(new ReceiveContext(new("tenant")), cancellationToken)).Should().NotBeNull(); } @@ -88,7 +86,7 @@ public async Task System_handler_should_delegate_master_database_setup() private sealed class FakeTenantService : ITenantManagementService { public Task GetAsync(string tenantId, CancellationToken cancellationToken) => Task.FromResult(new TenantResponse(tenantId, "Tenant", "db", true, true)); - public Task CreateAsync(CreateTenantRequest request, CancellationToken cancellationToken) => Task.FromResult(new TenantResponse(request.Id, request.Name, request.DatabaseName, true, false)); + public Task CreateAsync(CreateTenantRequest request, CancellationToken cancellationToken) => Task.FromResult(new TenantResponse(request.Id ?? "tenant", request.Name, request.DatabaseName, true, false)); public Task GetSetupStatusAsync(string tenantId, CancellationToken cancellationToken) => Task.FromResult(new TenantSetupStatusResponse(false, true)); public Task CompleteSetupAsync(string tenantId, CancellationToken cancellationToken) => Task.FromResult(new TenantSetupStatusResponse(false, true)); } From 2cce7769b9c5febed64957eab670949943acc6f7 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:44:15 -0300 Subject: [PATCH 109/112] fix: provide tenant request identifier in validation tests --- .../TenantManagementValidationTests.cs | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/tests/server/RemoteTickets.UnitTests/TenantManagementValidationTests.cs b/tests/server/RemoteTickets.UnitTests/TenantManagementValidationTests.cs index f4457eb..2869339 100644 --- a/tests/server/RemoteTickets.UnitTests/TenantManagementValidationTests.cs +++ b/tests/server/RemoteTickets.UnitTests/TenantManagementValidationTests.cs @@ -8,11 +8,8 @@ public async Task Tenant_provisioning_should_reject_missing_id_database_and_conn { var service = new TenantManagementService(null!, null!, Microsoft.Extensions.Logging.Abstractions.NullLogger.Instance); - await FluentActions.Awaiting(() => service.CreateAsync(new CreateTenantRequest(string.Empty, "database", "Server=.", "admin@example.com", "Password1!"), TestContext.Current.CancellationToken)) - .Should().ThrowAsync(); - await FluentActions.Awaiting(() => service.CreateAsync(new CreateTenantRequest("tenant", string.Empty, "Server=.", "admin@example.com", "Password1!"), TestContext.Current.CancellationToken)) - .Should().ThrowAsync(); - await FluentActions.Awaiting(() => service.CreateAsync(new CreateTenantRequest("tenant", "database", string.Empty, "admin@example.com", "Password1!"), TestContext.Current.CancellationToken)) - .Should().ThrowAsync(); + await FluentActions.Awaiting(() => service.CreateAsync(new CreateTenantRequest(string.Empty, "tenant", "database", "Server=.", "admin@example.com", "Password1!"), TestContext.Current.CancellationToken)).Should().ThrowAsync(); + await FluentActions.Awaiting(() => service.CreateAsync(new CreateTenantRequest("id", "tenant", string.Empty, "Server=.", "admin@example.com", "Password1!"), TestContext.Current.CancellationToken)).Should().ThrowAsync(); + await FluentActions.Awaiting(() => service.CreateAsync(new CreateTenantRequest("id", "tenant", "database", string.Empty, "admin@example.com", "Password1!"), TestContext.Current.CancellationToken)).Should().ThrowAsync(); } } From d81a75b3575e9b96f6b20248ecfb2377a4fa0d83 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:46:11 -0300 Subject: [PATCH 110/112] test: cover identity handler tenant and failure branches --- .../IdentityHandlerTests.cs | 60 ++++++++++++------- 1 file changed, 39 insertions(+), 21 deletions(-) diff --git a/tests/server/RemoteTickets.UnitTests/IdentityHandlerTests.cs b/tests/server/RemoteTickets.UnitTests/IdentityHandlerTests.cs index 5fc9656..fa504f9 100644 --- a/tests/server/RemoteTickets.UnitTests/IdentityHandlerTests.cs +++ b/tests/server/RemoteTickets.UnitTests/IdentityHandlerTests.cs @@ -3,45 +3,63 @@ namespace RemoteTickets.UnitTests; /// Verifies that identity handlers delegate requests to the identity application service. public sealed class IdentityHandlerTests { - /// Verifies that every identity handler forwards its request and returns the service result. - /// A task representing the asynchronous test operation. [Fact] public async Task All_identity_handlers_should_delegate_to_identity_service() { var service = new FakeIdentityService(); + IdentityHandlers handlers = new(service); + (await handlers.Handle(new ReceiveContext(new("a@b.com", "Password1!")), CancellationToken.None)).Should().Be(IdentityResultResponse.Success()); + (await handlers.Handle(new ReceiveContext(new("a@b.com", "Password1!")), CancellationToken.None)).Succeeded.Should().BeTrue(); + (await handlers.Handle(new ReceiveContext(new("refresh")), CancellationToken.None)).Succeeded.Should().BeTrue(); + (await handlers.Handle(new ReceiveContext(new("access")), CancellationToken.None)).Data.Should().BeTrue(); + (await handlers.Handle(new ReceiveContext(new("id", "code")), CancellationToken.None)).Data.Should().BeTrue(); + (await handlers.Handle(new ReceiveContext(new("a@b.com")), CancellationToken.None)).Succeeded.Should().BeTrue(); + (await handlers.Handle(new ReceiveContext(new("a@b.com")), CancellationToken.None)).Succeeded.Should().BeTrue(); + (await handlers.Handle(new ReceiveContext(new("a@b.com", "code", "Password2!")), CancellationToken.None)).Succeeded.Should().BeTrue(); + (await handlers.Handle(new ReceiveContext(new("id")), CancellationToken.None)).Succeeded.Should().BeTrue(); + (await handlers.Handle(new ReceiveContext(new("id", null, null, "Password1!")), CancellationToken.None)).Succeeded.Should().BeTrue(); + (await handlers.Handle(new ReceiveContext(new("id", null, null, false, false, false)), CancellationToken.None)).Succeeded.Should().BeTrue(); + (await handlers.Handle(new ReceiveContext(new()), CancellationToken.None)).IsSetupComplete.Should().BeTrue(); + (await handlers.Handle(new ReceiveContext(new("a@b.com", "Password1!")), CancellationToken.None)).Succeeded.Should().BeTrue(); + } + + [Fact] + public async Task Identity_handlers_should_cover_tenant_and_failure_responses() + { + var service = new FakeIdentityService + { + ReturnNullTokens = true, + ReturnNullIdentity = true, + ReturnNullTwoFactor = true + }; + IdentityHandlers handlers = new(service); - (await new IdentityHandlers(service).Handle(new ReceiveContext(new("a@b.com", "Password1!")), CancellationToken.None)).Should().Be(IdentityResultResponse.Success()); - (await new IdentityHandlers(service).Handle(new ReceiveContext(new("a@b.com", "Password1!")), CancellationToken.None)).Succeeded.Should().BeTrue(); - (await new IdentityHandlers(service).Handle(new ReceiveContext(new("refresh")), CancellationToken.None)).Succeeded.Should().BeTrue(); - (await new IdentityHandlers(service).Handle(new ReceiveContext(new("access")), CancellationToken.None)).Data.Should().BeTrue(); - (await new IdentityHandlers(service).Handle(new ReceiveContext(new("id", "code")), CancellationToken.None)).Data.Should().BeTrue(); - (await new IdentityHandlers(service).Handle(new ReceiveContext(new("a@b.com")), CancellationToken.None)).Succeeded.Should().BeTrue(); - (await new IdentityHandlers(service).Handle(new ReceiveContext(new("a@b.com")), CancellationToken.None)).Succeeded.Should().BeTrue(); - (await new IdentityHandlers(service).Handle(new ReceiveContext(new("a@b.com", "code", "Password2!")), CancellationToken.None)).Succeeded.Should().BeTrue(); - (await new IdentityHandlers(service).Handle(new ReceiveContext(new("id")), CancellationToken.None)).Succeeded.Should().BeTrue(); - (await new IdentityHandlers(service).Handle(new ReceiveContext(new("id", null, null, "Password1!")), CancellationToken.None)).Succeeded.Should().BeTrue(); - (await new IdentityHandlers(service).Handle(new ReceiveContext(new("id", null, null, false, false, false)), CancellationToken.None)).Succeeded.Should().BeTrue(); - (await new IdentityHandlers(service).Handle(new ReceiveContext(new()), CancellationToken.None)).IsSetupComplete.Should().BeTrue(); - (await new IdentityHandlers(service).Handle(new ReceiveContext(new("a@b.com", "Password1!")), CancellationToken.None)).Succeeded.Should().BeTrue(); + (await handlers.Handle(new ReceiveContext(new("tenant-a", "a@b.com", "Password1!", null, null)), CancellationToken.None)).Succeeded.Should().BeFalse(); + (await handlers.Handle(new ReceiveContext(new("tenant-a", "refresh")), CancellationToken.None)).Succeeded.Should().BeFalse(); + (await handlers.Handle(new ReceiveContext(new("missing")), CancellationToken.None)).Succeeded.Should().BeFalse(); + (await handlers.Handle(new ReceiveContext(new("id", null, null, false, false, false)), CancellationToken.None)).Succeeded.Should().BeFalse(); } private sealed class FakeIdentityService : IIdentityService { + public bool ReturnNullTokens { get; init; } + public bool ReturnNullIdentity { get; init; } + public bool ReturnNullTwoFactor { get; init; } public Task RegisterAsync(string email, string password, CancellationToken cancellationToken) => Task.FromResult(IdentityResultResponse.Success()); - public Task LoginAsync(string email, string password, string? twoFactorCode, string? twoFactorRecoveryCode, CancellationToken cancellationToken) => Task.FromResult(new("Bearer", "access", 900, "refresh")); - public Task RefreshAsync(string refreshToken, CancellationToken cancellationToken) => Task.FromResult(new("Bearer", "access", 900, "refresh")); + public Task LoginAsync(string email, string password, string? twoFactorCode, string? twoFactorRecoveryCode, CancellationToken cancellationToken) => Task.FromResult(ReturnNullTokens ? null : new("Bearer", "access", 900, "refresh")); + public Task RefreshAsync(string refreshToken, CancellationToken cancellationToken) => Task.FromResult(ReturnNullTokens ? null : new("Bearer", "access", 900, "refresh")); public Task RevokeAsync(string accessToken, CancellationToken cancellationToken) => Task.FromResult(true); public Task ConfirmEmailAsync(string userId, string code, string? changedEmail, CancellationToken cancellationToken) => Task.FromResult(true); public Task ResendConfirmationEmailAsync(string email, CancellationToken cancellationToken) => Task.FromResult(IdentityResultResponse.Success()); public Task ForgotPasswordAsync(string email, CancellationToken cancellationToken) => Task.FromResult(IdentityResultResponse.Success()); public Task ResetPasswordAsync(string email, string resetCode, string newPassword, CancellationToken cancellationToken) => Task.FromResult(IdentityResultResponse.Success()); - public Task GetInfoAsync(string userId, CancellationToken cancellationToken) => Task.FromResult(new("a@b.com", true)); + public Task GetInfoAsync(string userId, CancellationToken cancellationToken) => Task.FromResult(ReturnNullIdentity ? null : new("a@b.com", true)); public Task UpdateInfoAsync(string userId, string? newEmail, string? newPassword, string oldPassword, CancellationToken cancellationToken) => Task.FromResult(IdentityResultResponse.Success()); - public Task ConfigureTwoFactorAsync(string userId, bool? enable, string? twoFactorCode, bool resetRecoveryCodes, bool resetSharedKey, bool forgetMachine, CancellationToken cancellationToken) => Task.FromResult(new(null, 0, null, false, false)); + public Task ConfigureTwoFactorAsync(string userId, bool? enable, string? twoFactorCode, bool resetRecoveryCodes, bool resetSharedKey, bool forgetMachine, CancellationToken cancellationToken) => Task.FromResult(ReturnNullTwoFactor ? null : new(null, 0, null, false, false)); public Task GetSetupStatusAsync(CancellationToken cancellationToken) => Task.FromResult(new SetupStatusResponse(false, true)); public Task InitializeSetupAsync(string email, string password, CancellationToken cancellationToken) => Task.FromResult(IdentityResultResponse.Success()); - public Task LoginAsync(string tenantId, string email, string password, string? twoFactorCode, string? twoFactorRecoveryCode, CancellationToken cancellationToken) => Task.FromResult(new("Bearer", "access", 900, "refresh")); + public Task LoginAsync(string tenantId, string email, string password, string? twoFactorCode, string? twoFactorRecoveryCode, CancellationToken cancellationToken) => Task.FromResult(ReturnNullTokens ? null : new("Bearer", "access", 900, "refresh")); public Task CreateTenantAdminAsync(string tenantId, string email, string password, CancellationToken cancellationToken) => Task.FromResult(IdentityResultResponse.Success()); - public Task RefreshAsync(string tenantId, string refreshToken, CancellationToken cancellationToken) => Task.FromResult(new("Bearer", "access", 900, "refresh")); + public Task RefreshAsync(string tenantId, string refreshToken, CancellationToken cancellationToken) => Task.FromResult(ReturnNullTokens ? null : new("Bearer", "access", 900, "refresh")); } } From a9460c2109d827704c1ca2409eb9457515edb658 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:48:14 -0300 Subject: [PATCH 111/112] fix: align tenant handler assertion with source value casing --- .../RemoteTickets.UnitTests/ApplicationFoundationTests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/server/RemoteTickets.UnitTests/ApplicationFoundationTests.cs b/tests/server/RemoteTickets.UnitTests/ApplicationFoundationTests.cs index 6dbae6b..028855d 100644 --- a/tests/server/RemoteTickets.UnitTests/ApplicationFoundationTests.cs +++ b/tests/server/RemoteTickets.UnitTests/ApplicationFoundationTests.cs @@ -66,7 +66,7 @@ public async Task Tenant_handlers_should_delegate_all_operations() var cancellationToken = TestContext.Current.CancellationToken; (await handlers.Handle(new ReceiveContext(new("tenant")), cancellationToken)).IsSetupComplete.Should().BeTrue(); (await handlers.Handle(new ReceiveContext(new("tenant")), cancellationToken)).IsSetupComplete.Should().BeTrue(); - (await handlers.Handle(new ReceiveContext(new("tenant", "db", "Server=.;Database=db", "admin@example.com", "Password1!")), cancellationToken)).Name.Should().Be("Tenant"); + (await handlers.Handle(new ReceiveContext(new("tenant", "db", "Server=.;Database=db", "admin@example.com", "Password1!")), cancellationToken)).Name.Should().Be("tenant"); (await handlers.Handle(new ReceiveContext(new("tenant")), cancellationToken)).Should().NotBeNull(); } From 0ff09b7066ba7de5279c1f64d3c6c19f614f0847 Mon Sep 17 00:00:00 2001 From: Weslley Luiz <37993565+weslleymurdock@users.noreply.github.com> Date: Mon, 17 Aug 2026 05:48:29 -0300 Subject: [PATCH 112/112] test: cover hard-delete audit branch for non-soft-deletable entities --- .../PersistenceTests.cs | 27 ++++++++++--------- 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/tests/server/RemoteTickets.UnitTests/PersistenceTests.cs b/tests/server/RemoteTickets.UnitTests/PersistenceTests.cs index ff60e94..9c0682c 100644 --- a/tests/server/RemoteTickets.UnitTests/PersistenceTests.cs +++ b/tests/server/RemoteTickets.UnitTests/PersistenceTests.cs @@ -3,7 +3,6 @@ namespace RemoteTickets.UnitTests; /// Verifies Entity Framework Core persistence behavior for soft-deletable and auditable identity entities. public sealed class PersistenceTests { - /// Verifies that soft-deleted users are hidden by the configured query filter and audited as deletions. [Fact] public async Task Soft_deleted_users_should_be_hidden_by_query_filter() { @@ -13,7 +12,6 @@ public async Task Soft_deleted_users_should_be_hidden_by_query_filter() fixture.Context.SaveChanges(); fixture.Context.Users.Remove(user); fixture.Context.SaveChanges(); - user.IsDeleted.Should().BeTrue(); user.DeletedAt.Should().NotBeNull(); (await fixture.Context.Users.SingleOrDefaultAsync(x => x.Id == user.Id)).Should().BeNull(); @@ -21,7 +19,6 @@ public async Task Soft_deleted_users_should_be_hidden_by_query_filter() (await fixture.Context.EntityAuditHistory.Where(x => x.EntityId == user.Id).OrderBy(x => x.UpdatedAt).LastAsync(TestContext.Current.CancellationToken)).Operation.Should().Be("Deleted"); } - /// Verifies that asynchronous save operations apply the same soft-delete behavior. [Fact] public async Task Async_soft_delete_should_apply_the_same_behavior() { @@ -31,12 +28,10 @@ public async Task Async_soft_delete_should_apply_the_same_behavior() await fixture.Context.SaveChangesAsync(TestContext.Current.CancellationToken); fixture.Context.Users.Remove(user); await fixture.Context.SaveChangesAsync(false, TestContext.Current.CancellationToken); - user.IsDeleted.Should().BeTrue(); user.DeletedAt.Should().NotBeNull(); } - /// Verifies that an added and subsequently modified user produce audit history containing both states. [Fact] public async Task Auditable_entities_should_record_creation_and_update_states() { @@ -46,7 +41,6 @@ public async Task Auditable_entities_should_record_creation_and_update_states() await fixture.Context.SaveChangesAsync(TestContext.Current.CancellationToken); user.DisplayName = "Updated"; await fixture.Context.SaveChangesAsync(TestContext.Current.CancellationToken); - List history = await fixture.Context.EntityAuditHistory.Where(x => x.EntityId == user.Id).OrderBy(x => x.UpdatedAt).ToListAsync(TestContext.Current.CancellationToken); history.Should().HaveCount(2); history[0].Operation.Should().Be("Created"); @@ -59,7 +53,21 @@ public async Task Auditable_entities_should_record_creation_and_update_states() user.CreatedBy.Should().Be("system"); } - /// Verifies that audit records capture the authenticated actor and that the history table belongs to the audit schema. + [Fact] + public async Task Non_soft_deletable_auditable_state_should_record_hard_delete() + { + await using ContextFixture fixture = await CreateContextAsync(); + var state = new SystemSetupState { Id = Guid.CreateVersion7().ToString(), IsComplete = false }; + fixture.Context.SystemSetup.Add(state); + await fixture.Context.SaveChangesAsync(TestContext.Current.CancellationToken); + fixture.Context.SystemSetup.Remove(state); + await fixture.Context.SaveChangesAsync(TestContext.Current.CancellationToken); + + EntityAuditRecord history = await fixture.Context.EntityAuditHistory.Where(x => x.EntityId == state.Id).OrderBy(x => x.UpdatedAt).LastAsync(TestContext.Current.CancellationToken); + history.Operation.Should().Be("Deleted"); + history.CurrentEntityState.Should().Contain(state.Id); + } + [Fact] public async Task Audit_history_should_record_authenticated_actor_and_schema() { @@ -68,7 +76,6 @@ public async Task Audit_history_should_record_authenticated_actor_and_schema() var user = new User("actor@example.com") { Email = "actor@example.com", EmailConfirmed = true }; fixture.Context.Users.Add(user); await fixture.Context.SaveChangesAsync(TestContext.Current.CancellationToken); - EntityAuditRecord history = await fixture.Context.EntityAuditHistory.SingleAsync(x => x.EntityId == user.Id, TestContext.Current.CancellationToken); history.UpdatedBy.Should().Be("actor-1"); var auditEntity = fixture.Context.Model.FindEntityType(typeof(EntityAuditRecord)); @@ -77,7 +84,6 @@ public async Task Audit_history_should_record_authenticated_actor_and_schema() auditEntity.GetTableName().Should().Be("EntityHistory"); } - /// Verifies that the audit actor resolver falls back from subject to email and then to the system actor. [Fact] public async Task Audit_actor_should_fallback_to_subject_email_and_system() { @@ -89,7 +95,6 @@ public async Task Audit_actor_should_fallback_to_subject_email_and_system() await fixture.Context.SaveChangesAsync(TestContext.Current.CancellationToken); (await fixture.Context.EntityAuditHistory.SingleAsync(x => x.EntityId == user.Id, TestContext.Current.CancellationToken)).UpdatedBy.Should().Be("subject-1"); } - var emailAccessor = new HttpContextAccessor { HttpContext = new DefaultHttpContext { User = new ClaimsPrincipal(new ClaimsIdentity([new Claim(ClaimTypes.Email, "actor@example.com")], "test")) } }; await using (ContextFixture fixture = await CreateContextAsync(emailAccessor)) { @@ -98,7 +103,6 @@ public async Task Audit_actor_should_fallback_to_subject_email_and_system() await fixture.Context.SaveChangesAsync(TestContext.Current.CancellationToken); (await fixture.Context.EntityAuditHistory.SingleAsync(x => x.EntityId == user.Id, TestContext.Current.CancellationToken)).UpdatedBy.Should().Be("actor@example.com"); } - await using (ContextFixture fixture = await CreateContextAsync()) { var user = new User("system@example.com") { Email = "system@example.com" }; @@ -108,7 +112,6 @@ public async Task Audit_actor_should_fallback_to_subject_email_and_system() } } - /// Verifies that user and role constructors assign non-empty identity identifiers. [Fact] public void User_and_role_constructors_should_initialize_identity_ids() {