extract committer sanitation

Author: gossi

src/changelog.ts

@@ -136,7 +136,7 @@ export default class Changelog {
       const shouldKeepCommiter = login && !this.ignoreCommitter(login);
 
       if (login && shouldKeepCommiter && !committers[login]) {
-        committers[login] = await this.github.getUserData(user);
+        committers[login] = this.sanitizeCommitter(await this.github.getUserData(user));
       }
     }
 
@@ -147,6 +147,15 @@ export default class Changelog {
     return this.config.ignoreCommitters.some((c: string) => c === login || login.indexOf(c) > -1);
   }
 
+  private sanitizeCommitter(contributor: GitHubContributor) {
+    // Response for Copilot is "Copilot SWE Agent" - but we prefer "Copilot"
+    if (contributor.login === "Copilot") {
+      contributor.name = "Copilot";
+    }
+
+    return contributor;
+  }
+
   private toCommitInfos(commits: Git.CommitListItem[]): CommitInfo[] {
     return commits.map(commit => {
       const { sha, refName, summary: message, date } = commit;

src/github-api.ts

@@ -65,19 +65,14 @@ export default class GithubAPI {
     let login = userInfo.login;
     let path = "users";
 
+    // github API itself does not tell if contributor is an app. Best guess was to
+    // check the `html_url` for the `/apps/` segment
     if (userInfo.html_url && userInfo.html_url.includes("/apps/")) {
       path = "apps";
       login = userInfo.html_url.split("/").pop() as string;
     }
     const prefix = process.env.GITHUB_API_URL || `https://api.${this.github}`;
-    const data = await this._fetch(`${prefix}/${path}/${login}`);
-
-    if (login === "Copilot") {
-      // Response for Copilot is "Copilot SWE Agent" - but we prefer "Copilot"
-      data.name = "Copilot";
-    }
-
-    return data;
+    return await this._fetch(`${prefix}/${path}/${login}`);
   }
 
   private async _fetch(url: string): Promise<any> {