refactor(lightspeed): define OKP resources in flavour YAML [RHIDP-16103]

Move the OKP (Offline Knowledge Portal) Deployment, Service, and Route
out of imperative Go construction in internal/controller/okp.go and into
the lightspeed flavour as YAML manifests, so OKP is described like every
other flavour resource and its image string rides in the bundle
ConfigMap (visible to midstream image pinning). Addresses PR #3370
review comment: "should OKP be in the flavour YAML rather than Go?".

Each OKP object is a separately registered model key (OkpDeploymentKey,
OkpServiceKey, OkpRouteKey) with its own MergeFunc, and stays gated to
OpenShift in addToModel. Flavour gating is implicit (files live only in
flavours/lightspeed/). The runtime behavior is unchanged: same objects,
same OpenShift-only gating, same OKP_SERVICE_URL injection into the
lightspeed-core sidecar before apply (no dual ReplicaSet).

Remove applyOkpResources; OKP now flows through the normal
applyObjects(GetRuntimeObjects()) SSA path. Keep prepareOkpEnvVar and
prepareOkpConfig as controller wiring. Regenerate bundle manifests and
dist/rhdh/install.yaml.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: maysunfaisal

bundle/rhdh/manifests/rhdh-flavour-lightspeed-config_v1_configmap.yaml

@@ -0,0 +1,47 @@
+# OKP (Offline Knowledge Portal) standalone Deployment.
+# name/labels/selector are set by the operator at runtime (per Backstage CR); the values
+# below are placeholders. The image ref is intentionally declared here (not in Go source)
+# so midstream digest-pinning can resolve it in the generated bundle ConfigMap.
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+  name: lightspeed-okp
+spec:
+  replicas: 1
+  selector:
+    matchLabels:
+      app.kubernetes.io/name: lightspeed-okp
+  template:
+    metadata:
+      labels:
+        app.kubernetes.io/name: lightspeed-okp
+    spec:
+      containers:
+        - name: okp
+          image: registry.redhat.io/offline-knowledge-portal/rhokp-rhel9:1.2.10-1786628394
+          imagePullPolicy: IfNotPresent
+          ports:
+            - name: httpd
+              containerPort: 8080
+              protocol: TCP
+            - name: solr
+              containerPort: 8983
+              protocol: TCP
+          env:
+            - name: SOLR_JAVA_MEM
+              value: "-Xms1g -Xmx1g"
+            - name: SOLR_HOST_BIND
+              value: "0.0.0.0"
+            - name: HTTPD_SERVER_NAME
+              value: "localhost"
+            - name: HTTPD_COMPRESSED
+              value: "true"
+            - name: HTTPD_ENCRYPT
+              value: "false"
+          resources:
+            requests:
+              cpu: 200m
+              memory: 2Gi
+            limits:
+              cpu: "2"
+              memory: 4Gi

config/profile/rhdh/default-config/flavours/lightspeed/okp-deployment.yaml

@@ -0,0 +1,16 @@
+# OKP (Offline Knowledge Portal) standalone OpenShift Route.
+# name/labels and spec.to.name are set by the operator at runtime (per Backstage CR).
+# Applied on OpenShift only.
+apiVersion: route.openshift.io/v1
+kind: Route
+metadata:
+  name: lightspeed-okp
+spec:
+  to:
+    kind: Service
+    name: lightspeed-okp
+  port:
+    targetPort: httpd
+  tls:
+    termination: edge
+    insecureEdgeTerminationPolicy: Allow

config/profile/rhdh/default-config/flavours/lightspeed/okp-route.yaml

@@ -0,0 +1,19 @@
+# OKP (Offline Knowledge Portal) standalone ClusterIP Service.
+# name/labels/selector are set by the operator at runtime (per Backstage CR).
+apiVersion: v1
+kind: Service
+metadata:
+  name: lightspeed-okp
+spec:
+  type: ClusterIP
+  selector:
+    app.kubernetes.io/name: lightspeed-okp
+  ports:
+    - name: httpd
+      port: 8080
+      targetPort: httpd
+      protocol: TCP
+    - name: solr
+      port: 8983
+      targetPort: solr
+      protocol: TCP

config/profile/rhdh/default-config/flavours/lightspeed/okp-service.yaml

@@ -53,6 +53,9 @@ configMapGenerator:
   - default-config/flavours/lightspeed/configmap-files.yaml
   - default-config/flavours/lightspeed/deployment.yaml
   - default-config/flavours/lightspeed/dynamic-plugins.yaml
+  - default-config/flavours/lightspeed/okp-deployment.yaml
+  - default-config/flavours/lightspeed/okp-service.yaml
+  - default-config/flavours/lightspeed/okp-route.yaml
   name: flavour-lightspeed-config
 - files:
   - default-config/flavours/orchestrator/metadata.yaml

config/profile/rhdh/kustomization.yaml

@@ -115,17 +115,13 @@ func (r *BackstageReconciler) Reconcile(ctx context.Context, req ctrl.Request) (
 	// Inject OKP_SERVICE_URL into lightspeed-core before applying objects
 	r.prepareOkpEnvVar(&backstage, bsModel)
 
-	// Apply the runtime objects
+	// Apply the runtime objects (OKP Deployment/Service/Route are part of the model,
+	// sourced from the lightspeed flavour YAML and gated to OpenShift in pkg/model/okp-*.go)
 	err = r.applyObjects(ctx, bsModel.GetRuntimeObjects())
 	if err != nil {
 		return ctrl.Result{}, errorAndStatus(&backstage, "failed to apply backstage objects", err)
 	}
 
-	// Apply OKP resources if lightspeed flavour is enabled
-	if err := r.applyOkpResources(ctx, &backstage, bsModel); err != nil {
-		return ctrl.Result{}, errorAndStatus(&backstage, "failed to apply OKP resources", err)
-	}
-
 	r.setDeploymentStatus(ctx, &backstage, *bsModel)
 	return ctrl.Result{}, nil
 }