how to work with IntersectionType?

[norak]

I'm trying to write a rector set for my project to migrate from laravel/collective to spatie/html
currently my refactored code looks like this

- <?php echo \Collective\Html\FormFacade::button('<i class="fa fa-fw fa-close" aria-hidden="true"></i> ' . trans('LaravelLogger::laravel-logger.modals.shared.btnCancel'), array('class' => 'btn btn-outline pull-left btn-flat', 'type' => 'button', 'data-dismiss' => 'modal' )) ?>
- <?php echo \Collective\Html\FormFacade::button('<i class="fa ' . $actionBtnIcon . '" aria-hidden="true"></i> ' . $btnSubmitText, array('class' => 'btn btn-' . $modalClass . ' pull-right btn-flat', 'type' => 'button', 'id' => 'confirm' )) ?>
+ <?php echo html()->button('<i class="fa fa-fw fa-close" aria-hidden="true"></i> ' . trans('LaravelLogger::laravel-logger.modals.shared.btnCancel'))->class(['btn', 'btn-outline', 'pull-left', 'btn-flat'])->type(['button']) ?>
+ <?php echo html()->button('<i class="fa ' . $actionBtnIcon . '" aria-hidden="true"></i> ' . $btnSubmitText)->type(['button']) ?>

im stuck at this line of code

array('class' => 'btn btn-' . $modalClass . ' pull-right btn-flat')

i dont know what to do this variable in "class"

foreach ($node->args as $arg_key => $arg){
  if (!$arg instanceof Arg) {
   continue;
  }
$argValue = $this->valueResolver->getValue($arg->value); // return nothing

im writing my own ValueResolver to process this line, here is where am i

public function extractConstantArrayTypeValue(ConstantArrayType $constantArrayType) : ?array
{
$keys = [];
foreach ($constantArrayType->getKeyTypes() as $i => $keyType) {
	$keys[$i] = $keyType->getValue();
}
$values = [];
foreach ($constantArrayType->getValueTypes() as $i => $valueType) {
	if ($valueType instanceof ConstantArrayType) {
		$value = $this->extractConstantArrayTypeValue($valueType);
	} elseif ($valueType instanceof ConstantScalarType) {
		$value = $valueType->getValue();
	} elseif (ClassNameFromObjectTypeResolver::resolve($valueType) !== null) {
		continue;
	} elseif ($valueType instanceof IntersectionType) { 
        //array('class' => 'btn btn-' . $modalClass . ' pull-right btn-flat')	
		foreach ($valueType->getTypes() as $j => $subType) {
			if ($subType instanceof AccessoryNonFalsyStringType) {
                //i dont know how to resolve this
				continue;
			}
			$value = $subType->getValue(); 
            // Call to undefined method PHPStan\Type\StringType::getValue()
		}
	} else {
		return null;
	}
	$values[$keys[$i]] = $value;
}
return $values;
}

what should i do to make this

'class' => 'btn btn-' . $modalClass . ' pull-right btn-flat'

into this

->class(['btn', 'btn-'. $modalClass, 'pull-right', 'btn-flat'])

Any help will be great

[TomasVotruba]

Hi, could you share your minimal PHP input code via AST viewer? https://getrector.com/ast

Ideally just single item, short as single line if possible.

I'll look into it.

[norak]

https://getrector.com/ast/76e48fa307ccf76912f7560abfa508821304cebe
in ast it looks like regular concat but in code it resolves as IntersectionType somehow

[TomasVotruba]

No, to make the change happen the other values are not needed.

[norak]

how do i split first string when i cant get it?
FormButtonToSpatieRector.php

public function refactor(Node $node) : ?Node
{
if($node instanceof StaticCall) {
if ($node->getAttribute(AttributeKey::IS_FUNCCALL_NAME) === \true) {
	return null;
}
if (!$node->class instanceof Name) {
	return \false;
}
$staticCallClassName = $node->class->toString();
if ($staticCallClassName !== 'Collective\Html\FormFacade') {
	return \false;
}
if (!$node->name instanceof Identifier) {
	return \false;
}
$staticCallMethodName = $node->name->toString();
if($staticCallMethodName === 'button'){
	$new_function = new FuncCall(new Name('html'));

	foreach ($node->args as $arg_key => $arg){
		if (!$arg instanceof Arg) {
			continue;
		}
		// '<i class="fa ' . $actionBtnIcon . '" aria-hidden="true"></i> ' . $btnSubmitText, 
		// array('class' => 'btn btn-' . $modalClass . ' pull-right btn-flat', 'type' => 'button', 'id' => 'confirm' )
		$argValue = $this->valueResolver->getValue($arg->value); it does not return 'class'

		if($arg_key === 0){//all ok
			$btn_args = [];
			if($argValue instanceof Concat)
				$btn_args[] = new Arg($argValue);
			else
				$btn_args[] = new Arg(new String_($argValue));
			$new_function = new MethodCall($new_function, 'button', $btn_args);
		}

//if($arg_key === 1) var_dump($argValue); //array(2) {
//["type"]=> string(6) "button"
//["id"]=> string(7) "confirm"
//$this->valueResolver->getValue($arg->value) does not return 'class' item
		if($arg_key === 1){// all ok except class
			if(is_array($argValue)){
				foreach ($argValue as $arg_key => $arg_value){
					if(in_array($arg_key, ['class', 'type', 'id'])){
						$new_function = $this->add_new_method_call($new_function, $arg_key, $arg_value);
					}
				}
			}
		}
	}
	return $new_function;
}
}
return null;
}
function add_new_method_call($new_function, $arg_key, $arg_value)
{
$class_args = [];
$class_items = new Array_();
foreach (explode(' ', $arg_value) as $class_item){
if($class_item instanceof Concat)
	$class_items->items[] = new ArrayItem($class_item);
else
	$class_items->items[] = new ArrayItem(new String_($class_item));
}
$class_args[] = new Arg($class_items);

return new MethodCall($new_function, $arg_key, $class_args);
}

so i dive into Rector\PhpParser\Node\Value\ValueResolver

public function getValue($expr, bool $resolvedClassReference = \false){
if ($expr instanceof Arg) {
	$expr = $expr->value;
}
if ($expr instanceof Concat) {
	return $this->processConcat($expr, $resolvedClassReference);
}
if ($expr instanceof ClassConstFetch && $resolvedClassReference) {
	$class = $this->nodeNameResolver->getName($expr->class);
	if (\in_array($class, [ObjectReference::SELF, ObjectReference::STATIC], \true)) {
		$classReflection = $this->reflectionResolver->resolveClassReflection($expr);
		if ($classReflection instanceof ClassReflection) {
			return $classReflection->getName();
		}
	}
	if ($this->nodeNameResolver->isName($expr->name, 'class')) {
		return $class;
	}
}
$value = $this->resolveExprValueForConst($expr);
if ($value !== null) {
	return $value;
}
if ($expr instanceof ConstFetch) {
	return $this->nodeNameResolver->getName($expr);
}
$nodeStaticType = $this->nodeTypeResolver->getType($expr);
return $this->resolveConstantType($nodeStaticType); //it goes here then to extractConstantArrayTypeValue
}

public function extractConstantArrayTypeValue(ConstantArrayType $constantArrayType) : ?array
{
	$keys = [];
	foreach ($constantArrayType->getKeyTypes() as $i => $keyType) {
		$keys[$i] = $keyType->getValue();
	}
	var_dump($keys);
	/*array(3) {
	  [0]=>string(5) "class"
	  [1]=>string(4) "type"
	  [2]=>string(2) "id"
	}*/
	$values = [];
	
//		var_dump($constantArrayType);
/*["valueTypes":"PHPStan\Type\Constant\ConstantArrayType":private]=>
array(3) {
[0]=>object(PHPStan\Type\IntersectionType)#10433 (2) {
  ["types":"PHPStan\Type\IntersectionType":private]=>
  array(2) {
	[0]=>object(PHPStan\Type\Accessory\AccessoryNonFalsyStringType)#10431 (0) {}
	[1]=>object(PHPStan\Type\StringType)#10428 (0) {}
  }
  ["sortedTypes":"PHPStan\Type\IntersectionType":private]=>bool(false)
}
[1]=>object(PHPStan\Type\Constant\ConstantStringType)#10436 (4) {
  ["value":"PHPStan\Type\Constant\ConstantStringType":private]=>string(6) "button"
  ["isClassString":"PHPStan\Type\Constant\ConstantStringType":private]=>bool(false)
  ["objectType":"PHPStan\Type\Constant\ConstantStringType":private]=>NULL
  ["arrayKeyType":"PHPStan\Type\Constant\ConstantStringType":private]=>NULL
}
[2]=>object(PHPStan\Type\Constant\ConstantStringType)#10430 (4) {
  ["value":"PHPStan\Type\Constant\ConstantStringType":private]=>string(7) "confirm"
  ["isClassString":"PHPStan\Type\Constant\ConstantStringType":private]=>bool(false)
  ["objectType":"PHPStan\Type\Constant\ConstantStringType":private]=>NULL
  ["arrayKeyType":"PHPStan\Type\Constant\ConstantStringType":private]=>NULL}}*/
  
	foreach ($constantArrayType->getValueTypes() as $i => $valueType) {
		if ($valueType instanceof ConstantArrayType) { //nope
			$value = $this->extractConstantArrayTypeValue($valueType);
		} elseif ($valueType instanceof ConstantScalarType) { //nope
			$value = $valueType->getValue();
		} elseif (ClassNameFromObjectTypeResolver::resolve($valueType) !== null) { //nope
			continue;
		} elseif ($valueType instanceof IntersectionType) { // yes!!!
//	var_dump($valueType->getTypes());
/* array(2) {
[0]=>object(PHPStan\Type\Accessory\AccessoryNonFalsyStringType)#10431 (0) {}
[1]=>object(PHPStan\Type\StringType)#10428 (0) {}}*/
/////////
//what should i do here to get my array back?
/////////
		} else {
			return null;
		}
		$values[$keys[$i]] = $value;
	}
	return $values;
}

[TomasVotruba]

Value resolver is useful to extract dynamic unexpected data.
Here I'd use NodeFinder to find first String_ and get its value via $string->value

[norak]

<?php echo html()->button('<i class="fa ' . $actionBtnIcon . '" aria-hidden="true"></i> ' . $btnSubmitText)->type(['button'])->id(['confirm'])->class(['btn', 'btn-' . $modalClass, 'pull-right', 'btn-flat']) ?>
ok. this worked for me
first i found array, then used transformConcatToStringArray

$array = $this->nodeFinder->findFirstInstanceOf($node, Array_::class);
$class_args = [];
$class_items = new Array_();
foreach ($array->items as $arrayItem) {
	$arr_key_name = $arrayItem->key->value;
	if($arrayItem->value instanceof Concat){
		$class_array = $this->NodeTransformer->transformConcatToStringArray($arrayItem->value);
		foreach ($class_array->items as $key_row => $row){
			if($row->value instanceof Variable)
				continue;
			if(count($class_array->items) > $key_row && $class_array->items[$key_row+1]->value instanceof Variable){
				$class_items->items[] = new ArrayItem(new Concat($row->value, $class_array->items[$key_row+1]->value));
				continue;
			}
			$class_items->items[] = new ArrayItem($row->value);
		}
		$class_args[] = new Arg($class_items);
		$new_function = new MethodCall($new_function, $arr_key_name, $class_args);
	}
}

finaly done