Max Type Coverage Level using withTypeCoverageLevel method

[vinceAmstoutz]

What is the maximum value of the level parameter of withTypeCoverageLevel(), please? I haven't found anything about this in the documentation or source code ?

[samsonasik]

You can use PHP_INT_MAX i guess :)

[TomasVotruba]

Levels are temporary approach to get your project in shape gradually, without much pressure .
Once you're done, they should be replaced by full set 👍

[vinceAmstoutz]

yes, start with level 0, iterate, on full confident, use full typeDeclarations set

Confident after trying 9223372036854775807 levels (PHP_INT_MAX) ? 😅

[TomasVotruba]

If you're int max, you're already finished 😁

[vinceAmstoutz]

@TomasVotruba @samsonasik To sum up, withTypeCoverageLevel is based on rules for types starting at level 0 and ending at PHP_INT_MAX. That's a lot of levels, isn't it? Has it been designed to run in a loop using a shell script or similar, or else to increment the level in large steps ( 10 , 500 , 1000... )?

In fact, I don't really understand how best to use it to cover the types on a project from A to Z.

[TomasVotruba]

This might help: https://getrector.com/documentation/levels#content-one-level-at-a-time

1 level = 1 rule. Depending on codebase size and complexity, you can jump 1 or 5 or 10 steps at a time. We do 1 level/rule at at time, because legacy projects we work with are really huge.

If you clik on withTypeCoverageLevel() method, the IDE will lead you to TypeDeclarationLevel::RULES where all the rules are listed: https://github.com/rectorphp/rector-src/blob/abaf47c828502d09a968590292aafe71d34e3e17/src/Config/Level/TypeDeclarationLevel.php#L66-L136

Right now there is ~70-80 rules, so max level is the same number.

That's the whole magic :)

[TomasVotruba]

This will help with to understand too high level :) rectorphp/rector-src#6735