Code Modernizing / Config, does not behave as expected

[ItsReddi]

Assuming the following config:

->withPhpSets(
        //Max Optimized PHP Version, with all new features/optimizations enabled, but limited to withPhpVersion features
        php84: true 
    )
    //Max PHP Verision we want to be compatible with, rector will not use any features above this version
    ->withPhpVersion(PhpVersion::PHP_81);

I would expect:
https://github.com/rectorphp/rector/blob/main/rules/Php84/Rector/Param/ExplicitNullableParamTypeRector.php
is running, since it is not a PHP 8.4 syntax and would work on PHP 8.1.

Do i misunderstand the configurations? (see comments)

Thank you

[samsonasik]

For that, it is better to you need to use php 8.4 runtime, otherwise, it may cause unexpected error, eg on required after optional, see https://3v4l.org/5jms6, without nullable, it is working https://3v4l.org/4O5MK, that's why upgrade php step by step is better, to ensure per-feature applied correctly in order.

But if you want it so hard, you can do something like:

<?php

return \Rector\Config\RectorConfig::configure()
    ->withPaths([__DIR__ . '/src'])
    ->withPhpSets(php83: true)
    ->withPhpVersion(\Rector\ValueObject\PhpVersion::PHP_84)
    ->withRules([
         \Rector\Php84\Rector\Param\ExplicitNullableParamTypeRector::class,
    ]);

with the risk is on yours, see answer at issue #8761 (comment)

[samsonasik]

Yes, but on php 8.0, we have rule for it https://getrector.com/rule-detail/optional-parameters-after-required-rector

While nullable param exists since php 7.1, the upgrading should be by order, otherwise, it will got that error too early, that's why it is better to upgrade version by version, and verify, so you have safe result.

[ItsReddi]

Thank you for your patience.

To clarify, I am fine with this specific rule not being executed, but I still don't understand why. I'm already using PHP 8.1, so the 8.0 rules should work, and the 8.4 rules should be executed safely. Since I don't fully grasp this, I am unsure of the correct settings.

My goals:

• Code must be compatible with PHP 8.1
• I want to modernize the code to address deprecations and breaking changes in PHP 8.2, 8.3, and 8.4, which can already be fixed in PHP 8.1.

Here's my configuration:

->withPhpSets(php84: true)
->withPhpVersion(PhpVersion::PHP_81);

Or should it be:

->withPhpSets(php81: true)
->withPhpVersion(PhpVersion::PHP_84);

[samsonasik]

You can do:

->withPhpSets(php81: true)
->withPhpVersion(PhpVersion::PHP_84)
->withRules([
         \Rector\Php84\Rector\Param\ExplicitNullableParamTypeRector::class,
    ]);

[ItsReddi]

Thanks.

After experimenting with a deprecation from PHP 8.2, I realized I might have misunderstood how the tool works. It looks like I need to explicitly set the rules that can be applied. If i want to early address depreciations and breaking changes.
Correct?

I initially assumed that:

->withPhpSets(php84: true)
->withPhpVersion(PhpVersion::PHP_81);

would work automatically like this:

->withPhpSets(php81: true)
->withPhpVersion(PhpVersion::PHP_84)
->withRules([
    ExplicitNullableParamTypeRector::class,
    VariableInStringInterpolationFixerRector::class,
    // other deprecations fixable in 8.1
]);

But that assumption seems entirely incorrect, right?

[samsonasik]

withPhpSets() is collecting rules up until defined, while withPhpVersion enforce php version, only when php version and rules match, it will be executed, see provideMinPhpversion() method:

https://github.com/rectorphp/rector-src/blob/71fb2e4c9346bf6ce6b057ff3d77511662f7913c/rules/Php84/Rector/Param/ExplicitNullableParamTypeRector.php#L103-L106