From f51eb72ff91eeca286a9016eaf4fb8e28f8259f0 Mon Sep 17 00:00:00 2001 From: Christoph Purrer Date: Fri, 30 Oct 2026 12:24:43 -0700 Subject: [PATCH] Delete stub RCTAppSetupDefaultJsExecutorFactory (#59435) Summary: The default JS executor factory unconditionally returns `nullptr` and has no callers. Delete it with its now-unused imports and forward declarations, narrowing the header to forward declarations. Changelog: [Internal] Reviewed By: andrewdacenko Differential Revision: D127294774 --- .../Libraries/AppDelegate/RCTAppSetupUtils.h | 17 +++-------------- .../Libraries/AppDelegate/RCTAppSetupUtils.mm | 12 ------------ .../RCTDefaultReactNativeFactoryDelegate.mm | 4 ++++ 3 files changed, 7 insertions(+), 26 deletions(-) diff --git a/packages/react-native/Libraries/AppDelegate/RCTAppSetupUtils.h b/packages/react-native/Libraries/AppDelegate/RCTAppSetupUtils.h index ca6ff6cc0807..d6144bffb56e 100644 --- a/packages/react-native/Libraries/AppDelegate/RCTAppSetupUtils.h +++ b/packages/react-native/Libraries/AppDelegate/RCTAppSetupUtils.h @@ -6,22 +6,16 @@ */ #import -#import -#import -#ifdef __cplusplus +@class RCTBridge; +@class RCTRootView; -#import +#ifdef __cplusplus #import @protocol RCTDependencyProvider; -// Forward declaration to decrease compilation coupling -namespace facebook::react { -class JSExecutorFactory; -class RuntimeScheduler; -} // namespace facebook::react RCT_EXTERN NSArray *RCTAppSetupUnstableModulesRequiringMainQueueSetup( id dependencyProvider); @@ -29,9 +23,4 @@ RCT_EXTERN id RCTAppSetupDefaultModuleFromClass( Class moduleClass, id dependencyProvider); -std::unique_ptr RCTAppSetupDefaultJsExecutorFactory( - RCTBridge *bridge, - RCTTurboModuleManager *turboModuleManager, - const std::shared_ptr &runtimeScheduler); - #endif // __cplusplus diff --git a/packages/react-native/Libraries/AppDelegate/RCTAppSetupUtils.mm b/packages/react-native/Libraries/AppDelegate/RCTAppSetupUtils.mm index d5aabd85ea1c..513d8ab39680 100644 --- a/packages/react-native/Libraries/AppDelegate/RCTAppSetupUtils.mm +++ b/packages/react-native/Libraries/AppDelegate/RCTAppSetupUtils.mm @@ -7,10 +7,6 @@ #import "RCTAppSetupUtils.h" -#import -#import -#import - // Turbo Module #import #import @@ -92,11 +88,3 @@ // No custom initializer here. return [moduleClass new]; } - -std::unique_ptr RCTAppSetupDefaultJsExecutorFactory( - RCTBridge *bridge, - RCTTurboModuleManager *turboModuleManager, - const std::shared_ptr &runtimeScheduler) -{ - return nullptr; -} diff --git a/packages/react-native/Libraries/AppDelegate/RCTDefaultReactNativeFactoryDelegate.mm b/packages/react-native/Libraries/AppDelegate/RCTDefaultReactNativeFactoryDelegate.mm index e72ceced8275..56a438aa7e6c 100644 --- a/packages/react-native/Libraries/AppDelegate/RCTDefaultReactNativeFactoryDelegate.mm +++ b/packages/react-native/Libraries/AppDelegate/RCTDefaultReactNativeFactoryDelegate.mm @@ -6,6 +6,7 @@ */ #import "RCTDefaultReactNativeFactoryDelegate.h" +#import #import #import "RCTAppSetupUtils.h" #import "RCTDependencyProvider.h" @@ -47,10 +48,13 @@ - (JSRuntimeFactoryRef)createJSRuntimeFactory #endif } +#pragma clang diagnostic push +#pragma clang diagnostic ignored "-Wdeprecated-declarations" - (void)customizeRootView:(RCTRootView *)rootView { // Override point for customization after application launch. } +#pragma clang diagnostic pop - (RCTColorSpace)defaultColorSpace {