Skip to content

Commit d0fb338

Browse files
j-piaseckifacebook-github-bot
authored andcommitted
Check value of the Hermes V1 flag instead of whether it's defined (#53637)
Summary: Pull Request resolved: #53637 Changelog: [ANDROID][FIXED] - Check for the value of the HERMES_V1_ENABLED flag instead of whether it's defined Reviewed By: cortinico Differential Revision: D81920483 fbshipit-source-id: 550ae9fd27f666affe102b1c5c3f51bde7b5923e
1 parent 2152180 commit d0fb338

7 files changed

Lines changed: 7 additions & 7 deletions

File tree

packages/react-native/ReactAndroid/src/main/jni/react/hermes/reactexecutor/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ target_compile_reactnative_options(hermes_executor PRIVATE)
2828
if(${CMAKE_BUILD_TYPE} MATCHES Debug OR REACT_NATIVE_DEBUG_OPTIMIZED)
2929
target_compile_options(hermes_executor PRIVATE -DHERMES_ENABLE_DEBUGGER=1)
3030

31-
if (DEFINED HERMES_V1_ENABLED)
31+
if (HERMES_V1_ENABLED)
3232
target_compile_options(hermes_executor PRIVATE -DHERMES_V1_ENABLED=1)
3333
endif()
3434
endif()

packages/react-native/ReactAndroid/src/main/jni/react/runtime/hermes/jni/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ target_compile_reactnative_options(hermesinstancejni PRIVATE)
3030
if(${CMAKE_BUILD_TYPE} MATCHES Debug OR REACT_NATIVE_DEBUG_OPTIMIZED)
3131
target_compile_options(hermesinstancejni PRIVATE -DHERMES_ENABLE_DEBUGGER=1)
3232

33-
if (DEFINED HERMES_V1_ENABLED)
33+
if (HERMES_V1_ENABLED)
3434
target_compile_options(hermesinstancejni PRIVATE -DHERMES_V1_ENABLED=1)
3535
endif()
3636
endif ()

packages/react-native/ReactAndroid/src/main/jni/react/runtime/jni/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ target_compile_reactnative_options(rninstance PRIVATE)
2020
if(${CMAKE_BUILD_TYPE} MATCHES Debug OR REACT_NATIVE_DEBUG_OPTIMIZED)
2121
target_compile_options(rninstance PRIVATE -DHERMES_ENABLE_DEBUGGER=1)
2222

23-
if (DEFINED HERMES_V1_ENABLED)
23+
if (HERMES_V1_ENABLED)
2424
target_compile_options(rninstance PRIVATE -DHERMES_V1_ENABLED=1)
2525
endif()
2626
endif ()

packages/react-native/ReactCommon/hermes/executor/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ if(${CMAKE_BUILD_TYPE} MATCHES Debug OR REACT_NATIVE_DEBUG_OPTIMIZED)
3333
-DHERMES_ENABLE_DEBUGGER=1
3434
)
3535

36-
if (DEFINED HERMES_V1_ENABLED)
36+
if (HERMES_V1_ENABLED)
3737
target_compile_options(hermes_executor_common PRIVATE -DHERMES_V1_ENABLED=1)
3838
endif()
3939
else()

packages/react-native/ReactCommon/hermes/inspector-modern/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ if(${CMAKE_BUILD_TYPE} MATCHES Debug OR REACT_NATIVE_DEBUG_OPTIMIZED)
2424
-DHERMES_ENABLE_DEBUGGER=1
2525
)
2626

27-
if (DEFINED HERMES_V1_ENABLED)
27+
if (HERMES_V1_ENABLED)
2828
target_compile_options(hermes_inspector_modern PRIVATE -DHERMES_V1_ENABLED=1)
2929
endif()
3030
endif()

packages/react-native/ReactCommon/react/runtime/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ target_compile_reactnative_options(bridgeless PRIVATE)
1919
if(${CMAKE_BUILD_TYPE} MATCHES Debug OR REACT_NATIVE_DEBUG_OPTIMIZED)
2020
target_compile_options(bridgeless PRIVATE -DHERMES_ENABLE_DEBUGGER=1)
2121

22-
if (DEFINED HERMES_V1_ENABLED)
22+
if (HERMES_V1_ENABLED)
2323
target_compile_options(bridgeless PRIVATE -DHERMES_V1_ENABLED=1)
2424
endif()
2525
endif ()

packages/react-native/ReactCommon/react/runtime/hermes/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ if(${CMAKE_BUILD_TYPE} MATCHES Debug OR REACT_NATIVE_DEBUG_OPTIMIZED)
3636
-DHERMES_ENABLE_DEBUGGER=1
3737
)
3838

39-
if (DEFINED HERMES_V1_ENABLED)
39+
if (HERMES_V1_ENABLED)
4040
target_compile_options(bridgelesshermes PRIVATE -DHERMES_V1_ENABLED=1)
4141
endif()
4242
endif()

0 commit comments

Comments
 (0)