Skip to content

Commit 9971172

Browse files
chrfalchclaude
andcommitted
CI: rename the artifact step in the SwiftPM workflows
"Prime SwiftPM artifacts" borrowed jargon from a local test harness and made the step look bespoke. It is the ordinary `spm download`, pointed at the XCFrameworks the prebuild jobs just produced instead of the published nightly. Name it after what it does and say so in the comment. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent 853bcd7 commit 9971172

3 files changed

Lines changed: 27 additions & 18 deletions

File tree

.github/workflows/test-ios-spm-helloworld.yml

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -62,12 +62,15 @@ jobs:
6262
with:
6363
name: ReactNativeDependenciesRelease.xcframework.tar.gz
6464
path: /tmp/deps-release
65-
# `spm download` primes both flavor slots per call and skips any slot that
66-
# already validates, so prime in two passes: the first fills both slots
67-
# with the Release bits, then debug/ is dropped and re-primed from the
68-
# Debug tarballs while release/ validates and is left alone. hermes-engine
69-
# is fetched from Maven by the command itself.
70-
- name: Prime SwiftPM artifacts (Debug + Release)
65+
# The ordinary `spm download`, pointed at the XCFrameworks this run just
66+
# built rather than at the published nightly (RN_CORE_TARBALL_PATH /
67+
# RN_DEPS_TARBALL_PATH are overrides download-spm-artifacts.js already
68+
# supports). It fills both flavor slots per call and skips any slot that
69+
# already validates, so it runs twice: the first pass fills both slots
70+
# from the Release tarballs, then debug/ is dropped and refilled from the
71+
# Debug tarballs while release/ is left alone. hermes-engine is fetched
72+
# from Maven by the command itself.
73+
- name: Download XCFrameworks built in this run (Debug + Release)
7174
shell: bash
7275
working-directory: ${{ env.APP_IOS_DIR }}
7376
run: |

.github/workflows/test-ios-spm-newapp.yml

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -73,12 +73,15 @@ jobs:
7373
- name: Prepare the HelloWorld application
7474
shell: bash
7575
run: node ./scripts/e2e/init-project-e2e.js --useHelloWorld --pathToLocalReactNative "/tmp/react-native-tmp/$(cat /tmp/react-native-tmp/react-native-package-version)"
76-
# `spm download` primes both flavor slots per call and skips any slot that
77-
# already validates, so prime in two passes: the first fills both slots
78-
# with the Release bits, then debug/ is dropped and re-primed from the
79-
# Debug tarballs while release/ validates and is left alone. hermes-engine
80-
# is fetched from Maven by the command itself.
81-
- name: Prime SwiftPM artifacts (Debug + Release)
76+
# The ordinary `spm download`, pointed at the XCFrameworks this run just
77+
# built rather than at the published nightly (RN_CORE_TARBALL_PATH /
78+
# RN_DEPS_TARBALL_PATH are overrides download-spm-artifacts.js already
79+
# supports). It fills both flavor slots per call and skips any slot that
80+
# already validates, so it runs twice: the first pass fills both slots
81+
# from the Release tarballs, then debug/ is dropped and refilled from the
82+
# Debug tarballs while release/ is left alone. hermes-engine is fetched
83+
# from Maven by the command itself.
84+
- name: Download XCFrameworks built in this run (Debug + Release)
8285
shell: bash
8386
working-directory: ${{ env.APP_IOS_DIR }}
8487
run: |

.github/workflows/test-ios-spm-rntester.yml

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -62,12 +62,15 @@ jobs:
6262
with:
6363
name: ReactNativeDependenciesRelease.xcframework.tar.gz
6464
path: /tmp/deps-release
65-
# `spm download` primes both flavor slots per call and skips any slot that
66-
# already validates, so prime in two passes: the first fills both slots
67-
# with the Release bits, then debug/ is dropped and re-primed from the
68-
# Debug tarballs while release/ validates and is left alone. hermes-engine
69-
# is fetched from Maven by the command itself.
70-
- name: Prime SwiftPM artifacts (Debug + Release)
65+
# The ordinary `spm download`, pointed at the XCFrameworks this run just
66+
# built rather than at the published nightly (RN_CORE_TARBALL_PATH /
67+
# RN_DEPS_TARBALL_PATH are overrides download-spm-artifacts.js already
68+
# supports). It fills both flavor slots per call and skips any slot that
69+
# already validates, so it runs twice: the first pass fills both slots
70+
# from the Release tarballs, then debug/ is dropped and refilled from the
71+
# Debug tarballs while release/ is left alone. hermes-engine is fetched
72+
# from Maven by the command itself.
73+
- name: Download XCFrameworks built in this run (Debug + Release)
7174
shell: bash
7275
working-directory: ${{ env.APP_IOS_DIR }}
7376
run: |

0 commit comments

Comments
 (0)