Skip to content

Commit 6ce2a66

Browse files
Bridgeless-context ReactTextInputPropertyTest (#59252)
Summary: Replace the deprecated `BridgeReactContext` + mock `CatalystInstance` setup with `createTestReactApplicationContext` and pass the application directly as the themed base. Add the `ShadowSoLoader` Robolectric shadow the bridgeless helper needs. Changelog: [Internal] Differential Revision: D126543755
1 parent a340eec commit 6ce2a66

1 file changed

Lines changed: 9 additions & 13 deletions

File tree

‎packages/react-native/ReactAndroid/src/test/java/com/facebook/react/views/textinput/ReactTextInputPropertyTest.kt‎

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,6 @@
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8-
// TODO T207169925: Migrate CatalystInstance to Reacthost and remove the Suppress("DEPRECATION")
9-
// annotation
10-
@file:Suppress("DEPRECATION")
11-
128
package com.facebook.react.views.textinput
139

1410
import android.graphics.Color
@@ -27,10 +23,9 @@ import android.view.inputmethod.EditorInfo
2723
import androidx.annotation.RequiresApi
2824
import androidx.autofill.HintConstants
2925
import androidx.core.content.res.ResourcesCompat.ID_NULL
30-
import com.facebook.react.bridge.BridgeReactContext
31-
import com.facebook.react.bridge.CatalystInstance
3226
import com.facebook.react.bridge.JavaOnlyMap
33-
import com.facebook.react.bridge.ReactTestHelper.createMockCatalystInstance
27+
import com.facebook.react.bridge.ReactApplicationContext
28+
import com.facebook.react.bridge.ReactTestHelper.createTestReactApplicationContext
3429
import com.facebook.react.internal.featureflags.ReactNativeFeatureFlagsForTests
3530
import com.facebook.react.uimanager.BackgroundStyleApplicator
3631
import com.facebook.react.uimanager.DisplayMetricsHolder
@@ -42,19 +37,21 @@ import com.facebook.react.uimanager.style.BorderRadiusProp
4237
import com.facebook.react.views.text.DefaultStyleValuesUtil.getDefaultTextColorHint
4338
import com.facebook.react.views.text.ReactTextUpdate
4439
import com.facebook.react.views.text.internal.span.CustomStyleSpan
40+
import com.facebook.testutils.shadows.ShadowSoLoader
4541
import org.assertj.core.api.Assertions.assertThat
4642
import org.junit.Before
4743
import org.junit.Test
4844
import org.junit.runner.RunWith
4945
import org.robolectric.RobolectricTestRunner
5046
import org.robolectric.RuntimeEnvironment
47+
import org.robolectric.annotation.Config
5148

5249
/** Verify {@link EditText} view property being applied properly by {@link ReactTextInputManager} */
5350
@RunWith(RobolectricTestRunner::class)
51+
@Config(shadows = [ShadowSoLoader::class])
5452
class ReactTextInputPropertyTest {
5553

56-
private lateinit var context: BridgeReactContext
57-
private lateinit var catalystInstanceMock: CatalystInstance
54+
private lateinit var context: ReactApplicationContext
5855
private lateinit var themedContext: ThemedReactContext
5956
private lateinit var manager: ReactTextInputManager
6057
private lateinit var view: ReactEditText
@@ -72,10 +69,9 @@ class ReactTextInputPropertyTest {
7269
@Before
7370
fun setup() {
7471
ReactNativeFeatureFlagsForTests.setUp()
75-
context = BridgeReactContext(RuntimeEnvironment.getApplication())
76-
catalystInstanceMock = createMockCatalystInstance()
77-
context.initializeWithInstance(catalystInstanceMock)
78-
themedContext = ThemedReactContext(context, context.baseContext, null, ID_NULL)
72+
val application = RuntimeEnvironment.getApplication()
73+
context = createTestReactApplicationContext(application)
74+
themedContext = ThemedReactContext(context, application, null, ID_NULL)
7975
manager = ReactTextInputManager()
8076
DisplayMetricsHolder.setScreenDisplayMetrics(DisplayMetrics())
8177
view = manager.createViewInstance(themedContext)

0 commit comments

Comments
 (0)