Deprecate unread factory config blocks, delete loadSourceForBridge (#59439)

Summary:
Pull Request resolved: #59439

Seven bridge-related factory configuration blocks are written but never read. Mark them deprecated since external clients still set them, and delete the eighth (`loadSourceForBridge`), which has no writers at all. Also remove our own dead write and the only reader method.

Changelog: [Internal]

Differential Revision: D127294779

Author: christophpurrer

packages/react-native/Libraries/AppDelegate/RCTReactNativeFactory.mm

@@ -295,13 +295,6 @@ - (RCTRootViewFactory *)createRCTRootViewFactory
     [weakSelf.delegate customizeRootView:(RCTRootView *)rootView];
   };
 
-  if ([self.delegate respondsToSelector:@selector(extraModulesForBridge:)]) {
-    configuration.extraModulesForBridge = ^NSArray<id<RCTBridgeModule>> *_Nonnull(RCTBridge *_Nonnull bridge)
-    {
-      return [weakSelf.delegate extraModulesForBridge:bridge];
-    };
-  }
-
   configuration.jsRuntimeConfiguratorDelegate = self;
 
   return [[RCTRootViewFactory alloc] initWithTurboModuleDelegate:self hostDelegate:self configuration:configuration];

packages/react-native/Libraries/AppDelegate/RCTRootViewFactory.h

@@ -39,7 +39,6 @@ typedef void (^RCTLoadSourceForBridgeWithProgressBlock)(
     RCTBridge *bridge,
     RCTSourceLoadProgressBlock onProgress,
     RCTSourceLoadBlock loadCallback);
-typedef void (^RCTLoadSourceForBridgeBlock)(RCTBridge *bridge, RCTSourceLoadBlock loadCallback);
 
 #pragma mark - RCTRootViewFactory Configuration
 @interface RCTRootViewFactoryConfiguration : NSObject
@@ -74,7 +73,8 @@ typedef void (^RCTLoadSourceForBridgeBlock)(RCTBridge *bridge, RCTSourceLoadBloc
  *
  * @returns: a UIView properly configured with a bridge for React Native.
  */
-@property (nonatomic, nullable) RCTCreateRootViewWithBridgeBlock createRootViewWithBridge;
+@property (nonatomic, nullable) RCTCreateRootViewWithBridgeBlock createRootViewWithBridge __deprecated_msg(
+    "This API will be removed along with the legacy architecture.");
 
 /**
  * Block that allows to override default behavior of creating bridge.
@@ -87,7 +87,8 @@ typedef void (^RCTLoadSourceForBridgeBlock)(RCTBridge *bridge, RCTSourceLoadBloc
  *
  * @returns: a newly created instance of RCTBridge.
  */
-@property (nonatomic, nullable) RCTCreateBridgeWithDelegateBlock createBridgeWithDelegate;
+@property (nonatomic, nullable) RCTCreateBridgeWithDelegateBlock createBridgeWithDelegate __deprecated_msg(
+    "This API will be removed along with the legacy architecture.");
 
 /**
  * Block that allows to customize the rootView that is passed to React Native.
@@ -106,7 +107,8 @@ typedef void (^RCTLoadSourceForBridgeBlock)(RCTBridge *bridge, RCTSourceLoadBloc
  * When running from a locally bundled JS file, this should be a `file://` url
  * pointing to a path inside the app resources, e.g. `file://.../main.jsbundle`.
  */
-@property (nonatomic, nullable) RCTSourceURLForBridgeBlock sourceURLForBridge;
+@property (nonatomic, nullable) RCTSourceURLForBridgeBlock sourceURLForBridge __deprecated_msg(
+    "This API will be removed along with the legacy architecture.");
 
 /**
  * The bridge initializes any registered RCTBridgeModules automatically, however
@@ -122,12 +124,14 @@ typedef void (^RCTLoadSourceForBridgeBlock)(RCTBridge *bridge, RCTSourceLoadBloc
  * not recommended in most cases - if the module methods and behavior do not
  * match exactly, it may lead to bugs or crashes.
  */
-@property (nonatomic, nullable) RCTExtraModulesForBridgeBlock extraModulesForBridge;
+@property (nonatomic, nullable) RCTExtraModulesForBridgeBlock extraModulesForBridge __deprecated_msg(
+    "This API will be removed along with the legacy architecture.");
 
 /**
  * Retrieve the list of lazy-native-modules names for the given bridge.
  */
-@property (nonatomic, nullable) RCTExtraLazyModuleClassesForBridge extraLazyModuleClassesForBridge;
+@property (nonatomic, nullable) RCTExtraLazyModuleClassesForBridge extraLazyModuleClassesForBridge __deprecated_msg(
+    "This API will be removed along with the legacy architecture.");
 
 /**
  * The bridge will call this block when a module has been called from JS
@@ -136,20 +140,17 @@ typedef void (^RCTLoadSourceForBridgeBlock)(RCTBridge *bridge, RCTSourceLoadBloc
  * in the implementation, and the system must attempt to look for it again among registered.
  * If the module was not registered, return NO to prevent further searches.
  */
-@property (nonatomic, nullable) RCTBridgeDidNotFindModuleBlock bridgeDidNotFindModule;
+@property (nonatomic, nullable) RCTBridgeDidNotFindModuleBlock bridgeDidNotFindModule __deprecated_msg(
+    "This API will be removed along with the legacy architecture.");
 
 /**
  * The bridge will automatically attempt to load the JS source code from the
  * location specified by the `sourceURLForBridge:` method, however, if you want
  * to handle loading the JS yourself, you can do so by setting this property.
  */
-@property (nonatomic, nullable) RCTLoadSourceForBridgeWithProgressBlock loadSourceForBridgeWithProgress;
-
-/**
- * Similar to loadSourceForBridgeWithProgress but without progress
- * reporting.
- */
-@property (nonatomic, nullable) RCTLoadSourceForBridgeBlock loadSourceForBridge;
+@property (nonatomic, nullable)
+    RCTLoadSourceForBridgeWithProgressBlock loadSourceForBridgeWithProgress __deprecated_msg(
+        "This API will be removed along with the legacy architecture.");
 
 @end
 

packages/react-native/Libraries/AppDelegate/RCTRootViewFactory.mm

@@ -229,14 +229,6 @@ - (RCTHost *)createReactHost:(NSDictionary *)launchOptions
       reinterpret_cast<facebook::react::JSRuntimeFactory *>(jsRuntimeFactory), &js_runtime_factory_destroy);
 }
 
-- (NSArray<id<RCTBridgeModule>> *)extraModulesForBridge:(RCTBridge *)bridge
-{
-  if (_configuration.extraModulesForBridge != nil) {
-    return _configuration.extraModulesForBridge(bridge);
-  }
-  return nil;
-}
-
 - (NSURL *)bundleURL
 {
   return self->_configuration.bundleURLBlock();

scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api

@@ -1585,7 +1585,6 @@ interface RCTRootViewFactoryConfiguration : public NSObject {
   public @property (assign) RCTCustomizeRootViewBlock customizeRootView;
   public @property (assign) RCTExtraLazyModuleClassesForBridge extraLazyModuleClassesForBridge;
   public @property (assign) RCTExtraModulesForBridgeBlock extraModulesForBridge;
-  public @property (assign) RCTLoadSourceForBridgeBlock loadSourceForBridge;
   public @property (assign) RCTLoadSourceForBridgeWithProgressBlock loadSourceForBridgeWithProgress;
   public @property (assign) RCTSourceURLForBridgeBlock sourceURLForBridge;
   public @property (weak) id<RCTJSRuntimeConfiguratorProtocol> jsRuntimeConfiguratorDelegate;

scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api

@@ -1628,7 +1628,6 @@ interface RCTRootViewFactoryConfiguration : public NSObject {
   public @property (assign) RCTCustomizeRootViewBlock customizeRootView;
   public @property (assign) RCTExtraLazyModuleClassesForBridge extraLazyModuleClassesForBridge;
   public @property (assign) RCTExtraModulesForBridgeBlock extraModulesForBridge;
-  public @property (assign) RCTLoadSourceForBridgeBlock loadSourceForBridge;
   public @property (assign) RCTLoadSourceForBridgeWithProgressBlock loadSourceForBridgeWithProgress;
   public @property (assign) RCTSourceURLForBridgeBlock sourceURLForBridge;
   public @property (weak) id<RCTJSRuntimeConfiguratorProtocol> jsRuntimeConfiguratorDelegate;

scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api

@@ -1584,7 +1584,6 @@ interface RCTRootViewFactoryConfiguration : public NSObject {
   public @property (assign) RCTCustomizeRootViewBlock customizeRootView;
   public @property (assign) RCTExtraLazyModuleClassesForBridge extraLazyModuleClassesForBridge;
   public @property (assign) RCTExtraModulesForBridgeBlock extraModulesForBridge;
-  public @property (assign) RCTLoadSourceForBridgeBlock loadSourceForBridge;
   public @property (assign) RCTLoadSourceForBridgeWithProgressBlock loadSourceForBridgeWithProgress;
   public @property (assign) RCTSourceURLForBridgeBlock sourceURLForBridge;
   public @property (weak) id<RCTJSRuntimeConfiguratorProtocol> jsRuntimeConfiguratorDelegate;

scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api

@@ -1585,7 +1585,6 @@ interface RCTRootViewFactoryConfiguration : public NSObject {
   public @property (assign) RCTCustomizeRootViewBlock customizeRootView;
   public @property (assign) RCTExtraLazyModuleClassesForBridge extraLazyModuleClassesForBridge;
   public @property (assign) RCTExtraModulesForBridgeBlock extraModulesForBridge;
-  public @property (assign) RCTLoadSourceForBridgeBlock loadSourceForBridge;
   public @property (assign) RCTLoadSourceForBridgeWithProgressBlock loadSourceForBridgeWithProgress;
   public @property (assign) RCTSourceURLForBridgeBlock sourceURLForBridge;
   public @property (weak) id<RCTJSRuntimeConfiguratorProtocol> jsRuntimeConfiguratorDelegate;