Skip to content

Commit 2f6c4a4

Browse files
christophpurrermeta-codesync[bot]
authored andcommitted
Remove write-only bridge from sample legacy modules (#59261)
Summary: Pull Request resolved: #59261 RCTSampleLegacyModule on iOS and macOS stored a bridge that nothing reads. Delete the ivar and setter from both sample files. Changelog: [Internal] Reviewed By: shwanton Differential Revision: D126575656 fbshipit-source-id: 24554aa151537a14afd4f57ef8de5b5e465933c4
1 parent 797882e commit 2f6c4a4

1 file changed

Lines changed: 1 addition & 8 deletions

File tree

‎packages/react-native/ReactCommon/react/nativemodule/samples/platform/ios/ReactCommon/RCTSampleLegacyModule.mm‎

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,7 @@
77

88
#import "RCTSampleLegacyModule.h"
99

10-
@implementation RCTSampleLegacyModule {
11-
RCTBridge *_bridge;
12-
}
10+
@implementation RCTSampleLegacyModule
1311

1412
// Backward-compatible export
1513
RCT_EXPORT_MODULE()
@@ -20,11 +18,6 @@ + (BOOL)requiresMainQueueSetup
2018
return YES;
2119
}
2220

23-
- (void)setBridge:(RCTBridge *)bridge
24-
{
25-
_bridge = bridge;
26-
}
27-
2821
- (dispatch_queue_t)methodQueue
2922
{
3023
return dispatch_get_main_queue();

0 commit comments

Comments
 (0)