Skip to content

Commit 2b52147

Browse files
christophpurrermeta-codesync[bot]
authored andcommitted
Remove dead RCTBridge imports from sixteen bridgeless files (#59251)
Summary: Pull Request resolved: #59251 Seven implementation files imported the bridge header without referencing any symbol it provides. Nine public headers either imported it redundantly or narrowed it to the module protocol header they actually need. Changelog: [Internal] Reviewed By: javache Differential Revision: D126549484 fbshipit-source-id: 5b80b441542b63b3b7391fce65cea32385e441ac
1 parent 86695d8 commit 2b52147

16 files changed

Lines changed: 6 additions & 15 deletions

‎packages/react-native/Libraries/Blob/RCTBlobManager.h‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8-
#import <React/RCTBridge.h>
98
#import <React/RCTBridgeModule.h>
109
#import <React/RCTInitializing.h>
1110
#import <React/RCTURLRequestHandler.h>

‎packages/react-native/Libraries/Blob/RCTFileReaderModule.mm‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
#import <React/RCTFileReaderModule.h>
99

1010
#import <FBReactNativeSpec/FBReactNativeSpec.h>
11-
#import <React/RCTBridge.h>
1211
#import <React/RCTConvert.h>
1312

1413
#import <React/RCTBlobManager.h>

‎packages/react-native/Libraries/Image/RCTImageDataDecoder.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#import <UIKit/UIKit.h>
99

10-
#import <React/RCTBridge.h>
10+
#import <React/RCTBridgeModule.h>
1111
#import <React/RCTImageURLLoader.h>
1212
#import <React/RCTResizeMode.h>
1313
#import <React/RCTURLRequestHandler.h>

‎packages/react-native/Libraries/Image/RCTImageLoaderProtocol.h‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
#import <UIKit/UIKit.h>
99

10-
#import <React/RCTBridge.h>
1110
#import <React/RCTImageCache.h>
1211
#import <React/RCTImageDataDecoder.h>
1312
#import <React/RCTImageURLLoader.h>

‎packages/react-native/Libraries/Image/RCTImageURLLoader.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#import <UIKit/UIKit.h>
99

10-
#import <React/RCTBridge.h>
10+
#import <React/RCTBridgeModule.h>
1111
#import <React/RCTResizeMode.h>
1212

1313
NS_ASSUME_NONNULL_BEGIN

‎packages/react-native/Libraries/PushNotificationIOS/RCTPushNotificationManager.mm‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
#import <UserNotifications/UserNotifications.h>
1111

1212
#import <FBReactNativeSpec/FBReactNativeSpec.h>
13-
#import <React/RCTBridge.h>
1413
#import <React/RCTConvert.h>
1514
#import <React/RCTUtils.h>
1615

‎packages/react-native/Libraries/Settings/RCTSettingsManager.mm‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
#import <React/RCTSettingsManager.h>
99

1010
#import <FBReactNativeSpec/FBReactNativeSpec.h>
11-
#import <React/RCTBridge.h>
1211
#import <React/RCTConvert.h>
1312
#import <React/RCTEventDispatcherProtocol.h>
1413
#import <React/RCTUtils.h>

‎packages/react-native/React/CoreModules/RCTActionSheetManager.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#import <UIKit/UIKit.h>
99

10-
#import <React/RCTBridge.h>
10+
#import <React/RCTBridgeModule.h>
1111

1212
@interface RCTActionSheetManager : NSObject <RCTBridgeModule>
1313

‎packages/react-native/React/CoreModules/RCTActionSheetManager.mm‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313

1414
#if !TARGET_OS_TV
1515

16-
#import <React/RCTBridge.h>
1716
#import <React/RCTConvert.h>
1817
#import <React/RCTLog.h>
1918
#import <React/RCTUIManager.h>

‎packages/react-native/React/CoreModules/RCTAppState.mm‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99

1010
#import <FBReactNativeSpec/FBReactNativeSpec.h>
1111
#import <React/RCTAssert.h>
12-
#import <React/RCTBridge.h>
1312
#import <React/RCTEventDispatcherProtocol.h>
1413
#import <React/RCTInitializing.h>
1514
#import <React/RCTUtils.h>

0 commit comments

Comments
 (0)