Skip to content

Commit 1538234

Browse files
coadometa-codesync[bot]
authored andcommitted
Make platform-only scrollview implementation headers private (#58917)
Summary: Pull Request resolved: #58917 Mark three platform-specific `react/renderer/components/scrollview` headers as private: - iOS `RCTComponentViewHelpers.h` (previously untiered): the `RCTScrollViewProtocol` / `RCTScrollViewHandleCommand` helper used only by React Native's own iOS ScrollView component view to dispatch commands. - Android `AndroidHorizontalScrollContentViewComponentDescriptor.h` and `AndroidHorizontalScrollContentViewShadowNode.h` (previously "for frameworks"): the component is registered only by React Native's own Android core components registry, and the shadow node is only included by its descriptor. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D123623731 fbshipit-source-id: 3d78d7957bb94d6880775348d3998bc2910eef26
1 parent 38bd21b commit 1538234

3 files changed

Lines changed: 4 additions & 2 deletions

File tree

‎packages/react-native/ReactCommon/react/renderer/components/scrollview/platform/android/react/renderer/components/scrollview/AndroidHorizontalScrollContentViewComponentDescriptor.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/FrameworksGuard.h>
10+
#include <react/cxxstableapi/PrivateGuard.h>
1111

1212
#include <React/RendererCore.h>
1313
#include <react/renderer/components/scrollview/AndroidHorizontalScrollContentViewShadowNode.h>

‎packages/react-native/ReactCommon/react/renderer/components/scrollview/platform/android/react/renderer/components/scrollview/AndroidHorizontalScrollContentViewShadowNode.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/FrameworksGuard.h>
10+
#include <react/cxxstableapi/PrivateGuard.h>
1111

1212
#include <React/RendererCore.h>
1313
#include <React/View.h>

‎packages/react-native/ReactCommon/react/renderer/components/scrollview/platform/ios/react/renderer/components/scrollview/RCTComponentViewHelpers.h‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8+
#include <react/cxxstableapi/PrivateGuard.h>
9+
810
#import <Foundation/Foundation.h>
911
#import <React/RCTDefines.h>
1012
#import <React/RCTLog.h>

0 commit comments

Comments
 (0)