Skip to content

[Feature] Re-enable the embedlit analyzer after the Go 1.27 upgrade #5246

Description

@zhuangzhewei09

Search before asking

  • I had searched in the issues and found no similar feature requirement.

KubeRay Component

ci

Description

The Go 1.27 upgrade in #5188 temporarily disables the embedlit analyzer under modernize in .golangci.yml to keep the upgrade focused.

This issue tracks the code cleanup and re-enabling the analyzer after #5188 is merged, as requested in the review:
#5188 (comment)

Completion criteria:

  • Update the affected Go code and tests to address embedlit diagnostics while preserving existing behavior.
  • Remove embedlit and its temporary explanatory comments from modernize.disable, keeping other settings unchanged.
  • Pass the existing golangci-lint checks and the affected package tests with Go 1.27.

Use case

Go 1.27 allows struct literals to initialize fields promoted from embedded structs directly. The embedlit analyzer identifies opportunities to simplify these initializations.

Re-enabling the check after the cleanup lets CI enforce this pattern and removes the temporary exception introduced by the upgrade.

Related issues

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions