Data Partition can have it's non-existent "config.txt" edited!

[lurch]

...in other words, the "Edit config" button should be disabled when the Data Partition is the currently-highlighted entry in the OS-install list.

[maxnet]

Make sure you have the latest dev branch AND did a fresh installation.

[maxnet]

(It should add bootable => false to installed_os.json if at installation time if it has determined that the OS has no partition of file system type FAT. That property is then checked when selecting an os in the main menu to decide wheter or not to enable config.txt edit button)

[lurch]

I did. I noted that #103 has indeed been fixed and you can't install just the Data Partition now :)

But the "Edit config" button is still enabled when the Data Partition is highlighted, and trying to use it you get a "Error mounting boot partition" dialog and then it displays an all-grey config editor.

[maxnet]

What does your installed_os.json on noobs data partition look like?

[maxnet]

My bad, seems I forgot a toBool() here resulting in incorrect behavior: https://github.com/raspberrypi/noobs/blob/dev/recovery/mainwindow.cpp#L496
(Cannot test that currently though, not near a Pi)

[lurch]

Nope, looks like it was my bad, many apologies!
I now can't reproduce the problem, so it's possible that as I've been testing with so many SD cards I'd forgotten what version of NOOBS I had on what card ;)

(Or it may have been that I installed "Data Partition" using NOOBS 1.3.2 and then simply re-copied the newly-built NOOBS files to the first partition of the SD card without reformatting it first - which is obviously very non-standard behaviour)

[NicoHood]

The bug is still in 1.5
This fixes it:
#306