Merge branch 'main' into perf/tier2-cpu

Author: joak0068

.github/PULL_REQUEST_TEMPLATE.md

@@ -6,9 +6,8 @@
 
 ## Checklist
 
-- [ ] Ran `clang-format -i` on touched files (CI enforces formatting)
-- [ ] `scripts/build.sh` (or `.ps1`) builds clean
+<!-- Formatting, build, and CHANGELOG are checked automatically by CI. -->
+
 - [ ] New tunable values live in `src/config/params.h`
-- [ ] Added a line under `## [Unreleased]` in `CHANGELOG.md`
 - [ ] If a control changed, updated `docs/MIDI_PROTOCOL.md` and the `params::midi` map
 - [ ] Tested on hardware (Daisy Seed + Hothouse) — describe below, or note if untested

.github/workflows/firmware.yml

@@ -14,6 +14,27 @@ permissions:
   contents: write        # needed to create Releases on tag builds
 
 jobs:
+  changelog:
+    # Require a CHANGELOG.md entry on PRs. Skipped for PRs labelled
+    # 'skip-changelog' or 'dependencies' (e.g. the submodule-update bot).
+    if: >-
+      github.event_name == 'pull_request' &&
+      !contains(github.event.pull_request.labels.*.name, 'skip-changelog') &&
+      !contains(github.event.pull_request.labels.*.name, 'dependencies')
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+      - name: Require a CHANGELOG entry
+        run: |
+          base='${{ github.event.pull_request.base.sha }}'
+          if git diff --quiet "$base" HEAD -- CHANGELOG.md; then
+            echo "::error::This PR doesn't update CHANGELOG.md. Add a note under '## [Unreleased]', or label the PR 'skip-changelog'."
+            exit 1
+          fi
+          echo "CHANGELOG.md updated."
+
   format:
     runs-on: ubuntu-latest
     steps:

CHANGELOG.md

@@ -12,6 +12,9 @@ uses [Semantic Versioning](https://semver.org/) (`vMAJOR.MINOR.PATCH`).
   and the final hard clamp is folded into the master limiter (one less buffer pass).
 - **Link-time optimization** (`-flto`) trims ~1.5 KB of internal flash (98.2% → 97.1%);
   `usb_identity.c` is kept out of LTO so its USB-descriptor override stays deterministic.
+- **CI checks a CHANGELOG entry** on every PR (skippable via a `skip-changelog` /
+  `dependencies` label), and the PR template now lists only the manual items CI can't
+  verify (formatting, build, and changelog are enforced automatically).
 - **Contributor tooling.** Added `CONTRIBUTING.md`, GitHub issue/PR templates, a
   `.clang-format` (Google C++, 4-space, 100-col) + `.editorconfig`, and a CI job that
   enforces formatting. New `scripts/setup.{sh,ps1}` one-shot bootstrap (submodules + libs).

CONTRIBUTING.md

@@ -85,8 +85,11 @@ wrappers over the `Makefile` — keep the actual logic in the Makefile where pos
 ## Submitting a change
 
 1. Branch off `main`.
-2. Make your change; run `clang-format -i` and confirm `scripts/build.sh` succeeds.
+2. Make your change. Running `clang-format -i` and `scripts/build.sh` locally is the fast
+   way to catch problems, but CI enforces both either way.
 3. Add a line under `## [Unreleased]` in [`CHANGELOG.md`](CHANGELOG.md).
-4. Open a PR against `main`. CI builds the firmware and checks formatting on every PR.
+4. Open a PR against `main`. On every PR, CI builds the firmware, checks formatting, and
+   requires a `CHANGELOG.md` entry (label the PR `skip-changelog` for changes that don't
+   warrant one, e.g. CI-only tweaks).
 
 Releases are cut from version tags — see the *Releases & versioning* section of the README.