[#190] Stabilize rate-limit test storage setup

Author: armanist

tests/Feature/AppTestCase.php

@@ -25,6 +25,7 @@ public function setUp(): void
         parent::setUp();
         ob_start();
 
+        $this->ensureRateLimitStorageExists();
         self::$app = createApp(AppType::WEB, PROJECT_ROOT);
         $this->clearRateLimitStorage();
     }
@@ -78,4 +79,19 @@ private function clearRateLimitStorage(): void
             }
         }
     }
+
+    private function ensureRateLimitStorageExists(): void
+    {
+        $rateLimitDir = PROJECT_ROOT . DS . 'cache' . DS . 'data';
+
+        if (is_dir($rateLimitDir)) {
+            return;
+        }
+
+        $created = mkdir($rateLimitDir, 0777, true);
+
+        if (!$created && !is_dir($rateLimitDir)) {
+            throw new RuntimeException('Failed to create rate limit storage directory: ' . $rateLimitDir);
+        }
+    }
 }

tests/Feature/modules/Api/RateLimitTest.php

@@ -10,7 +10,6 @@ class RateLimitTest extends AppTestCase
     public function setUp(): void
     {
         parent::setUp();
-        $this->ensureRateLimitStorageExists();
         $this->clearRateLimitStorage();
     }
 
@@ -75,13 +74,4 @@ private function clearRateLimitStorage(): void
         }
     }
 
-    private function ensureRateLimitStorageExists(): void
-    {
-        $rateLimitDir = PROJECT_ROOT . DS . 'cache' . DS . 'data';
-
-        if (!is_dir($rateLimitDir)) {
-            $created = mkdir($rateLimitDir, 0777, true);
-            $this->assertTrue($created || is_dir($rateLimitDir), 'Failed to create rate limit storage directory: ' . $rateLimitDir);
-        }
-    }
 }