[#563] Align HttpClient adapter start contract

Author: armanist

src/HttpClient/Adapters/CurlAdapter.php

@@ -82,12 +82,9 @@ public function buildPostData($data)
         return $this->client->buildPostData($data);
     }
 
-    /**
-     * @return mixed
-     */
-    public function start()
+    public function start(): void
     {
-        return $this->client->exec();
+        $this->client->exec();
     }
 
     /**

src/HttpClient/Adapters/MultiCurlAdapter.php

@@ -54,12 +54,9 @@ public function error(callable $callback): MultiCurlAdapterInterface
         return $this;
     }
 
-    /**
-     * @return mixed
-     */
-    public function start()
+    public function start(): void
     {
-        return $this->client->start();
+        $this->client->start();
     }
 
     /**

src/HttpClient/Contracts/HttpClientAdapterInterface.php

@@ -18,9 +18,8 @@ interface HttpClientAdapterInterface
 {
     /**
      * Starts request execution
-     * @return mixed
      */
-    public function start();
+    public function start(): void;
 
     /**
      * Sets request header

tests/Unit/HttpClient/Adapters/CurlAdapterTest.php

@@ -36,7 +36,8 @@ public function testCurlAdapterDelegatesRequestMethods(): void
         $this->assertSame($adapter, $adapter->setOpt(CURLOPT_TIMEOUT, 10));
         $this->assertSame($adapter, $adapter->setOpts([CURLOPT_CONNECTTIMEOUT => 5]));
         $this->assertSame('a=1', $adapter->buildPostData(['a' => 1]));
-        $this->assertSame('ok', $adapter->start());
+
+        $adapter->start();
     }
 
     public function testCurlAdapterDelegatesResponseMethods(): void

tests/Unit/HttpClient/Adapters/MultiCurlAdapterTest.php

@@ -40,7 +40,8 @@ public function testMultiCurlAdapterDelegatesRequestMethods(): void
         $this->assertSame($adapter, $adapter->setOpts([CURLOPT_CONNECTTIMEOUT => 5]));
         $this->assertInstanceOf(CurlAdapter::class, $adapter->addGet('https://example.com', ['a' => 1]));
         $this->assertInstanceOf(CurlAdapter::class, $adapter->addPost('https://example.com', 'payload', true));
-        $this->assertNull($adapter->start());
+
+        $adapter->start();
     }
 
     public function testMultiCurlAdapterRegistersCallbacks(): void