Merge pull request #521 from armanist/issue/520-openapi-response-contract

[#520] Fix OpenAPI generated routes response contract

Author: armanist

CHANGELOG.md

@@ -81,6 +81,7 @@
 - Fixed cURL error message assertions for cross-version compatibility
 - Fixed SleekDB paginator query-state regression where `count()` could clear criteria before paginated data fetch on the same model instance (#514)
 - Standardized `defineValidationRules(Request $request): void` across DemoWeb and DemoApi middleware templates
+- Fixed OpenAPI installer route generation to return `Response` objects via `response()->...` helpers and avoid undefined response-variable usage (#520)
 - Standardized `defineValidationRules(Request $request): void` in Toolkit middleware templates
 
 ### Added

src/Console/Commands/OpenApiCommand.php

@@ -192,13 +192,13 @@ private function openapiRoutes(string $module): string
     {
         return 'return function ($route) {
     $route->group("openapi", function ($route) {
-        $route->get("docs", function (Quantum\Http\Response $response) {
-            $response->html(partial("openApi/openApi"));
+        $route->get("docs", function (): Quantum\Http\Response {
+            return response()->html(partial("openApi/openApi"));
         });
 
-        $route->get("spec", function (Quantum\Http\Response $response) {
+        $route->get("spec", function (): Quantum\Http\Response {
             $fs = Quantum\Storage\Factories\FileSystemFactory::get();
-            $response->json($fs->getJson(modules_dir() . "' . DS . $module . DS . 'resources' . DS . 'openapi' . DS . 'spec.json"));
+            return response()->json($fs->getJson(modules_dir() . "' . DS . $module . DS . 'resources' . DS . 'openapi' . DS . 'spec.json"));
         });
     });' . PHP_EOL;
     }