github-merge-queue Bot removed this pull request from the merge queue due to failed status checks 9 minutes ago
This failure: https://github.com/pyvista/pyvista/actions/runs/25170232275/job/73791246079#step:8:3069
FAILED tests/plotting/test_plotting.py::test_box - pytest_pyvista.pytest_pyvista.RegressionFileNotFoundError: /home/runner/_work/pyvista/pyvista/tests/plotting/image_cache/box_1.png does not exist in image cache
Seems to be related to pyvista/pyvista#8596, where I suspect the test initially fails, and the flaky test decorator retries the test, but it generates a second image (?) which has the wrong name, and so the retry fails with RegressionFileNotFoundError. The VerifyImageCache fixture I think keeps track of the test IDs internally... might need to somehow refresh this fixture as part of the retry. And if we find that we need to couple the flaky_test decorator with VerifyImageCache to make this work, then perhaps it should be moved into pytest-pyvista directly.
Originally posted by @user27182 in pyvista/pyvista#8604 (comment)
This failure: https://github.com/pyvista/pyvista/actions/runs/25170232275/job/73791246079#step:8:3069
Seems to be related to pyvista/pyvista#8596, where I suspect the test initially fails, and the flaky test decorator retries the test, but it generates a second image (?) which has the wrong name, and so the retry fails with
RegressionFileNotFoundError. TheVerifyImageCachefixture I think keeps track of the test IDs internally... might need to somehow refresh this fixture as part of the retry. And if we find that we need to couple theflaky_testdecorator withVerifyImageCacheto make this work, then perhaps it should be moved intopytest-pyvistadirectly.Originally posted by @user27182 in pyvista/pyvista#8604 (comment)