Add room rename feature

Author: python2121

app/routers/rooms.py

@@ -29,6 +29,10 @@ class RoomCreate(BaseModel):
     name: str
 
 
+class RoomRename(BaseModel):
+    name: str
+
+
 def _rooms_path():
     return settings.layout_file.parent / "rooms.json"
 
@@ -86,6 +90,29 @@ async def create_room(body: RoomCreate) -> Room:
     return new_room
 
 
+@router.patch("/{room_id}", response_model=Room)
+async def rename_room(room_id: str, body: RoomRename) -> Room:
+    """Rename a room (updates display name; room ID is unchanged)."""
+    if not ROOM_ID_RE.match(room_id):
+        raise HTTPException(
+            status_code=status.HTTP_400_BAD_REQUEST,
+            detail="Invalid room ID",
+        )
+    name = body.name.strip()
+    if not name:
+        raise HTTPException(
+            status_code=status.HTTP_400_BAD_REQUEST,
+            detail="Room name cannot be empty",
+        )
+    rooms = _read_rooms()
+    for room in rooms:
+        if room.id == room_id:
+            room.name = name
+            _write_rooms(rooms)
+            return room
+    raise HTTPException(status_code=status.HTTP_404_NOT_FOUND, detail="Room not found")
+
+
 @router.delete("/{room_id}", status_code=status.HTTP_204_NO_CONTENT)
 async def delete_room(room_id: str) -> None:
     """Delete a room and its layout file. Cannot delete the last room."""

app/static/js/app.js

@@ -249,6 +249,10 @@ const DashboardApp = (() => {
     return api("POST", "/api/rooms", { name });
   }
 
+  async function apiRenameRoom(roomId, name) {
+    return api("PATCH", `/api/rooms/${encodeURIComponent(roomId)}`, { name });
+  }
+
   async function apiDeleteRoom(roomId) {
     const res = await fetch(`/api/rooms/${encodeURIComponent(roomId)}`, { method: "DELETE" });
     if (!res.ok) {
@@ -528,6 +532,7 @@ const DashboardApp = (() => {
   }
 
   function showNewRoomForm() {
+    hideRenameRoomForm();
     const form = document.getElementById("new-room-form");
     if (form) {
       form.classList.remove("new-room-form--hidden");
@@ -543,6 +548,43 @@ const DashboardApp = (() => {
     if (input) input.value = "";
   }
 
+  function showRenameRoomForm() {
+    hideNewRoomForm();
+    const form = document.getElementById("rename-room-form");
+    if (form) {
+      form.classList.remove("new-room-form--hidden");
+      const input = document.getElementById("rename-room-name");
+      if (input) {
+        const current = rooms.find((r) => r.id === currentRoomId);
+        input.value = current ? current.name : "";
+        input.focus();
+        input.select();
+      }
+    }
+  }
+
+  function hideRenameRoomForm() {
+    const form = document.getElementById("rename-room-form");
+    if (form) form.classList.add("new-room-form--hidden");
+    const input = document.getElementById("rename-room-name");
+    if (input) input.value = "";
+  }
+
+  async function renameCurrentRoom() {
+    const input = document.getElementById("rename-room-name");
+    const name = input ? input.value.trim() : "";
+    if (!name) return;
+    try {
+      const updated = await apiRenameRoom(currentRoomId, name);
+      const idx = rooms.findIndex((r) => r.id === currentRoomId);
+      if (idx !== -1) rooms[idx] = updated;
+      hideRenameRoomForm();
+      renderRoomSelector();
+    } catch (err) {
+      console.error("Failed to rename room:", err);
+    }
+  }
+
   // ── Edit mode ──────────────────────────────────────────────────────
 
   function enterEditMode() {
@@ -560,6 +602,7 @@ const DashboardApp = (() => {
     btnEdit.classList.remove("fab--hidden");
     grid.setStatic(true);
     hideNewRoomForm();
+    hideRenameRoomForm();
 
     try {
       await saveLayout(serializeLayout(), currentRoomId);
@@ -931,6 +974,23 @@ const DashboardApp = (() => {
       });
     }
 
+    const btnRoomRename = document.getElementById("btn-room-rename");
+    if (btnRoomRename) btnRoomRename.addEventListener("click", showRenameRoomForm);
+
+    const btnRoomRenameSave = document.getElementById("btn-room-rename-save");
+    if (btnRoomRenameSave) btnRoomRenameSave.addEventListener("click", renameCurrentRoom);
+
+    const btnRoomCancelRename = document.getElementById("btn-room-cancel-rename");
+    if (btnRoomCancelRename) btnRoomCancelRename.addEventListener("click", hideRenameRoomForm);
+
+    const renameRoomNameInput = document.getElementById("rename-room-name");
+    if (renameRoomNameInput) {
+      renameRoomNameInput.addEventListener("keydown", (e) => {
+        if (e.key === "Enter") renameCurrentRoom();
+        if (e.key === "Escape") hideRenameRoomForm();
+      });
+    }
+
     const btnRoomDelete = document.getElementById("btn-room-delete");
     if (btnRoomDelete) btnRoomDelete.addEventListener("click", deleteCurrentRoom);
 

app/templates/index.html

@@ -28,6 +28,9 @@
         <button id="btn-room-new" class="btn btn--small" title="Add a new room">
           <i class="mdi mdi-home-plus-outline"></i> New Room
         </button>
+        <button id="btn-room-rename" class="btn btn--small" title="Rename this room">
+          <i class="mdi mdi-pencil-outline"></i>
+        </button>
         <button id="btn-room-delete" class="btn btn--small" title="Delete this room">
           <i class="mdi mdi-home-remove-outline"></i>
         </button>
@@ -37,6 +40,11 @@
         <button id="btn-room-create" class="btn btn--primary btn--small">Create</button>
         <button id="btn-room-cancel-new" class="btn btn--small">Cancel</button>
       </div>
+      <div id="rename-room-form" class="new-room-form new-room-form--hidden">
+        <input id="rename-room-name" type="text" class="toolbar__room-input" placeholder="Room name…" maxlength="40" />
+        <button id="btn-room-rename-save" class="btn btn--primary btn--small">Save</button>
+        <button id="btn-room-cancel-rename" class="btn btn--small">Cancel</button>
+      </div>
     </div>
     <div class="toolbar__right">
       <select id="theme-select" class="btn" title="Theme">

tests/test_rooms.py

@@ -80,6 +80,40 @@ def test_delete_room_invalid_id(client):
     assert res.status_code in (400, 404, 422)
 
 
+def test_rename_room(client):
+    """PATCH /api/rooms/{room_id} updates the room's display name."""
+    new = client.post("/api/rooms", json={"name": "Old Name"}).json()
+    room_id = new["id"]
+
+    res = client.patch(f"/api/rooms/{room_id}", json={"name": "New Name"})
+    assert res.status_code == 200
+    assert res.json()["name"] == "New Name"
+    assert res.json()["id"] == room_id  # ID is unchanged
+
+    # Name persists in listing
+    rooms = client.get("/api/rooms").json()
+    match = next(r for r in rooms if r["id"] == room_id)
+    assert match["name"] == "New Name"
+
+
+def test_rename_room_empty_name(client):
+    """PATCH /api/rooms/{room_id} with empty name returns 400."""
+    res = client.patch("/api/rooms/default", json={"name": "   "})
+    assert res.status_code == 400
+
+
+def test_rename_room_not_found(client):
+    """PATCH /api/rooms/{room_id} returns 404 for unknown room."""
+    res = client.patch("/api/rooms/does_not_exist", json={"name": "Whatever"})
+    assert res.status_code == 404
+
+
+def test_rename_room_invalid_id(client):
+    """PATCH /api/rooms/{room_id} returns 400 for invalid IDs."""
+    res = client.patch("/api/rooms/../../etc/passwd", json={"name": "X"})
+    assert res.status_code in (400, 404, 422)
+
+
 # ── Per-room layout isolation ────────────────────────────────────────