Commit f9eb423
committed
fix(web): stop treating TypeScript sources as video attachments
Review follow-ups on the #8688 port.
videoMimeType accepted any video/* MIME, and hosts map a .ts file to
video/mp2t. Attaching a TypeScript source turned it into an unnamed black
play tile, dropped its download row in the transcript, and ended at "This
video format cannot be played here". The extension now decides first, and a
bare MIME is only trusted when it names a container Pylon actually plays.
Also: re-wrapping a staged File copied the whole blob whenever the browser
reported no type at all, purely to stamp application/octet-stream that
mimeType already carries; that copy is now limited to real corrections. And
composer video tiles show the filename, which the transcript tile already
did — without it two videos are indistinguishable black squares.1 parent 9964755 commit f9eb423
3 files changed
Lines changed: 53 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3722 | 3722 | | |
3723 | 3723 | | |
3724 | 3724 | | |
| 3725 | + | |
| 3726 | + | |
| 3727 | + | |
| 3728 | + | |
3725 | 3729 | | |
3726 | | - | |
| 3730 | + | |
3727 | 3731 | | |
3728 | 3732 | | |
3729 | 3733 | | |
| |||
4602 | 4606 | | |
4603 | 4607 | | |
4604 | 4608 | | |
4605 | | - | |
| 4609 | + | |
| 4610 | + | |
| 4611 | + | |
| 4612 | + | |
| 4613 | + | |
| 4614 | + | |
| 4615 | + | |
| 4616 | + | |
4606 | 4617 | | |
4607 | 4618 | | |
4608 | 4619 | | |
| |||
Lines changed: 21 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
322 | 322 | | |
323 | 323 | | |
324 | 324 | | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
72 | 84 | | |
73 | 85 | | |
74 | 86 | | |
75 | | - | |
76 | | - | |
77 | 87 | | |
78 | | - | |
79 | | - | |
80 | | - | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
81 | 95 | | |
82 | 96 | | |
83 | 97 | | |
| |||
0 commit comments