Skip to content

Commit f0e015d

Browse files
rynfarrynfar
committed
docs(upstream-review): point WATCH-2 and WATCH-3 at their design issues
Also note in WATCH-1 that Pylon's own OpenCode task-progress fix is open as #178, so the row stays listed only because upstream #5760 is still open.
1 parent 025c749 commit f0e015d

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

‎.agents/upstream-review.md‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3115,8 +3115,8 @@ an entry comes due, is rewritten, or is retired, update the owning issue in the
31153115
same change. An owner that disagrees with this table is the failure this list
31163116
exists to prevent.
31173117

3118-
| ID | Owner | Upstream | Added | Current signal | Revisit when | Response to evaluate |
3119-
| ------- | -------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------ | ---------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
3120-
| WATCH-1 | [`#114`](https://github.com/pylon-code/pylon/issues/114) — Prime provider parity | `#5760` (issue, open) OpenCode `todowrite` updates do not reach the task sidebar; `#8097` (PR, open draft) restore composer tasks after relaunch | 2026-08-29 | `#5760` is a real defect **present in Pylon**: `OpenCodeAdapter.ts` emits no `turn.plan.updated`, so the composer Tasks tab, inline plan chip, and sidebar working line are dead on OpenCode, and every `todowrite` is misclassified `file_change` and inflates the edit count. Pylon is fixing this itself against the v2 SDK's structured `todo.updated` event; there is no upstream patch to take. **`#8097` is superseded** — Pylon shipped the same fix in `#137` (`8698a69e`) before the draft opened, via the `latest_plan_activity` CTE in `ProjectionSnapshotQuery.ts`, and with waiting-step retention the draft's settled-turn gate would regress. | For `#5760`: nothing to watch upstream — Pylon owns the fix. For `#8097`: only if it merges AND diverges from Pylon's approach. Check `gh pr view 8097 --repo pingdotgg/t3code --json state,mergedAt`. Its migration id 42 is unusable here (Pylon's 42 is `ProjectionProjectFaviconPath`; the manifest runs through 47, so any new migration is 048). Upstream's own trunk has a 42 collision between `#8097` and merged `#8160`. | Do not port `#8097`. Two fragments stand alone on their merits: its partial plan-activity index as a Pylon-numbered `048`, but only if `EXPLAIN QUERY PLAN` shows Pylon's CTE actually reverse-scans; and a Pylon-voiced Tasks section for `docs/user/composer.md`, which has none today. Its `turn.aborted` reducer hunks are an unrelated concern — investigate separately, do not smuggle them in. |
3121-
| WATCH-2 | [`#114`](https://github.com/pylon-code/pylon/issues/114) — Prime provider parity | `#6573` (PR) — authenticated cross-thread MCP tools | 2026-08-29 | **Premise gone.** Closed unmerged 2026-08-28 without adding permission splitting or bounded read-only tools. Nothing upstream to compare against today. | A replacement lands. Check `git log --oneline <cursor>..t3code-upstream/main -- apps/server/src/mcp/toolkits/` and `gh pr list --repo pingdotgg/t3code --search 'mcp thread tools' --state merged`. Not before 2026-11-01 — upstream abandoned this once and a rewrite is not a weekly event. | Compare with Pylon's scoped read-only context/checkpoint MCP design before adoption. Do not revive `#6573` itself. |
3122-
| WATCH-3 | [`#114`](https://github.com/pylon-code/pylon/issues/114) — Prime provider parity | `#7966` (issue) / `#7986` (PR) — server-side scheduled agent runs | 2026-08-29 | **Premise gone.** Both closed 2026-08-28; `#7986` closed unmerged. The implementation Pylon declined to cherry-pick no longer exists upstream. | A replacement scheduling implementation merges. Check `git log --oneline <cursor>..t3code-upstream/main -- apps/server/src/orchestration/Layers/TaskFireReactor.ts apps/server/src/orchestration/Layers/OrchestrationReactor.ts`. Not before 2026-11-01. | Fresh review only. Pylon's own canonical scheduled-turn ownership question in `#114` is unblocked by upstream's retreat, not answered by it. |
3118+
| ID | Owner | Upstream | Added | Current signal | Revisit when | Response to evaluate |
3119+
| ------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------ | ---------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
3120+
| WATCH-1 | [`#114`](https://github.com/pylon-code/pylon/issues/114) — Prime provider parity | `#5760` (issue, open) OpenCode `todowrite` updates do not reach the task sidebar; `#8097` (PR, open draft) restore composer tasks after relaunch | 2026-08-29 | `#5760` is a real defect **present in Pylon**: `OpenCodeAdapter.ts` emits no `turn.plan.updated`, so the composer Tasks tab, inline plan chip, and sidebar working line are dead on OpenCode, and every `todowrite` is misclassified `file_change` and inflates the edit count. Pylon is fixing this itself against the v2 SDK's structured `todo.updated` event; there is no upstream patch to take. That Pylon-side fix is open as [`#178`](https://github.com/pylon-code/pylon/pull/178) (`fix/opencode-plan-parity`), so `#5760` stays listed only because the upstream issue is still open. **`#8097` is superseded** — Pylon shipped the same fix in `#137` (`8698a69e`) before the draft opened, via the `latest_plan_activity` CTE in `ProjectionSnapshotQuery.ts`, and with waiting-step retention the draft's settled-turn gate would regress. | For `#5760`: nothing to watch upstream — Pylon owns the fix. For `#8097`: only if it merges AND diverges from Pylon's approach. Check `gh pr view 8097 --repo pingdotgg/t3code --json state,mergedAt`. Its migration id 42 is unusable here (Pylon's 42 is `ProjectionProjectFaviconPath`; the manifest runs through 47, so any new migration is 048). Upstream's own trunk has a 42 collision between `#8097` and merged `#8160`. | Do not port `#8097`. Two fragments stand alone on their merits: its partial plan-activity index as a Pylon-numbered `048`, but only if `EXPLAIN QUERY PLAN` shows Pylon's CTE actually reverse-scans; and a Pylon-voiced Tasks section for `docs/user/composer.md`, which has none today. Its `turn.aborted` reducer hunks are an unrelated concern — investigate separately, do not smuggle them in. |
3121+
| WATCH-2 | [`#174`](https://github.com/pylon-code/pylon/issues/174) — cross-thread messaging design; context in [`#114`](https://github.com/pylon-code/pylon/issues/114) | `#6573` (PR) — authenticated cross-thread MCP tools | 2026-08-29 | **Premise gone.** Closed unmerged 2026-08-28 without adding permission splitting or bounded read-only tools. Nothing upstream to compare against today. | A replacement lands. Check `git log --oneline <cursor>..t3code-upstream/main -- apps/server/src/mcp/toolkits/` and `gh pr list --repo pingdotgg/t3code --search 'mcp thread tools' --state merged`. Not before 2026-11-01 — upstream abandoned this once and a rewrite is not a weekly event. | Compare with Pylon's scoped read-only context/checkpoint MCP design before adoption. Do not revive `#6573` itself. |
3122+
| WATCH-3 | [`#177`](https://github.com/pylon-code/pylon/issues/177) — scheduled-run safety contract; context in [`#114`](https://github.com/pylon-code/pylon/issues/114) | `#7966` (issue) / `#7986` (PR) — server-side scheduled agent runs | 2026-08-29 | **Premise gone.** Both closed 2026-08-28; `#7986` closed unmerged. The implementation Pylon declined to cherry-pick no longer exists upstream. | A replacement scheduling implementation merges. Check `git log --oneline <cursor>..t3code-upstream/main -- apps/server/src/orchestration/Layers/TaskFireReactor.ts apps/server/src/orchestration/Layers/OrchestrationReactor.ts`. Not before 2026-11-01. | Fresh review only. Pylon's own canonical scheduled-turn ownership question in `#114` is unblocked by upstream's retreat, not answered by it. |

0 commit comments

Comments
 (0)