You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix(cli): address the xhigh review of Pylon triage
Six findings from the review of the port, in rough order of severity.
**Triage inspected the wrong install.** `resolveBaseDir` falls back to `~/.t3`,
which is T3 Code's runtime home, not Pylon's `~/.pylon-code`. On a Pylon Desktop
machine that reported the server as not running, pointed the agent at another
product's database, logs, and secrets directory, and created the scratch dir
inside a live T3 install. Triage now prefers Pylon's home when nothing is
specified and it exists. The shared resolver's default is left alone: every
other CLI command depends on it, so changing it belongs in its own change.
**One repository could not serve both roles.** The clone source and the issue
tracker are the same repo upstream but not here, so the documented example
(an issues-only repo) would have had the agent cloning a tree with no code in
it. Split into PYLON_TRIAGE_REPOSITORY and PYLON_TRIAGE_SOURCE_REPOSITORY, with
the playbook and context file naming which is which.
**An empty value read as configured.** `Config.string` accepts "", so an
exported-but-blank variable defeated the "not configured" guard and rendered a
blank repository line. Blank and whitespace now normalize to unset.
**The nightly caveat was inside the git ref.** `releaseTag` carried
"(nightly build; if this tag does not exist, clone main)", which the playbook
substitutes verbatim into `git clone --branch`. The tag is bare again and the
caveat moved to its own field.
**The label could lose a report.** `via-triage` does not exist in this repo, so
`gh issue create --label via-triage` would fail after the agent had written the
issue. The playbook now files without the label rather than losing the work.
**No user documentation.** Added docs/user/triage.md; the two environment
variables were documented only in a source comment.
Generated by \`t3 triage\` at ${input.generatedAt}.
203
218
204
219
- Installed version: ${input.version}
205
-
- Release tag for this version: ${input.releaseTag}
220
+
- Release tag for this version: ${input.releaseTag}${input.isNightly ? "\n- Nightly build: this tag may not exist; clone `main` instead and treat file and line references as approximate" : ""}
206
221
- OS: ${input.os}
207
222
- Node: ${input.nodeVersion}
208
223
- CLI launched as: ${input.launchedAs}
209
224
- Server process: ${input.server}
210
-
- Repository: ${input.repository??"not configured — do not try to post an issue; write it to a file next to this one and hand the path to the user"}
225
+
- Source repository (clone this to read code): ${input.sourceRepository??"not configured — skip the clone step and diagnose without source"}
226
+
- Issue repository (search and file here): ${input.issueRepository??"not configured — do not try to post an issue; write it to a file next to this one and hand the path to the user"}
0 commit comments