Skip to content

Commit c273eb4

Browse files
rynfarrynfar
committed
docs: record slice 3 and its three deferred commits
1 parent fb0593c commit c273eb4

1 file changed

Lines changed: 15 additions & 4 deletions

File tree

‎.agents/upstream-review.md‎

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -436,7 +436,18 @@ hosted-web preview deploys, T3 hosting), `73b2e8fdd` / `#5609` (automated
436436
production mobile EAS releases), and `b91a000a1` / `#6013` (a duplicate action
437437
on the T3-named default theme).
438438

439-
| Slice | Upstream | Decision | Pylon reference | Notes |
440-
| ----- | ---------------------------------------------------------------------------------------------------------------------------------------- | -------- | --------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
441-
| S1 | `deb901d63` / `#5538`, `062b4618c` / `#5782`, `2abe66800` / `#5916` | adopted | _pending_ | Security and performance, all three clean cherry-picks. `#5916` adds `default-src 'none'; style-src 'unsafe-inline'; sandbox` to SVG asset responses; Pylon's `http.ts` was identical to upstream, so it applied unchanged. **This is the mitigation for `#5775`** (manually chosen project icons in S5): an SVG served same-origin can carry inline script, so S5 must not land without it. `#5538` stops favicon resolution pinning the event loop and `#5782` bounds the file-link label so bracket runs stop rescanning — both matter for Pylon's "performance without compromise" line. |
442-
| S2 | `e70cdb478` / `#5710`, `89c320df0` / `#5762`, `a6c9b41f9` / `#5757`, `5bb8c0366` / `#5774`, `ddaa6afef` / `#5773`, `ba9c9ae81` / `#5788` | adopted | _pending_ | Server correctness, all six clean cherry-picks. `#5710` stops Claude resume handshakes completing turns that never ran; `#5762` lets a Codex thread with queued follow-ups actually stop; `#5774` adds an `onlyIfSettled` guard so settle-cleanup stops skip a thread re-engaged after the settle landed (new contracts field); `#5788` sets `OOMPolicy=continue` on the systemd unit, because agent tool calls share the server's cgroup and the kernel killing one greedy child was stopping the server, every live agent, and the user's connection; `#5757` lets agents open pasted images. `#5773` adds `vp run migrate-dev-db`, which **supersedes the hand-rolled `VACUUM INTO` recipe in the Test data section of the agent guidance** — it defaults to the T3-compatible `~/.t3` home, opens the source read-only, and refuses to rebuild the shared database, so it already obeys Pylon's "never write to the live install" rule. |
439+
| Slice | Upstream | Decision | Pylon reference | Notes |
440+
| ----- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | -------- | --------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
441+
| S1 | `deb901d63` / `#5538`, `062b4618c` / `#5782`, `2abe66800` / `#5916` | adopted | _pending_ | Security and performance, all three clean cherry-picks. `#5916` adds `default-src 'none'; style-src 'unsafe-inline'; sandbox` to SVG asset responses; Pylon's `http.ts` was identical to upstream, so it applied unchanged. **This is the mitigation for `#5775`** (manually chosen project icons in S5): an SVG served same-origin can carry inline script, so S5 must not land without it. `#5538` stops favicon resolution pinning the event loop and `#5782` bounds the file-link label so bracket runs stop rescanning — both matter for Pylon's "performance without compromise" line. |
442+
| S2 | `e70cdb478` / `#5710`, `89c320df0` / `#5762`, `a6c9b41f9` / `#5757`, `5bb8c0366` / `#5774`, `ddaa6afef` / `#5773`, `ba9c9ae81` / `#5788` | adopted | _pending_ | Server correctness, all six clean cherry-picks. `#5710` stops Claude resume handshakes completing turns that never ran; `#5762` lets a Codex thread with queued follow-ups actually stop; `#5774` adds an `onlyIfSettled` guard so settle-cleanup stops skip a thread re-engaged after the settle landed (new contracts field); `#5788` sets `OOMPolicy=continue` on the systemd unit, because agent tool calls share the server's cgroup and the kernel killing one greedy child was stopping the server, every live agent, and the user's connection; `#5757` lets agents open pasted images. `#5773` adds `vp run migrate-dev-db`, which **supersedes the hand-rolled `VACUUM INTO` recipe in the Test data section of the agent guidance** — it defaults to the T3-compatible `~/.t3` home, opens the source read-only, and refuses to rebuild the shared database, so it already obeys Pylon's "never write to the live install" rule. |
443+
| S3 | 19 commits: `064041072` / `#5691`, `89ee692bf` / `#5731`, `c2f8cb7ca` / `#5745`, `5208bdeb0` / `#5767`, `6f69b4407` / `#5776`, `285cf5947` / `#5770`, `02f4ce566` / `#5860`, `659986ce3` / `#5857`, `c8ad4b813` / `#5074`, `83d769f02` / `#5841`, `cbd55d637` / `#5935`, `0ca9fb3fb` / `#5909`, `ef051bdb8` / `#5928`, `d43210050` / `#5879`, `f0e297518` / `#5864`, `3d74474f6` / `#5938`, `fbcae59ef` / `#5964`, `8de0aa24d` / `#5878`, `0a7c662d3` / `#6000` | adopted | _pending_ | Sidebar follow-ups and web/desktop polish, all nineteen clean cherry-picks with no DotMatrix overlap. `#5776` matters most: rows on the sidebar Pylon just made default were showing a truncated plan step where the branch belongs. `#5767` stops pinned reorder reshuffling while writes land and `#5909` restores the worktree icon. `#5928` enables Restore defaults after theme-mix changes, which sits beside Pylon's own `legacySidebarEnabled` restore fix. **Three commits in this slice were deferred, not dropped** — see the note below the table. |
444+
445+
Deferred out of S3 to respect real dependencies, to be picked up after the
446+
slice that supplies the file each one edits: `be01b287b` / `#5716`
447+
(cursor-pointer styling) edits `usage/UsagePage.tsx`, which arrives with S4;
448+
`05eb05118` / `#5777` (unsent drafts in the sidebar) needs the
449+
`useHandleNewThread` rewrite from `6dbffa022` / `#5766` in S5; and
450+
`9821bca1c` / `#5624` (themed confirmation dialogs) edits
451+
`ProjectSettingsPanel.tsx`, which arrives with `288d8e345` / `#5768` in S5.
452+
Each was attempted in chronological order, conflicted only on the missing
453+
file, and was aborted cleanly rather than force-resolved.

0 commit comments

Comments
 (0)