Skip to content

Commit b21bf57

Browse files
committed
docs(web): name the real coupling behind the scroll fade padding
Review follow-up on the #8799 port. Moving the fade height into :root removed the co-location that made the pairing obvious, and the comment still claimed the top padding was the fade band's height. It is WorkspacePageContainer's pt-6, so a future bump of the token would silently desync the two and wash out controls on both this page and settings.
1 parent 0dc0f04 commit b21bf57

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

‎apps/web/src/routes/_chat.pull-requests.tsx‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1921,9 +1921,11 @@ function PullRequestsColumn({
19211921
ref={scrollRef}
19221922
className="topbar-scroll-fade scrollbar-gutter-both min-h-0 flex-1 overflow-y-auto"
19231923
>
1924-
{/* The top padding is the shared fade band's height, the same pairing the
1925-
settings page makes: at rest the controls sit fully below the mask, and only
1926-
content actually passing under the chrome fades. */}
1924+
{/* WorkspacePageContainer's pt-6 must stay at least as tall as
1925+
--workspace-titlebar-scroll-fade-height, so at rest the controls sit
1926+
fully below the mask and only content passing under the chrome fades.
1927+
The two live apart now, so raising the fade means raising that padding
1928+
here and on the settings page. */}
19271929
<WorkspacePageContainer className="gap-4">
19281930
<div className="flex flex-col gap-3">
19291931
<div ref={inFlowSearchRef} className="flex items-center gap-2">

0 commit comments

Comments
 (0)