Merge pull request #40 from pylon-code/upstream/2026-08-15-mobile-signout-crash

fix(mobile): prevent crash on sign out in settings

Author: rynfar

.agents/upstream-review.md

@@ -1110,6 +1110,28 @@ PR #26; typechecks clean on `t3`, `@t3tools/web`, `@t3tools/contracts`; `vp lint
 clean on both branches. **Neither got an integration pass** — no live multi-terminal
 session for `T1`, no Chrome/Safari clipboard check for `T2`.
 
+## 2026-08-15 (targeted) — `1add47b322ab1dfb5010bb363613650176b88088..ad117235b544e23545fe39143812db2ddd41af1f`
+
+**Cursor deliberately not advanced.** This was a targeted review, not a full
+batch. The developer asked whether upstream held a fix or a cause for an iOS
+crash on opening a session, so only mobile-relevant work was assessed. The
+remaining candidates in this 99-commit range are undecided, and
+`reviewed-through` stays at `1add47b32` until they are.
+
+Answer to the question that prompted it: **no**. The range holds exactly one
+mobile crash fix, `#4899`, and it guards sign-out in `SettingsAuthRouteScreen`
+— a different code path from opening a session. `git cherry` reports all 99
+commits absent from Pylon, so upstream work in this range cannot have caused
+the regression either; the crash window is Pylon's own
+`4c1830c6..24aac6537`. Every `patches/` entry except `@ff-labs__fff-node` is
+identical to upstream, which rules out patch divergence as the cause.
+
+| Change set | Upstream              | Decision | Pylon reference | Rationale or revisit condition                                                                                                                                                                                                                                                                                                                                        |
+| ---------- | --------------------- | -------- | --------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
+| M1         | `277a7cb44` / `#4899` | adopted  | `3b2b8d512`     | Signing out of the mobile settings account screen crashed: `UserProfileView` unmounts the instant `isSignedIn` flips false. The fix latches `hasBeenSignedIn` and pops back to `SettingsContent` instead. Clean single-file cherry-pick. Newly reachable for Pylon — mobile Connect sign-in only began working today, so this screen had never been exercised before. |
+
+Deferred register: unchanged and still empty.
+
 ## Deferred register
 
 _The register is currently empty. DEF-1 and DEF-2 were adopted on 2026-08-11

apps/mobile/src/features/settings/SettingsAuthRouteScreen.tsx

@@ -1,7 +1,7 @@
 import { useAuth } from "@clerk/expo";
 import { AuthView, UserProfileView } from "@clerk/expo/native";
 import { StackActions, useNavigation } from "@react-navigation/native";
-import { useCallback, useLayoutEffect } from "react";
+import { useCallback, useEffect, useLayoutEffect, useRef } from "react";
 import { View } from "react-native";
 
 import { hasCloudPublicConfig } from "../cloud/publicConfig";
@@ -25,11 +25,21 @@ function ConfiguredSettingsAuthRouteScreen() {
     () => navigation.dispatch(StackActions.popTo("SettingsContent")),
     [navigation],
   );
+  const hasBeenSignedIn = useRef(isSignedIn);
+  if (isSignedIn) {
+    hasBeenSignedIn.current = true;
+  }
+
+  useEffect(() => {
+    if (hasBeenSignedIn.current && isLoaded && isSignedIn === false) {
+      navigation.dispatch(StackActions.popTo("SettingsContent"));
+    }
+  }, [isLoaded, isSignedIn, navigation]);
 
   return (
     <View collapsable={false} className="flex-1 overflow-hidden bg-sheet">
       {isLoaded ? (
-        isSignedIn ? (
+        hasBeenSignedIn.current ? (
           <UserProfileView isDismissible={false} onHostBack={handleHostBack} />
         ) : (
           <AuthView isDismissible={false} onHostBack={handleHostBack} />