Commit 97df523
committed
fix(server): complete the settle-threads adoption
Three follow-ups the cherry-pick did not carry.
#8600 rewrites isUnpublishedBranch to treat a preserved branch.<name>.remote
and .merge pair as evidence the branch was published. That hunk applied to
neither a conflict nor a type error — it simply did not land, leaving the old
remote-refs-only check. Its own test caught it.
With the rewrite in place, Pylon's pruned-branch skip is no longer the right
answer: prune removes the tracking ref but leaves the config, so the branch is
now distinguishable from one that was never published and the lookup should run
rather than fall back to the last-known PR. Pylon's test asserted the saved API
call; it now asserts the live one.
ws.ts keeps upstream's narrowing from parkingCommand back to archiveCommand.
That is not a lost Pylon feature — upstream had parkingCommand too, and #8600
moves settle cleanup into ProviderCommandReactor's thread.settled handler, which
dispatches the same onlyIfSettled stop and also covers settlements with no
client attached.1 parent 0135cae commit 97df523
3 files changed
Lines changed: 40 additions & 16 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1523 | 1523 | | |
1524 | 1524 | | |
1525 | 1525 | | |
| 1526 | + | |
| 1527 | + | |
| 1528 | + | |
| 1529 | + | |
| 1530 | + | |
| 1531 | + | |
| 1532 | + | |
| 1533 | + | |
| 1534 | + | |
| 1535 | + | |
| 1536 | + | |
| 1537 | + | |
| 1538 | + | |
1526 | 1539 | | |
1527 | 1540 | | |
1528 | 1541 | | |
| |||
1532 | 1545 | | |
1533 | 1546 | | |
1534 | 1547 | | |
1535 | | - | |
1536 | | - | |
1537 | | - | |
1538 | | - | |
1539 | | - | |
| 1548 | + | |
| 1549 | + | |
| 1550 | + | |
| 1551 | + | |
| 1552 | + | |
1540 | 1553 | | |
1541 | 1554 | | |
1542 | 1555 | | |
| |||
1545 | 1558 | | |
1546 | 1559 | | |
1547 | 1560 | | |
1548 | | - | |
1549 | | - | |
| 1561 | + | |
| 1562 | + | |
1550 | 1563 | | |
1551 | 1564 | | |
1552 | 1565 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1406 | 1406 | | |
1407 | 1407 | | |
1408 | 1408 | | |
1409 | | - | |
| 1409 | + | |
1410 | 1410 | | |
1411 | 1411 | | |
1412 | 1412 | | |
| |||
1421 | 1421 | | |
1422 | 1422 | | |
1423 | 1423 | | |
1424 | | - | |
1425 | | - | |
1426 | | - | |
1427 | | - | |
1428 | | - | |
1429 | | - | |
1430 | | - | |
| 1424 | + | |
| 1425 | + | |
| 1426 | + | |
| 1427 | + | |
| 1428 | + | |
| 1429 | + | |
| 1430 | + | |
| 1431 | + | |
| 1432 | + | |
| 1433 | + | |
| 1434 | + | |
| 1435 | + | |
| 1436 | + | |
| 1437 | + | |
| 1438 | + | |
| 1439 | + | |
| 1440 | + | |
| 1441 | + | |
1431 | 1442 | | |
1432 | 1443 | | |
1433 | 1444 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| |||
0 commit comments